From: Luca Ceresoli via buildroot <buildroot@buildroot.org>
To: Brandon Maier <brandon.maier@collins.com>
Cc: Neal Frager <neal.frager@amd.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/1] boot/uboot/uboot.mk: fix zynqmp without pmufw
Date: Tue, 22 Nov 2022 22:28:21 +0100 [thread overview]
Message-ID: <20221122222821.58d7a364@booty> (raw)
In-Reply-To: <20221122201701.65681-1-brandon.maier@collins.com>
Hi Brandon,
On Tue, 22 Nov 2022 14:17:01 -0600
Brandon Maier <brandon.maier@collins.com> wrote:
> Commit d07e6b70 (boot/uboot/uboot.mk: add pmufw.elf support) broke
> configurations where the UBOOT_ZYNQMP_PMUFW was blank. Previously it
> would set the U-Boot CONFIG_PMUFW_INIT_FILE to the blank string, but now
> it will set it to ".bin" which causes U-Boot to fail to build.
>
> Signed-off-by: Brandon Maier <brandon.maier@collins.com>
> ---
> v2:
> - support pmufw with any extension
> ---
> boot/uboot/uboot.mk | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
> index 19e4183927..d037ae9c12 100644
> --- a/boot/uboot/uboot.mk
> +++ b/boot/uboot/uboot.mk
> @@ -394,8 +394,9 @@ UBOOT_ZYNQMP_PMUFW_BASENAME = $(basename $(UBOOT_ZYNQMP_PMUFW_PATH))
>
> define UBOOT_ZYNQMP_KCONFIG_PMUFW
> $(if $(filter %.elf,$(UBOOT_ZYNQMP_PMUFW_PATH)),
> - objcopy -O binary -I elf32-little $(UBOOT_ZYNQMP_PMUFW_BASENAME).elf $(UBOOT_ZYNQMP_PMUFW_BASENAME).bin)
> - $(call KCONFIG_SET_OPT,CONFIG_PMUFW_INIT_FILE,"$(UBOOT_ZYNQMP_PMUFW_BASENAME).bin")
> + objcopy -O binary -I elf32-little $(UBOOT_ZYNQMP_PMUFW_BASENAME).elf $(UBOOT_ZYNQMP_PMUFW_BASENAME).bin
> + $(call KCONFIG_SET_OPT,CONFIG_PMUFW_INIT_FILE,"$(UBOOT_ZYNQMP_PMUFW_BASENAME).bin"),
> + $(call KCONFIG_SET_OPT,CONFIG_PMUFW_INIT_FILE,"$(UBOOT_ZYNQMP_PMUFW_PATH)"))
> endef
Using the else branche of $(if) is different from what I had in
mind, but it is fine as well.
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Thanks!
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-11-22 21:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 20:17 [Buildroot] [PATCH v2 1/1] boot/uboot/uboot.mk: fix zynqmp without pmufw Brandon Maier via buildroot
2022-11-22 21:28 ` Luca Ceresoli via buildroot [this message]
2022-11-23 0:03 ` Frager, Neal via buildroot
2022-11-23 10:03 ` Peter Korsgaard
2022-11-26 18:40 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221122222821.58d7a364@booty \
--to=buildroot@buildroot.org \
--cc=brandon.maier@collins.com \
--cc=luca.ceresoli@bootlin.com \
--cc=neal.frager@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.