From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Joachim Wiberg <troglobit@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/1] package/ssdp-responder: fix warnings from check-package and shellcheck
Date: Tue, 22 Nov 2022 22:39:17 +0100 [thread overview]
Message-ID: <20221122223917.194d51d7@windsurf> (raw)
In-Reply-To: <20221106181946.501548-1-troglobit@gmail.com>
On Sun, 6 Nov 2022 19:19:46 +0100
Joachim Wiberg <troglobit@gmail.com> wrote:
> Summary of changes:
>
> - Fix use of $DAEMON, found by check-package
> - Expects DAEMON to be name of daemon controlled by script, this
> causes ripple efects in rest of script
> - Recommend `chmod a-x`, .mk file installs with `-m 0755`
> - Fix shellcheck warnings:
> - Use "$VAR" in case of spaces in filenames
> - recommend not using $? in if stmt, should use `if start-stop ...`
> - mismatch in indentation in case-esac
>
> Changes since v1:
>
> - Revert introduction of cmd() wrapper for start-stop-daemon, instead
> call start-stop-daemon directly in start() and stop() functions
The changes between versions should be...
>
> Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
> ---
... here. So that they don't show up in the final commit log.
Applied to next with this fixed. Thanks!
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-11-22 21:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 17:46 [Buildroot] [PATCH 0/3] package/ssdp-responder bump and check-package fixes Joachim Wiberg
2022-10-31 17:46 ` [Buildroot] [PATCH 1/3] package/ssdp-responder: bump to version 1.9 Joachim Wiberg
2022-10-31 20:47 ` Thomas Petazzoni via buildroot
2022-11-01 7:18 ` Joachim Wiberg
2022-11-02 17:06 ` Thomas Petazzoni via buildroot
2022-11-02 21:19 ` Yann E. MORIN
2022-11-02 21:21 ` Thomas Petazzoni via buildroot
2022-11-02 22:08 ` Joachim Wiberg
2022-11-05 18:45 ` Yann E. MORIN
2022-11-05 18:48 ` Yann E. MORIN
2022-11-06 8:47 ` Joachim Wiberg
2022-10-31 17:46 ` [Buildroot] [PATCH 2/3] package/ssdp-responder: minor update of help text Joachim Wiberg
2022-11-05 18:47 ` Yann E. MORIN
2022-10-31 17:46 ` [Buildroot] [PATCH 3/3] package/ssdp-responder: fix warnings from check-package and shellcheck Joachim Wiberg
2022-10-31 20:49 ` Thomas Petazzoni via buildroot
2022-11-01 7:30 ` Joachim Wiberg
2022-11-05 18:44 ` Yann E. MORIN
2022-11-06 8:54 ` Joachim Wiberg
2022-11-06 18:19 ` [Buildroot] [PATCH v2 1/1] " Joachim Wiberg
2022-11-22 21:39 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221122223917.194d51d7@windsurf \
--to=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=troglobit@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.