All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd.kuhls@t-online.de>
Cc: Stefan Ott <stefan@ott.net>, Samuel Martin <s.martin49@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 3/3] package/p2pool: new package
Date: Tue, 22 Nov 2022 23:41:23 +0100	[thread overview]
Message-ID: <20221122234123.0933646f@windsurf> (raw)
In-Reply-To: <20221031195205.429257-3-bernd.kuhls@t-online.de>

Hello,

On Mon, 31 Oct 2022 20:52:05 +0100
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:

> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> v2: disabled support for BR2_aarch64_be, not supported upstream:
>     https://github.com/tevador/RandomX/pull/257

Same comment as for monero, is this about AArch64 BE, or all BE
architectures?

> diff --git a/package/p2pool/Config.in b/package/p2pool/Config.in
> new file mode 100644
> index 0000000000..53f894e309
> --- /dev/null
> +++ b/package/p2pool/Config.in
> @@ -0,0 +1,27 @@
> +config BR2_PACKAGE_P2POOL
> +	bool "p2pool"
> +	depends on BR2_ARCH_IS_64
> +	depends on !BR2_aarch64_be

This package is not selecting monero, so why should it inherit its
dependencies? Or this RandomX thing is a library that is bundled in
both monero and p2pool?

> +# prevent compiler warnings being treated as errors
> +define P2POOL_REMOVE_WARNING_FLAGS
> +	$(SED) '/set(WARNING_FLAGS/d' $(@D)/cmake/flags.cmake
> +endef
> +P2POOL_POST_PATCH_HOOKS += P2POOL_REMOVE_WARNING_FLAGS

Is an upstreamable patch possible for this?

Thanks

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-11-22 22:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-31 19:52 [Buildroot] [PATCH v2 1/3] package/unbound: install to staging Bernd Kuhls
2022-10-31 19:52 ` [Buildroot] [PATCH v2 2/3] package/monero: new package Bernd Kuhls
2022-11-22 22:38   ` Thomas Petazzoni via buildroot
2022-10-31 19:52 ` [Buildroot] [PATCH v2 3/3] package/p2pool: " Bernd Kuhls
2022-11-22 22:41   ` Thomas Petazzoni via buildroot [this message]
2022-11-22 22:41 ` [Buildroot] [PATCH v2 1/3] package/unbound: install to staging Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221122234123.0933646f@windsurf \
    --to=buildroot@buildroot.org \
    --cc=bernd.kuhls@t-online.de \
    --cc=s.martin49@gmail.com \
    --cc=stefan@ott.net \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.