From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
Stefan Hajnoczi <stefanha@gmail.com>,
Laurent Vivier <laurent@vivier.eu>, Kevin Wolf <kwolf@redhat.com>
Subject: Re: [PATCH for-7.2 v2 3/4] libvhost-user: Fix two more format strings
Date: Wed, 23 Nov 2022 01:52:29 -0500 [thread overview]
Message-ID: <20221123015218-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <06a55dd7-4d98-8c6c-c9aa-b1f4222829d8@weilnetz.de>
On Wed, Nov 23, 2022 at 07:49:53AM +0100, Stefan Weil wrote:
> Am 23.11.22 um 07:35 schrieb Stefan Weil:
> > Am 15.11.22 um 08:25 schrieb Stefan Weil:
> > > Am 05.11.22 um 11:24 schrieb Stefan Weil:
> > >
> > > > This fix is required for 32 bit host. The bug was detected by CI
> > > > for arm-linux, but is also relevant for i386-linux.
> > > >
> > > > Reported-by: Stefan Hajnoczi <stefanha@gmail.com>
> > > > Signed-off-by: Stefan Weil <sw@weilnetz.de>
> > > > ---
> > > > subprojects/libvhost-user/libvhost-user.c | 3 ++-
> > > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/subprojects/libvhost-user/libvhost-user.c
> > > > b/subprojects/libvhost-user/libvhost-user.c
> > > > index d67953a1c3..80f9952e71 100644
> > > > --- a/subprojects/libvhost-user/libvhost-user.c
> > > > +++ b/subprojects/libvhost-user/libvhost-user.c
> > > > @@ -651,7 +651,8 @@ generate_faults(VuDev *dev) {
> > > > if (ioctl(dev->postcopy_ufd, UFFDIO_REGISTER, ®_struct)) {
> > > > vu_panic(dev, "%s: Failed to userfault region %d "
> > > > - "@%" PRIx64 " + size:%zx offset: %zx:
> > > > (ufd=%d)%s\n",
> > > > + "@%" PRIx64 " + size:%" PRIx64 "
> > > > offset: %" PRIx64
> > > > + ": (ufd=%d)%s\n",
> > > > __func__, i,
> > > > dev_region->mmap_addr,
> > > > dev_region->size, dev_region->mmap_offset,
> > >
> > >
> > > There is still no review for this patch.
> > >
> > > I added "for-7.2" to the subject here in my answer. How can we get
> > > all 4 patches of this series into the new release?
> > >
> > > Stefan
> >
> > Ping? Those bug fixes are still missing in -rc2.
> >
> > Stefan
>
> Hello Michael,
>
> I just noticed that MAINTAINERS has no entry for the files in
> subprojects/libvhost-user, so I did not cc you in my previous e-mails.
> Should that directory be added to the "vhost" section"?
>
> Stefan
pls do
next prev parent reply other threads:[~2022-11-23 6:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-05 10:24 [PATCH v2 for-7.2 0/4] libvhost-user: Add format attribute and fix format strings Stefan Weil
2022-11-05 10:24 ` Stefan Weil via
2022-11-05 10:24 ` [PATCH v2 1/4] libvhost-user: Fix wrong type of argument to formatting function (reported by LGTM) Stefan Weil
2022-11-05 10:24 ` Stefan Weil via
2022-11-05 10:24 ` [PATCH v2 2/4] libvhost-user: Fix format strings Stefan Weil
2022-11-05 10:24 ` Stefan Weil via
2022-11-05 10:24 ` [PATCH v2 3/4] libvhost-user: Fix two more " Stefan Weil
2022-11-05 10:24 ` Stefan Weil via
2022-11-05 11:06 ` Stefan Weil
2022-11-05 11:06 ` Stefan Weil via
2022-11-15 7:25 ` [PATCH for-7.2 " Stefan Weil
2022-11-15 7:25 ` Stefan Weil via
2022-11-23 6:35 ` Stefan Weil
2022-11-23 6:35 ` Stefan Weil via
2022-11-23 6:49 ` Stefan Weil
2022-11-23 6:49 ` Stefan Weil via
2022-11-23 6:52 ` Michael S. Tsirkin [this message]
2022-11-05 10:24 ` [PATCH v2 4/4] libvhost-user: Add format attribute to local function vu_panic Stefan Weil
2022-11-05 10:24 ` Stefan Weil via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221123015218-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=kwolf@redhat.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@gmail.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.