From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Julien Olivain <ju.o@free.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH next 1/2] package/highway: new package
Date: Wed, 23 Nov 2022 15:17:15 +0100 [thread overview]
Message-ID: <20221123151715.4a454fed@windsurf> (raw)
In-Reply-To: <20221122215557.789750-1-ju.o@free.fr>
Hello Julien,
On Tue, 22 Nov 2022 22:55:56 +0100
Julien Olivain <ju.o@free.fr> wrote:
> diff --git a/package/highway/Config.in b/package/highway/Config.in
> new file mode 100644
> index 0000000000..f9a0bc910c
> --- /dev/null
> +++ b/package/highway/Config.in
> @@ -0,0 +1,42 @@
> +config BR2_PACKAGE_HIGHWAY_ARCH_SUPPORTS
> + bool
> + # Supports all BR architectures by default, with few exceptions
> + default y
> + # Armv7 support is only with fpv4, see:
> + # https://github.com/google/highway/blob/1.0.1/CMakeLists.txt#L221
> + depends on !BR2_arm || BR2_ARM_FPU_VFPV4
Hm, I suppose if it works on other weird architectures, it must have a
non-optimized version, that could work on ARM platforms that do not
have a VFPv4 ?
> +ifeq ($(BR2_ARM_FPU_VFPV4),y)
> +HIGHWAY_CONF_OPTS += -DHWY_CMAKE_ARM7=ON
> +else
> +HIGHWAY_CONF_OPTS += -DHWY_CMAKE_ARM7=OFF
> +endif
So even with -DHWY_CMAKE_ARM7=OFF, it doesn't work for ARMv5, or ARMv7
without VFPv4 ?
> diff --git a/support/testing/tests/package/test_highway.py b/support/testing/tests/package/test_highway.py
Runtime tests coming together with the new package: excellent!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-11-23 14:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 21:55 [Buildroot] [PATCH next 1/2] package/highway: new package Julien Olivain
2022-11-22 21:59 ` [Buildroot] [PATCH next 2/2] package/libjxl: " Julien Olivain
2022-11-23 14:37 ` Thomas Petazzoni via buildroot
2022-11-24 21:03 ` Julien Olivain
2022-11-23 14:17 ` Thomas Petazzoni via buildroot [this message]
2022-11-24 20:59 ` [Buildroot] [PATCH next 1/2] package/highway: " Julien Olivain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221123151715.4a454fed@windsurf \
--to=buildroot@buildroot.org \
--cc=ju.o@free.fr \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.