From: Jakub Kicinski <kuba@kernel.org>
To: Maxim Korotkov <korotkov.maxim.s@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Guangbin Huang <huangguangbin2@huawei.com>,
Andrew Lunn <andrew@lunn.ch>,
Alexander Lobakin <alexandr.lobakin@intel.com>,
"Keller, Jacob E" <jacob.e.keller@intel.com>,
Tom Rix <trix@redhat.com>, Marco Bonelli <marco@mebeim.net>,
Edward Cree <ecree@solarflare.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH v3] ethtool: avoiding integer overflow in ethtool_phys_id()
Date: Wed, 23 Nov 2022 20:11:36 -0800 [thread overview]
Message-ID: <20221123201136.232ed8e7@kernel.org> (raw)
In-Reply-To: <20221122122901.22294-1-korotkov.maxim.s@gmail.com>
On Tue, 22 Nov 2022 15:29:01 +0300 Maxim Korotkov wrote:
> The value of an arithmetic expression "n * id.data" is subject
> to possible overflow due to a failure to cast operands to a larger data
> type before performing arithmetic. Used macro for multiplication instead
> operator for avoiding overflow.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Maxim Korotkov <korotkov.maxim.s@gmail.com>
Applying to net-next, pretty sure nobody expects us to support blinking
an LED 4 billion times, at a rate low enough for a human eye to see...
But let's watch the stable bots pick it up anyway.
next prev parent reply other threads:[~2022-11-24 4:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 12:29 [PATCH v3] ethtool: avoiding integer overflow in ethtool_phys_id() Maxim Korotkov
2022-11-22 13:39 ` Alexander Lobakin
2022-11-22 14:49 ` Andrew Lunn
2022-11-24 4:11 ` Jakub Kicinski [this message]
2022-11-24 4:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221123201136.232ed8e7@kernel.org \
--to=kuba@kernel.org \
--cc=alexandr.lobakin@intel.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=edumazet@google.com \
--cc=huangguangbin2@huawei.com \
--cc=jacob.e.keller@intel.com \
--cc=korotkov.maxim.s@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=marco@mebeim.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.