All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Neal Frager via buildroot <buildroot@buildroot.org>
Cc: luca.ceresoli@bootlin.com, Neal Frager <neal.frager@amd.com>
Subject: Re: [Buildroot] [PATCH v4 1/1] boot/uboot/uboot.mk: add binary u-boot.elf support
Date: Wed, 23 Nov 2022 23:30:21 +0100	[thread overview]
Message-ID: <20221123233021.09ce037b@windsurf> (raw)
In-Reply-To: <20221123143126.17843-1-neal.frager@amd.com>

Hello Neal,

On Wed, 23 Nov 2022 07:31:26 -0700
Neal Frager via buildroot <buildroot@buildroot.org> wrote:

> If a user requests a u-boot binary in elf format,
> they may actually want the stripped u-boot.elf version.
> This patch provides the stripped u-boot.elf binary.
> 
> Signed-off-by: Neal Frager <neal.frager@amd.com>

I've applied to next, after doing some further fixes.

>  config BR2_TARGET_UBOOT_FORMAT_ELF
> +	bool "u-boot"
> +	help
> +	  Configures the u-boot ELF file with debug symbols.

This option does not "configure", it "installs". Also, I'm not sure
having debugging symbols in u-boot is guaranteed, I suppose it depends
on whether debugging is enabled or not. So I changed this to:

+         Install the u-boot image, which is directly the ELF binary
+         for the main U-Boot, potentially with debugging symbols.

> +config BR2_TARGET_UBOOT_FORMAT_BIN_ELF
>  	bool "u-boot.elf"
> +	help
> +	  Configures the u-boot.elf binary version of ELF file.
> +	  Debug symbols are not included in this ELF file.

So I researched a bit more, and this u-boot.elf is produced when
CONFIG_REMAKE_ELF=y in U-Boot. So I changed this to:

+config BR2_TARGET_UBOOT_FORMAT_REMAKE_ELF
        bool "u-boot.elf"
+       help
+         Install the u-boot.elf image, which is produced when
+         CONFIG_REMAKE_ELF=y. It is an ELF image (u-boot.elf)
+         produced from the raw U-Boot binary (u-boot.bin), which may
+         already have been statically relocated and may already have
+         a device-tree appended to it.

The description was taken from the CONFIG_REMAKE_ELF help text in U-Boot.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-11-23 22:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-23 14:31 [Buildroot] [PATCH v4 1/1] boot/uboot/uboot.mk: add binary u-boot.elf support Neal Frager via buildroot
2022-11-23 22:30 ` Thomas Petazzoni via buildroot [this message]
2022-11-24 10:24   ` Frager, Neal via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221123233021.09ce037b@windsurf \
    --to=buildroot@buildroot.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=neal.frager@amd.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.