From: Manivannan Sadhasivam <mani@kernel.org>
To: Asutosh Das <quic_asutoshd@quicinc.com>
Cc: "Powen Kao (高伯文)" <Powen.Kao@mediatek.com>,
"Bart Van Assche" <bvanassche@acm.org>,
"Stanley Chu (朱原陞)" <stanley.chu@mediatek.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"Peter Wang (王信友)" <peter.wang@mediatek.com>,
"Naomi Chu (朱詠田)" <Naomi.Chu@mediatek.com>,
"Alice Chao (趙珮均)" <Alice.Chao@mediatek.com>,
linux-scsi@vger.kernel.org, quic_cang@quicinc.com
Subject: Re: 52a518019c causes issue with Qualcomm UFSHC
Date: Thu, 24 Nov 2022 11:06:34 +0530 [thread overview]
Message-ID: <20221124053634.GB5119@thinkpad> (raw)
In-Reply-To: <20221121225634.GA20677@asutoshd-linux1.qualcomm.com>
On Mon, Nov 21, 2022 at 02:56:34PM -0800, Asutosh Das wrote:
> On Sat, Nov 19 2022 at 20:16 -0800, Powen Kao (高伯文) wrote:
> > Hi Asutosh,
> >
> >
> >
> > Reverting the patch doesn't sound feasible on MTK platform ☹
> >
> >
> >
> > > > I don't think invoking a clock scaling notification during
> >
> > > > ufshcd_host_reset_and_restore() sounds right to me.
> >
> > But the point is that driver has the right to know that the clk is scaled no matter where ufshcd_scale_clks() is invoked, no?
> >
> >
> >
> > Do you mind applying this patch on qcom driver to check on host status before further operation?
>
> + Mani, linux-scsi
>
> Hello Powen
> Thanks for the change. I will think of something to work-around the issue.
> However, I would like to point out that a change that breaks an existing driver
> must be fixed or reverted, not the other way around.
>
May I know what the actual issue is? I've tested v6.1-rc1 that has this change
and didn't see any issues on SM8250, SDM845 and SM8450.
Thanks,
mani
> -asd
>
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2022-11-24 5:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221115014804.GA24294@asutoshd-linux1.qualcomm.com>
[not found] ` <KL1PR03MB5836A982CAE0FE411743BF7283069@KL1PR03MB5836.apcprd03.prod.outlook.com>
[not found] ` <20221117174634.GA12056@asutoshd-linux1.qualcomm.com>
[not found] ` <584b6f9a-c4f9-8ecc-98d9-216923d85ddf@acm.org>
[not found] ` <20221118191058.GA28646@asutoshd-linux1.qualcomm.com>
[not found] ` <TYZPR03MB5825B4D5259FA22CCC876E7783089@TYZPR03MB5825.apcprd03.prod.outlook.com>
2022-11-21 22:56 ` 52a518019c causes issue with Qualcomm UFSHC Asutosh Das
2022-11-23 14:55 ` Powen Kao (高伯文)
2022-11-24 5:36 ` Manivannan Sadhasivam [this message]
2022-11-29 15:07 ` Asutosh Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221124053634.GB5119@thinkpad \
--to=mani@kernel.org \
--cc=Alice.Chao@mediatek.com \
--cc=Naomi.Chu@mediatek.com \
--cc=Powen.Kao@mediatek.com \
--cc=bvanassche@acm.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=peter.wang@mediatek.com \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.