From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DE5D33D7 for ; Thu, 24 Nov 2022 18:44:59 +0000 (UTC) Received: by mail-pl1-f182.google.com with SMTP id 4so2131623pli.0 for ; Thu, 24 Nov 2022 10:44:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=5mUc7Hj+XQfjTjlDIFjVYP+TraLI2iMKH19WfjbmoCU=; b=qrssbKT0+X3S2a2vA11xfRsFFE4GBXlNnE3Zh83wyE/w7BcnXA8O3tKMV+MsNTedd5 o2mVKqmODuotSHR59IgWUSH7zyL9r+dwGCTFvGwDKbxkauQMab+S2T5Xs9LFCwVVdM9j WkqgWig6tXHfByOjZfNwAeyBf+1vh+Mo9PGTt+HkZbpWqABdUpLksBLyvCf+ZhhWeyGs MyoeWSKhjiXt95/TxHXXFXJ6T3stbaWbvDWF8SAxiNYpxnIr+awhB3hb1Pdep/8Ho6cP BqQw87mzNiLP6hXkkFbJNy1ty49OtCtlsq7XDbZL9zMxLQ0IhbpTfHkIXSpmNfWPIMU7 OdKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5mUc7Hj+XQfjTjlDIFjVYP+TraLI2iMKH19WfjbmoCU=; b=xxHZ6M9cpdgyvlesf/K24o0yksdilO884j8pBsYXCUbLrvKZTZPiKcawIF8h3nHY3B rfPJ6D1uF3XLCOsfycseOeF4XhPwCBp67QZcL45TGf7np8Pl+9d1Q7IqMlKJ8q4/cONI PuFFoaKArG3wh5yuMdD/vRJcy7FILlgyf7/5ZDLw9mLkeFV0F2X256pUtXOuYPuragym SKBq9a98PkPzL+1/AmtdO6829JWTYqvospf980Hc1r150nRbfkwMJz8HCGlluzXqe/qW LBAT4CS8VDE3xnWcli6thHA7ugrqj/Y/2al/8rT8GuMjxuUsanBOe1GEDDDDDJhuB4wo 4zUw== X-Gm-Message-State: ANoB5pkJDtGBsovE2bQjuKmtR+/cmrIev8CkWE8AFNMGwEnwBChG0Ifg M9Q9NTGdrggpAqGRgK8f0xsb X-Google-Smtp-Source: AA0mqf5MMfxGvtucAaoiCKcufA3lnsdQsAgasNIMeAFqC8DNifHVxaNFhZZEDb+GN87gxeUCiAxbxw== X-Received: by 2002:a17:90b:358a:b0:218:c490:33f6 with SMTP id mm10-20020a17090b358a00b00218c49033f6mr17801949pjb.83.1669315498433; Thu, 24 Nov 2022 10:44:58 -0800 (PST) Received: from thinkpad ([117.202.190.212]) by smtp.gmail.com with ESMTPSA id b12-20020aa7950c000000b0056c349f5c70sm1539156pfp.79.2022.11.24.10.44.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Nov 2022 10:44:57 -0800 (PST) Date: Fri, 25 Nov 2022 00:14:48 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: "lpieralisi@kernel.org" , Aisheng Dong , "bhelgaas@google.com" , "devicetree@vger.kernel.org" , "festevam@gmail.com" , "imx@lists.linux.dev" , "jdmason@kudzu.us" , "kernel@pengutronix.de" , "kishon@ti.com" , "krzysztof.kozlowski+dt@linaro.org" , "kw@linux.com" , "linux-arm-kernel@lists.infradead.org" , dl-linux-imx , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , "lorenzo.pieralisi@arm.com" , "lznuaa@gmail.com" , "maz@kernel.org" , "ntb@lists.linux.dev" , Peng Fan , "robh+dt@kernel.org" , "s.hauer@pengutronix.de" , "shawnguo@kernel.org" , "tglx@linutronix.de" Subject: Re: [EXT] Re: [PATCH v13 2/2] PCI: endpoint: pci-epf-vntb: using platform MSI as doorbell Message-ID: <20221124184448.GF5119@thinkpad> References: <20221124055036.1630573-1-Frank.Li@nxp.com> <20221124055036.1630573-3-Frank.Li@nxp.com> <20221124090028.GC5119@thinkpad> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Nov 24, 2022 at 06:03:40PM +0000, Frank Li wrote: > > > > -----Original Message----- > > From: Manivannan Sadhasivam > > Sent: Thursday, November 24, 2022 3:00 AM > > To: Frank Li > > Cc: lpieralisi@kernel.org; Aisheng Dong ; > > bhelgaas@google.com; devicetree@vger.kernel.org; festevam@gmail.com; > > imx@lists.linux.dev; jdmason@kudzu.us; kernel@pengutronix.de; > > kishon@ti.com; krzysztof.kozlowski+dt@linaro.org; kw@linux.com; linux- > > arm-kernel@lists.infradead.org; dl-linux-imx ; linux- > > kernel@vger.kernel.org; linux-pci@vger.kernel.org; > > lorenzo.pieralisi@arm.com; lznuaa@gmail.com; maz@kernel.org; > > ntb@lists.linux.dev; Peng Fan ; robh+dt@kernel.org; > > s.hauer@pengutronix.de; shawnguo@kernel.org; tglx@linutronix.de > > Subject: [EXT] Re: [PATCH v13 2/2] PCI: endpoint: pci-epf-vntb: using platform > > MSI as doorbell > > > > Caution: EXT Email > > > > On Thu, Nov 24, 2022 at 12:50:36AM -0500, Frank Li wrote: > > > ┌────────────┐ ┌─────────────── > > ────────────────────┐ ┌───────── > > ───────┐ > > > │ │ │ │ │ │ > > > │ │ │ PCI Endpoint │ │ PCI Host │ > > > │ │ │ │ │ │ > > > │ │◄──┤ 1.platform_msi_domain_alloc_irqs()│ │ > > │ > > > │ │ │ │ │ │ > > > │ MSI ├──►│ 2.write_msi_msg() ├──►├─BAR > > │ > > > │ Controller │ │ update doorbell register address│ │ │ > > > │ │ │ for BAR │ │ │ > > > │ │ │ │ │ 3. Write BAR│ > > > │ │◄──┼────────────────────── > > ─────────────┼───┤ │ > > > │ │ │ │ │ │ > > > │ ├──►│ 4.Irq Handle │ │ │ > > > │ │ │ │ │ │ > > > │ │ │ │ │ │ > > > └────────────┘ └─────────────── > > ────────────────────┘ └───────── > > ───────┘ > > > > > > > There are at least couple of BAR regions used in this patch but they were not > > mentioned in the above diagram. > > This patch just affected one BAR regions. Do you like "BAR[DB]"? > > Do you want to me draw other BARs, which used by this function? > It'd be good to just mention DB BAR. > > > > The subject should be: > > > > "PCI: endpoint: pci-epf-vntb: Use EP MSI controller to handle DB from host" > > > > > Using platform MSI interrupt controller as endpoint(EP)'s doorbell. > > > > > > > Above line is not needed. > > > > > The memory assigned for BAR region by the PCI host is mapped to the > > > > Which BAR? (BAR 1 aka. DB BAR)? There are multiple BAR regions exposed by > > this function driver. > > > > > message address of platform msi interrupt controller in PCI Endpoint. > > > > s/msi/MSI. Also, use either Endpoint or EP, pick one but not both. > > > > > Such that, whenever the PCI host writes to the BAR region, it will > > > trigger an IRQ in the EP. > > > > > > Basic working follow as > > > > "work flow is"? > > > > > 1. EP function driver call platform_msi_domain_alloc_irqs() alloc a > > > > pci-epf-vntb function driver calls platform_msi_domain_alloc_irqs() to > > allocate > > MSI's from the platform MSI controller. > > > > > MSI irq from MSI controller with call back function write_msi_msg(); > > > 2. write_msg_msg will config BAR and map to address defined in msi_msg; > > > > The epf_ntb_write_msi_msg() passed as a callback will write the offset of the > > MSI controller's MSI address dedicated for each MSI to the doorbell register > > db_offset and also writes the MSI data to db_data register in the CTRL BAR > > region. > > > > > 3. Host side trigger an IRQ at Endpoint by write to BAR region. > > > > > > > Finally, the host can trigger doorbell by reading the offset of the doorbell > > from db_offset register and writing the data read from db_data register in > > CTRL > > BAR region to the computed address in the DB BAR region. > > > > > Add MSI doorbell support for pci-epf-vntb. Query if system has an MSI > > > controller. Set up doorbell address according to struct msi_msg. > > > > > > So PCI host can write this doorbell address to trigger EP side's IRQ. > > > > > > If no MSI controller exists, fall back to software polling. > > > > > > > "Add doorbell support to pci-epf-vntb function driver making use of the > > platform > > MSI controller. If the MSI controller is not available, fallback to the polling > > method." > > > > Also, please move this paragraph to the beginning of the description. > > > > > Signed-off-by: Frank Li > > > --- > > > drivers/pci/endpoint/functions/pci-epf-vntb.c | 146 +++++++++++++++--- > > > 1 file changed, 125 insertions(+), 21 deletions(-) > > > > > > diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c > > b/drivers/pci/endpoint/functions/pci-epf-vntb.c > > > index 0d744975f815..f770a068e58c 100644 > > > --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c > > > +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c > > > @@ -44,6 +44,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > > > > static struct workqueue_struct *kpcintb_workqueue; > > > > > > @@ -137,11 +138,14 @@ struct epf_ntb { > > > struct epf_ntb_ctrl *reg; > > > > > > u32 *epf_db; > > > + phys_addr_t epf_db_phys; > > > > > > phys_addr_t vpci_mw_phy[MAX_MW]; > > > void __iomem *vpci_mw_addr[MAX_MW]; > > > > > > struct delayed_work cmd_handler; > > > + > > > + int msi_virqbase; > > > }; > > > > You should add kernel doc comments for this struct in a separate patch. It > > will > > help in understanding the driver better. > > > > > > > > #define to_epf_ntb(epf_group) container_of((epf_group), struct epf_ntb, > > group) > > > @@ -256,11 +260,13 @@ static void epf_ntb_cmd_handler(struct > > work_struct *work) > > > > > > ntb = container_of(work, struct epf_ntb, cmd_handler.work); > > > > > > - for (i = 1; i < ntb->db_count; i++) { > > > - if (ntb->epf_db[i]) { > > > - ntb->db |= 1 << (i - 1); > > > - ntb_db_event(&ntb->ntb, i); > > > - ntb->epf_db[i] = 0; > > > > A comment here stating that polling is implemented would be better. > > > > > + if (!ntb->epf_db_phys) { > > > + for (i = 1; i < ntb->db_count; i++) { > > > + if (ntb->epf_db[i]) { > > > + ntb->db |= 1 << (i - 1); > > > + ntb_db_event(&ntb->ntb, i); > > > + ntb->epf_db[i] = 0; > > > + } > > > } > > > } > > > > > > @@ -518,6 +524,28 @@ static int epf_ntb_configure_interrupt(struct > > epf_ntb *ntb) > > > return 0; > > > } > > > > > > +static int epf_ntb_db_size(struct epf_ntb *ntb) > > > +{ > > > + const struct pci_epc_features *epc_features; > > > + size_t size = sizeof(u32) * ntb->db_count; > > > + u32 align; > > > + > > > + epc_features = pci_epc_get_features(ntb->epf->epc, > > > + ntb->epf->func_no, > > > + ntb->epf->vfunc_no); > > > + align = epc_features->align; > > > + > > > + if (size < 128) > > > > Shouldn't this be (size > 128)? > > This is one coming from pci-epf-ntb.c. > Not sure there are some EP hardware have such limitation. > I'm not sure if that is correct though. drivers/ntb/hw/epf/ntb_hw_epf.c sets the upper limit to 32 (NTB_EPF_MAX_DB_COUNT + 1) DBs, in that case the size cannot go beyond 128. Thanks, Mani -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40D21C43219 for ; Thu, 24 Nov 2022 18:46:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AxawWY6YRTD9YG9NZhMf3maNNmUk/VnSSwugH5Cr/Hg=; b=V45ITmm2jXe4Qn iznLcT6qmJxRgjdJguXeXRk342o+RH2geS+VC+0WULXFAc+P18LB3MSXggIs9W+r+WKsxwrRCi1Dq Qr2ADcKAV5YngiMBqgnF809pwcmhrFz4hCCI/066lSk6/uTNhQXL0Bh5VpTEzohCftD+jmnLgysuy xUW3DtZydOFoYv4OaQk/WGVUuRCl26rklJBQmJ4yGQimHpkkFYlDmH8u9cJsZJr/w2n+uJz7++ogU J9e5w1lhOoy2nz9m/a7Dz0P86HwzIEIt34kGKoI4XBm01Aj8TQWlppoCRTigFClthfws3deHWtX2R vSFNhwi/av2ly5ymMEOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oyHDd-00B0so-Iz; Thu, 24 Nov 2022 18:45:05 +0000 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oyHDZ-00B0pW-NB for linux-arm-kernel@lists.infradead.org; Thu, 24 Nov 2022 18:45:03 +0000 Received: by mail-pj1-x102e.google.com with SMTP id 3-20020a17090a098300b00219041dcbe9so1075038pjo.3 for ; Thu, 24 Nov 2022 10:44:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=5mUc7Hj+XQfjTjlDIFjVYP+TraLI2iMKH19WfjbmoCU=; b=qrssbKT0+X3S2a2vA11xfRsFFE4GBXlNnE3Zh83wyE/w7BcnXA8O3tKMV+MsNTedd5 o2mVKqmODuotSHR59IgWUSH7zyL9r+dwGCTFvGwDKbxkauQMab+S2T5Xs9LFCwVVdM9j WkqgWig6tXHfByOjZfNwAeyBf+1vh+Mo9PGTt+HkZbpWqABdUpLksBLyvCf+ZhhWeyGs MyoeWSKhjiXt95/TxHXXFXJ6T3stbaWbvDWF8SAxiNYpxnIr+awhB3hb1Pdep/8Ho6cP BqQw87mzNiLP6hXkkFbJNy1ty49OtCtlsq7XDbZL9zMxLQ0IhbpTfHkIXSpmNfWPIMU7 OdKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5mUc7Hj+XQfjTjlDIFjVYP+TraLI2iMKH19WfjbmoCU=; b=Gek2RAvKVI/Vs554gkuEUcThXDIHydy6rIuLlWoGqKl+PbiMkk+ehF9KD+mRf8pRUd yDLs6q27BBZHF1mlp3YRa9pHm/P+HksuaXQJsM1vp/IxiXDL84HTa6vD2HiFIlp3ulr/ zYFdHkldGU7yx85XBtbTUT9Ha48Y6uO7uTNkP0KYUxD6865Ysw321FXVu6PYT7t6Tife 0/wO+vLydyUQUv93KB35eoN5y8I2Y7Cd61YJgtAS9uiBEEk/D1PRRsci94NjzVmXkMsW 6pNm+WD+8ckas5rckNHmmUUUFz8+sBG16S5z5+xLtGXs0aTAF337dwEtRovjjSnuYEnT TuWQ== X-Gm-Message-State: ANoB5pmzbWhkW4614a0AmMf2lb3SrWvt0Afm9undMXwWHJfPNRbSNoFO X6xZODTIPcQk6ECIrRTG1hhq X-Google-Smtp-Source: AA0mqf5MMfxGvtucAaoiCKcufA3lnsdQsAgasNIMeAFqC8DNifHVxaNFhZZEDb+GN87gxeUCiAxbxw== X-Received: by 2002:a17:90b:358a:b0:218:c490:33f6 with SMTP id mm10-20020a17090b358a00b00218c49033f6mr17801949pjb.83.1669315498433; Thu, 24 Nov 2022 10:44:58 -0800 (PST) Received: from thinkpad ([117.202.190.212]) by smtp.gmail.com with ESMTPSA id b12-20020aa7950c000000b0056c349f5c70sm1539156pfp.79.2022.11.24.10.44.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Nov 2022 10:44:57 -0800 (PST) Date: Fri, 25 Nov 2022 00:14:48 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: "lpieralisi@kernel.org" , Aisheng Dong , "bhelgaas@google.com" , "devicetree@vger.kernel.org" , "festevam@gmail.com" , "imx@lists.linux.dev" , "jdmason@kudzu.us" , "kernel@pengutronix.de" , "kishon@ti.com" , "krzysztof.kozlowski+dt@linaro.org" , "kw@linux.com" , "linux-arm-kernel@lists.infradead.org" , dl-linux-imx , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , "lorenzo.pieralisi@arm.com" , "lznuaa@gmail.com" , "maz@kernel.org" , "ntb@lists.linux.dev" , Peng Fan , "robh+dt@kernel.org" , "s.hauer@pengutronix.de" , "shawnguo@kernel.org" , "tglx@linutronix.de" Subject: Re: [EXT] Re: [PATCH v13 2/2] PCI: endpoint: pci-epf-vntb: using platform MSI as doorbell Message-ID: <20221124184448.GF5119@thinkpad> References: <20221124055036.1630573-1-Frank.Li@nxp.com> <20221124055036.1630573-3-Frank.Li@nxp.com> <20221124090028.GC5119@thinkpad> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221124_104501_792345_8061B298 X-CRM114-Status: GOOD ( 50.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBOb3YgMjQsIDIwMjIgYXQgMDY6MDM6NDBQTSArMDAwMCwgRnJhbmsgTGkgd3JvdGU6 Cj4gCj4gCj4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+ID4gRnJvbTogTWFuaXZhbm5h biBTYWRoYXNpdmFtIDxtYW5pdmFubmFuLnNhZGhhc2l2YW1AbGluYXJvLm9yZz4KPiA+IFNlbnQ6 IFRodXJzZGF5LCBOb3ZlbWJlciAyNCwgMjAyMiAzOjAwIEFNCj4gPiBUbzogRnJhbmsgTGkgPGZy YW5rLmxpQG54cC5jb20+Cj4gPiBDYzogbHBpZXJhbGlzaUBrZXJuZWwub3JnOyBBaXNoZW5nIERv bmcgPGFpc2hlbmcuZG9uZ0BueHAuY29tPjsKPiA+IGJoZWxnYWFzQGdvb2dsZS5jb207IGRldmlj ZXRyZWVAdmdlci5rZXJuZWwub3JnOyBmZXN0ZXZhbUBnbWFpbC5jb207Cj4gPiBpbXhAbGlzdHMu bGludXguZGV2OyBqZG1hc29uQGt1ZHp1LnVzOyBrZXJuZWxAcGVuZ3V0cm9uaXguZGU7Cj4gPiBr aXNob25AdGkuY29tOyBrcnp5c3p0b2Yua296bG93c2tpK2R0QGxpbmFyby5vcmc7IGt3QGxpbnV4 LmNvbTsgbGludXgtCj4gPiBhcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmc7IGRsLWxpbnV4 LWlteCA8bGludXgtaW14QG54cC5jb20+OyBsaW51eC0KPiA+IGtlcm5lbEB2Z2VyLmtlcm5lbC5v cmc7IGxpbnV4LXBjaUB2Z2VyLmtlcm5lbC5vcmc7Cj4gPiBsb3JlbnpvLnBpZXJhbGlzaUBhcm0u Y29tOyBsem51YWFAZ21haWwuY29tOyBtYXpAa2VybmVsLm9yZzsKPiA+IG50YkBsaXN0cy5saW51 eC5kZXY7IFBlbmcgRmFuIDxwZW5nLmZhbkBueHAuY29tPjsgcm9iaCtkdEBrZXJuZWwub3JnOwo+ ID4gcy5oYXVlckBwZW5ndXRyb25peC5kZTsgc2hhd25ndW9Aa2VybmVsLm9yZzsgdGdseEBsaW51 dHJvbml4LmRlCj4gPiBTdWJqZWN0OiBbRVhUXSBSZTogW1BBVENIIHYxMyAyLzJdIFBDSTogZW5k cG9pbnQ6IHBjaS1lcGYtdm50YjogdXNpbmcgcGxhdGZvcm0KPiA+IE1TSSBhcyBkb29yYmVsbAo+ ID4gCj4gPiBDYXV0aW9uOiBFWFQgRW1haWwKPiA+IAo+ID4gT24gVGh1LCBOb3YgMjQsIDIwMjIg YXQgMTI6NTA6MzZBTSAtMDUwMCwgRnJhbmsgTGkgd3JvdGU6Cj4gPiA+IOKUjOKUgOKUgOKUgOKU gOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUkCAgIOKUjOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKU gOKUgOKUgOKUgOKUgOKUgOKUgOKUgAo+ID4g4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA 4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSQICAg4pSM4pSA4pSA4pSA4pSA4pSA4pSA 4pSA4pSA4pSACj4gPiDilIDilIDilIDilIDilIDilIDilIDilJAKPiA+ID4g4pSCICAgICAgICAg ICAg4pSCICAg4pSCICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICDilIIgICDilIIg ICAgICAgICAgICAgICAg4pSCCj4gPiA+IOKUgiAgICAgICAgICAgIOKUgiAgIOKUgiBQQ0kgRW5k cG9pbnQgICAgICAgICAgICAgICAgICAgICAg4pSCICAg4pSCIFBDSSBIb3N0ICAgICAgIOKUggo+ ID4gPiDilIIgICAgICAgICAgICDilIIgICDilIIgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIOKUgiAgIOKUgiAgICAgICAgICAgICAgICDilIIKPiA+ID4g4pSCICAgICAgICAgICAg 4pSC4peE4pSA4pSA4pSkIDEucGxhdGZvcm1fbXNpX2RvbWFpbl9hbGxvY19pcnFzKCnilIIgICDi lIIKPiA+IOKUggo+ID4gPiDilIIgICAgICAgICAgICDilIIgICDilIIgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIOKUgiAgIOKUgiAgICAgICAgICAgICAgICDilIIKPiA+ID4g4pSC IE1TSSAgICAgICAg4pSc4pSA4pSA4pa64pSCIDIud3JpdGVfbXNpX21zZygpICAgICAgICAgICAg ICAgICDilJzilIDilIDilrrilJzilIBCQVI8bj4KPiA+IOKUggo+ID4gPiDilIIgQ29udHJvbGxl ciDilIIgICDilIIgICB1cGRhdGUgZG9vcmJlbGwgcmVnaXN0ZXIgYWRkcmVzc+KUgiAgIOKUgiAg ICAgICAgICAgICAgICDilIIKPiA+ID4g4pSCICAgICAgICAgICAg4pSCICAg4pSCICAgZm9yIEJB UiAgICAgICAgICAgICAgICAgICAgICAgICDilIIgICDilIIgICAgICAgICAgICAgICAg4pSCCj4g PiA+IOKUgiAgICAgICAgICAgIOKUgiAgIOKUgiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAg4pSCICAg4pSCIDMuIFdyaXRlIEJBUjxuPuKUggo+ID4gPiDilIIgICAgICAgICAgICDi lILil4TilIDilIDilLzilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDi lIDilIDilIDilIDilIDilIDilIDilIAKPiA+IOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKU gOKUgOKUgOKUgOKUvOKUgOKUgOKUgOKUpCAgICAgICAgICAgICAgICDilIIKPiA+ID4g4pSCICAg ICAgICAgICAg4pSCICAg4pSCICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICDilIIg ICDilIIgICAgICAgICAgICAgICAg4pSCCj4gPiA+IOKUgiAgICAgICAgICAgIOKUnOKUgOKUgOKW uuKUgiA0LklycSBIYW5kbGUgICAgICAgICAgICAgICAgICAgICAg4pSCICAg4pSCICAgICAgICAg ICAgICAgIOKUggo+ID4gPiDilIIgICAgICAgICAgICDilIIgICDilIIgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIOKUgiAgIOKUgiAgICAgICAgICAgICAgICDilIIKPiA+ID4g4pSC ICAgICAgICAgICAg4pSCICAg4pSCICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICDi lIIgICDilIIgICAgICAgICAgICAgICAg4pSCCj4gPiA+IOKUlOKUgOKUgOKUgOKUgOKUgOKUgOKU gOKUgOKUgOKUgOKUgOKUgOKUmCAgIOKUlOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKU gOKUgOKUgOKUgOKUgAo+ID4g4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA 4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSYICAg4pSU4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA Cj4gPiDilIDilIDilIDilIDilIDilIDilIDilJgKPiA+ID4KPiA+IAo+ID4gVGhlcmUgYXJlIGF0 IGxlYXN0IGNvdXBsZSBvZiBCQVIgcmVnaW9ucyB1c2VkIGluIHRoaXMgcGF0Y2ggYnV0IHRoZXkg d2VyZSBub3QKPiA+IG1lbnRpb25lZCBpbiB0aGUgYWJvdmUgZGlhZ3JhbS4KPiAKPiBUaGlzIHBh dGNoIGp1c3QgYWZmZWN0ZWQgb25lIEJBUiByZWdpb25zLiAgRG8geW91IGxpa2UgIkJBUltEQl0i Pwo+IAo+IERvIHlvdSB3YW50IHRvIG1lIGRyYXcgb3RoZXIgQkFScywgd2hpY2ggdXNlZCBieSB0 aGlzIGZ1bmN0aW9uPwo+IAoKSXQnZCBiZSBnb29kIHRvIGp1c3QgbWVudGlvbiBEQiBCQVIuCgo+ ID4gCj4gPiBUaGUgc3ViamVjdCBzaG91bGQgYmU6Cj4gPiAKPiA+ICJQQ0k6IGVuZHBvaW50OiBw Y2ktZXBmLXZudGI6IFVzZSBFUCBNU0kgY29udHJvbGxlciB0byBoYW5kbGUgREIgZnJvbSBob3N0 Igo+ID4gCj4gPiA+IFVzaW5nIHBsYXRmb3JtIE1TSSBpbnRlcnJ1cHQgY29udHJvbGxlciBhcyBl bmRwb2ludChFUCkncyBkb29yYmVsbC4KPiA+ID4KPiA+IAo+ID4gQWJvdmUgbGluZSBpcyBub3Qg bmVlZGVkLgo+ID4gCj4gPiA+IFRoZSBtZW1vcnkgYXNzaWduZWQgZm9yIEJBUiByZWdpb24gYnkg dGhlIFBDSSBob3N0IGlzIG1hcHBlZCB0byB0aGUKPiA+IAo+ID4gV2hpY2ggQkFSPyAoQkFSIDEg YWthLiBEQiBCQVIpPyBUaGVyZSBhcmUgbXVsdGlwbGUgQkFSIHJlZ2lvbnMgZXhwb3NlZCBieQo+ ID4gdGhpcyBmdW5jdGlvbiBkcml2ZXIuCj4gPiAKPiA+ID4gbWVzc2FnZSBhZGRyZXNzIG9mIHBs YXRmb3JtIG1zaSBpbnRlcnJ1cHQgY29udHJvbGxlciBpbiBQQ0kgRW5kcG9pbnQuCj4gPiAKPiA+ IHMvbXNpL01TSS4gQWxzbywgdXNlIGVpdGhlciBFbmRwb2ludCBvciBFUCwgcGljayBvbmUgYnV0 IG5vdCBib3RoLgo+ID4gCj4gPiA+IFN1Y2ggdGhhdCwgd2hlbmV2ZXIgdGhlIFBDSSBob3N0IHdy aXRlcyB0byB0aGUgQkFSIHJlZ2lvbiwgaXQgd2lsbAo+ID4gPiB0cmlnZ2VyIGFuIElSUSBpbiB0 aGUgRVAuCj4gPiA+Cj4gPiA+IEJhc2ljIHdvcmtpbmcgZm9sbG93IGFzCj4gPiAKPiA+ICJ3b3Jr IGZsb3cgaXMiPwo+ID4gCj4gPiA+IDEuIEVQIGZ1bmN0aW9uIGRyaXZlciBjYWxsIHBsYXRmb3Jt X21zaV9kb21haW5fYWxsb2NfaXJxcygpIGFsbG9jIGEKPiA+IAo+ID4gcGNpLWVwZi12bnRiIGZ1 bmN0aW9uIGRyaXZlciBjYWxscyBwbGF0Zm9ybV9tc2lfZG9tYWluX2FsbG9jX2lycXMoKSB0bwo+ ID4gYWxsb2NhdGUKPiA+IE1TSSdzIGZyb20gdGhlIHBsYXRmb3JtIE1TSSBjb250cm9sbGVyLgo+ ID4gCj4gPiA+IE1TSSBpcnEgZnJvbSBNU0kgY29udHJvbGxlciB3aXRoIGNhbGwgYmFjayBmdW5j dGlvbiB3cml0ZV9tc2lfbXNnKCk7Cj4gPiA+IDIuIHdyaXRlX21zZ19tc2cgd2lsbCBjb25maWcg QkFSIGFuZCBtYXAgdG8gYWRkcmVzcyBkZWZpbmVkIGluIG1zaV9tc2c7Cj4gPiAKPiA+IFRoZSBl cGZfbnRiX3dyaXRlX21zaV9tc2coKSBwYXNzZWQgYXMgYSBjYWxsYmFjayB3aWxsIHdyaXRlIHRo ZSBvZmZzZXQgb2YgdGhlCj4gPiBNU0kgY29udHJvbGxlcidzIE1TSSBhZGRyZXNzIGRlZGljYXRl ZCBmb3IgZWFjaCBNU0kgdG8gdGhlIGRvb3JiZWxsIHJlZ2lzdGVyCj4gPiBkYl9vZmZzZXQgYW5k IGFsc28gd3JpdGVzIHRoZSBNU0kgZGF0YSB0byBkYl9kYXRhIHJlZ2lzdGVyIGluIHRoZSBDVFJM IEJBUgo+ID4gcmVnaW9uLgo+ID4gCj4gPiA+IDMuIEhvc3Qgc2lkZSB0cmlnZ2VyIGFuIElSUSBh dCBFbmRwb2ludCBieSB3cml0ZSB0byBCQVIgcmVnaW9uLgo+ID4gPgo+ID4gCj4gPiBGaW5hbGx5 LCB0aGUgaG9zdCBjYW4gdHJpZ2dlciBkb29yYmVsbCBieSByZWFkaW5nIHRoZSBvZmZzZXQgb2Yg dGhlIGRvb3JiZWxsCj4gPiBmcm9tIGRiX29mZnNldCByZWdpc3RlciBhbmQgd3JpdGluZyB0aGUg ZGF0YSByZWFkIGZyb20gZGJfZGF0YSByZWdpc3RlciBpbgo+ID4gQ1RSTAo+ID4gQkFSIHJlZ2lv biB0byB0aGUgY29tcHV0ZWQgYWRkcmVzcyBpbiB0aGUgREIgQkFSIHJlZ2lvbi4KPiA+IAo+ID4g PiBBZGQgTVNJIGRvb3JiZWxsIHN1cHBvcnQgZm9yIHBjaS1lcGYtdm50Yi4gUXVlcnkgaWYgc3lz dGVtIGhhcyBhbiBNU0kKPiA+ID4gY29udHJvbGxlci4gU2V0IHVwIGRvb3JiZWxsIGFkZHJlc3Mg YWNjb3JkaW5nIHRvIHN0cnVjdCBtc2lfbXNnLgo+ID4gPgo+ID4gPiBTbyBQQ0kgaG9zdCBjYW4g d3JpdGUgdGhpcyBkb29yYmVsbCBhZGRyZXNzIHRvIHRyaWdnZXIgRVAgc2lkZSdzIElSUS4KPiA+ ID4KPiA+ID4gSWYgbm8gTVNJIGNvbnRyb2xsZXIgZXhpc3RzLCBmYWxsIGJhY2sgdG8gc29mdHdh cmUgcG9sbGluZy4KPiA+ID4KPiA+IAo+ID4gIkFkZCBkb29yYmVsbCBzdXBwb3J0IHRvIHBjaS1l cGYtdm50YiBmdW5jdGlvbiBkcml2ZXIgbWFraW5nIHVzZSBvZiB0aGUKPiA+IHBsYXRmb3JtCj4g PiBNU0kgY29udHJvbGxlci4gSWYgdGhlIE1TSSBjb250cm9sbGVyIGlzIG5vdCBhdmFpbGFibGUs IGZhbGxiYWNrIHRvIHRoZSBwb2xsaW5nCj4gPiBtZXRob2QuIgo+ID4gCj4gPiBBbHNvLCBwbGVh c2UgbW92ZSB0aGlzIHBhcmFncmFwaCB0byB0aGUgYmVnaW5uaW5nIG9mIHRoZSBkZXNjcmlwdGlv bi4KPiA+IAo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBGcmFuayBMaSA8RnJhbmsuTGlAbnhwLmNvbT4K PiA+ID4gLS0tCj4gPiA+ICBkcml2ZXJzL3BjaS9lbmRwb2ludC9mdW5jdGlvbnMvcGNpLWVwZi12 bnRiLmMgfCAxNDYgKysrKysrKysrKysrKysrLS0tCj4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgMTI1 IGluc2VydGlvbnMoKyksIDIxIGRlbGV0aW9ucygtKQo+ID4gPgo+ID4gPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9wY2kvZW5kcG9pbnQvZnVuY3Rpb25zL3BjaS1lcGYtdm50Yi5jCj4gPiBiL2RyaXZl cnMvcGNpL2VuZHBvaW50L2Z1bmN0aW9ucy9wY2ktZXBmLXZudGIuYwo+ID4gPiBpbmRleCAwZDc0 NDk3NWY4MTUuLmY3NzBhMDY4ZTU4YyAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9wY2kvZW5k cG9pbnQvZnVuY3Rpb25zL3BjaS1lcGYtdm50Yi5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvcGNpL2Vu ZHBvaW50L2Z1bmN0aW9ucy9wY2ktZXBmLXZudGIuYwo+ID4gPiBAQCAtNDQsNiArNDQsNyBAQAo+ ID4gPiAgI2luY2x1ZGUgPGxpbnV4L3BjaS1lcGMuaD4KPiA+ID4gICNpbmNsdWRlIDxsaW51eC9w Y2ktZXBmLmg+Cj4gPiA+ICAjaW5jbHVkZSA8bGludXgvbnRiLmg+Cj4gPiA+ICsjaW5jbHVkZSA8 bGludXgvbXNpLmg+Cj4gPiA+Cj4gPiA+ICBzdGF0aWMgc3RydWN0IHdvcmtxdWV1ZV9zdHJ1Y3Qg KmtwY2ludGJfd29ya3F1ZXVlOwo+ID4gPgo+ID4gPiBAQCAtMTM3LDExICsxMzgsMTQgQEAgc3Ry dWN0IGVwZl9udGIgewo+ID4gPiAgICAgICBzdHJ1Y3QgZXBmX250Yl9jdHJsICpyZWc7Cj4gPiA+ Cj4gPiA+ICAgICAgIHUzMiAqZXBmX2RiOwo+ID4gPiArICAgICBwaHlzX2FkZHJfdCBlcGZfZGJf cGh5czsKPiA+ID4KPiA+ID4gICAgICAgcGh5c19hZGRyX3QgdnBjaV9td19waHlbTUFYX01XXTsK PiA+ID4gICAgICAgdm9pZCBfX2lvbWVtICp2cGNpX213X2FkZHJbTUFYX01XXTsKPiA+ID4KPiA+ ID4gICAgICAgc3RydWN0IGRlbGF5ZWRfd29yayBjbWRfaGFuZGxlcjsKPiA+ID4gKwo+ID4gPiAr ICAgICBpbnQgbXNpX3ZpcnFiYXNlOwo+ID4gPiAgfTsKPiA+IAo+ID4gWW91IHNob3VsZCBhZGQg a2VybmVsIGRvYyBjb21tZW50cyBmb3IgdGhpcyBzdHJ1Y3QgaW4gYSBzZXBhcmF0ZSBwYXRjaC4g SXQKPiA+IHdpbGwKPiA+IGhlbHAgaW4gdW5kZXJzdGFuZGluZyB0aGUgZHJpdmVyIGJldHRlci4K PiA+IAo+ID4gPgo+ID4gPiAgI2RlZmluZSB0b19lcGZfbnRiKGVwZl9ncm91cCkgY29udGFpbmVy X29mKChlcGZfZ3JvdXApLCBzdHJ1Y3QgZXBmX250YiwKPiA+IGdyb3VwKQo+ID4gPiBAQCAtMjU2 LDExICsyNjAsMTMgQEAgc3RhdGljIHZvaWQgZXBmX250Yl9jbWRfaGFuZGxlcihzdHJ1Y3QKPiA+ IHdvcmtfc3RydWN0ICp3b3JrKQo+ID4gPgo+ID4gPiAgICAgICBudGIgPSBjb250YWluZXJfb2Yo d29yaywgc3RydWN0IGVwZl9udGIsIGNtZF9oYW5kbGVyLndvcmspOwo+ID4gPgo+ID4gPiAtICAg ICBmb3IgKGkgPSAxOyBpIDwgbnRiLT5kYl9jb3VudDsgaSsrKSB7Cj4gPiA+IC0gICAgICAgICAg ICAgaWYgKG50Yi0+ZXBmX2RiW2ldKSB7Cj4gPiA+IC0gICAgICAgICAgICAgICAgICAgICBudGIt PmRiIHw9IDEgPDwgKGkgLSAxKTsKPiA+ID4gLSAgICAgICAgICAgICAgICAgICAgIG50Yl9kYl9l dmVudCgmbnRiLT5udGIsIGkpOwo+ID4gPiAtICAgICAgICAgICAgICAgICAgICAgbnRiLT5lcGZf ZGJbaV0gPSAwOwo+ID4gCj4gPiBBIGNvbW1lbnQgaGVyZSBzdGF0aW5nIHRoYXQgcG9sbGluZyBp cyBpbXBsZW1lbnRlZCB3b3VsZCBiZSBiZXR0ZXIuCj4gPiAKPiA+ID4gKyAgICAgaWYgKCFudGIt PmVwZl9kYl9waHlzKSB7Cj4gPiA+ICsgICAgICAgICAgICAgZm9yIChpID0gMTsgaSA8IG50Yi0+ ZGJfY291bnQ7IGkrKykgewo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgaWYgKG50Yi0+ZXBm X2RiW2ldKSB7Cj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG50Yi0+ZGIgfD0g MSA8PCAoaSAtIDEpOwo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICBudGJfZGJf ZXZlbnQoJm50Yi0+bnRiLCBpKTsKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg bnRiLT5lcGZfZGJbaV0gPSAwOwo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgfQo+ID4gPiAg ICAgICAgICAgICAgIH0KPiA+ID4gICAgICAgfQo+ID4gPgo+ID4gPiBAQCAtNTE4LDYgKzUyNCwy OCBAQCBzdGF0aWMgaW50IGVwZl9udGJfY29uZmlndXJlX2ludGVycnVwdChzdHJ1Y3QKPiA+IGVw Zl9udGIgKm50YikKPiA+ID4gICAgICAgcmV0dXJuIDA7Cj4gPiA+ICB9Cj4gPiA+Cj4gPiA+ICtz dGF0aWMgaW50IGVwZl9udGJfZGJfc2l6ZShzdHJ1Y3QgZXBmX250YiAqbnRiKQo+ID4gPiArewo+ ID4gPiArICAgICBjb25zdCBzdHJ1Y3QgcGNpX2VwY19mZWF0dXJlcyAqZXBjX2ZlYXR1cmVzOwo+ ID4gPiArICAgICBzaXplX3Qgc2l6ZSA9IHNpemVvZih1MzIpICogbnRiLT5kYl9jb3VudDsKPiA+ ID4gKyAgICAgdTMyIGFsaWduOwo+ID4gPiArCj4gPiA+ICsgICAgIGVwY19mZWF0dXJlcyA9IHBj aV9lcGNfZ2V0X2ZlYXR1cmVzKG50Yi0+ZXBmLT5lcGMsCj4gPiA+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIG50Yi0+ZXBmLT5mdW5jX25vLAo+ID4gPiArICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBudGItPmVwZi0+dmZ1bmNfbm8pOwo+ ID4gPiArICAgICBhbGlnbiA9IGVwY19mZWF0dXJlcy0+YWxpZ247Cj4gPiA+ICsKPiA+ID4gKyAg ICAgaWYgKHNpemUgPCAxMjgpCj4gPiAKPiA+IFNob3VsZG4ndCB0aGlzIGJlIChzaXplID4gMTI4 KT8KPiAgCj4gVGhpcyBpcyBvbmUgY29taW5nIGZyb20gcGNpLWVwZi1udGIuYy4KPiBOb3Qgc3Vy ZSB0aGVyZSBhcmUgc29tZSBFUCBoYXJkd2FyZSBoYXZlIHN1Y2ggbGltaXRhdGlvbi4KPiAgCgpJ J20gbm90IHN1cmUgaWYgdGhhdCBpcyBjb3JyZWN0IHRob3VnaC4gZHJpdmVycy9udGIvaHcvZXBm L250Yl9od19lcGYuYyBzZXRzCnRoZSB1cHBlciBsaW1pdCB0byAzMiAoTlRCX0VQRl9NQVhfREJf Q09VTlQgKyAxKSBEQnMsIGluIHRoYXQgY2FzZSB0aGUgc2l6ZQpjYW5ub3QgZ28gYmV5b25kIDEy OC4KClRoYW5rcywKTWFuaQotLSAK4K6u4K6j4K6/4K614K6j4K+N4K6j4K6p4K+NIOCumuCupOCu vuCumuCuv+CuteCuruCvjQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtYXJtLWtlcm5lbAo=