From: Dylan Yudaken <dylany@meta.com>
To: Jens Axboe <axboe@kernel.dk>, Pavel Begunkov <asml.silence@gmail.com>
Cc: <io-uring@vger.kernel.org>, <kernel-team@fb.com>,
Dylan Yudaken <dylany@meta.com>
Subject: [PATCH for-next 1/3] io_uring: remove io_req_complete_post_tw
Date: Fri, 25 Nov 2022 02:34:10 -0800 [thread overview]
Message-ID: <20221125103412.1425305-2-dylany@meta.com> (raw)
In-Reply-To: <20221125103412.1425305-1-dylany@meta.com>
It's only used in one place. Inline it.
Signed-off-by: Dylan Yudaken <dylany@meta.com>
---
io_uring/io_uring.c | 2 +-
io_uring/io_uring.h | 7 -------
2 files changed, 1 insertion(+), 8 deletions(-)
diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c
index 164904e7da25..38589cf380d1 100644
--- a/io_uring/io_uring.c
+++ b/io_uring/io_uring.c
@@ -1521,7 +1521,7 @@ void io_req_task_complete(struct io_kiocb *req, bool *locked)
if (*locked)
io_req_complete_defer(req);
else
- io_req_complete_post_tw(req, locked);
+ io_req_complete_post(req, IO_URING_F_UNLOCKED);
}
/*
diff --git a/io_uring/io_uring.h b/io_uring/io_uring.h
index dcb8e3468f1d..76659d2fc90c 100644
--- a/io_uring/io_uring.h
+++ b/io_uring/io_uring.h
@@ -37,13 +37,6 @@ bool io_aux_cqe(struct io_ring_ctx *ctx, bool defer, u64 user_data, s32 res, u32
bool allow_overflow);
void __io_commit_cqring_flush(struct io_ring_ctx *ctx);
-static inline void io_req_complete_post_tw(struct io_kiocb *req, bool *locked)
-{
- unsigned flags = *locked ? 0 : IO_URING_F_UNLOCKED;
-
- io_req_complete_post(req, flags);
-}
-
struct page **io_pin_pages(unsigned long ubuf, unsigned long len, int *npages);
struct file *io_file_get_normal(struct io_kiocb *req, int fd);
--
2.30.2
next prev parent reply other threads:[~2022-11-25 10:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 10:34 [PATCH for-next 0/3] io_uring: completion cleanups Dylan Yudaken
2022-11-25 10:34 ` Dylan Yudaken [this message]
2022-11-25 10:34 ` [PATCH for-next 2/3] io_uring: spelling fix Dylan Yudaken
2022-11-25 10:34 ` [PATCH for-next 3/3] io_uring: Revert "io_uring: io_req_complete_post should defer if available" Dylan Yudaken
2022-11-25 13:13 ` (subset) [PATCH for-next 0/3] io_uring: completion cleanups Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221125103412.1425305-2-dylany@meta.com \
--to=dylany@meta.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=kernel-team@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.