From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07911C4332F for ; Fri, 25 Nov 2022 18:45:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7iV+ipwE9KFJHSzygwA/cgGB3Oga1vTh/VVwEA8RDfA=; b=tyuxMUA7YoIcgA B8Jk4uPJSWjexuq1fURg4Moa7C4YhpPRoZGAJCFdu3dPyvVd5NpG3+BohBPeb8Z1dsRj3m8nBvoYX SjxbDCf8uWT+EypmXxSuwpKQvmVPCaFxU6vNWbj7KfGy8iAFr/8W0JTBJobGyejcfilud12DQ1pRo gWeJrv3v/d5PYDuYOasiU7I/PzqH/wY2aMcFRsyP7Krwoa7iKeyq4mC4LBLHqYq7oE42kJdKOGXx2 TVG5OCyMOgqDU5G5l+pS5hAkZPWuq+3eDLyW5f/PALTta9LqDdAP7/QQFnq/9OgbXtfsz5ZQM4yPt /AXuuS2BAFXcNhFj4jlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oydgK-001J6E-0K; Fri, 25 Nov 2022 18:44:12 +0000 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oydgG-001J2y-Kh for linux-arm-kernel@lists.infradead.org; Fri, 25 Nov 2022 18:44:10 +0000 Received: by mail-pj1-x1035.google.com with SMTP id a1-20020a17090abe0100b00218a7df7789so8400831pjs.5 for ; Fri, 25 Nov 2022 10:44:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=YFUcQ3hLuxafQYtxQnWs87DdE99a3mWHbnJqXUnaU40=; b=wJNS50eWgo70qBzwRJ/eacnPCkagYxdtrqNdFD4nfBt0ByVzB1jHs4I5dSd7W/hRlV XLAEIcyFK1c0YL3L1oqAuONU+7aF5NIHAIWAFc/UoPvh8fGWv8DU+nDyugqquQphVyvy mZABavgj6fEQ9KleIjLsKS88R8uRtrMJPlde1PWmnrp1JLlbdjF12SwrSyZN0pRoGlrv /Os3aKcXhKKm91745O+g/S8vJk9t8X2eCEWZ6Rfxvjdgw3BhUKoKF0v8KOm8HFZZNMFU 1Cce1lG+UBgDXqirKs4LEddhvaXFYG+kvCfyImLrnlMPxeu1GvJASeqKrpq/mYrOI6iR MUqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YFUcQ3hLuxafQYtxQnWs87DdE99a3mWHbnJqXUnaU40=; b=WFeGvY9iZOlxDn5/NCCtQ6/5NSZiIdj33WON7zk2C/KgRBpVhAg4y0kUvz0NarSAoI Uo+RSIuCtXH6PWhREa6yTV60DyqN7rF199d3PpYBcaVvd6AbBFILaud53AY+23IZvhVs K1ZOXlt29cwOFV+WighVXahyBhHZrtAB0ZWJCrDWCV2mSIVz3tuPK5FI2LDd0ugcvxN/ gGVvFsue2NSbW2PD8J/0vRhU/y+Ij20f4C4lCqQpmE1OZdkCF1H1mh6rMAaRl3wfsCh/ jYbK77OECVEl9NocWES3AHK1Tc309Gl42sPGv7EIaa++rX/QGBjErIMEb1gmnSHHwAGR 3+AQ== X-Gm-Message-State: ANoB5plQLRkhtIsvWE6mKkVG5Et73l8ceu0cZnkTBETgVvIv90scRMRB 0NNmTo67SKJfu6hGycrbVIIsaw== X-Google-Smtp-Source: AA0mqf7dGVW4MXOGlUxRKNCXMQzyzk240b9VEqd1QcNaooVXqjFTk78T7hsrfzGxsU2Jndumrs3gNA== X-Received: by 2002:a17:90a:c006:b0:219:158d:b19a with SMTP id p6-20020a17090ac00600b00219158db19amr2114270pjt.152.1669401844720; Fri, 25 Nov 2022 10:44:04 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id x13-20020aa79a4d000000b0056ba7cda4b5sm3522287pfj.16.2022.11.25.10.44.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Nov 2022 10:44:04 -0800 (PST) Date: Fri, 25 Nov 2022 10:44:01 -0800 From: Stephen Hemminger To: Maciej Fijalkowski Cc: Vladimir Oltean , , "David S. Miller" , "Eric Dumazet" , Jakub Kicinski , Paolo Abeni , Claudiu Manoil , "Giuseppe Cavallaro" , Alexandre Torgue , Jose Abreu , "Maxime Coquelin" , Yang Yang , "Xu Panda" , , , Subject: Re: [PATCH net-next] Revert "net: stmmac: use sysfs_streq() instead of strncmp()" Message-ID: <20221125104401.0e18979f@hermes.local> In-Reply-To: References: <20221125105304.3012153-1-vladimir.oltean@nxp.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221125_104408_918592_327497A8 X-CRM114-Status: GOOD ( 30.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAyNSBOb3YgMjAyMiAxMjo1ODoyMyArMDEwMApNYWNpZWogRmlqYWxrb3dza2kgPG1h Y2llai5maWphbGtvd3NraUBpbnRlbC5jb20+IHdyb3RlOgoKPiBPbiBGcmksIE5vdiAyNSwgMjAy MiBhdCAxMjo1MzowNFBNICswMjAwLCBWbGFkaW1pciBPbHRlYW4gd3JvdGU6Cj4gPiBUaGlzIHJl dmVydHMgY29tbWl0IGY3MmNkNzZiMDVlYTFjZTkyNTg0ODRlODEyNzkzMmQwZWE5MjhmMjIuCj4g PiBUaGlzIHBhdGNoIGlzIHNvIGJyb2tlbiwgaXQgaHVydHMuIEFwcGFyZW50bHkgbm8gb25lIHJl dmlld2VkIGl0IGFuZCBpdAo+ID4gcGFzc2VkIHRoZSBidWlsZCB0ZXN0aW5nIChiZWNhdXNlIHRo ZSBjb2RlIHdhcyBjb21waWxlZCBvdXQpLCBidXQgaXQgd2FzCj4gPiBvYnZpb3VzbHkgbmV2ZXIg Y29tcGlsZS10ZXN0ZWQsIHNpbmNlIGl0IHByb2R1Y2VzIHRoZSBmb2xsb3dpbmcgYnVpbGQKPiA+ IGVycm9yLCBkdWUgdG8gYW4gaW5jb21wbGV0ZSBjb252ZXJzaW9uIHdoZXJlIGFuIGV4dHJhIGFy Z3VtZW50IHdhcyBsZWZ0LAo+ID4gYWx0aG91Z2ggdGhlIGZ1bmN0aW9uIGJlaW5nIGNhbGxlZCB3 YXMgbGVmdDoKPiA+IAo+ID4gc3RtbWFjX21haW4uYzogSW4gZnVuY3Rpb24g4oCYc3RtbWFjX2Nt ZGxpbmVfb3B04oCZOgo+ID4gc3RtbWFjX21haW4uYzo3NTg2OjI4OiBlcnJvcjogdG9vIG1hbnkg YXJndW1lbnRzIHRvIGZ1bmN0aW9uIOKAmHN5c2ZzX3N0cmVx4oCZCj4gPiAgNzU4NiB8ICAgICAg ICAgICAgICAgICB9IGVsc2UgaWYgKHN5c2ZzX3N0cmVxKG9wdCwgInBhdXNlOiIsIDYpKSB7Cj4g PiAgICAgICB8ICAgICAgICAgICAgICAgICAgICAgICAgICAgIF5+fn5+fn5+fn5+Cj4gPiBJbiBm aWxlIGluY2x1ZGVkIGZyb20gLi4vaW5jbHVkZS9saW51eC9iaXRtYXAuaDoxMSwKPiA+ICAgICAg ICAgICAgICAgICAgZnJvbSAuLi9pbmNsdWRlL2xpbnV4L2NwdW1hc2suaDoxMiwKPiA+ICAgICAg ICAgICAgICAgICAgZnJvbSAuLi9pbmNsdWRlL2xpbnV4L3NtcC5oOjEzLAo+ID4gICAgICAgICAg ICAgICAgICBmcm9tIC4uL2luY2x1ZGUvbGludXgvbG9ja2RlcC5oOjE0LAo+ID4gICAgICAgICAg ICAgICAgICBmcm9tIC4uL2luY2x1ZGUvbGludXgvbXV0ZXguaDoxNywKPiA+ICAgICAgICAgICAg ICAgICAgZnJvbSAuLi9pbmNsdWRlL2xpbnV4L25vdGlmaWVyLmg6MTQsCj4gPiAgICAgICAgICAg ICAgICAgIGZyb20gLi4vaW5jbHVkZS9saW51eC9jbGsuaDoxNCwKPiA+ICAgICAgICAgICAgICAg ICAgZnJvbSAuLi9kcml2ZXJzL25ldC9ldGhlcm5ldC9zdG1pY3JvL3N0bW1hYy9zdG1tYWNfbWFp bi5jOjE3Ogo+ID4gLi4vaW5jbHVkZS9saW51eC9zdHJpbmcuaDoxODU6MTM6IG5vdGU6IGRlY2xh cmVkIGhlcmUKPiA+ICAgMTg1IHwgZXh0ZXJuIGJvb2wgc3lzZnNfc3RyZXEoY29uc3QgY2hhciAq czEsIGNvbnN0IGNoYXIgKnMyKTsKPiA+ICAgICAgIHwgICAgICAgICAgICAgXn5+fn5+fn5+fn4K PiA+IAo+ID4gV2hhdCdzIGV2ZW4gd29yc2UgaXMgdGhhdCB0aGUgcGF0Y2ggaXMgZmxhdCBvdXQg d3JvbmcuIFRoZSBzdG1tYWNfY21kbGluZV9vcHQoKQo+ID4gZnVuY3Rpb24gZG9lcyBub3QgcGFy c2Ugc3lzZnMgaW5wdXQsIGJ1dCBjbWRsaW5lIGlucHV0IHN1Y2ggYXMKPiA+ICJzdG1tYWNldGg9 dGM6MSxwYXVzZToxIi4gVGhlIHBhdHRlcm4gb2YgdXNpbmcgc3Ryc2VwKCkgZm9sbG93ZWQgYnkK PiA+IHN0cm5jbXAoKSBmb3Igc3VjaCBzdHJpbmdzIGlzIG5vdCB1bmlxdWUgdG8gc3RtbWFjLCBp dCBjYW4gYWxzbyBiZSBmb3VuZAo+ID4gbWFpbmx5IGluIGRyaXZlcnMgdW5kZXIgZHJpdmVycy92 aWRlby9mYmRldi8uCj4gPiAKPiA+IFdpdGggc3RybmNtcCgidGM6IiwgMyksIHRoZSBjb2RlIG1h dGNoZXMgb24gdGhlICJ0YzoxIiB0b2tlbiBwcm9wZXJseS4KPiA+IFdpdGggc3lzZnNfc3RyZXEo InRjOiIpLCBpdCBkb2Vzbid0Lgo+ID4gCj4gPiBGaXhlczogZjcyY2Q3NmIwNWVhICgibmV0OiBz dG1tYWM6IHVzZSBzeXNmc19zdHJlcSgpIGluc3RlYWQgb2Ygc3RybmNtcCgpIikKPiA+IFNpZ25l ZC1vZmYtYnk6IFZsYWRpbWlyIE9sdGVhbiA8dmxhZGltaXIub2x0ZWFuQG54cC5jb20+ICAKPiAK PiBBaCB0aGUgaW5mYW1vdXMgc3RyaW5nIGhhbmRsaW5nIGluIEMuLi4KPiAKPiBBY2tlZC1ieTog TWFjaWVqIEZpamFsa293c2tpIDxtYWNpZWouZmlqYWxrb3dza2lAaW50ZWwuY29tPgo+IAo+IEV2 ZW4gd2hlbiB0aGVyZSB3b3VsZCBiZSBubyBidWlsZCBlcnJvciBJIGFncmVlIHRoYXQgd2Ugc2hv dWxkIGhhdmUga2VwdAo+IHRoZSBjb2RlIGFzIGl0IHdhcy4KPiAKPiA+IC0tLQo+ID4gIC4uLi9u ZXQvZXRoZXJuZXQvc3RtaWNyby9zdG1tYWMvc3RtbWFjX21haW4uYyAgfCAxOCArKysrKysrKyst LS0tLS0tLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgOSBpbnNlcnRpb25zKCspLCA5IGRlbGV0aW9u cygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQvZXRoZXJuZXQvc3RtaWNyby9z dG1tYWMvc3RtbWFjX21haW4uYyBiL2RyaXZlcnMvbmV0L2V0aGVybmV0L3N0bWljcm8vc3RtbWFj L3N0bW1hY19tYWluLmMKPiA+IGluZGV4IDFhODZlNjZlNDU2MC4uM2FmZmI3ZDNhMDA1IDEwMDY0 NAo+ID4gLS0tIGEvZHJpdmVycy9uZXQvZXRoZXJuZXQvc3RtaWNyby9zdG1tYWMvc3RtbWFjX21h aW4uYwo+ID4gKysrIGIvZHJpdmVycy9uZXQvZXRoZXJuZXQvc3RtaWNyby9zdG1tYWMvc3RtbWFj X21haW4uYwo+ID4gQEAgLTc1NjUsMzEgKzc1NjUsMzEgQEAgc3RhdGljIGludCBfX2luaXQgc3Rt bWFjX2NtZGxpbmVfb3B0KGNoYXIgKnN0cikKPiA+ICAJaWYgKCFzdHIgfHwgISpzdHIpCj4gPiAg CQlyZXR1cm4gMTsKPiA+ICAJd2hpbGUgKChvcHQgPSBzdHJzZXAoJnN0ciwgIiwiKSkgIT0gTlVM TCkgewo+ID4gLQkJaWYgKHN5c2ZzX3N0cmVxKG9wdCwgImRlYnVnOiIpKSB7Cj4gPiArCQlpZiAo IXN0cm5jbXAob3B0LCAiZGVidWc6IiwgNikpIHsKPiA+ICAJCQlpZiAoa3N0cnRvaW50KG9wdCAr IDYsIDAsICZkZWJ1ZykpCj4gPiAgCQkJCWdvdG8gZXJyOwo+ID4gLQkJfSBlbHNlIGlmIChzeXNm c19zdHJlcShvcHQsICJwaHlhZGRyOiIpKSB7Cj4gPiArCQl9IGVsc2UgaWYgKCFzdHJuY21wKG9w dCwgInBoeWFkZHI6IiwgOCkpIHsKPiA+ICAJCQlpZiAoa3N0cnRvaW50KG9wdCArIDgsIDAsICZw aHlhZGRyKSkKPiA+ICAJCQkJZ290byBlcnI7Cj4gPiAtCQl9IGVsc2UgaWYgKHN5c2ZzX3N0cmVx KG9wdCwgImJ1Zl9zejoiKSkgewo+ID4gKwkJfSBlbHNlIGlmICghc3RybmNtcChvcHQsICJidWZf c3o6IiwgNykpIHsKPiA+ICAJCQlpZiAoa3N0cnRvaW50KG9wdCArIDcsIDAsICZidWZfc3opKQo+ ID4gIAkJCQlnb3RvIGVycjsKPiA+IC0JCX0gZWxzZSBpZiAoc3lzZnNfc3RyZXEob3B0LCAidGM6 IikpIHsKPiA+ICsJCX0gZWxzZSBpZiAoIXN0cm5jbXAob3B0LCAidGM6IiwgMykpIHsKPiA+ICAJ CQlpZiAoa3N0cnRvaW50KG9wdCArIDMsIDAsICZ0YykpCj4gPiAgCQkJCWdvdG8gZXJyOwo+ID4g LQkJfSBlbHNlIGlmIChzeXNmc19zdHJlcShvcHQsICJ3YXRjaGRvZzoiKSkgewo+ID4gKwkJfSBl bHNlIGlmICghc3RybmNtcChvcHQsICJ3YXRjaGRvZzoiLCA5KSkgewo+ID4gIAkJCWlmIChrc3Ry dG9pbnQob3B0ICsgOSwgMCwgJndhdGNoZG9nKSkKPiA+ICAJCQkJZ290byBlcnI7Cj4gPiAtCQl9 IGVsc2UgaWYgKHN5c2ZzX3N0cmVxKG9wdCwgImZsb3dfY3RybDoiKSkgewo+ID4gKwkJfSBlbHNl IGlmICghc3RybmNtcChvcHQsICJmbG93X2N0cmw6IiwgMTApKSB7Cj4gPiAgCQkJaWYgKGtzdHJ0 b2ludChvcHQgKyAxMCwgMCwgJmZsb3dfY3RybCkpCj4gPiAgCQkJCWdvdG8gZXJyOwo+ID4gLQkJ fSBlbHNlIGlmIChzeXNmc19zdHJlcShvcHQsICJwYXVzZToiLCA2KSkgewo+ID4gKwkJfSBlbHNl IGlmICghc3RybmNtcChvcHQsICJwYXVzZToiLCA2KSkgewo+ID4gIAkJCWlmIChrc3RydG9pbnQo b3B0ICsgNiwgMCwgJnBhdXNlKSkKPiA+ICAJCQkJZ290byBlcnI7Cj4gPiAtCQl9IGVsc2UgaWYg KHN5c2ZzX3N0cmVxKG9wdCwgImVlZV90aW1lcjoiKSkgewo+ID4gKwkJfSBlbHNlIGlmICghc3Ry bmNtcChvcHQsICJlZWVfdGltZXI6IiwgMTApKSB7Cj4gPiAgCQkJaWYgKGtzdHJ0b2ludChvcHQg KyAxMCwgMCwgJmVlZV90aW1lcikpCj4gPiAgCQkJCWdvdG8gZXJyOwo+ID4gLQkJfSBlbHNlIGlm IChzeXNmc19zdHJlcShvcHQsICJjaGFpbl9tb2RlOiIpKSB7Cj4gPiArCQl9IGVsc2UgaWYgKCFz dHJuY21wKG9wdCwgImNoYWluX21vZGU6IiwgMTEpKSB7Cj4gPiAgCQkJaWYgKGtzdHJ0b2ludChv cHQgKyAxMSwgMCwgJmNoYWluX21vZGUpKQo+ID4gIAkJCQlnb3RvIGVycjsKPiA+ICAJCX0KPiA+ IC0tIAo+ID4gMi4zNC4xCj4gPiAgIAoKQ29uZmlndXJpbmcgdmlhIG1vZHVsZSBvcHRpb25zIGlz IGJhZCBpZGVhLgpJZiB5b3UgaGF2ZSB0byBkbyBpdCBkb24ndCByb2xsIHlvdXIgb3duIGtleS92 YWx1ZSBwYXJzaW5nLgpJZiB0aGUgZHJpdmVyIGp1c3QgdXNlZCByZWd1bGFyIG1vZHVsZV9wYXJh bSgpIGZvciB0aGlzIGl0IHdvdWxkbid0IGhhdmUgdGhpcyBjcmFwLgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5n IGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73B2FC4167B for ; Fri, 25 Nov 2022 18:44:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229733AbiKYSoI (ORCPT ); Fri, 25 Nov 2022 13:44:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229570AbiKYSoH (ORCPT ); Fri, 25 Nov 2022 13:44:07 -0500 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FD3745ECC for ; Fri, 25 Nov 2022 10:44:05 -0800 (PST) Received: by mail-pl1-x62b.google.com with SMTP id p12so4704489plq.4 for ; Fri, 25 Nov 2022 10:44:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=YFUcQ3hLuxafQYtxQnWs87DdE99a3mWHbnJqXUnaU40=; b=wJNS50eWgo70qBzwRJ/eacnPCkagYxdtrqNdFD4nfBt0ByVzB1jHs4I5dSd7W/hRlV XLAEIcyFK1c0YL3L1oqAuONU+7aF5NIHAIWAFc/UoPvh8fGWv8DU+nDyugqquQphVyvy mZABavgj6fEQ9KleIjLsKS88R8uRtrMJPlde1PWmnrp1JLlbdjF12SwrSyZN0pRoGlrv /Os3aKcXhKKm91745O+g/S8vJk9t8X2eCEWZ6Rfxvjdgw3BhUKoKF0v8KOm8HFZZNMFU 1Cce1lG+UBgDXqirKs4LEddhvaXFYG+kvCfyImLrnlMPxeu1GvJASeqKrpq/mYrOI6iR MUqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YFUcQ3hLuxafQYtxQnWs87DdE99a3mWHbnJqXUnaU40=; b=z4SqZ1c0LySSAKu+caqE9VA9Cjo3KH3vbIQBY5L5rH+1mxSMFfuLkMbjnEK4/m8V5y /7Ekl0W2+soslOxHJ1DJ3BRujXWw3X0VqY/0CLYjLkXsyG9zjm5F8n1IInBFxVstzFsS b5sMbqKlFCpuLMXbin340LWLVrqjwtUtFfZhuO4BevAnvR3S7rJH93hGnLboLl+rKysg 3go/HW/GgEcbemx3WsbimKz/eVzJLq9yF/yAqlKolNnh23CwXnNEnRy6j30YN2kPCrqz vho77UFT+vKqj00yjkz8iNmIXUliwDtbNQxe459HbudcpCgy8o3wbSLIduG+hIK1NkuJ ijHg== X-Gm-Message-State: ANoB5pmZJ05WZPMQliGCT2M3Fae4HXKqYukphUaXNL8+clSoiIMcmumh ZUYJF2B8y+ZTs86OvROh3SwPgg== X-Google-Smtp-Source: AA0mqf7dGVW4MXOGlUxRKNCXMQzyzk240b9VEqd1QcNaooVXqjFTk78T7hsrfzGxsU2Jndumrs3gNA== X-Received: by 2002:a17:90a:c006:b0:219:158d:b19a with SMTP id p6-20020a17090ac00600b00219158db19amr2114270pjt.152.1669401844720; Fri, 25 Nov 2022 10:44:04 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id x13-20020aa79a4d000000b0056ba7cda4b5sm3522287pfj.16.2022.11.25.10.44.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Nov 2022 10:44:04 -0800 (PST) Date: Fri, 25 Nov 2022 10:44:01 -0800 From: Stephen Hemminger To: Maciej Fijalkowski Cc: Vladimir Oltean , , "David S. Miller" , "Eric Dumazet" , Jakub Kicinski , Paolo Abeni , Claudiu Manoil , "Giuseppe Cavallaro" , Alexandre Torgue , Jose Abreu , "Maxime Coquelin" , Yang Yang , "Xu Panda" , , , Subject: Re: [PATCH net-next] Revert "net: stmmac: use sysfs_streq() instead of strncmp()" Message-ID: <20221125104401.0e18979f@hermes.local> In-Reply-To: References: <20221125105304.3012153-1-vladimir.oltean@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 25 Nov 2022 12:58:23 +0100 Maciej Fijalkowski wrote: > On Fri, Nov 25, 2022 at 12:53:04PM +0200, Vladimir Oltean wrote: > > This reverts commit f72cd76b05ea1ce9258484e8127932d0ea928f22. > > This patch is so broken, it hurts. Apparently no one reviewed it and it > > passed the build testing (because the code was compiled out), but it was > > obviously never compile-tested, since it produces the following build > > error, due to an incomplete conversion where an extra argument was left, > > although the function being called was left: > >=20 > > stmmac_main.c: In function =E2=80=98stmmac_cmdline_opt=E2=80=99: > > stmmac_main.c:7586:28: error: too many arguments to function =E2=80=98s= ysfs_streq=E2=80=99 > > 7586 | } else if (sysfs_streq(opt, "pause:", 6)) { > > | ^~~~~~~~~~~ > > In file included from ../include/linux/bitmap.h:11, > > from ../include/linux/cpumask.h:12, > > from ../include/linux/smp.h:13, > > from ../include/linux/lockdep.h:14, > > from ../include/linux/mutex.h:17, > > from ../include/linux/notifier.h:14, > > from ../include/linux/clk.h:14, > > from ../drivers/net/ethernet/stmicro/stmmac/stmmac_mai= n.c:17: > > ../include/linux/string.h:185:13: note: declared here > > 185 | extern bool sysfs_streq(const char *s1, const char *s2); > > | ^~~~~~~~~~~ > >=20 > > What's even worse is that the patch is flat out wrong. The stmmac_cmdli= ne_opt() > > function does not parse sysfs input, but cmdline input such as > > "stmmaceth=3Dtc:1,pause:1". The pattern of using strsep() followed by > > strncmp() for such strings is not unique to stmmac, it can also be found > > mainly in drivers under drivers/video/fbdev/. > >=20 > > With strncmp("tc:", 3), the code matches on the "tc:1" token properly. > > With sysfs_streq("tc:"), it doesn't. > >=20 > > Fixes: f72cd76b05ea ("net: stmmac: use sysfs_streq() instead of strncmp= ()") > > Signed-off-by: Vladimir Oltean =20 >=20 > Ah the infamous string handling in C... >=20 > Acked-by: Maciej Fijalkowski >=20 > Even when there would be no build error I agree that we should have kept > the code as it was. >=20 > > --- > > .../net/ethernet/stmicro/stmmac/stmmac_main.c | 18 +++++++++--------- > > 1 file changed, 9 insertions(+), 9 deletions(-) > >=20 > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/driver= s/net/ethernet/stmicro/stmmac/stmmac_main.c > > index 1a86e66e4560..3affb7d3a005 100644 > > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > @@ -7565,31 +7565,31 @@ static int __init stmmac_cmdline_opt(char *str) > > if (!str || !*str) > > return 1; > > while ((opt =3D strsep(&str, ",")) !=3D NULL) { > > - if (sysfs_streq(opt, "debug:")) { > > + if (!strncmp(opt, "debug:", 6)) { > > if (kstrtoint(opt + 6, 0, &debug)) > > goto err; > > - } else if (sysfs_streq(opt, "phyaddr:")) { > > + } else if (!strncmp(opt, "phyaddr:", 8)) { > > if (kstrtoint(opt + 8, 0, &phyaddr)) > > goto err; > > - } else if (sysfs_streq(opt, "buf_sz:")) { > > + } else if (!strncmp(opt, "buf_sz:", 7)) { > > if (kstrtoint(opt + 7, 0, &buf_sz)) > > goto err; > > - } else if (sysfs_streq(opt, "tc:")) { > > + } else if (!strncmp(opt, "tc:", 3)) { > > if (kstrtoint(opt + 3, 0, &tc)) > > goto err; > > - } else if (sysfs_streq(opt, "watchdog:")) { > > + } else if (!strncmp(opt, "watchdog:", 9)) { > > if (kstrtoint(opt + 9, 0, &watchdog)) > > goto err; > > - } else if (sysfs_streq(opt, "flow_ctrl:")) { > > + } else if (!strncmp(opt, "flow_ctrl:", 10)) { > > if (kstrtoint(opt + 10, 0, &flow_ctrl)) > > goto err; > > - } else if (sysfs_streq(opt, "pause:", 6)) { > > + } else if (!strncmp(opt, "pause:", 6)) { > > if (kstrtoint(opt + 6, 0, &pause)) > > goto err; > > - } else if (sysfs_streq(opt, "eee_timer:")) { > > + } else if (!strncmp(opt, "eee_timer:", 10)) { > > if (kstrtoint(opt + 10, 0, &eee_timer)) > > goto err; > > - } else if (sysfs_streq(opt, "chain_mode:")) { > > + } else if (!strncmp(opt, "chain_mode:", 11)) { > > if (kstrtoint(opt + 11, 0, &chain_mode)) > > goto err; > > } > > --=20 > > 2.34.1 > > =20 Configuring via module options is bad idea. If you have to do it don't roll your own key/value parsing. If the driver just used regular module_param() for this it wouldn't have th= is crap.