From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Baruch Siach via buildroot <buildroot@buildroot.org>
Cc: buildroot@busybox.net
Subject: Re: [Buildroot] [PATCH] package/dash: fix static with shared build
Date: Fri, 25 Nov 2022 23:20:24 +0100 [thread overview]
Message-ID: <20221125232024.7b1da5c7@windsurf> (raw)
In-Reply-To: <58294107fad727dfc01e76ca23a47ab08a1ef9ea.1669368933.git.baruch@tkos.co.il>
On Fri, 25 Nov 2022 11:35:33 +0200
Baruch Siach via buildroot <buildroot@buildroot.org> wrote:
> When BR2_SHARED_STATIC_LIBS is enabled we pass both --enable-static and
> --enable-shared to configure. dash configure.ac only looks for
> --enable-static to make the build static. But when linking against
> libedit pkg-config only returns dynamic linking dependencies, so the
> indirect ncurses dependency in not mentioned. The end result is that
> libedit can't find ncurses symbols on link.
>
> BR2_SHARED_STATIC_LIBS only makes sense for libraries, not executable
> binaries. Pass --disable-static unless BR2_STATIC_LIBS is enabled for
> static only build.
>
> Fixes:
> http://autobuild.buildroot.net/results/137d39cc5ec436759a2fde3f26ce5633e0ad6c2e/
> http://autobuild.buildroot.net/results/55a38e0e45212bf7403d9ccb626c9422e3affe72/
> http://autobuild.buildroot.net/results/8f109f1a04a6a2ff6d8c4c920e499fbaec3f72b9/
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> package/dash/dash.mk | 4 ++++
> 1 file changed, 4 insertions(+)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-11-25 22:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 9:35 [Buildroot] [PATCH] package/dash: fix static with shared build Baruch Siach via buildroot
2022-11-25 22:20 ` Thomas Petazzoni via buildroot [this message]
2022-12-06 22:12 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221125232024.7b1da5c7@windsurf \
--to=buildroot@buildroot.org \
--cc=buildroot@busybox.net \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.