From: Changbin Du <changbin.du@gmail.com>
To: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Quentin Monnet <quentin@isovalent.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Shuah Khan <shuah@kernel.org>
Cc: Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
Mykola Lysenko <mykolal@fb.com>,
linux-perf-users@vger.kernel.org,
linux-kselftest@vger.kernel.org,
Changbin Du <changbin.du@gmail.com>
Subject: [PATCH 1/2] libbpf: show more info about missing ".BTF" section
Date: Sat, 26 Nov 2022 19:11:46 +0800 [thread overview]
Message-ID: <20221126111147.199366-2-changbin.du@gmail.com> (raw)
In-Reply-To: <20221126111147.199366-1-changbin.du@gmail.com>
Show more information about why failed instead of just saying "No such file or
directory".
Now will print below info:
libbpf: can not find '.BTF' section
libbpf: is CONFIG_DEBUG_INFO_BTF enabled for kernel?
Error: failed to load BTF from /home/changbin/work/linux/vmlinux: No such file or directory
Signed-off-by: Changbin Du <changbin.du@gmail.com>
---
tools/lib/bpf/btf.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/tools/lib/bpf/btf.c b/tools/lib/bpf/btf.c
index d88647da2c7f..3f661d991808 100644
--- a/tools/lib/bpf/btf.c
+++ b/tools/lib/bpf/btf.c
@@ -906,6 +906,15 @@ struct btf *btf__new(const void *data, __u32 size)
return libbpf_ptr(btf_new(data, size, NULL));
}
+static bool is_vmlinux(const char *path)
+{
+ size_t path_len = strlen(path);
+ size_t suffix_len = strlen("vmlinux");
+
+ return (path_len >= suffix_len) &&
+ (!memcmp(path + path_len - suffix_len, "vmlinux", suffix_len));
+}
+
static struct btf *btf_parse_elf(const char *path, struct btf *base_btf,
struct btf_ext **btf_ext)
{
@@ -990,6 +999,9 @@ static struct btf *btf_parse_elf(const char *path, struct btf *base_btf,
err = 0;
if (!btf_data) {
+ pr_warn("can not find '%s' section\n", BTF_ELF_SEC);
+ if (is_vmlinux(path))
+ pr_warn("is CONFIG_DEBUG_INFO_BTF enabled for kernel?\n");
err = -ENOENT;
goto done;
}
--
2.37.2
next prev parent reply other threads:[~2022-11-26 11:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-26 11:11 [PATCH 0/2] bpftool: improve error handing for missing .BTF section Changbin Du
2022-11-26 11:11 ` Changbin Du [this message]
2022-11-29 5:59 ` [PATCH 1/2] libbpf: show more info about missing ".BTF" section Andrii Nakryiko
2022-11-29 8:59 ` Changbin Du
2022-11-26 11:11 ` [PATCH 2/2] makefiles: do not generate empty vmlinux.h Changbin Du
2022-11-29 6:00 ` Andrii Nakryiko
2022-11-29 8:48 ` Changbin Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221126111147.199366-2-changbin.du@gmail.com \
--to=changbin.du@gmail.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.lau@linux.dev \
--cc=mingo@redhat.com \
--cc=mykolal@fb.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=quentin@isovalent.com \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.