From: Jack Schofield <schofija@oregonstate.edu>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH] staging: emxx_udc: Remove unneeded parentheses
Date: Sun, 27 Nov 2022 20:40:12 -0800 [thread overview]
Message-ID: <20221128044012.GA2028@virt> (raw)
Parentheses are not required around condition tests. Remove to follow
Linux Kernel coding style. Issue reported by checkpatch.
Signed-off-by: Jack Schofield <schofija@oregonstate.edu>
---
There are more instances of extra parens to cleanup. If this patch is
welcome I can continue to cleanup this file.
drivers/staging/emxx_udc/emxx_udc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
index b4e19174bef2..1d4ac8374fe2 100644
--- a/drivers/staging/emxx_udc/emxx_udc.c
+++ b/drivers/staging/emxx_udc/emxx_udc.c
@@ -149,8 +149,8 @@ static void _nbu2ss_ep0_complete(struct usb_ep *_ep, struct usb_request *_req)
/* SET_FEATURE */
recipient = (u8)(p_ctrl->bRequestType & USB_RECIP_MASK);
selector = le16_to_cpu(p_ctrl->wValue);
- if ((recipient == USB_RECIP_DEVICE) &&
- (selector == USB_DEVICE_TEST_MODE)) {
+ if (recipient == USB_RECIP_DEVICE &&
+ selector == USB_DEVICE_TEST_MODE) {
wIndex = le16_to_cpu(p_ctrl->wIndex);
test_mode = (u32)(wIndex >> 8);
_nbu2ss_set_test_mode(udc, test_mode);
@@ -287,7 +287,7 @@ static int _nbu2ss_epn_exit(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep)
u32 num;
u32 data;
- if ((ep->epnum == 0) || (udc->vbus_active == 0))
+ if (ep->epnum == 0 || udc->vbus_active == 0)
return -EINVAL;
num = ep->epnum - 1;
--
2.25.1
next reply other threads:[~2022-11-28 4:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 4:40 Jack Schofield [this message]
2022-12-05 12:28 ` [PATCH] staging: emxx_udc: Remove unneeded parentheses Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221128044012.GA2028@virt \
--to=schofija@oregonstate.edu \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.