From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBED6C433FE for ; Mon, 28 Nov 2022 08:17:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OZlnf7wkbbJvpJUR4Xgbykol1tpQXLRg4SlaA/LBzMg=; b=wm5qHSLBij75jP 0gCbjv9S/eg11+dGRdjHjuXJxt0+dOPFGZUBfbjpMt/Ktp+LpmBlDg/dT+J2lt8g25edjrpRch72H TmGdcdAYASZoEZEL1kFkuPLMtomxxWaY4a/VaPpUvT1KsxRg/jYNP2kKiXwdi2jgAHvHeIdwAwGVA vJzE+eMnHwpYITTcP52djnY/C5+iontlDarjl60bGDc7d7qjfWZa9+NPeX8Jg7EJNEVhycmTq62dt aAQVTTG38zW6Kxw7ErjaskikOlZg7GraRxKo+yJWtoVVA0d8Q91GG4NZCFK00dg6IybXsYfz67000 SoeHAHLFNW0M5sDGXV7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozZJl-0007ZI-PX; Mon, 28 Nov 2022 08:16:45 +0000 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozZIv-0006UL-SX for linux-arm-kernel@lists.infradead.org; Mon, 28 Nov 2022 08:15:55 +0000 Received: by mail-pj1-x1029.google.com with SMTP id k2-20020a17090a4c8200b002187cce2f92so13202740pjh.2 for ; Mon, 28 Nov 2022 00:15:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=41dMnLlQhVdjKXFxljKHhsQK7EgN1jbnFbZkDumWU3k=; b=NCmqK9rQ94cfbvI1oGd7hVmrNMvAbjRG3S0lUj+b8ld9Mr0X+bVPi1WKUzclB49N2R 5eQps+vIbFLhlk5P2Z7NmEP/q8Bkra4og1rIheAvILOHGsCsXSo/R6WagfoL8DMlXoni SQqY9LYvVjLdl6sqtSkjt9AEwvJWMAGdW2rSj9qJB9igzYjtfLpWMqMkxkhm/F9adD51 JkWuj0AkF4hofIsGXNtu5nhAOIsMUBPYyjeTG56bDvXVXz+JJDk7m/Mq4eTohbQy0nCi qQum4GPrOKMwOH1OWDhLE9g9HzmSi2xHfYRx01zN7ahDenswr82aF3IR74gBh2qi66Tj AOAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=41dMnLlQhVdjKXFxljKHhsQK7EgN1jbnFbZkDumWU3k=; b=tXeScgWRxhpbgwDeGmOqnGQThkjDjG7ZL12yVaE4HnJ0OSPjdDAhybvqhN5OG0Kr/M YRWtrX1eAyZur+DHfLbxcBIm7LpBr0htJEhHnlDuIbi7gm3oZeN6OaiB7zh3fYFZeWUC eAICQVHumGhxYKoEBC0efihwoCtuPfCGAubciY0BQwVOlVaO0ujM1pAoyaZSEvMP+jFv 38znUyIpi0QS0TAKrwQR1O048A4BRW7JWYV0rnXOu22QC5obvf+KtdnwTy3yaH+Zl9fO sNOxqGk6HDMKJXrM6LYDUxfEvL0InJrInYElHPiYC+TNBQRxf+0bMMKUG/rnXPu0oGku XKdw== X-Gm-Message-State: ANoB5pm9ITZk29k/N3rp8KoPD5p50j48HkHnbkp0WpBFvRPqBXzsbWmP 4814uwEP/u4OZn2TwOeM194+ X-Google-Smtp-Source: AA0mqf6mLO+PCP/hLz4RzLO/qKBWBH5saTD6FZRHSdv23lFs82iecpQbnFjLPZdDntZseE5lX6lfOg== X-Received: by 2002:a17:902:aa06:b0:183:7f67:25d7 with SMTP id be6-20020a170902aa0600b001837f6725d7mr31064610plb.164.1669623339852; Mon, 28 Nov 2022 00:15:39 -0800 (PST) Received: from thinkpad ([117.217.177.120]) by smtp.gmail.com with ESMTPSA id w11-20020a170902ca0b00b001868ed86a95sm8085387pld.174.2022.11.28.00.15.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Nov 2022 00:15:37 -0800 (PST) Date: Mon, 28 Nov 2022 13:45:31 +0530 From: Manivannan Sadhasivam To: Thorsten Leemhuis Cc: catalin.marinas@arm.com, will@kernel.org, robin.murphy@arm.com, amit.pundir@linaro.org, andersson@kernel.org, quic_sibis@quicinc.com, sumit.semwal@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "arm64: dma: Drop cache invalidation from arch_dma_prep_coherent()" Message-ID: <20221128081531.GA60329@thinkpad> References: <20221114110329.68413-1-manivannan.sadhasivam@linaro.org> <6a5b523d-711b-d809-06b9-fdada64c9c65@leemhuis.info> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6a5b523d-711b-d809-06b9-fdada64c9c65@leemhuis.info> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221128_001554_058142_FF1C2BAD X-CRM114-Status: GOOD ( 18.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBOb3YgMjgsIDIwMjIgYXQgMDY6NDQ6MTNBTSArMDEwMCwgVGhvcnN0ZW4gTGVlbWh1 aXMgd3JvdGU6Cj4gT24gMTQuMTEuMjIgMTI6MDMsIE1hbml2YW5uYW4gU2FkaGFzaXZhbSB3cm90 ZToKPiA+IFRoaXMgcmV2ZXJ0cyBjb21taXQgYzQ0MDk0ZWVlMzJmMzJmMTc1YWFkYzBlZmNhYzQ0 OWQ5OWIxYmJmNy4KPiA+IAo+ID4gQXMgcmVwb3J0ZWQgYnkgQW1pdCBbMV0sIGRyb3BwaW5nIGNh Y2hlIGludmFsaWRhdGlvbiBmcm9tCj4gPiBhcmNoX2RtYV9wcmVwX2NvaGVyZW50KCkgdHJpZ2dl cnMgYSBjcmFzaCBvbiB0aGUgUXVhbGNvbW0gU004MjUwIHBsYXRmb3JtCj4gPiAobW9zdCBwcm9i YWJseSBvbiBvdGhlciBRY29tIHBsYXRmb3JtcyB0b28pLiBUaGUgcmVhc29uIGlzLCBRY29tCj4g PiBxY29tX3E2djVfbXNzIGRyaXZlciBjb3BpZXMgdGhlIGZpcm13YXJlIG1ldGFkYXRhIGFuZCBz aGFyZXMgaXQgd2l0aCBtb2RlbQo+ID4gZm9yIHZhbGlkYXRpb24uIFRoZSBtb2RlbSBoYXMgYSBz ZWN1cmUgYmxvY2sgKFhQVSkgdGhhdCB3aWxsIHRyaWdnZXIgYQo+ID4gd2hvbGUgc3lzdGVtIGNy YXNoIGlmIHRoZSBzaGFyZWQgbWVtb3J5IGlzIGFjY2Vzc2VkIGJ5IHRoZSBDUFUgd2hpbGUgbW9k ZW0KPiA+IGlzIHBva2luZyBhdCBpdC4KPiA+IFsuLi5dCj4gPiBbMV0gaHR0cHM6Ly9sb3JlLmtl cm5lbC5vcmcvbGludXgtYXJtLWtlcm5lbC9DQU1pMUhkMVZCQ0ZoZjcrRVhXSFFXY0d5NGs9dGN5 TGE3UkdpRmRwcnRSbmVnU0cwTXdAbWFpbC5nbWFpbC5jb20vCj4gPgo+IAo+IEkgaGF2ZSBBbWl0 J3MgcmVwb3J0IG9uIHRoZSBsaXN0IG9mIHRyYWNrZWQgcmVncmVzc2lvbnMuIEkgYWxzbyBub3Rp Y2VkCj4gdGhlIHByb3Bvc2VkIGNoYW5nZSAiYXJtNjQ6IGR0czogcWNvbTogc2M4MjgweHA6IGZp eCBQQ0llIERNQSBjb2hlcmVuY3kiOgo+IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2FsbC8yMDIy MTEyNDE0MjUwMS4yOTMxNC0xLWpvaGFuK2xpbmFyb0BrZXJuZWwub3JnLwo+IAo+IEkgaGF2ZSBu byBleHBlcnRpc2UgaW4gdGhpcyBhcmVhLCBidXQgaXQgbG9va2VkIHNvbWV3aGF0IHJlbGF0ZWQg dG8gbXkKPiBleWVzLCBzbyBwbGVhc2UgYWxsb3cgbWUgdG8gcXVpY2tseSBhc2s6IGlzIHRoYXQg cmVsYXRlZCBvciBldmVuCj4gc3VwcG9zZWQgdG8gZml4IEFtaXQncyByZWdyZXNzaW9uPwo+IAoK VGhlIHByb3Bvc2VkIHBhdGNoIGRvZXNuJ3QgZml4IHRoZSByZWdyZXNzaW9uIHJlcG9ydGVkIGJ5 IEFtaXQuIEJ1dCB0aGUgcGF0Y2gKaXRzZWxmIGZpeGVzIGFuIGlzc3VlIHRoYXQgbWlnaHQgYmUg dHJpZ2dlcmVkIG1vcmUgZnJlcXVlbnRseSBieSBjNDQwOTRlZWUzMmYuCgpUaGFua3MsCk1hbmkK Cj4gQ2lhbywgVGhvcnN0ZW4KCi0tIArgrq7grqPgrr/grrXgrqPgr43grqPgrqngr40g4K6a4K6k 4K6+4K6a4K6/4K614K6u4K+NCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D9D0C4167D for ; Mon, 28 Nov 2022 08:15:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230103AbiK1IPv (ORCPT ); Mon, 28 Nov 2022 03:15:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229774AbiK1IPn (ORCPT ); Mon, 28 Nov 2022 03:15:43 -0500 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72B456151 for ; Mon, 28 Nov 2022 00:15:40 -0800 (PST) Received: by mail-pl1-x62c.google.com with SMTP id p24so5676719plw.1 for ; Mon, 28 Nov 2022 00:15:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=41dMnLlQhVdjKXFxljKHhsQK7EgN1jbnFbZkDumWU3k=; b=NCmqK9rQ94cfbvI1oGd7hVmrNMvAbjRG3S0lUj+b8ld9Mr0X+bVPi1WKUzclB49N2R 5eQps+vIbFLhlk5P2Z7NmEP/q8Bkra4og1rIheAvILOHGsCsXSo/R6WagfoL8DMlXoni SQqY9LYvVjLdl6sqtSkjt9AEwvJWMAGdW2rSj9qJB9igzYjtfLpWMqMkxkhm/F9adD51 JkWuj0AkF4hofIsGXNtu5nhAOIsMUBPYyjeTG56bDvXVXz+JJDk7m/Mq4eTohbQy0nCi qQum4GPrOKMwOH1OWDhLE9g9HzmSi2xHfYRx01zN7ahDenswr82aF3IR74gBh2qi66Tj AOAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=41dMnLlQhVdjKXFxljKHhsQK7EgN1jbnFbZkDumWU3k=; b=YMBCEwjlN5peESD1sZyJGPEpzMhBlDGGHo1G3I5hDde332ZHaXdovfY/XwqabqAjxL kILw5XXie6Nm+yGblWv8yMnaEoksa8p2+6ahkr3LB7TsiHVH/07RpLTZlJ+O/J2/c12k eNAsxeO1EsBy3+Imrm4efnFNTSr7f0yplqV+Ll1fbikmRojSkjcPvGxHaVkjUl3C6Snn TAmUC4Twy68JgdHZoyGqBuHlcQjpYG0wYp3ctRE8UHKPDzXnRseCJL8WvOEj2gJzseh2 wBsSVOOR8/nbGtvjHRBRcIuD/G8yxGQTwdxKJaeXelGp8iHf9MfH6Mf6cCjXlnfaZeq3 LssQ== X-Gm-Message-State: ANoB5pkSHBHezMqEI465MnStx7YnJM9KRCFp6WVw2flVLXva9lIx4Gqz 3cxN39fIuR0wQ7d414Ugv1Kw X-Google-Smtp-Source: AA0mqf6mLO+PCP/hLz4RzLO/qKBWBH5saTD6FZRHSdv23lFs82iecpQbnFjLPZdDntZseE5lX6lfOg== X-Received: by 2002:a17:902:aa06:b0:183:7f67:25d7 with SMTP id be6-20020a170902aa0600b001837f6725d7mr31064610plb.164.1669623339852; Mon, 28 Nov 2022 00:15:39 -0800 (PST) Received: from thinkpad ([117.217.177.120]) by smtp.gmail.com with ESMTPSA id w11-20020a170902ca0b00b001868ed86a95sm8085387pld.174.2022.11.28.00.15.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Nov 2022 00:15:37 -0800 (PST) Date: Mon, 28 Nov 2022 13:45:31 +0530 From: Manivannan Sadhasivam To: Thorsten Leemhuis Cc: catalin.marinas@arm.com, will@kernel.org, robin.murphy@arm.com, amit.pundir@linaro.org, andersson@kernel.org, quic_sibis@quicinc.com, sumit.semwal@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "arm64: dma: Drop cache invalidation from arch_dma_prep_coherent()" Message-ID: <20221128081531.GA60329@thinkpad> References: <20221114110329.68413-1-manivannan.sadhasivam@linaro.org> <6a5b523d-711b-d809-06b9-fdada64c9c65@leemhuis.info> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6a5b523d-711b-d809-06b9-fdada64c9c65@leemhuis.info> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 28, 2022 at 06:44:13AM +0100, Thorsten Leemhuis wrote: > On 14.11.22 12:03, Manivannan Sadhasivam wrote: > > This reverts commit c44094eee32f32f175aadc0efcac449d99b1bbf7. > > > > As reported by Amit [1], dropping cache invalidation from > > arch_dma_prep_coherent() triggers a crash on the Qualcomm SM8250 platform > > (most probably on other Qcom platforms too). The reason is, Qcom > > qcom_q6v5_mss driver copies the firmware metadata and shares it with modem > > for validation. The modem has a secure block (XPU) that will trigger a > > whole system crash if the shared memory is accessed by the CPU while modem > > is poking at it. > > [...] > > [1] https://lore.kernel.org/linux-arm-kernel/CAMi1Hd1VBCFhf7+EXWHQWcGy4k=tcyLa7RGiFdprtRnegSG0Mw@mail.gmail.com/ > > > > I have Amit's report on the list of tracked regressions. I also noticed > the proposed change "arm64: dts: qcom: sc8280xp: fix PCIe DMA coherency": > https://lore.kernel.org/all/20221124142501.29314-1-johan+linaro@kernel.org/ > > I have no expertise in this area, but it looked somewhat related to my > eyes, so please allow me to quickly ask: is that related or even > supposed to fix Amit's regression? > The proposed patch doesn't fix the regression reported by Amit. But the patch itself fixes an issue that might be triggered more frequently by c44094eee32f. Thanks, Mani > Ciao, Thorsten -- மணிவண்ணன் சதாசிவம்