From: Jakub Kicinski <kuba@kernel.org>
To: Jerry Ray <jerry.ray@microchip.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v3] dsa: lan9303: Add 3 ethtool stats
Date: Mon, 28 Nov 2022 15:21:45 -0800 [thread overview]
Message-ID: <20221128152145.486c6e4b@kernel.org> (raw)
In-Reply-To: <20221128205521.32116-1-jerry.ray@microchip.com>
On Mon, 28 Nov 2022 14:55:21 -0600 Jerry Ray wrote:
> These statistics are maintained by the switch and count the packets
> dropped due to buffer limits. Note that the rtnl_link_stats: rx_dropped
> statistic does not include dropped packets due to buffer exhaustion and as
> such, part of this counter would more appropriately fall under the
> rx_missed_errors.
Why not add them there as well?
Are these drops accounted for in any drop / error statistics within
rtnl_link_stats?
It's okay to provide implementation specific breakdown via ethtool -S
but user must be able to notice that there are some drops / errors in
the system by looking at standard stats.
next prev parent reply other threads:[~2022-11-28 23:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 20:55 [PATCH net-next v3] dsa: lan9303: Add 3 ethtool stats Jerry Ray
2022-11-28 21:05 ` Vladimir Oltean
2022-11-30 15:57 ` Jerry.Ray
2022-11-30 16:00 ` Andrew Lunn
2022-11-28 23:21 ` Jakub Kicinski [this message]
2022-11-30 15:51 ` Jerry.Ray
2022-11-30 16:52 ` Jakub Kicinski
2022-11-30 18:12 ` Jerry.Ray
2022-11-30 18:50 ` Vladimir Oltean
2022-12-01 15:56 ` Jerry.Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221128152145.486c6e4b@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=jerry.ray@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.