From: Christoph Hellwig <hch@lst.de>
To: Song Liu <song@kernel.org>
Cc: bpf@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, x86@kernel.org, peterz@infradead.org,
hch@lst.de, rick.p.edgecombe@intel.com, rppt@kernel.org,
mcgrof@kernel.org
Subject: Re: [PATCH bpf-next v5 3/6] selftests/vm: extend test_vmalloc to test execmem_* APIs
Date: Tue, 29 Nov 2022 09:35:18 +0100 [thread overview]
Message-ID: <20221129083518.GA25167@lst.de> (raw)
In-Reply-To: <20221128190245.2337461-4-song@kernel.org>
> +#if DEBUG_TEST_VMALLOC_EXEMEM_ALLOC
> +EXPORT_SYMBOL_GPL(execmem_alloc);
> +#endif
> +#if DEBUG_TEST_VMALLOC_EXEMEM_ALLOC
> +EXPORT_SYMBOL_GPL(execmem_fill);
> +#endif
> +#if DEBUG_TEST_VMALLOC_EXEMEM_ALLOC
> +EXPORT_SYMBOL_GPL(execmem_free);
> +#endif
Still NAK. These symbols never have any business being exported
ever. Just force the test to be built-in if you want to test this
functionality.
next prev parent reply other threads:[~2022-11-29 8:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 19:02 [PATCH bpf-next v5 0/6] execmem_alloc for BPF programs Song Liu
2022-11-28 19:02 ` [PATCH bpf-next v5 1/6] vmalloc: introduce execmem_alloc, execmem_free, and execmem_fill Song Liu
2022-11-28 19:02 ` [PATCH bpf-next v5 2/6] x86/alternative: support execmem_alloc() and execmem_free() Song Liu
2022-11-28 19:02 ` [PATCH bpf-next v5 3/6] selftests/vm: extend test_vmalloc to test execmem_* APIs Song Liu
2022-11-29 8:35 ` Christoph Hellwig [this message]
2022-11-29 17:31 ` Song Liu
2022-11-29 20:22 ` Christoph Hellwig
2022-11-28 19:02 ` [PATCH bpf-next v5 4/6] bpf: use execmem_alloc for bpf program and bpf dispatcher Song Liu
2022-11-28 19:02 ` [PATCH bpf-next v5 5/6] vmalloc: introduce register_text_tail_vm() Song Liu
2022-11-28 19:02 ` [PATCH bpf-next v5 6/6] x86: use register_text_tail_vm Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221129083518.GA25167@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=bpf@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=peterz@infradead.org \
--cc=rick.p.edgecombe@intel.com \
--cc=rppt@kernel.org \
--cc=song@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.