From: "hch@lst.de" <hch@lst.de>
To: "Rao, Lei" <lei.rao@intel.com>
Cc: Chaitanya Kulkarni <chaitanyak@nvidia.com>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"axboe@fb.com" <axboe@fb.com>, "hch@lst.de" <hch@lst.de>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nvme: clear the prp2 field of the nvme command.
Date: Tue, 29 Nov 2022 09:43:10 +0100 [thread overview]
Message-ID: <20221129084310.GB25609@lst.de> (raw)
In-Reply-To: <4cee0097-4f08-1990-112f-6e39229f59ef@intel.com>
On Tue, Nov 29, 2022 at 12:50:57PM +0800, Rao, Lei wrote:
> stricter checks, and if prp2 is not used but has a value, some warnings will be
> printed. According to the NVMe spec, it seems to write a reserved field produces
> an undefined result, so maybe clearing it is better.
NVMe is a little weird about reserved fields settable by the host.
I don't think your controllers warnings are correct, but given that
the cost of clearing is very low I think we should clear it in Linux.
Please resend a patch with the clearing in the right place as suggested
in my previous mail.
next prev parent reply other threads:[~2022-11-29 8:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 1:47 [PATCH] nvme: clear the prp2 field of the nvme command Lei Rao
2022-11-29 4:16 ` Chaitanya Kulkarni
2022-11-29 4:50 ` Rao, Lei
2022-11-29 8:43 ` hch [this message]
2022-11-29 8:41 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2022-11-29 9:48 Lei Rao
2022-11-29 13:38 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221129084310.GB25609@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=chaitanyak@nvidia.com \
--cc=kbusch@kernel.org \
--cc=lei.rao@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.