All of lore.kernel.org
 help / color / mirror / Atom feed
From: <zhang.songyi@zte.com.cn>
To: <arnd@arndb.de>
Cc: <zhang.songyi@zte.com.cn>, <robert.jarzmik@free.fr>,
	<lkundrak@v3.sk>, <linux-kernel@vger.kernel.org>
Subject: [PATCH linux-next] pxa: Remove dev_err() after platform_get_irq()
Date: Wed, 30 Nov 2022 15:56:06 +0800 (CST)	[thread overview]
Message-ID: <202211301556064978448@zte.com.cn> (raw)

From: zhang songyi <zhang.songyi@zte.com.cn>

There is no need to call the dev_err() function directly to print a
custom message when handling an error from either the platform_get_irq()
or platform_get_irq_byname() functions as both are going to display an
appropriate error message in case of a failure.

/drivers/soc/pxa/ssp.c:150:2-9: line 150 is redundant because
platform_get_irq() already prints an error

Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
---
 drivers/soc/pxa/ssp.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/soc/pxa/ssp.c b/drivers/soc/pxa/ssp.c
index 93449fb3519e..7085901b4e4b 100644
--- a/drivers/soc/pxa/ssp.c
+++ b/drivers/soc/pxa/ssp.c
@@ -147,7 +147,6 @@ static int pxa_ssp_probe(struct platform_device *pdev)

        ssp->irq = platform_get_irq(pdev, 0);
        if (ssp->irq < 0) {
-               dev_err(dev, "no IRQ resource defined\n");
                return -ENODEV;
        }

--
2.15.2

             reply	other threads:[~2022-11-30  7:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-30  7:56 zhang.songyi [this message]
2022-12-01  6:31 ` [PATCH linux-next] pxa: Remove dev_err() after platform_get_irq() Lubomir Rintel
2022-12-01 15:31 ` Arnd Bergmann
2022-12-01 18:15 ` Robert Jarzmik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202211301556064978448@zte.com.cn \
    --to=zhang.songyi@zte.com.cn \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkundrak@v3.sk \
    --cc=robert.jarzmik@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.