From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26F65C4321E for ; Thu, 1 Dec 2022 00:33:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cWum6qNSuESYvR/qkGjEwIXzbigOqWPyjGXhv2B+p1E=; b=FmvzgH4MelZsFX yz4yWJfopNOjTh5S3L28kZAzBFXhjOz1pSXhr+bM7+TaZ/wekvCUX34OptX40YPg/oCv5y0a/Nh2v CtqO9w9QZ5PYH3RdiHsBp/4U9xqUnF5g9giDfeBTicEE80MfQSEkIiN6W7WgkpEPlynVV948kKD6n QuHXd1vL+ZkmRuBkF3nhHafy8q02CVsWTxCEzexD//Z688AXluzaV7a946Ugoc3wfx5lthxwnWFwR IihX7zglN5mSsClw4DWl4mXslqBN3M5MpCeLOtHo6t9e++I9JuEYUj7cGSNvVdRP9XHKu1Re/tCqW DggOYmjArwovdyj3hWAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0XVr-003fC1-VY; Thu, 01 Dec 2022 00:33:16 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0XVd-003f66-9W; Thu, 01 Dec 2022 00:33:03 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 67E7AD6E; Wed, 30 Nov 2022 16:33:01 -0800 (PST) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1D8763F67D; Wed, 30 Nov 2022 16:32:50 -0800 (PST) Date: Thu, 1 Dec 2022 00:31:02 +0000 From: Andre Przywara To: Palmer Dabbelt Cc: Conor Dooley , Arnd Bergmann , Will Deacon , Marc Zyngier , ajones@ventanamicro.com, heiko@sntech.de, samuel@sholland.org, wens@csie.org, jernej.skrabec@gmail.com, linux-sunxi@lists.linux.dev, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, jszhang@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, aou@eecs.berkeley.edu, apatel@ventanamicro.com, Atish Patra , christianshewitt@gmail.com, Conor Dooley , guoren@kernel.org, heinrich.schuchardt@canonical.com, linus.walleij@linaro.org, Paul Walmsley , stano.jakubek@gmail.com Subject: Re: [PATCH v2 12/12] riscv: defconfig: Enable the Allwinner D1 platform and drivers Message-ID: <20221201003102.1b131a2d@slackpad.lan> In-Reply-To: References: Organization: Arm Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221130_163301_455943_C7355238 X-CRM114-Status: GOOD ( 45.51 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gV2VkLCAzMCBOb3YgMjAyMiAxMjoyNDowOCAtMDgwMCAoUFNUKQpQYWxtZXIgRGFiYmVsdCA8 cGFsbWVyQGRhYmJlbHQuY29tPiB3cm90ZToKCkhpLAoKPiBPbiBNb24sIDI4IE5vdiAyMDIyIDIy OjU0OjE4IFBTVCAoLTA4MDApLCBDb25vciBEb29sZXkgd3JvdGU6Cj4gPgo+ID4KPiA+IE9uIDI5 IE5vdmVtYmVyIDIwMjIgMDY6NDk6MjUgR01ULCBBbmRyZXcgSm9uZXMgPGFqb25lc0B2ZW50YW5h bWljcm8uY29tPiB3cm90ZTogIAo+ID4+T24gTW9uLCBOb3YgMjgsIDIwMjIgYXQgMDk6MTc6MzhQ TSArMDAwMCwgQ29ub3IgRG9vbGV5IHdyb3RlOiAgCj4gPj4+IE9uIDI4LzExLzIwMjIgMjE6MTEs IEhlaWtvIFN0w7xibmVyIHdyb3RlOiAgCj4gPj4+ID4gQW0gU2Ftc3RhZywgMjYuIE5vdmVtYmVy IDIwMjIsIDE3OjQwOjExIENFVCBzY2hyaWViIENvbm9yIERvb2xleTogIAo+ID4+PiA+PiBPbiBG cmksIE5vdiAyNSwgMjAyMiBhdCAwNTo0Njo1NlBNIC0wNjAwLCBTYW11ZWwgSG9sbGFuZCB3cm90 ZTogIAo+ID4+PiA+Pj4gTm93IHRoYXQgc2V2ZXJhbCBEMS1iYXNlZCBib2FyZHMgYXJlIHN1cHBv cnRlZCwgZW5hYmxlIHRoZSBwbGF0Zm9ybSBpbgo+ID4+PiA+Pj4gb3VyIGRlZmNvbmZpZy4gQnVp bGQgaW4gdGhlIGRyaXZlcnMgd2hpY2ggYXJlIG5lY2Vzc2FyeSB0byBib290LCBzdWNoIGFzCj4g Pj4+ID4+PiB0aGUgcGluY3RybCwgTU1DLCBSVEMgKHdoaWNoIHByb3ZpZGVzIGNyaXRpY2FsIGNs b2NrcyksIFNQSSAoZm9yIGZsYXNoKSwKPiA+Pj4gPj4+IGFuZCB3YXRjaGRvZyAod2hpY2ggbWF5 IGJlIGxlZnQgZW5hYmxlZCBieSB0aGUgYm9vdGxvYWRlcikuICAKPiA+Pj4gPj4KPiA+Pj4gPj4g QWxsIG9mIHRoYXQgbG9va3MgZ29vZC4KPiA+Pj4gPj4gIAo+ID4+PiA+Pj4gT3RoZXIgY29tbW9u Cj4gPj4+ID4+PiBvbmJvYXJkIHBlcmlwaGVyYWxzIGFyZSBlbmFibGVkIGFzIG1vZHVsZXMuICAK PiA+Pj4gPj4KPiA+Pj4gPj4gVGhpcyBJIGFtIG5vdCBzdXJlIGFib3V0IHRob3VnaC4gSSdsbCBs ZWF2ZSB0aGF0IHRvIFBhbG1lciBzaW5jZSBJJ20KPiA+Pj4gPj4gcHJldHR5IHN1cmUgaXQgd2Fz IGhpbSB0aGF0IHNhaWQgaXQsIGJ1dCBJIHRob3VnaHQgdGhlIHBsYW4gd2FzIG9ubHkKPiA+Pj4g Pj4gdHVybmluZyBvbiBzdHVmZiByZXF1aXJlZCB0byBib290IHRvIGEgY29uc29sZSAmIHRoaW5n cyB0aGF0IGFyZQo+ID4+PiA+PiBnZW5lcmFsbHkgdXNlZnVsIHJhdGhlciB0aGFuIGVuYWJsaW5n IG1vZHVsZXMgZm9yIGV2ZXJ5b25lJ3MgInJhbmRvbSIKPiA+Pj4gPj4gZHJpdmVycy4gUGFsbWVy PyAgCj4gPj4+ID4gCj4gPj4+ID4gSXNuJ3QgdGhlIGRlZmNvbmZpZyBtZWFudCBhcyBhIHN0YXJ0 aW5nIHBvaW50IHRvIGdldCB3b3JraW5nIHN5c3RlbXMKPiA+Pj4gPiB3aXRoIG1pbmltYWwgY29u ZmlnIGVmZm9ydD8gQXQgbGVhc3QgdGhhdCB3YXMgYWx3YXlzIHRoZSB3YXkgdG8gZ28gb24gYXJt Cj4gPj4+ID4gc28gZmFyIDotKSAuCj4gPj4+ID4gCj4gPj4+ID4gU28gaGF2aW5nIGJvb3QtcmVx dWlyZWQgZHJpdmVycyBidWlsdC1pbiB3aXRoIHRoZSByZXN0IGVuYWJsZWQgYXMgbW9kdWxlcwo+ ID4+PiA+IGZvciBzdXBwb3J0ZWQgYm9hcmRzIHdpbGwgYWxsb3cgcGVvcGxlIHRvIGJvb3QgdGhl aXJzIHdpdGhvdXQgaGVhZGFjaGVzLgo+ID4+PiA+IAo+ID4+PiA+IERpc2FibGluZyB1bm5lZWRl ZCBkcml2ZXJzIGlmIHlvdSdyZSBzdGFydmVkIGZvciBzdG9yYWdlIHNwYWNlIGluIGEgc3BlY2lh bAo+ID4+PiA+IHByb2plY3QgaXMgYWx3YXlzIGVhc2llciB0aGFuIGh1bnRpbmcgZG93biBhbGwg dGhlIGRyaXZlcnMgdG8gZW5hYmxlIGZvciBhCj4gPj4+ID4gc3BlY2lmaWMgYm9hcmQuICAgCj4g Pj4+IAo+ID4+PiBJIHdvdWxkbid0IG1pbmQgYmVpbmcgYWJsZSB0byB0dXJuIG9uIGFsbCB0aGUg UG9sYXJGaXJlIFNvQyBzdHVmZiBhbmQKPiA+Pj4geWVhaCwgdGhhdCB3b3VsZCBiZSB0aGUgd2F5 IHRoYXQgYXJtNjQgZG9lcyBpdC4gQnV0IEkgZG8gcmVjYWxsIGhlYXJpbmcKPiA+Pj4gdGhhdCBJ IHNob3VsZCBub3QgdHVybiBzdHVmZiBvbiB0aGlzIHdheSwgd2hlbiBJIGluaXRpYWxseSB0cmll ZCB0bwo+ID4+PiB0dXJuIHN0dWZmIG9uIHZpYSBzZWxlY3RzLCBnb3QgYSBuYWNrIGFuZCBhc2tl ZCBpZiBJIGNvdWxkIGRvIHRoaXMgaW5zdGVhZC4KPiA+Pj4gCj4gPj4+IEJ1dCBpdCBtYXkgYmUg dGhhdCBJIG1pc3JlbWVtYmVyLCB3aGljaCBpcyB3aHkgSSBhcHBlYWxlZCB0byB0aGUgSGlnaGVy Cj4gPj4+IFBvd2VycyBmb3IgY2xhcmlmaWNhdGlvbiA6KSAgCj4gPj4KPiA+PkZXSVcsIEkgZG9u J3Qgd29ycnkgdG9vIG11Y2ggYWJvdXQgbW9kdWxlcyBpbiBkZWZjb25maWcgYmVjYXVzZSBJIGFs d2F5cwo+ID4+aW1tZWRpYXRlbHkgYXBwbHkgYSAnTFNNT0Q9JFBXRC9MIGxvY2FsbW9kY29uZmln JyB0byBpdCwgd2hlcmUgdGhlIEwKPiA+PmZpbGUgaXMgYW4gbHNtb2Qgb3V0cHV0IHdoaWNoIG9u bHkgaW5jbHVkZXMgbW9kdWxlcyBJIG5lZWQuICAKPiA+Cj4gPiBpZGssIGRlZmNvbmZpZyB0byBt ZSBpcyBub3QgYWJvdXQgeW91IG9yIEksIGl0J3MgYWJvdXQgQSBEZXZlbG9wZXIgdGhhdCBnZXRz IGFuIFNCQyBvciBhIGRldmtpdCBhbmQgdGhlaXIgZXhwZXJpZW5jZS4KPiA+IE9yIGFsdGVybmF0 aXZlbHksIHNvbWVvbmUncyBDSSA7KQo+ID4gSSdkIGxpa2UgdG8gcHV0IGV2ZXJ5dGhpbmcgaW4s IGJ1dCBJIHJlY2FsbCB0aGF0IGJlaW5nIHNob3QgZG93biwgdGhhdCdzIGFsbC4gIAo+IAo+IFRo ZSB3aG9sZSAid2hvIGlzIGRlZmNvbmZpZyBmb3IiIGRpc2N1c3Npb24gYWx3YXlzIGVuZHMgdXAg a2luZCBvZiAKPiB2YWd1ZSwgYnV0IElJVUMgaXQncyBnZW5lcmFsbHkgYWltZWQgYXQga2VybmVs IGhhY2tlcnMgYXMgb3Bwb3NlZCB0byBlbmQgCj4gdXNlcnMgLS0gc28gaXQncyBub3QgbWVhbnQg dG8gYmUgYSBkaXN0byBjb25maWcsIHRoYXQncyB3aHkgd2UgaGF2ZSAKPiB0aGluZ3MgbGlrZSB0 aGUgZGVidWcgb3B0aW9ucyB0dXJuZWQgb24uICBJIHRlbmQgdG8gdGhpbmsgb2YgaXQgYXMgYSAi aWYgCj4gYSBwYXRjaCBzdWJtaXR0ZXIgaXMgZ29pbmcgdG8gdGVzdCBvbmx5IG9uZSBjb25maWcs IHRoZW4gd2hhdCBkbyBJIHdhbnQgCj4gaW4gaXQ/IiBhbmQgbGV0IHRoYXQgZGV0ZXJtaW5lIHdo YXQgZ29lcyBpbiBkZWZjb25maWcuCgpZZXMsIHRoaXMgaXMgYWxzbyB0aGUgZ3VpZGVsaW5lIGZv ciBhcm02NC4gT24gdG9wIG9mIHRoYXQgaXQncyBzdXBwb3NlZAp0byBiZSBhIHNhbmUgY29tbW9u IGNvbmZpZyB0byBiZSB1c2VkIHRvIHJlcHJvZHVjZSBidWdzLiBBIGNvbW1vbgpxdWVzdGlvbiBm cm9tIG1haW50YWluZXJzIGlzICJEb2VzIGl0IGhhcHBlbiB3aXRoIGRlZmNvbmZpZz8iLiBJZiBu b3QsCndoYXQgZG9lcyBpdCB0YWtlIG9uIHRvcCBvZiBkZWZjb25maWcgdG8gZ2V0IHRoZXJlPwpU aGUgaWRlYSBpcyB0aGF0IHBlb3BsZSBjYW4gcnVuIHRoZSBzYW1lIGNvbmZpZyBhbmQgdGh1cyB0 aGUgc2FtZSBpbWFnZQpvbiAqdGhlaXIqIGJvYXJkcywgcmVnYXJkbGVzcyBvZiB0aGUgcGFydGlj dWxhciBwbGF0Zm9ybS4KCj4gSU1PIGhhdmluZyBkZWZjb25maWcgY29udGFpbiB0aGUgZHJpdmVy cyBuZWNlc3NhcnkgdG8gYm9vdCBldmVyeSBjb21tb24gCj4gZGV2IGJvYXJkIGFzID15LCBhbmQg aGF2aW5nID1tIGZvciBhbnl0aGluZyBlbHNlIG9uIHRob3NlIGJvYXJkcyBhbHNvIAo+IHNlZW0g cmVhc29uYWJsZS4gIFRoYXQgd2lsbCBtYWtlIHRoZSB0cmFuc2l0aW9uIGZyb20gdmVuZG9yL2Rp c3RybyAKPiBrZXJuZWxzIHRvIHVwc3RyZWFtIGEgYml0IHNtb290aGVyLCB3aGljaCBpcyBhbHdh eXMgZ29vZC4gIEkgZ3Vlc3MgCj4gdGhlcmUncyBzb21lIHNsaWdodCBidWlsZCB0aW1lIGFuZCBp bWFnZSBzaXplIGlzc3VlcywgYnV0IGFzaWRlIGZyb20gCj4gc29tZSB2ZXJ5IHNtYWxsIHN5c3Rl bXMgdGhhdCBzaG91bGRuJ3QgYmUgdG9vIGJhZCBmb3Iga2VybmVsIGRldmVsb3BlcnMgCj4gLS0g YW5kIGlmIHdlIHJlYWxseSBlbmQgdXAgd2l0aCBhbm90aGVyIHBvcHVsYXIgc3lzdGVtIHdpdGgg Nk1pQiBvZiBSQU0gCj4gd2UgY2FuIGp1c3Qgc3RpY2sgYW5vdGhlciB0aW55IGRlZmNvbmZpZyBp biB0aGVyZSBmb3IgaXQuCj4gCj4gSSBhY3R1YWxseSBkb24ndCB1c2UgbW9kdWxlcyB3aGVuIGRv aW5nIGtlcm5lbCBkZXZlbG9wbWVudCBiZWNhdXNlIEkgCj4gZmluZCBpdCBlYXNpZXIgdG8gdHJh Y2sgdGhpbmdzIHdoZW4gdGhleSdyZSBwYWNrZWQgaW50byBhIHNpbmdsZSBiaW5hcnksIAoKT3Jp Z2luYWxseSBhcm02NCBpbmNsdWRlZCBtb3N0IGRyaXZlcnMgYXMgWz15XSwgYnV0IHRoaXMgZ3Jl dyB0b28gYmlnCnF1aWNrbHksIHNvIGl0IHdhcyBzY2FsZWQgYmFjayB0byBiZSBhYmxlIHRvIGJv b3QgZnJvbSB0aGUgYm9hcmQncyBtYXNzCnN0b3JhZ2UgKFNEIGNhcmQsIFNBVEEsIE5WTWUpLCB3 aXRoIG5vbi1lc3NlbnRpYWwgZHJpdmVycyBpbmNsdWRlZCBhcwptb2R1bGVzLiBBbmQgeWVzLCBt b3N0IHBlb3BsZSBqdXN0IGJ1aWxkIGFuZCB1c2UgdGhlIEltYWdlLCB3aGljaCBrZWVwcwp0aGUg YnVpbGQgZWZmb3J0IHJlYXNvbmFibGUuCkFsc28gcmVxdWlyZWQgZmVhdHVyZXMgdG8gbWFrZSBz eXN0ZW1kIGhhcHB5LCBhbmQgdG8gZW5hYmxlIG90aGVyIGNvcmUKZGlzdHJvIGZlYXR1cmVzLCB3 ZXJlIGluY2x1ZGVkLCBzbyB0aGF0IHN1Y2gga2VybmVscyBjYW4gYm9vdCBkaXN0cm8KdXNlcmxh bmQgd2l0aG91dCBsb3Npbmcgc2lnbmlmaWNhbnQgZnVuY3Rpb25hbGl0eS4KCj4gYnV0IEkgZG9u J3QgdGhpbmsgaXQncyBuZWNlc3NhcnkgdG8gc3RlZXIgZXZlcnlvbmUgdGhhdCB3YXkuCj4gCj4g QWRkaW5nIHNvbWUgb2YgdGhlIEFybSBmb2xrcyBoZXJlLCBpbiBjYXNlIHRoZXkgaGF2ZSB0aG91 Z2h0cy4gIFRoZSBiZXN0IAo+IGJldCBpcyBwcm9iYWJseSB0byB0cnkgYW5kIGRvIHNvbWV0aGlu ZyBzaW1pbGFyLCB0aG91Z2ggbXkgd29ycnkgaXMgdGhhdCAKPiB0aGUgYW5zd2VyIGlzIHNvbWV0 aGluZyBsaWtlICJ0YXJnZXQgc3RhbmRhcmQgcGxhdGZvcm1zIiBhbmQgd2UgZG9uJ3QgCj4gaGF2 ZSBhbnkuCgpObyBzdWNoIHRoaW5nIG9uIGFybTY0IGVpdGhlciA6LSgKCkNoZWVycywKQW5kcmUK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXJp c2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 95A607E0 for ; Thu, 1 Dec 2022 00:33:01 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 67E7AD6E; Wed, 30 Nov 2022 16:33:01 -0800 (PST) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1D8763F67D; Wed, 30 Nov 2022 16:32:50 -0800 (PST) Date: Thu, 1 Dec 2022 00:31:02 +0000 From: Andre Przywara To: Palmer Dabbelt Cc: Conor Dooley , Arnd Bergmann , Will Deacon , Marc Zyngier , ajones@ventanamicro.com, heiko@sntech.de, samuel@sholland.org, wens@csie.org, jernej.skrabec@gmail.com, linux-sunxi@lists.linux.dev, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, jszhang@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, aou@eecs.berkeley.edu, apatel@ventanamicro.com, Atish Patra , christianshewitt@gmail.com, Conor Dooley , guoren@kernel.org, heinrich.schuchardt@canonical.com, linus.walleij@linaro.org, Paul Walmsley , stano.jakubek@gmail.com Subject: Re: [PATCH v2 12/12] riscv: defconfig: Enable the Allwinner D1 platform and drivers Message-ID: <20221201003102.1b131a2d@slackpad.lan> In-Reply-To: References: Organization: Arm Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 30 Nov 2022 12:24:08 -0800 (PST) Palmer Dabbelt wrote: Hi, > On Mon, 28 Nov 2022 22:54:18 PST (-0800), Conor Dooley wrote: > > > > > > On 29 November 2022 06:49:25 GMT, Andrew Jones wrote: =20 > >>On Mon, Nov 28, 2022 at 09:17:38PM +0000, Conor Dooley wrote: =20 > >>> On 28/11/2022 21:11, Heiko St=C3=BCbner wrote: =20 > >>> > Am Samstag, 26. November 2022, 17:40:11 CET schrieb Conor Dooley: = =20 > >>> >> On Fri, Nov 25, 2022 at 05:46:56PM -0600, Samuel Holland wrote: =20 > >>> >>> Now that several D1-based boards are supported, enable the platfo= rm in > >>> >>> our defconfig. Build in the drivers which are necessary to boot, = such as > >>> >>> the pinctrl, MMC, RTC (which provides critical clocks), SPI (for = flash), > >>> >>> and watchdog (which may be left enabled by the bootloader). =20 > >>> >> > >>> >> All of that looks good. > >>> >> =20 > >>> >>> Other common > >>> >>> onboard peripherals are enabled as modules. =20 > >>> >> > >>> >> This I am not sure about though. I'll leave that to Palmer since I= 'm > >>> >> pretty sure it was him that said it, but I thought the plan was on= ly > >>> >> turning on stuff required to boot to a console & things that are > >>> >> generally useful rather than enabling modules for everyone's "rand= om" > >>> >> drivers. Palmer? =20 > >>> >=20 > >>> > Isn't the defconfig meant as a starting point to get working systems > >>> > with minimal config effort? At least that was always the way to go = on arm > >>> > so far :-) . > >>> >=20 > >>> > So having boot-required drivers built-in with the rest enabled as m= odules > >>> > for supported boards will allow people to boot theirs without heada= ches. > >>> >=20 > >>> > Disabling unneeded drivers if you're starved for storage space in a= special > >>> > project is always easier than hunting down all the drivers to enabl= e for a > >>> > specific board. =20 > >>>=20 > >>> I wouldn't mind being able to turn on all the PolarFire SoC stuff and > >>> yeah, that would be the way that arm64 does it. But I do recall heari= ng > >>> that I should not turn stuff on this way, when I initially tried to > >>> turn stuff on via selects, got a nack and asked if I could do this in= stead. > >>>=20 > >>> But it may be that I misremember, which is why I appealed to the High= er > >>> Powers for clarification :) =20 > >> > >>FWIW, I don't worry too much about modules in defconfig because I always > >>immediately apply a 'LSMOD=3D$PWD/L localmodconfig' to it, where the L > >>file is an lsmod output which only includes modules I need. =20 > > > > idk, defconfig to me is not about you or I, it's about A Developer that= gets an SBC or a devkit and their experience. > > Or alternatively, someone's CI ;) > > I'd like to put everything in, but I recall that being shot down, that'= s all. =20 >=20 > The whole "who is defconfig for" discussion always ends up kind of=20 > vague, but IIUC it's generally aimed at kernel hackers as opposed to end= =20 > users -- so it's not meant to be a disto config, that's why we have=20 > things like the debug options turned on. I tend to think of it as a "if= =20 > a patch submitter is going to test only one config, then what do I want=20 > in it?" and let that determine what goes in defconfig. Yes, this is also the guideline for arm64. On top of that it's supposed to be a sane common config to be used to reproduce bugs. A common question from maintainers is "Does it happen with defconfig?". If not, what does it take on top of defconfig to get there? The idea is that people can run the same config and thus the same image on *their* boards, regardless of the particular platform. > IMO having defconfig contain the drivers necessary to boot every common=20 > dev board as =3Dy, and having =3Dm for anything else on those boards also= =20 > seem reasonable. That will make the transition from vendor/distro=20 > kernels to upstream a bit smoother, which is always good. I guess=20 > there's some slight build time and image size issues, but aside from=20 > some very small systems that shouldn't be too bad for kernel developers=20 > -- and if we really end up with another popular system with 6MiB of RAM=20 > we can just stick another tiny defconfig in there for it. >=20 > I actually don't use modules when doing kernel development because I=20 > find it easier to track things when they're packed into a single binary,= =20 Originally arm64 included most drivers as [=3Dy], but this grew too big quickly, so it was scaled back to be able to boot from the board's mass storage (SD card, SATA, NVMe), with non-essential drivers included as modules. And yes, most people just build and use the Image, which keeps the build effort reasonable. Also required features to make systemd happy, and to enable other core distro features, were included, so that such kernels can boot distro userland without losing significant functionality. > but I don't think it's necessary to steer everyone that way. >=20 > Adding some of the Arm folks here, in case they have thoughts. The best= =20 > bet is probably to try and do something similar, though my worry is that= =20 > the answer is something like "target standard platforms" and we don't=20 > have any. No such thing on arm64 either :-( Cheers, Andre From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9834C4321E for ; Thu, 1 Dec 2022 00:33:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R1Mog7c+HrMoJcEjRup2bexWuGpmlBu4VQlhOTPF7tQ=; b=h2HvfWmrsddVG9 TkTK+/+l6ZSrx715SNLG1WqHWDu2gSAAlYVz/hLUJGFFpqJfVSLcGekKIDJ18tCc6RxiGvV56DGAr m8ZstwkFT0RhuoYA8s+QoW+bFnJ6hqpRF0aj7q+WVvtD7h5wogdNfr7bQE5k86CrffKsaWXAAzHAw ZXy4ekDcMW6ahi7lAAbXAB4iaYN2yh/EGp7aeWP/J6Ffc8YLBnWVJZtV48sOTcu53lSiAI7Dnwu82 ND4wIkIA0GSw0id5wXOKPfn4YUieQMoAeGaq0yMwp46J2tsj6LEM1cbZqWqMVQmn1MYZP2aOc0yoL GaSErJF65hWxvS+XzKHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0XVh-003f8A-Ez; Thu, 01 Dec 2022 00:33:05 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0XVd-003f66-9W; Thu, 01 Dec 2022 00:33:03 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 67E7AD6E; Wed, 30 Nov 2022 16:33:01 -0800 (PST) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1D8763F67D; Wed, 30 Nov 2022 16:32:50 -0800 (PST) Date: Thu, 1 Dec 2022 00:31:02 +0000 From: Andre Przywara To: Palmer Dabbelt Cc: Conor Dooley , Arnd Bergmann , Will Deacon , Marc Zyngier , ajones@ventanamicro.com, heiko@sntech.de, samuel@sholland.org, wens@csie.org, jernej.skrabec@gmail.com, linux-sunxi@lists.linux.dev, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, jszhang@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, aou@eecs.berkeley.edu, apatel@ventanamicro.com, Atish Patra , christianshewitt@gmail.com, Conor Dooley , guoren@kernel.org, heinrich.schuchardt@canonical.com, linus.walleij@linaro.org, Paul Walmsley , stano.jakubek@gmail.com Subject: Re: [PATCH v2 12/12] riscv: defconfig: Enable the Allwinner D1 platform and drivers Message-ID: <20221201003102.1b131a2d@slackpad.lan> In-Reply-To: References: Organization: Arm Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221130_163301_455943_C7355238 X-CRM114-Status: GOOD ( 45.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAzMCBOb3YgMjAyMiAxMjoyNDowOCAtMDgwMCAoUFNUKQpQYWxtZXIgRGFiYmVsdCA8 cGFsbWVyQGRhYmJlbHQuY29tPiB3cm90ZToKCkhpLAoKPiBPbiBNb24sIDI4IE5vdiAyMDIyIDIy OjU0OjE4IFBTVCAoLTA4MDApLCBDb25vciBEb29sZXkgd3JvdGU6Cj4gPgo+ID4KPiA+IE9uIDI5 IE5vdmVtYmVyIDIwMjIgMDY6NDk6MjUgR01ULCBBbmRyZXcgSm9uZXMgPGFqb25lc0B2ZW50YW5h bWljcm8uY29tPiB3cm90ZTogIAo+ID4+T24gTW9uLCBOb3YgMjgsIDIwMjIgYXQgMDk6MTc6MzhQ TSArMDAwMCwgQ29ub3IgRG9vbGV5IHdyb3RlOiAgCj4gPj4+IE9uIDI4LzExLzIwMjIgMjE6MTEs IEhlaWtvIFN0w7xibmVyIHdyb3RlOiAgCj4gPj4+ID4gQW0gU2Ftc3RhZywgMjYuIE5vdmVtYmVy IDIwMjIsIDE3OjQwOjExIENFVCBzY2hyaWViIENvbm9yIERvb2xleTogIAo+ID4+PiA+PiBPbiBG cmksIE5vdiAyNSwgMjAyMiBhdCAwNTo0Njo1NlBNIC0wNjAwLCBTYW11ZWwgSG9sbGFuZCB3cm90 ZTogIAo+ID4+PiA+Pj4gTm93IHRoYXQgc2V2ZXJhbCBEMS1iYXNlZCBib2FyZHMgYXJlIHN1cHBv cnRlZCwgZW5hYmxlIHRoZSBwbGF0Zm9ybSBpbgo+ID4+PiA+Pj4gb3VyIGRlZmNvbmZpZy4gQnVp bGQgaW4gdGhlIGRyaXZlcnMgd2hpY2ggYXJlIG5lY2Vzc2FyeSB0byBib290LCBzdWNoIGFzCj4g Pj4+ID4+PiB0aGUgcGluY3RybCwgTU1DLCBSVEMgKHdoaWNoIHByb3ZpZGVzIGNyaXRpY2FsIGNs b2NrcyksIFNQSSAoZm9yIGZsYXNoKSwKPiA+Pj4gPj4+IGFuZCB3YXRjaGRvZyAod2hpY2ggbWF5 IGJlIGxlZnQgZW5hYmxlZCBieSB0aGUgYm9vdGxvYWRlcikuICAKPiA+Pj4gPj4KPiA+Pj4gPj4g QWxsIG9mIHRoYXQgbG9va3MgZ29vZC4KPiA+Pj4gPj4gIAo+ID4+PiA+Pj4gT3RoZXIgY29tbW9u Cj4gPj4+ID4+PiBvbmJvYXJkIHBlcmlwaGVyYWxzIGFyZSBlbmFibGVkIGFzIG1vZHVsZXMuICAK PiA+Pj4gPj4KPiA+Pj4gPj4gVGhpcyBJIGFtIG5vdCBzdXJlIGFib3V0IHRob3VnaC4gSSdsbCBs ZWF2ZSB0aGF0IHRvIFBhbG1lciBzaW5jZSBJJ20KPiA+Pj4gPj4gcHJldHR5IHN1cmUgaXQgd2Fz IGhpbSB0aGF0IHNhaWQgaXQsIGJ1dCBJIHRob3VnaHQgdGhlIHBsYW4gd2FzIG9ubHkKPiA+Pj4g Pj4gdHVybmluZyBvbiBzdHVmZiByZXF1aXJlZCB0byBib290IHRvIGEgY29uc29sZSAmIHRoaW5n cyB0aGF0IGFyZQo+ID4+PiA+PiBnZW5lcmFsbHkgdXNlZnVsIHJhdGhlciB0aGFuIGVuYWJsaW5n IG1vZHVsZXMgZm9yIGV2ZXJ5b25lJ3MgInJhbmRvbSIKPiA+Pj4gPj4gZHJpdmVycy4gUGFsbWVy PyAgCj4gPj4+ID4gCj4gPj4+ID4gSXNuJ3QgdGhlIGRlZmNvbmZpZyBtZWFudCBhcyBhIHN0YXJ0 aW5nIHBvaW50IHRvIGdldCB3b3JraW5nIHN5c3RlbXMKPiA+Pj4gPiB3aXRoIG1pbmltYWwgY29u ZmlnIGVmZm9ydD8gQXQgbGVhc3QgdGhhdCB3YXMgYWx3YXlzIHRoZSB3YXkgdG8gZ28gb24gYXJt Cj4gPj4+ID4gc28gZmFyIDotKSAuCj4gPj4+ID4gCj4gPj4+ID4gU28gaGF2aW5nIGJvb3QtcmVx dWlyZWQgZHJpdmVycyBidWlsdC1pbiB3aXRoIHRoZSByZXN0IGVuYWJsZWQgYXMgbW9kdWxlcwo+ ID4+PiA+IGZvciBzdXBwb3J0ZWQgYm9hcmRzIHdpbGwgYWxsb3cgcGVvcGxlIHRvIGJvb3QgdGhl aXJzIHdpdGhvdXQgaGVhZGFjaGVzLgo+ID4+PiA+IAo+ID4+PiA+IERpc2FibGluZyB1bm5lZWRl ZCBkcml2ZXJzIGlmIHlvdSdyZSBzdGFydmVkIGZvciBzdG9yYWdlIHNwYWNlIGluIGEgc3BlY2lh bAo+ID4+PiA+IHByb2plY3QgaXMgYWx3YXlzIGVhc2llciB0aGFuIGh1bnRpbmcgZG93biBhbGwg dGhlIGRyaXZlcnMgdG8gZW5hYmxlIGZvciBhCj4gPj4+ID4gc3BlY2lmaWMgYm9hcmQuICAgCj4g Pj4+IAo+ID4+PiBJIHdvdWxkbid0IG1pbmQgYmVpbmcgYWJsZSB0byB0dXJuIG9uIGFsbCB0aGUg UG9sYXJGaXJlIFNvQyBzdHVmZiBhbmQKPiA+Pj4geWVhaCwgdGhhdCB3b3VsZCBiZSB0aGUgd2F5 IHRoYXQgYXJtNjQgZG9lcyBpdC4gQnV0IEkgZG8gcmVjYWxsIGhlYXJpbmcKPiA+Pj4gdGhhdCBJ IHNob3VsZCBub3QgdHVybiBzdHVmZiBvbiB0aGlzIHdheSwgd2hlbiBJIGluaXRpYWxseSB0cmll ZCB0bwo+ID4+PiB0dXJuIHN0dWZmIG9uIHZpYSBzZWxlY3RzLCBnb3QgYSBuYWNrIGFuZCBhc2tl ZCBpZiBJIGNvdWxkIGRvIHRoaXMgaW5zdGVhZC4KPiA+Pj4gCj4gPj4+IEJ1dCBpdCBtYXkgYmUg dGhhdCBJIG1pc3JlbWVtYmVyLCB3aGljaCBpcyB3aHkgSSBhcHBlYWxlZCB0byB0aGUgSGlnaGVy Cj4gPj4+IFBvd2VycyBmb3IgY2xhcmlmaWNhdGlvbiA6KSAgCj4gPj4KPiA+PkZXSVcsIEkgZG9u J3Qgd29ycnkgdG9vIG11Y2ggYWJvdXQgbW9kdWxlcyBpbiBkZWZjb25maWcgYmVjYXVzZSBJIGFs d2F5cwo+ID4+aW1tZWRpYXRlbHkgYXBwbHkgYSAnTFNNT0Q9JFBXRC9MIGxvY2FsbW9kY29uZmln JyB0byBpdCwgd2hlcmUgdGhlIEwKPiA+PmZpbGUgaXMgYW4gbHNtb2Qgb3V0cHV0IHdoaWNoIG9u bHkgaW5jbHVkZXMgbW9kdWxlcyBJIG5lZWQuICAKPiA+Cj4gPiBpZGssIGRlZmNvbmZpZyB0byBt ZSBpcyBub3QgYWJvdXQgeW91IG9yIEksIGl0J3MgYWJvdXQgQSBEZXZlbG9wZXIgdGhhdCBnZXRz IGFuIFNCQyBvciBhIGRldmtpdCBhbmQgdGhlaXIgZXhwZXJpZW5jZS4KPiA+IE9yIGFsdGVybmF0 aXZlbHksIHNvbWVvbmUncyBDSSA7KQo+ID4gSSdkIGxpa2UgdG8gcHV0IGV2ZXJ5dGhpbmcgaW4s IGJ1dCBJIHJlY2FsbCB0aGF0IGJlaW5nIHNob3QgZG93biwgdGhhdCdzIGFsbC4gIAo+IAo+IFRo ZSB3aG9sZSAid2hvIGlzIGRlZmNvbmZpZyBmb3IiIGRpc2N1c3Npb24gYWx3YXlzIGVuZHMgdXAg a2luZCBvZiAKPiB2YWd1ZSwgYnV0IElJVUMgaXQncyBnZW5lcmFsbHkgYWltZWQgYXQga2VybmVs IGhhY2tlcnMgYXMgb3Bwb3NlZCB0byBlbmQgCj4gdXNlcnMgLS0gc28gaXQncyBub3QgbWVhbnQg dG8gYmUgYSBkaXN0byBjb25maWcsIHRoYXQncyB3aHkgd2UgaGF2ZSAKPiB0aGluZ3MgbGlrZSB0 aGUgZGVidWcgb3B0aW9ucyB0dXJuZWQgb24uICBJIHRlbmQgdG8gdGhpbmsgb2YgaXQgYXMgYSAi aWYgCj4gYSBwYXRjaCBzdWJtaXR0ZXIgaXMgZ29pbmcgdG8gdGVzdCBvbmx5IG9uZSBjb25maWcs IHRoZW4gd2hhdCBkbyBJIHdhbnQgCj4gaW4gaXQ/IiBhbmQgbGV0IHRoYXQgZGV0ZXJtaW5lIHdo YXQgZ29lcyBpbiBkZWZjb25maWcuCgpZZXMsIHRoaXMgaXMgYWxzbyB0aGUgZ3VpZGVsaW5lIGZv ciBhcm02NC4gT24gdG9wIG9mIHRoYXQgaXQncyBzdXBwb3NlZAp0byBiZSBhIHNhbmUgY29tbW9u IGNvbmZpZyB0byBiZSB1c2VkIHRvIHJlcHJvZHVjZSBidWdzLiBBIGNvbW1vbgpxdWVzdGlvbiBm cm9tIG1haW50YWluZXJzIGlzICJEb2VzIGl0IGhhcHBlbiB3aXRoIGRlZmNvbmZpZz8iLiBJZiBu b3QsCndoYXQgZG9lcyBpdCB0YWtlIG9uIHRvcCBvZiBkZWZjb25maWcgdG8gZ2V0IHRoZXJlPwpU aGUgaWRlYSBpcyB0aGF0IHBlb3BsZSBjYW4gcnVuIHRoZSBzYW1lIGNvbmZpZyBhbmQgdGh1cyB0 aGUgc2FtZSBpbWFnZQpvbiAqdGhlaXIqIGJvYXJkcywgcmVnYXJkbGVzcyBvZiB0aGUgcGFydGlj dWxhciBwbGF0Zm9ybS4KCj4gSU1PIGhhdmluZyBkZWZjb25maWcgY29udGFpbiB0aGUgZHJpdmVy cyBuZWNlc3NhcnkgdG8gYm9vdCBldmVyeSBjb21tb24gCj4gZGV2IGJvYXJkIGFzID15LCBhbmQg aGF2aW5nID1tIGZvciBhbnl0aGluZyBlbHNlIG9uIHRob3NlIGJvYXJkcyBhbHNvIAo+IHNlZW0g cmVhc29uYWJsZS4gIFRoYXQgd2lsbCBtYWtlIHRoZSB0cmFuc2l0aW9uIGZyb20gdmVuZG9yL2Rp c3RybyAKPiBrZXJuZWxzIHRvIHVwc3RyZWFtIGEgYml0IHNtb290aGVyLCB3aGljaCBpcyBhbHdh eXMgZ29vZC4gIEkgZ3Vlc3MgCj4gdGhlcmUncyBzb21lIHNsaWdodCBidWlsZCB0aW1lIGFuZCBp bWFnZSBzaXplIGlzc3VlcywgYnV0IGFzaWRlIGZyb20gCj4gc29tZSB2ZXJ5IHNtYWxsIHN5c3Rl bXMgdGhhdCBzaG91bGRuJ3QgYmUgdG9vIGJhZCBmb3Iga2VybmVsIGRldmVsb3BlcnMgCj4gLS0g YW5kIGlmIHdlIHJlYWxseSBlbmQgdXAgd2l0aCBhbm90aGVyIHBvcHVsYXIgc3lzdGVtIHdpdGgg Nk1pQiBvZiBSQU0gCj4gd2UgY2FuIGp1c3Qgc3RpY2sgYW5vdGhlciB0aW55IGRlZmNvbmZpZyBp biB0aGVyZSBmb3IgaXQuCj4gCj4gSSBhY3R1YWxseSBkb24ndCB1c2UgbW9kdWxlcyB3aGVuIGRv aW5nIGtlcm5lbCBkZXZlbG9wbWVudCBiZWNhdXNlIEkgCj4gZmluZCBpdCBlYXNpZXIgdG8gdHJh Y2sgdGhpbmdzIHdoZW4gdGhleSdyZSBwYWNrZWQgaW50byBhIHNpbmdsZSBiaW5hcnksIAoKT3Jp Z2luYWxseSBhcm02NCBpbmNsdWRlZCBtb3N0IGRyaXZlcnMgYXMgWz15XSwgYnV0IHRoaXMgZ3Jl dyB0b28gYmlnCnF1aWNrbHksIHNvIGl0IHdhcyBzY2FsZWQgYmFjayB0byBiZSBhYmxlIHRvIGJv b3QgZnJvbSB0aGUgYm9hcmQncyBtYXNzCnN0b3JhZ2UgKFNEIGNhcmQsIFNBVEEsIE5WTWUpLCB3 aXRoIG5vbi1lc3NlbnRpYWwgZHJpdmVycyBpbmNsdWRlZCBhcwptb2R1bGVzLiBBbmQgeWVzLCBt b3N0IHBlb3BsZSBqdXN0IGJ1aWxkIGFuZCB1c2UgdGhlIEltYWdlLCB3aGljaCBrZWVwcwp0aGUg YnVpbGQgZWZmb3J0IHJlYXNvbmFibGUuCkFsc28gcmVxdWlyZWQgZmVhdHVyZXMgdG8gbWFrZSBz eXN0ZW1kIGhhcHB5LCBhbmQgdG8gZW5hYmxlIG90aGVyIGNvcmUKZGlzdHJvIGZlYXR1cmVzLCB3 ZXJlIGluY2x1ZGVkLCBzbyB0aGF0IHN1Y2gga2VybmVscyBjYW4gYm9vdCBkaXN0cm8KdXNlcmxh bmQgd2l0aG91dCBsb3Npbmcgc2lnbmlmaWNhbnQgZnVuY3Rpb25hbGl0eS4KCj4gYnV0IEkgZG9u J3QgdGhpbmsgaXQncyBuZWNlc3NhcnkgdG8gc3RlZXIgZXZlcnlvbmUgdGhhdCB3YXkuCj4gCj4g QWRkaW5nIHNvbWUgb2YgdGhlIEFybSBmb2xrcyBoZXJlLCBpbiBjYXNlIHRoZXkgaGF2ZSB0aG91 Z2h0cy4gIFRoZSBiZXN0IAo+IGJldCBpcyBwcm9iYWJseSB0byB0cnkgYW5kIGRvIHNvbWV0aGlu ZyBzaW1pbGFyLCB0aG91Z2ggbXkgd29ycnkgaXMgdGhhdCAKPiB0aGUgYW5zd2VyIGlzIHNvbWV0 aGluZyBsaWtlICJ0YXJnZXQgc3RhbmRhcmQgcGxhdGZvcm1zIiBhbmQgd2UgZG9uJ3QgCj4gaGF2 ZSBhbnkuCgpObyBzdWNoIHRoaW5nIG9uIGFybTY0IGVpdGhlciA6LSgKCkNoZWVycywKQW5kcmUK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFy bS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1r ZXJuZWwK