From: coverity-bot <keescook@chromium.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Sean Christopherson <seanjc@google.com>,
x86@kernel.org, Maxim Levitsky <mlevitsk@redhat.com>,
linux-kernel@vger.kernel.org, Borislav Petkov <bp@alien8.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
kvm@vger.kernel.org, Dave Hansen <dave.hansen@linux.intel.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Coverity: emulator_leave_smm(): Error handling issues
Date: Thu, 1 Dec 2022 08:25:50 -0800 [thread overview]
Message-ID: <202212010825.8589611F@keescook> (raw)
Hello!
This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20221201 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:
Wed Nov 9 12:31:18 2022 -0500
1d0da94cdafe ("KVM: x86: do not go through ctxt->ops when emulating rsm")
Coverity reported the following:
*** CID 1527763: Error handling issues (CHECKED_RETURN)
arch/x86/kvm/smm.c:631 in emulator_leave_smm()
625 cr4 = kvm_read_cr4(vcpu);
626 if (cr4 & X86_CR4_PAE)
627 kvm_set_cr4(vcpu, cr4 & ~X86_CR4_PAE);
628
629 /* And finally go back to 32-bit mode. */
630 efer = 0;
vvv CID 1527763: Error handling issues (CHECKED_RETURN)
vvv Calling "kvm_set_msr" without checking return value (as is done elsewhere 5 out of 6 times).
631 kvm_set_msr(vcpu, MSR_EFER, efer);
632 }
633 #endif
634
635 /*
636 * Give leave_smm() a chance to make ISA-specific changes to the vCPU
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1527763 ("Error handling issues")
Fixes: 1d0da94cdafe ("KVM: x86: do not go through ctxt->ops when emulating rsm")
Thanks for your attention!
--
Coverity-bot
next reply other threads:[~2022-12-01 16:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 16:25 coverity-bot [this message]
2022-12-01 18:18 ` Coverity: emulator_leave_smm(): Error handling issues Sean Christopherson
2022-12-01 23:22 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202212010825.8589611F@keescook \
--to=keescook@chromium.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=gustavo@embeddedor.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.