From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9C45E10F6; Thu, 1 Dec 2022 10:23:03 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 175C1D6E; Thu, 1 Dec 2022 02:23:09 -0800 (PST) Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D4DF93F67D; Thu, 1 Dec 2022 02:22:55 -0800 (PST) Date: Thu, 1 Dec 2022 10:22:52 +0000 From: Andre Przywara To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: Thierry Reding , Conor Dooley , Linus Walleij , Bartosz Golaszewski , Douglas Anderson , Pavel Machek , Claudiu Beznea , Nicolas Ferre , Alexandre Belloni , Ray Jui , Scott Branden , Broadcom internal kernel review list , Benson Leung , Guenter Roeck , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , Florian Fainelli , Heiko Stuebner , Palmer Dabbelt , Paul Walmsley , Michael Walle , Orson Zhai , Baolin Wang , Chunyan Zhang , Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Samuel Holland , Hammer Hsieh , Nobuhiro Iwamatsu , Sean Anderson , Michal Simek , Bjorn Andersson , Stephen Boyd , Matthias Kaehlcke , Satya Priya , linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v2 01/11] pwm: Make .get_state() callback return an error code Message-ID: <20221201102252.52ace284@donnerap.cambridge.arm.com> In-Reply-To: <20221130152148.2769768-2-u.kleine-koenig@pengutronix.de> References: <20221130152148.2769768-1-u.kleine-koenig@pengutronix.de> <20221130152148.2769768-2-u.kleine-koenig@pengutronix.de> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 30 Nov 2022 16:21:38 +0100 Uwe Kleine-K=C3=B6nig wrote: Hi, > .get_state() might fail in some cases. To make it possible that a driver > signals such a failure change the prototype of .get_state() to return an > error code. >=20 > This patch was created using coccinelle and the following semantic patch: >=20 > @p1@ > identifier getstatefunc; > identifier driver; > @@ > struct pwm_ops driver =3D { > ..., > .get_state =3D getstatefunc > ,... > }; >=20 > @p2@ > identifier p1.getstatefunc; > identifier chip, pwm, state; > @@ > -void > +int > getstatefunc(struct pwm_chip *chip, struct pwm_device *pwm, struct pwm_s= tate *state) > { > ... > - return; > + return 0; > ... > } >=20 > plus the actual change of the prototype in include/linux/pwm.h (plus some > manual fixing of indentions and empty lines). >=20 > So for now all drivers return success unconditionally. They are adapted > in the following patches to make the changes easier reviewable. >=20 > Signed-off-by: Uwe Kleine-K=C3=B6nig > --- > drivers/gpio/gpio-mvebu.c | 9 ++++++--- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 14 ++++++++------ > drivers/leds/rgb/leds-qcom-lpg.c | 14 ++++++++------ > drivers/pwm/pwm-atmel.c | 6 ++++-- > drivers/pwm/pwm-bcm-iproc.c | 8 +++++--- > drivers/pwm/pwm-crc.c | 10 ++++++---- > drivers/pwm/pwm-cros-ec.c | 8 +++++--- > drivers/pwm/pwm-dwc.c | 6 ++++-- > drivers/pwm/pwm-hibvt.c | 6 ++++-- > drivers/pwm/pwm-imx-tpm.c | 8 +++++--- > drivers/pwm/pwm-imx27.c | 8 +++++--- > drivers/pwm/pwm-intel-lgm.c | 6 ++++-- > drivers/pwm/pwm-iqs620a.c | 6 ++++-- > drivers/pwm/pwm-keembay.c | 6 ++++-- > drivers/pwm/pwm-lpss.c | 6 ++++-- > drivers/pwm/pwm-meson.c | 8 +++++--- > drivers/pwm/pwm-mtk-disp.c | 12 +++++++----- > drivers/pwm/pwm-pca9685.c | 8 +++++--- > drivers/pwm/pwm-raspberrypi-poe.c | 8 +++++--- > drivers/pwm/pwm-rockchip.c | 12 +++++++----- > drivers/pwm/pwm-sifive.c | 6 ++++-- > drivers/pwm/pwm-sl28cpld.c | 8 +++++--- > drivers/pwm/pwm-sprd.c | 8 +++++--- > drivers/pwm/pwm-stm32-lp.c | 8 +++++--- > drivers/pwm/pwm-sun4i.c | 12 +++++++----- > drivers/pwm/pwm-sunplus.c | 6 ++++-- > drivers/pwm/pwm-visconti.c | 6 ++++-- > drivers/pwm/pwm-xilinx.c | 8 +++++--- > include/linux/pwm.h | 4 ++-- > 29 files changed, 146 insertions(+), 89 deletions(-) >=20 [ ... ] > diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c > index c8445b0a3339..37d75e252d4e 100644 > --- a/drivers/pwm/pwm-sun4i.c > +++ b/drivers/pwm/pwm-sun4i.c > @@ -108,9 +108,9 @@ static inline void sun4i_pwm_writel(struct sun4i_pwm_= chip *chip, > writel(val, chip->base + offset); > } > =20 > -static void sun4i_pwm_get_state(struct pwm_chip *chip, > - struct pwm_device *pwm, > - struct pwm_state *state) > +static int sun4i_pwm_get_state(struct pwm_chip *chip, > + struct pwm_device *pwm, > + struct pwm_state *state) > { > struct sun4i_pwm_chip *sun4i_pwm =3D to_sun4i_pwm_chip(chip); > u64 clk_rate, tmp; > @@ -132,7 +132,7 @@ static void sun4i_pwm_get_state(struct pwm_chip *chip, > state->duty_cycle =3D DIV_ROUND_UP_ULL(state->period, 2); > state->polarity =3D PWM_POLARITY_NORMAL; > state->enabled =3D true; > - return; > + return 0; > } > =20 > if ((PWM_REG_PRESCAL(val, pwm->hwpwm) =3D=3D PWM_PRESCAL_MASK) && > @@ -142,7 +142,7 @@ static void sun4i_pwm_get_state(struct pwm_chip *chip, > prescaler =3D prescaler_table[PWM_REG_PRESCAL(val, pwm->hwpwm)]; > =20 > if (prescaler =3D=3D 0) > - return; > + return 0; > =20 > if (val & BIT_CH(PWM_ACT_STATE, pwm->hwpwm)) > state->polarity =3D PWM_POLARITY_NORMAL; > @@ -162,6 +162,8 @@ static void sun4i_pwm_get_state(struct pwm_chip *chip, > =20 > tmp =3D (u64)prescaler * NSEC_PER_SEC * PWM_REG_PRD(val); > state->period =3D DIV_ROUND_CLOSEST_ULL(tmp, clk_rate); > + > + return 0; > } > =20 > static int sun4i_pwm_calculate(struct sun4i_pwm_chip *sun4i_pwm, For sunxi: Reviewed-by: Andre Przywara Just one comment: I don't see a sunxi specific patch later in the series, though it seems we have at least one error error exit (see prescaler =3D=3D= 0 above). Plus potentially another exit if clk_get_rate() (at the very beginning) fails. Shall I send a patch for that? Cheers, Andre. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6788AC47088 for ; Thu, 1 Dec 2022 10:23:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=42qcVO5rHRAdYQI6Lb+OuWrrP7L2vRb/EzFxz14/Rwg=; b=X+Rw+ywM7THijz HlL3dAe+kCbF5DKVdBKzuF7yNJ2r5gkjBF49JAx0einqgjZI2WKCygeXJmrhsGKBQs+NoA0SWKn9q 781kNTSBXYp790iBAMyk0rgjISPRYrjkKZFFp3PQ2XYvqAZsSdu/NMIxnZzdl0ZHPGi1O0hMB5ZPf zQq6tSAwXwz/vyy227tvISY1+kOG9DqAw7VMJQgU45nC4OLSYjVIMLyfB2NgHxMm3nqap0OIoIZIT p64haz17JQWE3rsYOPNnEhB9q4g64mXJcpCh5ZY9cD0hhCt1/wXkDvKU64g+F/wNyJPj10a3iY11E yHirzJrMVsFVnqs8PRmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0gil-006g9f-3w; Thu, 01 Dec 2022 10:23:11 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0gih-006g6F-2d; Thu, 01 Dec 2022 10:23:09 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 175C1D6E; Thu, 1 Dec 2022 02:23:09 -0800 (PST) Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D4DF93F67D; Thu, 1 Dec 2022 02:22:55 -0800 (PST) Date: Thu, 1 Dec 2022 10:22:52 +0000 From: Andre Przywara To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: Thierry Reding , Conor Dooley , Linus Walleij , Bartosz Golaszewski , Douglas Anderson , Pavel Machek , Claudiu Beznea , Nicolas Ferre , Alexandre Belloni , Ray Jui , Scott Branden , Broadcom internal kernel review list , Benson Leung , Guenter Roeck , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , Florian Fainelli , Heiko Stuebner , Palmer Dabbelt , Paul Walmsley , Michael Walle , Orson Zhai , Baolin Wang , Chunyan Zhang , Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Samuel Holland , Hammer Hsieh , Nobuhiro Iwamatsu , Sean Anderson , Michal Simek , Bjorn Andersson , Stephen Boyd , Matthias Kaehlcke , Satya Priya , linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v2 01/11] pwm: Make .get_state() callback return an error code Message-ID: <20221201102252.52ace284@donnerap.cambridge.arm.com> In-Reply-To: <20221130152148.2769768-2-u.kleine-koenig@pengutronix.de> References: <20221130152148.2769768-1-u.kleine-koenig@pengutronix.de> <20221130152148.2769768-2-u.kleine-koenig@pengutronix.de> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221201_022307_257666_4BD03F7D X-CRM114-Status: GOOD ( 25.50 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org T24gV2VkLCAzMCBOb3YgMjAyMiAxNjoyMTozOCArMDEwMApVd2UgS2xlaW5lLUvDtm5pZyA8dS5r bGVpbmUta29lbmlnQHBlbmd1dHJvbml4LmRlPiB3cm90ZToKCkhpLAoKPiAuZ2V0X3N0YXRlKCkg bWlnaHQgZmFpbCBpbiBzb21lIGNhc2VzLiBUbyBtYWtlIGl0IHBvc3NpYmxlIHRoYXQgYSBkcml2 ZXIKPiBzaWduYWxzIHN1Y2ggYSBmYWlsdXJlIGNoYW5nZSB0aGUgcHJvdG90eXBlIG9mIC5nZXRf c3RhdGUoKSB0byByZXR1cm4gYW4KPiBlcnJvciBjb2RlLgo+IAo+IFRoaXMgcGF0Y2ggd2FzIGNy ZWF0ZWQgdXNpbmcgY29jY2luZWxsZSBhbmQgdGhlIGZvbGxvd2luZyBzZW1hbnRpYyBwYXRjaDoK PiAKPiBAcDFACj4gaWRlbnRpZmllciBnZXRzdGF0ZWZ1bmM7Cj4gaWRlbnRpZmllciBkcml2ZXI7 Cj4gQEAKPiAgc3RydWN0IHB3bV9vcHMgZHJpdmVyID0gewo+ICAgICAgICAgLi4uLAo+ICAgICAg ICAgLmdldF9zdGF0ZSA9IGdldHN0YXRlZnVuYwo+ICAgICAgICAgLC4uLgo+ICB9Owo+IAo+IEBw MkAKPiBpZGVudGlmaWVyIHAxLmdldHN0YXRlZnVuYzsKPiBpZGVudGlmaWVyIGNoaXAsIHB3bSwg c3RhdGU7Cj4gQEAKPiAtdm9pZAo+ICtpbnQKPiAgZ2V0c3RhdGVmdW5jKHN0cnVjdCBwd21fY2hp cCAqY2hpcCwgc3RydWN0IHB3bV9kZXZpY2UgKnB3bSwgc3RydWN0IHB3bV9zdGF0ZSAqc3RhdGUp Cj4gIHsKPiAgICAuLi4KPiAtICByZXR1cm47Cj4gKyAgcmV0dXJuIDA7Cj4gICAgLi4uCj4gIH0K PiAKPiBwbHVzIHRoZSBhY3R1YWwgY2hhbmdlIG9mIHRoZSBwcm90b3R5cGUgaW4gaW5jbHVkZS9s aW51eC9wd20uaCAocGx1cyBzb21lCj4gbWFudWFsIGZpeGluZyBvZiBpbmRlbnRpb25zIGFuZCBl bXB0eSBsaW5lcykuCj4gCj4gU28gZm9yIG5vdyBhbGwgZHJpdmVycyByZXR1cm4gc3VjY2VzcyB1 bmNvbmRpdGlvbmFsbHkuIFRoZXkgYXJlIGFkYXB0ZWQKPiBpbiB0aGUgZm9sbG93aW5nIHBhdGNo ZXMgdG8gbWFrZSB0aGUgY2hhbmdlcyBlYXNpZXIgcmV2aWV3YWJsZS4KPiAKPiBTaWduZWQtb2Zm LWJ5OiBVd2UgS2xlaW5lLUvDtm5pZyA8dS5rbGVpbmUta29lbmlnQHBlbmd1dHJvbml4LmRlPgo+ IC0tLQo+ICBkcml2ZXJzL2dwaW8vZ3Bpby1tdmVidS5jICAgICAgICAgICAgIHwgIDkgKysrKysr LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9icmlkZ2UvdGktc242NWRzaTg2LmMgfCAxNCArKysrKysr Ky0tLS0tLQo+ICBkcml2ZXJzL2xlZHMvcmdiL2xlZHMtcWNvbS1scGcuYyAgICAgIHwgMTQgKysr KysrKystLS0tLS0KPiAgZHJpdmVycy9wd20vcHdtLWF0bWVsLmMgICAgICAgICAgICAgICB8ICA2 ICsrKystLQo+ICBkcml2ZXJzL3B3bS9wd20tYmNtLWlwcm9jLmMgICAgICAgICAgIHwgIDggKysr KystLS0KPiAgZHJpdmVycy9wd20vcHdtLWNyYy5jICAgICAgICAgICAgICAgICB8IDEwICsrKysr Ky0tLS0KPiAgZHJpdmVycy9wd20vcHdtLWNyb3MtZWMuYyAgICAgICAgICAgICB8ICA4ICsrKysr LS0tCj4gIGRyaXZlcnMvcHdtL3B3bS1kd2MuYyAgICAgICAgICAgICAgICAgfCAgNiArKysrLS0K PiAgZHJpdmVycy9wd20vcHdtLWhpYnZ0LmMgICAgICAgICAgICAgICB8ICA2ICsrKystLQo+ICBk cml2ZXJzL3B3bS9wd20taW14LXRwbS5jICAgICAgICAgICAgIHwgIDggKysrKystLS0KPiAgZHJp dmVycy9wd20vcHdtLWlteDI3LmMgICAgICAgICAgICAgICB8ICA4ICsrKysrLS0tCj4gIGRyaXZl cnMvcHdtL3B3bS1pbnRlbC1sZ20uYyAgICAgICAgICAgfCAgNiArKysrLS0KPiAgZHJpdmVycy9w d20vcHdtLWlxczYyMGEuYyAgICAgICAgICAgICB8ICA2ICsrKystLQo+ICBkcml2ZXJzL3B3bS9w d20ta2VlbWJheS5jICAgICAgICAgICAgIHwgIDYgKysrKy0tCj4gIGRyaXZlcnMvcHdtL3B3bS1s cHNzLmMgICAgICAgICAgICAgICAgfCAgNiArKysrLS0KPiAgZHJpdmVycy9wd20vcHdtLW1lc29u LmMgICAgICAgICAgICAgICB8ICA4ICsrKysrLS0tCj4gIGRyaXZlcnMvcHdtL3B3bS1tdGstZGlz cC5jICAgICAgICAgICAgfCAxMiArKysrKysrLS0tLS0KPiAgZHJpdmVycy9wd20vcHdtLXBjYTk2 ODUuYyAgICAgICAgICAgICB8ICA4ICsrKysrLS0tCj4gIGRyaXZlcnMvcHdtL3B3bS1yYXNwYmVy cnlwaS1wb2UuYyAgICAgfCAgOCArKysrKy0tLQo+ICBkcml2ZXJzL3B3bS9wd20tcm9ja2NoaXAu YyAgICAgICAgICAgIHwgMTIgKysrKysrKy0tLS0tCj4gIGRyaXZlcnMvcHdtL3B3bS1zaWZpdmUu YyAgICAgICAgICAgICAgfCAgNiArKysrLS0KPiAgZHJpdmVycy9wd20vcHdtLXNsMjhjcGxkLmMg ICAgICAgICAgICB8ICA4ICsrKysrLS0tCj4gIGRyaXZlcnMvcHdtL3B3bS1zcHJkLmMgICAgICAg ICAgICAgICAgfCAgOCArKysrKy0tLQo+ICBkcml2ZXJzL3B3bS9wd20tc3RtMzItbHAuYyAgICAg ICAgICAgIHwgIDggKysrKystLS0KPiAgZHJpdmVycy9wd20vcHdtLXN1bjRpLmMgICAgICAgICAg ICAgICB8IDEyICsrKysrKystLS0tLQo+ICBkcml2ZXJzL3B3bS9wd20tc3VucGx1cy5jICAgICAg ICAgICAgIHwgIDYgKysrKy0tCj4gIGRyaXZlcnMvcHdtL3B3bS12aXNjb250aS5jICAgICAgICAg ICAgfCAgNiArKysrLS0KPiAgZHJpdmVycy9wd20vcHdtLXhpbGlueC5jICAgICAgICAgICAgICB8 ICA4ICsrKysrLS0tCj4gIGluY2x1ZGUvbGludXgvcHdtLmggICAgICAgICAgICAgICAgICAgfCAg NCArKy0tCj4gIDI5IGZpbGVzIGNoYW5nZWQsIDE0NiBpbnNlcnRpb25zKCspLCA4OSBkZWxldGlv bnMoLSkKPiAKClsgLi4uIF0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9wd20vcHdtLXN1bjRpLmMg Yi9kcml2ZXJzL3B3bS9wd20tc3VuNGkuYwo+IGluZGV4IGM4NDQ1YjBhMzMzOS4uMzdkNzVlMjUy ZDRlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvcHdtL3B3bS1zdW40aS5jCj4gKysrIGIvZHJpdmVy cy9wd20vcHdtLXN1bjRpLmMKPiBAQCAtMTA4LDkgKzEwOCw5IEBAIHN0YXRpYyBpbmxpbmUgdm9p ZCBzdW40aV9wd21fd3JpdGVsKHN0cnVjdCBzdW40aV9wd21fY2hpcCAqY2hpcCwKPiAgCXdyaXRl bCh2YWwsIGNoaXAtPmJhc2UgKyBvZmZzZXQpOwo+ICB9Cj4gIAo+IC1zdGF0aWMgdm9pZCBzdW40 aV9wd21fZ2V0X3N0YXRlKHN0cnVjdCBwd21fY2hpcCAqY2hpcCwKPiAtCQkJCXN0cnVjdCBwd21f ZGV2aWNlICpwd20sCj4gLQkJCQlzdHJ1Y3QgcHdtX3N0YXRlICpzdGF0ZSkKPiArc3RhdGljIGlu dCBzdW40aV9wd21fZ2V0X3N0YXRlKHN0cnVjdCBwd21fY2hpcCAqY2hpcCwKPiArCQkJICAgICAg IHN0cnVjdCBwd21fZGV2aWNlICpwd20sCj4gKwkJCSAgICAgICBzdHJ1Y3QgcHdtX3N0YXRlICpz dGF0ZSkKPiAgewo+ICAJc3RydWN0IHN1bjRpX3B3bV9jaGlwICpzdW40aV9wd20gPSB0b19zdW40 aV9wd21fY2hpcChjaGlwKTsKPiAgCXU2NCBjbGtfcmF0ZSwgdG1wOwo+IEBAIC0xMzIsNyArMTMy LDcgQEAgc3RhdGljIHZvaWQgc3VuNGlfcHdtX2dldF9zdGF0ZShzdHJ1Y3QgcHdtX2NoaXAgKmNo aXAsCj4gIAkJc3RhdGUtPmR1dHlfY3ljbGUgPSBESVZfUk9VTkRfVVBfVUxMKHN0YXRlLT5wZXJp b2QsIDIpOwo+ICAJCXN0YXRlLT5wb2xhcml0eSA9IFBXTV9QT0xBUklUWV9OT1JNQUw7Cj4gIAkJ c3RhdGUtPmVuYWJsZWQgPSB0cnVlOwo+IC0JCXJldHVybjsKPiArCQlyZXR1cm4gMDsKPiAgCX0K PiAgCj4gIAlpZiAoKFBXTV9SRUdfUFJFU0NBTCh2YWwsIHB3bS0+aHdwd20pID09IFBXTV9QUkVT Q0FMX01BU0spICYmCj4gQEAgLTE0Miw3ICsxNDIsNyBAQCBzdGF0aWMgdm9pZCBzdW40aV9wd21f Z2V0X3N0YXRlKHN0cnVjdCBwd21fY2hpcCAqY2hpcCwKPiAgCQlwcmVzY2FsZXIgPSBwcmVzY2Fs ZXJfdGFibGVbUFdNX1JFR19QUkVTQ0FMKHZhbCwgcHdtLT5od3B3bSldOwo+ICAKPiAgCWlmIChw cmVzY2FsZXIgPT0gMCkKPiAtCQlyZXR1cm47Cj4gKwkJcmV0dXJuIDA7Cj4gIAo+ICAJaWYgKHZh bCAmIEJJVF9DSChQV01fQUNUX1NUQVRFLCBwd20tPmh3cHdtKSkKPiAgCQlzdGF0ZS0+cG9sYXJp dHkgPSBQV01fUE9MQVJJVFlfTk9STUFMOwo+IEBAIC0xNjIsNiArMTYyLDggQEAgc3RhdGljIHZv aWQgc3VuNGlfcHdtX2dldF9zdGF0ZShzdHJ1Y3QgcHdtX2NoaXAgKmNoaXAsCj4gIAo+ICAJdG1w ID0gKHU2NClwcmVzY2FsZXIgKiBOU0VDX1BFUl9TRUMgKiBQV01fUkVHX1BSRCh2YWwpOwo+ICAJ c3RhdGUtPnBlcmlvZCA9IERJVl9ST1VORF9DTE9TRVNUX1VMTCh0bXAsIGNsa19yYXRlKTsKPiAr Cj4gKwlyZXR1cm4gMDsKPiAgfQo+ICAKPiAgc3RhdGljIGludCBzdW40aV9wd21fY2FsY3VsYXRl KHN0cnVjdCBzdW40aV9wd21fY2hpcCAqc3VuNGlfcHdtLAoKRm9yIHN1bnhpOgoKUmV2aWV3ZWQt Ynk6IEFuZHJlIFByenl3YXJhIDxhbmRyZS5wcnp5d2FyYUBhcm0uY29tPgoKSnVzdCBvbmUgY29t bWVudDogSSBkb24ndCBzZWUgYSBzdW54aSBzcGVjaWZpYyBwYXRjaCBsYXRlciBpbiB0aGUgc2Vy aWVzLAp0aG91Z2ggaXQgc2VlbXMgd2UgaGF2ZSBhdCBsZWFzdCBvbmUgZXJyb3IgZXJyb3IgZXhp dCAoc2VlIHByZXNjYWxlciA9PSAwCmFib3ZlKS4gUGx1cyBwb3RlbnRpYWxseSBhbm90aGVyIGV4 aXQgaWYgY2xrX2dldF9yYXRlKCkgKGF0IHRoZSB2ZXJ5CmJlZ2lubmluZykgZmFpbHMuClNoYWxs IEkgc2VuZCBhIHBhdGNoIGZvciB0aGF0PwoKQ2hlZXJzLApBbmRyZS4KCgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYW1sb2dpYyBtYWlsaW5n IGxpc3QKbGludXgtYW1sb2dpY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYW1sb2dpYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC65BC43217 for ; Thu, 1 Dec 2022 10:23:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GA7oN2s3WHcSj59qVebmyJjKA4+CA7mM93qlQQhxEYE=; b=aw9C6vnc6i7BSa ubWz0XqcR/d6hooTHc5lSJcnq7Y4STn1eUgO4BzZWE5oVA9Ni9MURc5diTj1XMCAL0Mni+tpTgCSe +qBOyGJIr7Nmgd43ER8vaxbJc4BQ41YWRzg2pIxFqadKgyRw/Nf+SZNcaW8eym0fOtZP86SY0pl2O TYKJTNTeJwAzJRK7ziCLpOb5+kkONJ67dmy6V7ps3mDqiBAFy9/0e84W2uyss2+r5rdktRQFyhto/ JwldGH3TxuodEuGf0ju2YUdVdlL2IYqyX1yjawYqJz6+TCrIqVMt1WPk82oCDDjDSbtKfwaxWOQRL OCEBClGhKU33kVpWcSgA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0gio-006gCe-W6; Thu, 01 Dec 2022 10:23:15 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0gih-006g6F-2d; Thu, 01 Dec 2022 10:23:09 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 175C1D6E; Thu, 1 Dec 2022 02:23:09 -0800 (PST) Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D4DF93F67D; Thu, 1 Dec 2022 02:22:55 -0800 (PST) Date: Thu, 1 Dec 2022 10:22:52 +0000 From: Andre Przywara To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: Thierry Reding , Conor Dooley , Linus Walleij , Bartosz Golaszewski , Douglas Anderson , Pavel Machek , Claudiu Beznea , Nicolas Ferre , Alexandre Belloni , Ray Jui , Scott Branden , Broadcom internal kernel review list , Benson Leung , Guenter Roeck , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , Florian Fainelli , Heiko Stuebner , Palmer Dabbelt , Paul Walmsley , Michael Walle , Orson Zhai , Baolin Wang , Chunyan Zhang , Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Samuel Holland , Hammer Hsieh , Nobuhiro Iwamatsu , Sean Anderson , Michal Simek , Bjorn Andersson , Stephen Boyd , Matthias Kaehlcke , Satya Priya , linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v2 01/11] pwm: Make .get_state() callback return an error code Message-ID: <20221201102252.52ace284@donnerap.cambridge.arm.com> In-Reply-To: <20221130152148.2769768-2-u.kleine-koenig@pengutronix.de> References: <20221130152148.2769768-1-u.kleine-koenig@pengutronix.de> <20221130152148.2769768-2-u.kleine-koenig@pengutronix.de> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221201_022307_257666_4BD03F7D X-CRM114-Status: GOOD ( 25.50 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gV2VkLCAzMCBOb3YgMjAyMiAxNjoyMTozOCArMDEwMApVd2UgS2xlaW5lLUvDtm5pZyA8dS5r bGVpbmUta29lbmlnQHBlbmd1dHJvbml4LmRlPiB3cm90ZToKCkhpLAoKPiAuZ2V0X3N0YXRlKCkg bWlnaHQgZmFpbCBpbiBzb21lIGNhc2VzLiBUbyBtYWtlIGl0IHBvc3NpYmxlIHRoYXQgYSBkcml2 ZXIKPiBzaWduYWxzIHN1Y2ggYSBmYWlsdXJlIGNoYW5nZSB0aGUgcHJvdG90eXBlIG9mIC5nZXRf c3RhdGUoKSB0byByZXR1cm4gYW4KPiBlcnJvciBjb2RlLgo+IAo+IFRoaXMgcGF0Y2ggd2FzIGNy ZWF0ZWQgdXNpbmcgY29jY2luZWxsZSBhbmQgdGhlIGZvbGxvd2luZyBzZW1hbnRpYyBwYXRjaDoK PiAKPiBAcDFACj4gaWRlbnRpZmllciBnZXRzdGF0ZWZ1bmM7Cj4gaWRlbnRpZmllciBkcml2ZXI7 Cj4gQEAKPiAgc3RydWN0IHB3bV9vcHMgZHJpdmVyID0gewo+ICAgICAgICAgLi4uLAo+ICAgICAg ICAgLmdldF9zdGF0ZSA9IGdldHN0YXRlZnVuYwo+ICAgICAgICAgLC4uLgo+ICB9Owo+IAo+IEBw MkAKPiBpZGVudGlmaWVyIHAxLmdldHN0YXRlZnVuYzsKPiBpZGVudGlmaWVyIGNoaXAsIHB3bSwg c3RhdGU7Cj4gQEAKPiAtdm9pZAo+ICtpbnQKPiAgZ2V0c3RhdGVmdW5jKHN0cnVjdCBwd21fY2hp cCAqY2hpcCwgc3RydWN0IHB3bV9kZXZpY2UgKnB3bSwgc3RydWN0IHB3bV9zdGF0ZSAqc3RhdGUp Cj4gIHsKPiAgICAuLi4KPiAtICByZXR1cm47Cj4gKyAgcmV0dXJuIDA7Cj4gICAgLi4uCj4gIH0K PiAKPiBwbHVzIHRoZSBhY3R1YWwgY2hhbmdlIG9mIHRoZSBwcm90b3R5cGUgaW4gaW5jbHVkZS9s aW51eC9wd20uaCAocGx1cyBzb21lCj4gbWFudWFsIGZpeGluZyBvZiBpbmRlbnRpb25zIGFuZCBl bXB0eSBsaW5lcykuCj4gCj4gU28gZm9yIG5vdyBhbGwgZHJpdmVycyByZXR1cm4gc3VjY2VzcyB1 bmNvbmRpdGlvbmFsbHkuIFRoZXkgYXJlIGFkYXB0ZWQKPiBpbiB0aGUgZm9sbG93aW5nIHBhdGNo ZXMgdG8gbWFrZSB0aGUgY2hhbmdlcyBlYXNpZXIgcmV2aWV3YWJsZS4KPiAKPiBTaWduZWQtb2Zm LWJ5OiBVd2UgS2xlaW5lLUvDtm5pZyA8dS5rbGVpbmUta29lbmlnQHBlbmd1dHJvbml4LmRlPgo+ IC0tLQo+ICBkcml2ZXJzL2dwaW8vZ3Bpby1tdmVidS5jICAgICAgICAgICAgIHwgIDkgKysrKysr LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9icmlkZ2UvdGktc242NWRzaTg2LmMgfCAxNCArKysrKysr Ky0tLS0tLQo+ICBkcml2ZXJzL2xlZHMvcmdiL2xlZHMtcWNvbS1scGcuYyAgICAgIHwgMTQgKysr KysrKystLS0tLS0KPiAgZHJpdmVycy9wd20vcHdtLWF0bWVsLmMgICAgICAgICAgICAgICB8ICA2 ICsrKystLQo+ICBkcml2ZXJzL3B3bS9wd20tYmNtLWlwcm9jLmMgICAgICAgICAgIHwgIDggKysr KystLS0KPiAgZHJpdmVycy9wd20vcHdtLWNyYy5jICAgICAgICAgICAgICAgICB8IDEwICsrKysr Ky0tLS0KPiAgZHJpdmVycy9wd20vcHdtLWNyb3MtZWMuYyAgICAgICAgICAgICB8ICA4ICsrKysr LS0tCj4gIGRyaXZlcnMvcHdtL3B3bS1kd2MuYyAgICAgICAgICAgICAgICAgfCAgNiArKysrLS0K PiAgZHJpdmVycy9wd20vcHdtLWhpYnZ0LmMgICAgICAgICAgICAgICB8ICA2ICsrKystLQo+ICBk cml2ZXJzL3B3bS9wd20taW14LXRwbS5jICAgICAgICAgICAgIHwgIDggKysrKystLS0KPiAgZHJp dmVycy9wd20vcHdtLWlteDI3LmMgICAgICAgICAgICAgICB8ICA4ICsrKysrLS0tCj4gIGRyaXZl cnMvcHdtL3B3bS1pbnRlbC1sZ20uYyAgICAgICAgICAgfCAgNiArKysrLS0KPiAgZHJpdmVycy9w d20vcHdtLWlxczYyMGEuYyAgICAgICAgICAgICB8ICA2ICsrKystLQo+ICBkcml2ZXJzL3B3bS9w d20ta2VlbWJheS5jICAgICAgICAgICAgIHwgIDYgKysrKy0tCj4gIGRyaXZlcnMvcHdtL3B3bS1s cHNzLmMgICAgICAgICAgICAgICAgfCAgNiArKysrLS0KPiAgZHJpdmVycy9wd20vcHdtLW1lc29u LmMgICAgICAgICAgICAgICB8ICA4ICsrKysrLS0tCj4gIGRyaXZlcnMvcHdtL3B3bS1tdGstZGlz cC5jICAgICAgICAgICAgfCAxMiArKysrKysrLS0tLS0KPiAgZHJpdmVycy9wd20vcHdtLXBjYTk2 ODUuYyAgICAgICAgICAgICB8ICA4ICsrKysrLS0tCj4gIGRyaXZlcnMvcHdtL3B3bS1yYXNwYmVy cnlwaS1wb2UuYyAgICAgfCAgOCArKysrKy0tLQo+ICBkcml2ZXJzL3B3bS9wd20tcm9ja2NoaXAu YyAgICAgICAgICAgIHwgMTIgKysrKysrKy0tLS0tCj4gIGRyaXZlcnMvcHdtL3B3bS1zaWZpdmUu YyAgICAgICAgICAgICAgfCAgNiArKysrLS0KPiAgZHJpdmVycy9wd20vcHdtLXNsMjhjcGxkLmMg ICAgICAgICAgICB8ICA4ICsrKysrLS0tCj4gIGRyaXZlcnMvcHdtL3B3bS1zcHJkLmMgICAgICAg ICAgICAgICAgfCAgOCArKysrKy0tLQo+ICBkcml2ZXJzL3B3bS9wd20tc3RtMzItbHAuYyAgICAg ICAgICAgIHwgIDggKysrKystLS0KPiAgZHJpdmVycy9wd20vcHdtLXN1bjRpLmMgICAgICAgICAg ICAgICB8IDEyICsrKysrKystLS0tLQo+ICBkcml2ZXJzL3B3bS9wd20tc3VucGx1cy5jICAgICAg ICAgICAgIHwgIDYgKysrKy0tCj4gIGRyaXZlcnMvcHdtL3B3bS12aXNjb250aS5jICAgICAgICAg ICAgfCAgNiArKysrLS0KPiAgZHJpdmVycy9wd20vcHdtLXhpbGlueC5jICAgICAgICAgICAgICB8 ICA4ICsrKysrLS0tCj4gIGluY2x1ZGUvbGludXgvcHdtLmggICAgICAgICAgICAgICAgICAgfCAg NCArKy0tCj4gIDI5IGZpbGVzIGNoYW5nZWQsIDE0NiBpbnNlcnRpb25zKCspLCA4OSBkZWxldGlv bnMoLSkKPiAKClsgLi4uIF0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9wd20vcHdtLXN1bjRpLmMg Yi9kcml2ZXJzL3B3bS9wd20tc3VuNGkuYwo+IGluZGV4IGM4NDQ1YjBhMzMzOS4uMzdkNzVlMjUy ZDRlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvcHdtL3B3bS1zdW40aS5jCj4gKysrIGIvZHJpdmVy cy9wd20vcHdtLXN1bjRpLmMKPiBAQCAtMTA4LDkgKzEwOCw5IEBAIHN0YXRpYyBpbmxpbmUgdm9p ZCBzdW40aV9wd21fd3JpdGVsKHN0cnVjdCBzdW40aV9wd21fY2hpcCAqY2hpcCwKPiAgCXdyaXRl bCh2YWwsIGNoaXAtPmJhc2UgKyBvZmZzZXQpOwo+ICB9Cj4gIAo+IC1zdGF0aWMgdm9pZCBzdW40 aV9wd21fZ2V0X3N0YXRlKHN0cnVjdCBwd21fY2hpcCAqY2hpcCwKPiAtCQkJCXN0cnVjdCBwd21f ZGV2aWNlICpwd20sCj4gLQkJCQlzdHJ1Y3QgcHdtX3N0YXRlICpzdGF0ZSkKPiArc3RhdGljIGlu dCBzdW40aV9wd21fZ2V0X3N0YXRlKHN0cnVjdCBwd21fY2hpcCAqY2hpcCwKPiArCQkJICAgICAg IHN0cnVjdCBwd21fZGV2aWNlICpwd20sCj4gKwkJCSAgICAgICBzdHJ1Y3QgcHdtX3N0YXRlICpz dGF0ZSkKPiAgewo+ICAJc3RydWN0IHN1bjRpX3B3bV9jaGlwICpzdW40aV9wd20gPSB0b19zdW40 aV9wd21fY2hpcChjaGlwKTsKPiAgCXU2NCBjbGtfcmF0ZSwgdG1wOwo+IEBAIC0xMzIsNyArMTMy LDcgQEAgc3RhdGljIHZvaWQgc3VuNGlfcHdtX2dldF9zdGF0ZShzdHJ1Y3QgcHdtX2NoaXAgKmNo aXAsCj4gIAkJc3RhdGUtPmR1dHlfY3ljbGUgPSBESVZfUk9VTkRfVVBfVUxMKHN0YXRlLT5wZXJp b2QsIDIpOwo+ICAJCXN0YXRlLT5wb2xhcml0eSA9IFBXTV9QT0xBUklUWV9OT1JNQUw7Cj4gIAkJ c3RhdGUtPmVuYWJsZWQgPSB0cnVlOwo+IC0JCXJldHVybjsKPiArCQlyZXR1cm4gMDsKPiAgCX0K PiAgCj4gIAlpZiAoKFBXTV9SRUdfUFJFU0NBTCh2YWwsIHB3bS0+aHdwd20pID09IFBXTV9QUkVT Q0FMX01BU0spICYmCj4gQEAgLTE0Miw3ICsxNDIsNyBAQCBzdGF0aWMgdm9pZCBzdW40aV9wd21f Z2V0X3N0YXRlKHN0cnVjdCBwd21fY2hpcCAqY2hpcCwKPiAgCQlwcmVzY2FsZXIgPSBwcmVzY2Fs ZXJfdGFibGVbUFdNX1JFR19QUkVTQ0FMKHZhbCwgcHdtLT5od3B3bSldOwo+ICAKPiAgCWlmIChw cmVzY2FsZXIgPT0gMCkKPiAtCQlyZXR1cm47Cj4gKwkJcmV0dXJuIDA7Cj4gIAo+ICAJaWYgKHZh bCAmIEJJVF9DSChQV01fQUNUX1NUQVRFLCBwd20tPmh3cHdtKSkKPiAgCQlzdGF0ZS0+cG9sYXJp dHkgPSBQV01fUE9MQVJJVFlfTk9STUFMOwo+IEBAIC0xNjIsNiArMTYyLDggQEAgc3RhdGljIHZv aWQgc3VuNGlfcHdtX2dldF9zdGF0ZShzdHJ1Y3QgcHdtX2NoaXAgKmNoaXAsCj4gIAo+ICAJdG1w ID0gKHU2NClwcmVzY2FsZXIgKiBOU0VDX1BFUl9TRUMgKiBQV01fUkVHX1BSRCh2YWwpOwo+ICAJ c3RhdGUtPnBlcmlvZCA9IERJVl9ST1VORF9DTE9TRVNUX1VMTCh0bXAsIGNsa19yYXRlKTsKPiAr Cj4gKwlyZXR1cm4gMDsKPiAgfQo+ICAKPiAgc3RhdGljIGludCBzdW40aV9wd21fY2FsY3VsYXRl KHN0cnVjdCBzdW40aV9wd21fY2hpcCAqc3VuNGlfcHdtLAoKRm9yIHN1bnhpOgoKUmV2aWV3ZWQt Ynk6IEFuZHJlIFByenl3YXJhIDxhbmRyZS5wcnp5d2FyYUBhcm0uY29tPgoKSnVzdCBvbmUgY29t bWVudDogSSBkb24ndCBzZWUgYSBzdW54aSBzcGVjaWZpYyBwYXRjaCBsYXRlciBpbiB0aGUgc2Vy aWVzLAp0aG91Z2ggaXQgc2VlbXMgd2UgaGF2ZSBhdCBsZWFzdCBvbmUgZXJyb3IgZXJyb3IgZXhp dCAoc2VlIHByZXNjYWxlciA9PSAwCmFib3ZlKS4gUGx1cyBwb3RlbnRpYWxseSBhbm90aGVyIGV4 aXQgaWYgY2xrX2dldF9yYXRlKCkgKGF0IHRoZSB2ZXJ5CmJlZ2lubmluZykgZmFpbHMuClNoYWxs IEkgc2VuZCBhIHBhdGNoIGZvciB0aGF0PwoKQ2hlZXJzLApBbmRyZS4KCgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtcm9ja2NoaXAgbWFpbGlu ZyBsaXN0CkxpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1B3D5C43217 for ; Thu, 1 Dec 2022 10:23:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RTUd7dQB7wamsobIcV3LNCOmCzXfsuk6/qJb/YoHIIg=; b=sAjmHZ4toAdcHP IoM2rBzXUf3c4UXk5of1TCPbmDoXi3HKu4Svoyp8AauN/ZO8pPJZeeDRnnslpOK10udsJXVv/O2WN k9rbDQOpMEtmwZCqKAyU7I8WK7Q2dsffg3TjvZ8bxlZqPArmRn976+bXFff2Na8Z6ubpphfUdXJzh fHa00AUstIlKU2VsA5zcHa2FWoaUzUQmPsqICxJLtYL6LVPcly1hY+Rwn+qztFghvWmAfVS7VuAqI ugyIdm8q2q5MubqdiHe/A9sBXSZUpPEqlQWmO9rLMrLa1yTKApbE0QnenW7NYFkq8UeNp5mrqxw87 Nf7aZyhE5iO9uFMq1/Jg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0gin-006gBG-HD; Thu, 01 Dec 2022 10:23:13 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0gih-006g6F-2d; Thu, 01 Dec 2022 10:23:09 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 175C1D6E; Thu, 1 Dec 2022 02:23:09 -0800 (PST) Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D4DF93F67D; Thu, 1 Dec 2022 02:22:55 -0800 (PST) Date: Thu, 1 Dec 2022 10:22:52 +0000 From: Andre Przywara To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: Thierry Reding , Conor Dooley , Linus Walleij , Bartosz Golaszewski , Douglas Anderson , Pavel Machek , Claudiu Beznea , Nicolas Ferre , Alexandre Belloni , Ray Jui , Scott Branden , Broadcom internal kernel review list , Benson Leung , Guenter Roeck , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , Florian Fainelli , Heiko Stuebner , Palmer Dabbelt , Paul Walmsley , Michael Walle , Orson Zhai , Baolin Wang , Chunyan Zhang , Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Samuel Holland , Hammer Hsieh , Nobuhiro Iwamatsu , Sean Anderson , Michal Simek , Bjorn Andersson , Stephen Boyd , Matthias Kaehlcke , Satya Priya , linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v2 01/11] pwm: Make .get_state() callback return an error code Message-ID: <20221201102252.52ace284@donnerap.cambridge.arm.com> In-Reply-To: <20221130152148.2769768-2-u.kleine-koenig@pengutronix.de> References: <20221130152148.2769768-1-u.kleine-koenig@pengutronix.de> <20221130152148.2769768-2-u.kleine-koenig@pengutronix.de> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221201_022307_257666_4BD03F7D X-CRM114-Status: GOOD ( 25.50 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gV2VkLCAzMCBOb3YgMjAyMiAxNjoyMTozOCArMDEwMApVd2UgS2xlaW5lLUvDtm5pZyA8dS5r bGVpbmUta29lbmlnQHBlbmd1dHJvbml4LmRlPiB3cm90ZToKCkhpLAoKPiAuZ2V0X3N0YXRlKCkg bWlnaHQgZmFpbCBpbiBzb21lIGNhc2VzLiBUbyBtYWtlIGl0IHBvc3NpYmxlIHRoYXQgYSBkcml2 ZXIKPiBzaWduYWxzIHN1Y2ggYSBmYWlsdXJlIGNoYW5nZSB0aGUgcHJvdG90eXBlIG9mIC5nZXRf c3RhdGUoKSB0byByZXR1cm4gYW4KPiBlcnJvciBjb2RlLgo+IAo+IFRoaXMgcGF0Y2ggd2FzIGNy ZWF0ZWQgdXNpbmcgY29jY2luZWxsZSBhbmQgdGhlIGZvbGxvd2luZyBzZW1hbnRpYyBwYXRjaDoK PiAKPiBAcDFACj4gaWRlbnRpZmllciBnZXRzdGF0ZWZ1bmM7Cj4gaWRlbnRpZmllciBkcml2ZXI7 Cj4gQEAKPiAgc3RydWN0IHB3bV9vcHMgZHJpdmVyID0gewo+ICAgICAgICAgLi4uLAo+ICAgICAg ICAgLmdldF9zdGF0ZSA9IGdldHN0YXRlZnVuYwo+ICAgICAgICAgLC4uLgo+ICB9Owo+IAo+IEBw MkAKPiBpZGVudGlmaWVyIHAxLmdldHN0YXRlZnVuYzsKPiBpZGVudGlmaWVyIGNoaXAsIHB3bSwg c3RhdGU7Cj4gQEAKPiAtdm9pZAo+ICtpbnQKPiAgZ2V0c3RhdGVmdW5jKHN0cnVjdCBwd21fY2hp cCAqY2hpcCwgc3RydWN0IHB3bV9kZXZpY2UgKnB3bSwgc3RydWN0IHB3bV9zdGF0ZSAqc3RhdGUp Cj4gIHsKPiAgICAuLi4KPiAtICByZXR1cm47Cj4gKyAgcmV0dXJuIDA7Cj4gICAgLi4uCj4gIH0K PiAKPiBwbHVzIHRoZSBhY3R1YWwgY2hhbmdlIG9mIHRoZSBwcm90b3R5cGUgaW4gaW5jbHVkZS9s aW51eC9wd20uaCAocGx1cyBzb21lCj4gbWFudWFsIGZpeGluZyBvZiBpbmRlbnRpb25zIGFuZCBl bXB0eSBsaW5lcykuCj4gCj4gU28gZm9yIG5vdyBhbGwgZHJpdmVycyByZXR1cm4gc3VjY2VzcyB1 bmNvbmRpdGlvbmFsbHkuIFRoZXkgYXJlIGFkYXB0ZWQKPiBpbiB0aGUgZm9sbG93aW5nIHBhdGNo ZXMgdG8gbWFrZSB0aGUgY2hhbmdlcyBlYXNpZXIgcmV2aWV3YWJsZS4KPiAKPiBTaWduZWQtb2Zm LWJ5OiBVd2UgS2xlaW5lLUvDtm5pZyA8dS5rbGVpbmUta29lbmlnQHBlbmd1dHJvbml4LmRlPgo+ IC0tLQo+ICBkcml2ZXJzL2dwaW8vZ3Bpby1tdmVidS5jICAgICAgICAgICAgIHwgIDkgKysrKysr LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9icmlkZ2UvdGktc242NWRzaTg2LmMgfCAxNCArKysrKysr Ky0tLS0tLQo+ICBkcml2ZXJzL2xlZHMvcmdiL2xlZHMtcWNvbS1scGcuYyAgICAgIHwgMTQgKysr KysrKystLS0tLS0KPiAgZHJpdmVycy9wd20vcHdtLWF0bWVsLmMgICAgICAgICAgICAgICB8ICA2 ICsrKystLQo+ICBkcml2ZXJzL3B3bS9wd20tYmNtLWlwcm9jLmMgICAgICAgICAgIHwgIDggKysr KystLS0KPiAgZHJpdmVycy9wd20vcHdtLWNyYy5jICAgICAgICAgICAgICAgICB8IDEwICsrKysr Ky0tLS0KPiAgZHJpdmVycy9wd20vcHdtLWNyb3MtZWMuYyAgICAgICAgICAgICB8ICA4ICsrKysr LS0tCj4gIGRyaXZlcnMvcHdtL3B3bS1kd2MuYyAgICAgICAgICAgICAgICAgfCAgNiArKysrLS0K PiAgZHJpdmVycy9wd20vcHdtLWhpYnZ0LmMgICAgICAgICAgICAgICB8ICA2ICsrKystLQo+ICBk cml2ZXJzL3B3bS9wd20taW14LXRwbS5jICAgICAgICAgICAgIHwgIDggKysrKystLS0KPiAgZHJp dmVycy9wd20vcHdtLWlteDI3LmMgICAgICAgICAgICAgICB8ICA4ICsrKysrLS0tCj4gIGRyaXZl cnMvcHdtL3B3bS1pbnRlbC1sZ20uYyAgICAgICAgICAgfCAgNiArKysrLS0KPiAgZHJpdmVycy9w d20vcHdtLWlxczYyMGEuYyAgICAgICAgICAgICB8ICA2ICsrKystLQo+ICBkcml2ZXJzL3B3bS9w d20ta2VlbWJheS5jICAgICAgICAgICAgIHwgIDYgKysrKy0tCj4gIGRyaXZlcnMvcHdtL3B3bS1s cHNzLmMgICAgICAgICAgICAgICAgfCAgNiArKysrLS0KPiAgZHJpdmVycy9wd20vcHdtLW1lc29u LmMgICAgICAgICAgICAgICB8ICA4ICsrKysrLS0tCj4gIGRyaXZlcnMvcHdtL3B3bS1tdGstZGlz cC5jICAgICAgICAgICAgfCAxMiArKysrKysrLS0tLS0KPiAgZHJpdmVycy9wd20vcHdtLXBjYTk2 ODUuYyAgICAgICAgICAgICB8ICA4ICsrKysrLS0tCj4gIGRyaXZlcnMvcHdtL3B3bS1yYXNwYmVy cnlwaS1wb2UuYyAgICAgfCAgOCArKysrKy0tLQo+ICBkcml2ZXJzL3B3bS9wd20tcm9ja2NoaXAu YyAgICAgICAgICAgIHwgMTIgKysrKysrKy0tLS0tCj4gIGRyaXZlcnMvcHdtL3B3bS1zaWZpdmUu YyAgICAgICAgICAgICAgfCAgNiArKysrLS0KPiAgZHJpdmVycy9wd20vcHdtLXNsMjhjcGxkLmMg ICAgICAgICAgICB8ICA4ICsrKysrLS0tCj4gIGRyaXZlcnMvcHdtL3B3bS1zcHJkLmMgICAgICAg ICAgICAgICAgfCAgOCArKysrKy0tLQo+ICBkcml2ZXJzL3B3bS9wd20tc3RtMzItbHAuYyAgICAg ICAgICAgIHwgIDggKysrKystLS0KPiAgZHJpdmVycy9wd20vcHdtLXN1bjRpLmMgICAgICAgICAg ICAgICB8IDEyICsrKysrKystLS0tLQo+ICBkcml2ZXJzL3B3bS9wd20tc3VucGx1cy5jICAgICAg ICAgICAgIHwgIDYgKysrKy0tCj4gIGRyaXZlcnMvcHdtL3B3bS12aXNjb250aS5jICAgICAgICAg ICAgfCAgNiArKysrLS0KPiAgZHJpdmVycy9wd20vcHdtLXhpbGlueC5jICAgICAgICAgICAgICB8 ICA4ICsrKysrLS0tCj4gIGluY2x1ZGUvbGludXgvcHdtLmggICAgICAgICAgICAgICAgICAgfCAg NCArKy0tCj4gIDI5IGZpbGVzIGNoYW5nZWQsIDE0NiBpbnNlcnRpb25zKCspLCA4OSBkZWxldGlv bnMoLSkKPiAKClsgLi4uIF0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9wd20vcHdtLXN1bjRpLmMg Yi9kcml2ZXJzL3B3bS9wd20tc3VuNGkuYwo+IGluZGV4IGM4NDQ1YjBhMzMzOS4uMzdkNzVlMjUy ZDRlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvcHdtL3B3bS1zdW40aS5jCj4gKysrIGIvZHJpdmVy cy9wd20vcHdtLXN1bjRpLmMKPiBAQCAtMTA4LDkgKzEwOCw5IEBAIHN0YXRpYyBpbmxpbmUgdm9p ZCBzdW40aV9wd21fd3JpdGVsKHN0cnVjdCBzdW40aV9wd21fY2hpcCAqY2hpcCwKPiAgCXdyaXRl bCh2YWwsIGNoaXAtPmJhc2UgKyBvZmZzZXQpOwo+ICB9Cj4gIAo+IC1zdGF0aWMgdm9pZCBzdW40 aV9wd21fZ2V0X3N0YXRlKHN0cnVjdCBwd21fY2hpcCAqY2hpcCwKPiAtCQkJCXN0cnVjdCBwd21f ZGV2aWNlICpwd20sCj4gLQkJCQlzdHJ1Y3QgcHdtX3N0YXRlICpzdGF0ZSkKPiArc3RhdGljIGlu dCBzdW40aV9wd21fZ2V0X3N0YXRlKHN0cnVjdCBwd21fY2hpcCAqY2hpcCwKPiArCQkJICAgICAg IHN0cnVjdCBwd21fZGV2aWNlICpwd20sCj4gKwkJCSAgICAgICBzdHJ1Y3QgcHdtX3N0YXRlICpz dGF0ZSkKPiAgewo+ICAJc3RydWN0IHN1bjRpX3B3bV9jaGlwICpzdW40aV9wd20gPSB0b19zdW40 aV9wd21fY2hpcChjaGlwKTsKPiAgCXU2NCBjbGtfcmF0ZSwgdG1wOwo+IEBAIC0xMzIsNyArMTMy LDcgQEAgc3RhdGljIHZvaWQgc3VuNGlfcHdtX2dldF9zdGF0ZShzdHJ1Y3QgcHdtX2NoaXAgKmNo aXAsCj4gIAkJc3RhdGUtPmR1dHlfY3ljbGUgPSBESVZfUk9VTkRfVVBfVUxMKHN0YXRlLT5wZXJp b2QsIDIpOwo+ICAJCXN0YXRlLT5wb2xhcml0eSA9IFBXTV9QT0xBUklUWV9OT1JNQUw7Cj4gIAkJ c3RhdGUtPmVuYWJsZWQgPSB0cnVlOwo+IC0JCXJldHVybjsKPiArCQlyZXR1cm4gMDsKPiAgCX0K PiAgCj4gIAlpZiAoKFBXTV9SRUdfUFJFU0NBTCh2YWwsIHB3bS0+aHdwd20pID09IFBXTV9QUkVT Q0FMX01BU0spICYmCj4gQEAgLTE0Miw3ICsxNDIsNyBAQCBzdGF0aWMgdm9pZCBzdW40aV9wd21f Z2V0X3N0YXRlKHN0cnVjdCBwd21fY2hpcCAqY2hpcCwKPiAgCQlwcmVzY2FsZXIgPSBwcmVzY2Fs ZXJfdGFibGVbUFdNX1JFR19QUkVTQ0FMKHZhbCwgcHdtLT5od3B3bSldOwo+ICAKPiAgCWlmIChw cmVzY2FsZXIgPT0gMCkKPiAtCQlyZXR1cm47Cj4gKwkJcmV0dXJuIDA7Cj4gIAo+ICAJaWYgKHZh bCAmIEJJVF9DSChQV01fQUNUX1NUQVRFLCBwd20tPmh3cHdtKSkKPiAgCQlzdGF0ZS0+cG9sYXJp dHkgPSBQV01fUE9MQVJJVFlfTk9STUFMOwo+IEBAIC0xNjIsNiArMTYyLDggQEAgc3RhdGljIHZv aWQgc3VuNGlfcHdtX2dldF9zdGF0ZShzdHJ1Y3QgcHdtX2NoaXAgKmNoaXAsCj4gIAo+ICAJdG1w ID0gKHU2NClwcmVzY2FsZXIgKiBOU0VDX1BFUl9TRUMgKiBQV01fUkVHX1BSRCh2YWwpOwo+ICAJ c3RhdGUtPnBlcmlvZCA9IERJVl9ST1VORF9DTE9TRVNUX1VMTCh0bXAsIGNsa19yYXRlKTsKPiAr Cj4gKwlyZXR1cm4gMDsKPiAgfQo+ICAKPiAgc3RhdGljIGludCBzdW40aV9wd21fY2FsY3VsYXRl KHN0cnVjdCBzdW40aV9wd21fY2hpcCAqc3VuNGlfcHdtLAoKRm9yIHN1bnhpOgoKUmV2aWV3ZWQt Ynk6IEFuZHJlIFByenl3YXJhIDxhbmRyZS5wcnp5d2FyYUBhcm0uY29tPgoKSnVzdCBvbmUgY29t bWVudDogSSBkb24ndCBzZWUgYSBzdW54aSBzcGVjaWZpYyBwYXRjaCBsYXRlciBpbiB0aGUgc2Vy aWVzLAp0aG91Z2ggaXQgc2VlbXMgd2UgaGF2ZSBhdCBsZWFzdCBvbmUgZXJyb3IgZXJyb3IgZXhp dCAoc2VlIHByZXNjYWxlciA9PSAwCmFib3ZlKS4gUGx1cyBwb3RlbnRpYWxseSBhbm90aGVyIGV4 aXQgaWYgY2xrX2dldF9yYXRlKCkgKGF0IHRoZSB2ZXJ5CmJlZ2lubmluZykgZmFpbHMuClNoYWxs IEkgc2VuZCBhIHBhdGNoIGZvciB0aGF0PwoKQ2hlZXJzLApBbmRyZS4KCgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFpbGluZyBs aXN0CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A456FC4708E for ; Thu, 1 Dec 2022 10:23:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ECC1910E5AB; Thu, 1 Dec 2022 10:23:06 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 3393E10E5AB for ; Thu, 1 Dec 2022 10:23:03 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 175C1D6E; Thu, 1 Dec 2022 02:23:09 -0800 (PST) Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D4DF93F67D; Thu, 1 Dec 2022 02:22:55 -0800 (PST) Date: Thu, 1 Dec 2022 10:22:52 +0000 From: Andre Przywara To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Subject: Re: [PATCH v2 01/11] pwm: Make .get_state() callback return an error code Message-ID: <20221201102252.52ace284@donnerap.cambridge.arm.com> In-Reply-To: <20221130152148.2769768-2-u.kleine-koenig@pengutronix.de> References: <20221130152148.2769768-1-u.kleine-koenig@pengutronix.de> <20221130152148.2769768-2-u.kleine-koenig@pengutronix.de> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Alexandre Torgue , dri-devel@lists.freedesktop.org, Douglas Anderson , Conor Dooley , Thierry Reding , Satya Priya , Pavel Machek , Guenter Roeck , Nobuhiro Iwamatsu , linux-riscv@lists.infradead.org, linux-leds@vger.kernel.org, Jerome Brunet , chrome-platform@lists.linux.dev, Florian Fainelli , Samuel Holland , Sean Anderson , Kevin Hilman , Bartosz Golaszewski , Michal Simek , linux-stm32@st-md-mailman.stormreply.com, Hammer Hsieh , linux-rockchip@lists.infradead.org, Chen-Yu Tsai , Matthias Kaehlcke , Broadcom internal kernel review list , NXP Linux Team , Orson Zhai , linux-sunxi@lists.linux.dev, linux-pwm@vger.kernel.org, Maxime Coquelin , Martin Blumenstingl , Ray Jui , Sascha Hauer , Stephen Boyd , linux-gpio@vger.kernel.org, Fabrice Gasnier , linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, Baolin Wang , Paul Walmsley , Matthias Brugger , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Scott Branden , Bjorn Andersson , Nicolas Ferre , Michael Walle , Palmer Dabbelt , Pengutronix Kernel Team , Chunyan Zhang , Shawn Guo , Claudiu Beznea Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 30 Nov 2022 16:21:38 +0100 Uwe Kleine-K=C3=B6nig wrote: Hi, > .get_state() might fail in some cases. To make it possible that a driver > signals such a failure change the prototype of .get_state() to return an > error code. >=20 > This patch was created using coccinelle and the following semantic patch: >=20 > @p1@ > identifier getstatefunc; > identifier driver; > @@ > struct pwm_ops driver =3D { > ..., > .get_state =3D getstatefunc > ,... > }; >=20 > @p2@ > identifier p1.getstatefunc; > identifier chip, pwm, state; > @@ > -void > +int > getstatefunc(struct pwm_chip *chip, struct pwm_device *pwm, struct pwm_s= tate *state) > { > ... > - return; > + return 0; > ... > } >=20 > plus the actual change of the prototype in include/linux/pwm.h (plus some > manual fixing of indentions and empty lines). >=20 > So for now all drivers return success unconditionally. They are adapted > in the following patches to make the changes easier reviewable. >=20 > Signed-off-by: Uwe Kleine-K=C3=B6nig > --- > drivers/gpio/gpio-mvebu.c | 9 ++++++--- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 14 ++++++++------ > drivers/leds/rgb/leds-qcom-lpg.c | 14 ++++++++------ > drivers/pwm/pwm-atmel.c | 6 ++++-- > drivers/pwm/pwm-bcm-iproc.c | 8 +++++--- > drivers/pwm/pwm-crc.c | 10 ++++++---- > drivers/pwm/pwm-cros-ec.c | 8 +++++--- > drivers/pwm/pwm-dwc.c | 6 ++++-- > drivers/pwm/pwm-hibvt.c | 6 ++++-- > drivers/pwm/pwm-imx-tpm.c | 8 +++++--- > drivers/pwm/pwm-imx27.c | 8 +++++--- > drivers/pwm/pwm-intel-lgm.c | 6 ++++-- > drivers/pwm/pwm-iqs620a.c | 6 ++++-- > drivers/pwm/pwm-keembay.c | 6 ++++-- > drivers/pwm/pwm-lpss.c | 6 ++++-- > drivers/pwm/pwm-meson.c | 8 +++++--- > drivers/pwm/pwm-mtk-disp.c | 12 +++++++----- > drivers/pwm/pwm-pca9685.c | 8 +++++--- > drivers/pwm/pwm-raspberrypi-poe.c | 8 +++++--- > drivers/pwm/pwm-rockchip.c | 12 +++++++----- > drivers/pwm/pwm-sifive.c | 6 ++++-- > drivers/pwm/pwm-sl28cpld.c | 8 +++++--- > drivers/pwm/pwm-sprd.c | 8 +++++--- > drivers/pwm/pwm-stm32-lp.c | 8 +++++--- > drivers/pwm/pwm-sun4i.c | 12 +++++++----- > drivers/pwm/pwm-sunplus.c | 6 ++++-- > drivers/pwm/pwm-visconti.c | 6 ++++-- > drivers/pwm/pwm-xilinx.c | 8 +++++--- > include/linux/pwm.h | 4 ++-- > 29 files changed, 146 insertions(+), 89 deletions(-) >=20 [ ... ] > diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c > index c8445b0a3339..37d75e252d4e 100644 > --- a/drivers/pwm/pwm-sun4i.c > +++ b/drivers/pwm/pwm-sun4i.c > @@ -108,9 +108,9 @@ static inline void sun4i_pwm_writel(struct sun4i_pwm_= chip *chip, > writel(val, chip->base + offset); > } > =20 > -static void sun4i_pwm_get_state(struct pwm_chip *chip, > - struct pwm_device *pwm, > - struct pwm_state *state) > +static int sun4i_pwm_get_state(struct pwm_chip *chip, > + struct pwm_device *pwm, > + struct pwm_state *state) > { > struct sun4i_pwm_chip *sun4i_pwm =3D to_sun4i_pwm_chip(chip); > u64 clk_rate, tmp; > @@ -132,7 +132,7 @@ static void sun4i_pwm_get_state(struct pwm_chip *chip, > state->duty_cycle =3D DIV_ROUND_UP_ULL(state->period, 2); > state->polarity =3D PWM_POLARITY_NORMAL; > state->enabled =3D true; > - return; > + return 0; > } > =20 > if ((PWM_REG_PRESCAL(val, pwm->hwpwm) =3D=3D PWM_PRESCAL_MASK) && > @@ -142,7 +142,7 @@ static void sun4i_pwm_get_state(struct pwm_chip *chip, > prescaler =3D prescaler_table[PWM_REG_PRESCAL(val, pwm->hwpwm)]; > =20 > if (prescaler =3D=3D 0) > - return; > + return 0; > =20 > if (val & BIT_CH(PWM_ACT_STATE, pwm->hwpwm)) > state->polarity =3D PWM_POLARITY_NORMAL; > @@ -162,6 +162,8 @@ static void sun4i_pwm_get_state(struct pwm_chip *chip, > =20 > tmp =3D (u64)prescaler * NSEC_PER_SEC * PWM_REG_PRD(val); > state->period =3D DIV_ROUND_CLOSEST_ULL(tmp, clk_rate); > + > + return 0; > } > =20 > static int sun4i_pwm_calculate(struct sun4i_pwm_chip *sun4i_pwm, For sunxi: Reviewed-by: Andre Przywara Just one comment: I don't see a sunxi specific patch later in the series, though it seems we have at least one error error exit (see prescaler =3D=3D= 0 above). Plus potentially another exit if clk_get_rate() (at the very beginning) fails. Shall I send a patch for that? Cheers, Andre.