From: Denys Dmytriyenko <denis@denix.org>
To: Khem Raj <raj.khem@gmail.com>
Cc: meta-ti@lists.yoctoproject.org
Subject: Re: [meta-ti] [PATCH] linux-ti: Drop unneeded update_data calls
Date: Thu, 1 Dec 2022 09:36:43 -0500 [thread overview]
Message-ID: <20221201143643.GT22689@denix.org> (raw)
In-Reply-To: <20221201064805.2094474-1-raj.khem@gmail.com>
NAK
cmem is being removed:
https://patchwork.yoctoproject.org/project/ti/patch/20221104224653.1223044-51-denis@denix.org/
ti-unpack is being patched already:
https://patchwork.yoctoproject.org/project/ti/patch/20221125230020.5316-1-reatmon@ti.com/
It's just getting longer to get the patches merged due to other breakages
in master...
--
Denys
On Wed, Nov 30, 2022 at 10:48:05PM -0800, Khem Raj wrote:
> datastore works dynamically we don't need the update_data calls
> anymore, so far they were no-ops, now bitbake has recently dropped this
> API and hence compile fails with core/master
>
> Fixes
> *** 0052: bb.data.update_data(localdata)
> 0053:
> 0054: cmem_dtsi.add(localdata.getVar('CMEM_DTSI'))
> 0055:
> 0056: d.appendVar('SRC_URI', ' file://'.join(cmem_dtsi))
> Exception: AttributeError: module 'bb.data' has no attribute 'update_data'
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> meta-ti-bsp/recipes-kernel/linux/cmem.inc | 2 --
> meta-ti-extras/recipes-ti/includes/ti-unpack.inc | 1 -
> 2 files changed, 3 deletions(-)
>
> diff --git a/meta-ti-bsp/recipes-kernel/linux/cmem.inc b/meta-ti-bsp/recipes-kernel/linux/cmem.inc
> index fd913f6c..f560932c 100644
> --- a/meta-ti-bsp/recipes-kernel/linux/cmem.inc
> +++ b/meta-ti-bsp/recipes-kernel/linux/cmem.inc
> @@ -49,7 +49,6 @@ python do_unpack() {
> # Create copy of data for additional override
> localdata = bb.data.createCopy(d)
> localdata.setVar('OVERRIDES', '%s:%s' % (cmem_machine, old_overrides))
> - bb.data.update_data(localdata)
>
> cmem_dtsi.add(localdata.getVar('CMEM_DTSI'))
>
> @@ -67,7 +66,6 @@ python do_setup_cmem() {
> # Create copy of data for additional override
> localdata = bb.data.createCopy(d)
> localdata.setVar('OVERRIDES', '%s:%s' % (cmem_machine, old_overrides))
> - bb.data.update_data(localdata)
>
> # Get source directory and dtsi filename
> src_dir = localdata.getVar('WORKDIR')
> diff --git a/meta-ti-extras/recipes-ti/includes/ti-unpack.inc b/meta-ti-extras/recipes-ti/includes/ti-unpack.inc
> index 46bfb957..13068843 100644
> --- a/meta-ti-extras/recipes-ti/includes/ti-unpack.inc
> +++ b/meta-ti-extras/recipes-ti/includes/ti-unpack.inc
> @@ -24,7 +24,6 @@ python ti_bin_do_unpack() {
> bb.fatal("TI installer requires 32bit glibc libraries for proper operation\nrun 'yum install glibc.i686' on Fedora or 'apt-get install libc6:i386' on Ubuntu/Debian")
>
> localdata = bb.data.createCopy(d)
> - bb.data.update_data(localdata)
>
> binfile = localdata.getVar('BINFILE')
> binfile = bb.data.expand(binfile, localdata)
> --
> 2.38.1
>
next prev parent reply other threads:[~2022-12-01 14:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 6:48 [PATCH] linux-ti: Drop unneeded update_data calls Khem Raj
2022-12-01 14:36 ` Denys Dmytriyenko [this message]
2022-12-01 17:40 ` [meta-ti] " Khem Raj
2022-12-01 20:48 ` Ryan Eatmon
2022-12-02 18:57 ` Khem Raj
2022-12-02 19:53 ` Ryan Eatmon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221201143643.GT22689@denix.org \
--to=denis@denix.org \
--cc=meta-ti@lists.yoctoproject.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.