From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD6FEC4332F for ; Thu, 1 Dec 2022 23:45:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y3A5YIrBDCMKwwjRSHMgJKaQ9uS/wJFEUJAUf0BQE+Y=; b=L6NBZRRrm2cnga 7GweUwRkpgzirNgEfR4fK/7X1D1NYKr6p46uwCTOFtz/boLgXVV0e5G1cPZjJK1LFnpOw2GKOjCbu anRP7My1ILfM86h6prO16c4afclgwpjdbHLUiXkEKiqC93tkuDlwVMGhOaNpN9o06dl3llmyjBC4m 2Mt7QUtwycxyegNITpwj8I9j4/3UuBV+PnObmmtbgRYjI24No64znSqwa6aLBYZJRjUZCXN2DG/Jo TNYv4FeCIK8+ks/WPM2ATDnFCJlcLBuLV7QFEjRDE5X0nb5vLcCk2tgR2wnuXRemIwgrPLAlpPGGD 6Ug9ae367q3t28FmgcvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0tF8-00Bp6H-2R; Thu, 01 Dec 2022 23:45:26 +0000 Received: from mail-oi1-f182.google.com ([209.85.167.182]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0sjt-00BZjg-U4; Thu, 01 Dec 2022 23:13:11 +0000 Received: by mail-oi1-f182.google.com with SMTP id h132so3696555oif.2; Thu, 01 Dec 2022 15:13:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OKxrfU4YmpY1Kl1yHeMXQyKUWxu44u51bjZxjiYhfek=; b=I5KjxH0PpdkbhUq9avs4t6zg9dbtbuxvW0NA5HJchfITxRIYas0/zSXo9vyvcEx7mu 0PlzGJSxrsFgaFL1NI3081Qw1Wd/4kJOu1v3ai/baPM9PuXrsL9Ftjdm/e5/HUYBVM2y NOXuAVQWJ99jAHt5s4T5Gy2niMSSNPn6DXyZlPmzkJkyAtgd1fPM1kEV1bPxmKJDFtdn sSLTmy+T9NETcoLAKPKll9IZsxdEtbreknMWXpoTNqCxYxxVymhVojihu4DP2tttEvRi sRz2ag72UXiYLEI2l5P9gwwwe0fsVdXXbp3S0lzLSDozWwPpjwEipFthbmZn1uBdEyto CWCQ== X-Gm-Message-State: ANoB5plYsbQ4OeV6dPy88rhmCwFPyaSGYw0JLd9gF0o+oQ/OI03HzyMl gexxNOHQUQzxTFGndkiU9w== X-Google-Smtp-Source: AA0mqf6Hw+Gk/anvjA2tVJyGiBiFgpkYa/VeAI295MqD5oc4uGzJJSmIKRZpn+m9seyj7pP7+kUz+A== X-Received: by 2002:a54:4783:0:b0:354:7e1:d3ac with SMTP id o3-20020a544783000000b0035407e1d3acmr26707554oic.237.1669936382827; Thu, 01 Dec 2022 15:13:02 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id p64-20020acad843000000b0035a9003b8edsm2345943oig.40.2022.12.01.15.13.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 15:13:02 -0800 (PST) Received: (nullmailer pid 1658241 invoked by uid 1000); Thu, 01 Dec 2022 23:13:01 -0000 Date: Thu, 1 Dec 2022 17:13:01 -0600 From: Rob Herring To: Sandor Yu Cc: andrzej.hajda@intel.com, neil.armstrong@linaro.org, robert.foss@linaro.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@gmail.com, daniel@ffwll.ch, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, vkoul@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, kernel@pengutronix.de, linux-imx@nxp.com, oliver.brown@nxp.com Subject: Re: [PATCH v5 07/10] dt-bindings: phy: Add Cadence HDP-TX DP PHY Message-ID: <20221201231301.GA1653935-robh@kernel.org> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221201_151310_013103_1D0D68B7 X-CRM114-Status: GOOD ( 17.65 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Mon, Nov 28, 2022 at 03:36:15PM +0800, Sandor Yu wrote: > Add bindings for Cadence HDP-TX DisplayPort PHY. > > Signed-off-by: Sandor Yu > --- > .../bindings/phy/cdns,hdptx-dp-phy.yaml | 68 +++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/cdns,hdptx-dp-phy.yaml > > diff --git a/Documentation/devicetree/bindings/phy/cdns,hdptx-dp-phy.yaml b/Documentation/devicetree/bindings/phy/cdns,hdptx-dp-phy.yaml > new file mode 100644 > index 000000000000..f4f741150c12 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/cdns,hdptx-dp-phy.yaml > @@ -0,0 +1,68 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/cdns,hdptx-dp-phy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cadence HDP-TX(HDMI/DisplayPort) PHY for DisplayPort protocol > + > +maintainers: > + - Sandor Yu > + > +properties: > + compatible: > + enum: > + - cdns,hdptx-dp-phy Again, name based on SoC and SoC vendor. > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: PHY reference clock. > + - description: APB clock. > + > + clock-names: > + items: > + - const: ref > + - const: apb > + > + "#phy-cells": > + const: 0 > + > + cdns,num-lanes: There is a standard way to define the number of lanes. That goes in output endpoint for the DP node. Not that convenient to the phy, but the information is already there, don't duplicate it. > + description: > + Number of lanes. > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [1, 2, 3, 4] > + default: 4 > + > + cdns,max-bit-rate: Same with this. > + description: > + Maximum DisplayPort link bit rate to use, in Mbps > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [2160, 2430, 2700, 3240, 4320, 5400] > + default: 5400 > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - "#phy-cells" > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + dp_phy: phy@32c00000 { > + compatible = "cdns,hdptx-dp-phy"; > + reg = <0x32c00000 0x100000>; > + #phy-cells = <0>; > + clocks = <&hdmi_phy_27m>, <&clk IMX8MQ_CLK_DISP_APB_ROOT>; > + clock-names = "ref", "apb"; > + cdns,num-lanes = <4>; > + cdns,max-bit-rate = <5400>; > + }; > -- > 2.34.1 > > -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE5ADC4332F for ; Thu, 1 Dec 2022 23:45:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PbYkA13bgduBHk4Xbkx/+s1yj3fD1KQaKnwBIzZdInk=; b=Nfive7CicboHvM 5ThGCqUPs7aaYRLzdSjy5yifUaRESogO/h/PuA49AHmLzvrskM2Tz2RAE9joOzt6kLeK4vDFzNxED Fzi8WgYgcHsQ0pIqsO8zb6Zz95oWVQeQ/jcP9WY5eCghcS2Ui/4xiofnXeV1j6StzWW8LVZZfjtrh iv1AWmUIP9Kgwp6+0fBkXvKJH1esBd4YkKZ+RGSAg81oeYwLGsx5e1TQVCB8FM4m2MyFKJmpstK2N 588GuyBqWNCIeID5Oksteb6Hod+YcVTWYeT7TFOOicU4juRk1msUMoRCEgUz1tT+7acYsmK+a4uzu M11bUVTsxyaYaBZR7UDQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0tEa-00BorV-By; Thu, 01 Dec 2022 23:44:52 +0000 Received: from mail-oi1-f182.google.com ([209.85.167.182]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0sjt-00BZjg-U4; Thu, 01 Dec 2022 23:13:11 +0000 Received: by mail-oi1-f182.google.com with SMTP id h132so3696555oif.2; Thu, 01 Dec 2022 15:13:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OKxrfU4YmpY1Kl1yHeMXQyKUWxu44u51bjZxjiYhfek=; b=I5KjxH0PpdkbhUq9avs4t6zg9dbtbuxvW0NA5HJchfITxRIYas0/zSXo9vyvcEx7mu 0PlzGJSxrsFgaFL1NI3081Qw1Wd/4kJOu1v3ai/baPM9PuXrsL9Ftjdm/e5/HUYBVM2y NOXuAVQWJ99jAHt5s4T5Gy2niMSSNPn6DXyZlPmzkJkyAtgd1fPM1kEV1bPxmKJDFtdn sSLTmy+T9NETcoLAKPKll9IZsxdEtbreknMWXpoTNqCxYxxVymhVojihu4DP2tttEvRi sRz2ag72UXiYLEI2l5P9gwwwe0fsVdXXbp3S0lzLSDozWwPpjwEipFthbmZn1uBdEyto CWCQ== X-Gm-Message-State: ANoB5plYsbQ4OeV6dPy88rhmCwFPyaSGYw0JLd9gF0o+oQ/OI03HzyMl gexxNOHQUQzxTFGndkiU9w== X-Google-Smtp-Source: AA0mqf6Hw+Gk/anvjA2tVJyGiBiFgpkYa/VeAI295MqD5oc4uGzJJSmIKRZpn+m9seyj7pP7+kUz+A== X-Received: by 2002:a54:4783:0:b0:354:7e1:d3ac with SMTP id o3-20020a544783000000b0035407e1d3acmr26707554oic.237.1669936382827; Thu, 01 Dec 2022 15:13:02 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id p64-20020acad843000000b0035a9003b8edsm2345943oig.40.2022.12.01.15.13.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 15:13:02 -0800 (PST) Received: (nullmailer pid 1658241 invoked by uid 1000); Thu, 01 Dec 2022 23:13:01 -0000 Date: Thu, 1 Dec 2022 17:13:01 -0600 From: Rob Herring To: Sandor Yu Cc: andrzej.hajda@intel.com, neil.armstrong@linaro.org, robert.foss@linaro.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@gmail.com, daniel@ffwll.ch, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, vkoul@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, kernel@pengutronix.de, linux-imx@nxp.com, oliver.brown@nxp.com Subject: Re: [PATCH v5 07/10] dt-bindings: phy: Add Cadence HDP-TX DP PHY Message-ID: <20221201231301.GA1653935-robh@kernel.org> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221201_151310_013103_1D0D68B7 X-CRM114-Status: GOOD ( 17.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 28, 2022 at 03:36:15PM +0800, Sandor Yu wrote: > Add bindings for Cadence HDP-TX DisplayPort PHY. > > Signed-off-by: Sandor Yu > --- > .../bindings/phy/cdns,hdptx-dp-phy.yaml | 68 +++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/cdns,hdptx-dp-phy.yaml > > diff --git a/Documentation/devicetree/bindings/phy/cdns,hdptx-dp-phy.yaml b/Documentation/devicetree/bindings/phy/cdns,hdptx-dp-phy.yaml > new file mode 100644 > index 000000000000..f4f741150c12 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/cdns,hdptx-dp-phy.yaml > @@ -0,0 +1,68 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/cdns,hdptx-dp-phy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cadence HDP-TX(HDMI/DisplayPort) PHY for DisplayPort protocol > + > +maintainers: > + - Sandor Yu > + > +properties: > + compatible: > + enum: > + - cdns,hdptx-dp-phy Again, name based on SoC and SoC vendor. > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: PHY reference clock. > + - description: APB clock. > + > + clock-names: > + items: > + - const: ref > + - const: apb > + > + "#phy-cells": > + const: 0 > + > + cdns,num-lanes: There is a standard way to define the number of lanes. That goes in output endpoint for the DP node. Not that convenient to the phy, but the information is already there, don't duplicate it. > + description: > + Number of lanes. > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [1, 2, 3, 4] > + default: 4 > + > + cdns,max-bit-rate: Same with this. > + description: > + Maximum DisplayPort link bit rate to use, in Mbps > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [2160, 2430, 2700, 3240, 4320, 5400] > + default: 5400 > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - "#phy-cells" > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + dp_phy: phy@32c00000 { > + compatible = "cdns,hdptx-dp-phy"; > + reg = <0x32c00000 0x100000>; > + #phy-cells = <0>; > + clocks = <&hdmi_phy_27m>, <&clk IMX8MQ_CLK_DISP_APB_ROOT>; > + clock-names = "ref", "apb"; > + cdns,num-lanes = <4>; > + cdns,max-bit-rate = <5400>; > + }; > -- > 2.34.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 569B2C4332F for ; Thu, 1 Dec 2022 23:13:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230128AbiLAXNS (ORCPT ); Thu, 1 Dec 2022 18:13:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230422AbiLAXNG (ORCPT ); Thu, 1 Dec 2022 18:13:06 -0500 Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AAE1BA65A2; Thu, 1 Dec 2022 15:13:03 -0800 (PST) Received: by mail-oi1-f173.google.com with SMTP id r21so3640212oie.13; Thu, 01 Dec 2022 15:13:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OKxrfU4YmpY1Kl1yHeMXQyKUWxu44u51bjZxjiYhfek=; b=vHMPKiY8XxZDQSD6tWPqxTc/FbmPBAD59Fl5N5oG3Q/130vxZYb8W1RQEu4FnbZ+6d WpqQa9JORPOjh4oCa2i2w5S0DswbNpqEayOTjStxEO2lQMgxLexYMRBNx7HS4SNMAqZc WO1yCYfAQnRnLH+/iTtFpQ/Ykd45OTRsYBb66SbQrZvAmQpCliYFTkyAuWLmdVChjcuj WJB00kmHRR5N5wCZZatra7SdSIwv2nZXqYPEWVC6XhKR8TWRpdHj4/kToVpkGqDlRZzN 3WAaPkvxxCrHjpD60lmTQ5VWA5+tPTG9a3er7BFDUw+uNjHxUjqFb+23cKonQE7P3nwA ENqw== X-Gm-Message-State: ANoB5pkhOiDEdhyFU4Lr4Rq/VqAEw5uB0zpH0V0DmFH5JlP5hfLvy9jC X7KLthYmWsVKZ52SusC8/g== X-Google-Smtp-Source: AA0mqf6Hw+Gk/anvjA2tVJyGiBiFgpkYa/VeAI295MqD5oc4uGzJJSmIKRZpn+m9seyj7pP7+kUz+A== X-Received: by 2002:a54:4783:0:b0:354:7e1:d3ac with SMTP id o3-20020a544783000000b0035407e1d3acmr26707554oic.237.1669936382827; Thu, 01 Dec 2022 15:13:02 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id p64-20020acad843000000b0035a9003b8edsm2345943oig.40.2022.12.01.15.13.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 15:13:02 -0800 (PST) Received: (nullmailer pid 1658241 invoked by uid 1000); Thu, 01 Dec 2022 23:13:01 -0000 Date: Thu, 1 Dec 2022 17:13:01 -0600 From: Rob Herring To: Sandor Yu Cc: andrzej.hajda@intel.com, neil.armstrong@linaro.org, robert.foss@linaro.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@gmail.com, daniel@ffwll.ch, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, vkoul@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, kernel@pengutronix.de, linux-imx@nxp.com, oliver.brown@nxp.com Subject: Re: [PATCH v5 07/10] dt-bindings: phy: Add Cadence HDP-TX DP PHY Message-ID: <20221201231301.GA1653935-robh@kernel.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Nov 28, 2022 at 03:36:15PM +0800, Sandor Yu wrote: > Add bindings for Cadence HDP-TX DisplayPort PHY. > > Signed-off-by: Sandor Yu > --- > .../bindings/phy/cdns,hdptx-dp-phy.yaml | 68 +++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/cdns,hdptx-dp-phy.yaml > > diff --git a/Documentation/devicetree/bindings/phy/cdns,hdptx-dp-phy.yaml b/Documentation/devicetree/bindings/phy/cdns,hdptx-dp-phy.yaml > new file mode 100644 > index 000000000000..f4f741150c12 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/cdns,hdptx-dp-phy.yaml > @@ -0,0 +1,68 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/cdns,hdptx-dp-phy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cadence HDP-TX(HDMI/DisplayPort) PHY for DisplayPort protocol > + > +maintainers: > + - Sandor Yu > + > +properties: > + compatible: > + enum: > + - cdns,hdptx-dp-phy Again, name based on SoC and SoC vendor. > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: PHY reference clock. > + - description: APB clock. > + > + clock-names: > + items: > + - const: ref > + - const: apb > + > + "#phy-cells": > + const: 0 > + > + cdns,num-lanes: There is a standard way to define the number of lanes. That goes in output endpoint for the DP node. Not that convenient to the phy, but the information is already there, don't duplicate it. > + description: > + Number of lanes. > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [1, 2, 3, 4] > + default: 4 > + > + cdns,max-bit-rate: Same with this. > + description: > + Maximum DisplayPort link bit rate to use, in Mbps > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [2160, 2430, 2700, 3240, 4320, 5400] > + default: 5400 > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - "#phy-cells" > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + dp_phy: phy@32c00000 { > + compatible = "cdns,hdptx-dp-phy"; > + reg = <0x32c00000 0x100000>; > + #phy-cells = <0>; > + clocks = <&hdmi_phy_27m>, <&clk IMX8MQ_CLK_DISP_APB_ROOT>; > + clock-names = "ref", "apb"; > + cdns,num-lanes = <4>; > + cdns,max-bit-rate = <5400>; > + }; > -- > 2.34.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84B47C4332F for ; Thu, 1 Dec 2022 23:13:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2E96E10E687; Thu, 1 Dec 2022 23:13:08 +0000 (UTC) Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) by gabe.freedesktop.org (Postfix) with ESMTPS id B647C10E686 for ; Thu, 1 Dec 2022 23:13:03 +0000 (UTC) Received: by mail-oi1-f172.google.com with SMTP id c129so3746757oia.0 for ; Thu, 01 Dec 2022 15:13:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OKxrfU4YmpY1Kl1yHeMXQyKUWxu44u51bjZxjiYhfek=; b=SDu61Y2VbPMLQaBCokOYX/ZEQaRJQHJhZbVQUBoPr9zt893TWEnB35/Lc26NiuLYmp 6KWKpo7KhBreCvVgSGtR2+EtOmjItZMF9GM0AEqAT5zicpPaHyqpnHaV2OznZj5C5GmC 343LuDa495O6ERti2NyaEYe86gdEnega3eHEyAHutjGN1GkM+PPyaxGv5y+rteRBvuZa nHsTp/Yegf0AQXVtsGFtxPEZUU3fVwD0C2TDWSXlqAW0ulYAHzjiT1c/hTCDE42BGJ2a eGDHXuEGl1HfK6lvxURvngsKEr4ce7qEk/mvaKC73YG3/pYndLkra+/6pNIMzj9GQ3I2 G34Q== X-Gm-Message-State: ANoB5pnDdNjFDUEyGaZN0701PXrMUOEYnFQ92cf3dZx/92DCxaUCENjq fj2kW2ijwibfLDWUEdo94w== X-Google-Smtp-Source: AA0mqf6Hw+Gk/anvjA2tVJyGiBiFgpkYa/VeAI295MqD5oc4uGzJJSmIKRZpn+m9seyj7pP7+kUz+A== X-Received: by 2002:a54:4783:0:b0:354:7e1:d3ac with SMTP id o3-20020a544783000000b0035407e1d3acmr26707554oic.237.1669936382827; Thu, 01 Dec 2022 15:13:02 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id p64-20020acad843000000b0035a9003b8edsm2345943oig.40.2022.12.01.15.13.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 15:13:02 -0800 (PST) Received: (nullmailer pid 1658241 invoked by uid 1000); Thu, 01 Dec 2022 23:13:01 -0000 Date: Thu, 1 Dec 2022 17:13:01 -0600 From: Rob Herring To: Sandor Yu Subject: Re: [PATCH v5 07/10] dt-bindings: phy: Add Cadence HDP-TX DP PHY Message-ID: <20221201231301.GA1653935-robh@kernel.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, neil.armstrong@linaro.org, oliver.brown@nxp.com, krzysztof.kozlowski+dt@linaro.org, jonas@kwiboo.se, linux-arm-kernel@lists.infradead.org, shawnguo@kernel.org, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, jernej.skrabec@gmail.com, vkoul@kernel.org, robert.foss@linaro.org, andrzej.hajda@intel.com, linux-phy@lists.infradead.org, linux-imx@nxp.com, kernel@pengutronix.de, devicetree@vger.kernel.org, Laurent.pinchart@ideasonboard.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Nov 28, 2022 at 03:36:15PM +0800, Sandor Yu wrote: > Add bindings for Cadence HDP-TX DisplayPort PHY. > > Signed-off-by: Sandor Yu > --- > .../bindings/phy/cdns,hdptx-dp-phy.yaml | 68 +++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/cdns,hdptx-dp-phy.yaml > > diff --git a/Documentation/devicetree/bindings/phy/cdns,hdptx-dp-phy.yaml b/Documentation/devicetree/bindings/phy/cdns,hdptx-dp-phy.yaml > new file mode 100644 > index 000000000000..f4f741150c12 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/cdns,hdptx-dp-phy.yaml > @@ -0,0 +1,68 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/cdns,hdptx-dp-phy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cadence HDP-TX(HDMI/DisplayPort) PHY for DisplayPort protocol > + > +maintainers: > + - Sandor Yu > + > +properties: > + compatible: > + enum: > + - cdns,hdptx-dp-phy Again, name based on SoC and SoC vendor. > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: PHY reference clock. > + - description: APB clock. > + > + clock-names: > + items: > + - const: ref > + - const: apb > + > + "#phy-cells": > + const: 0 > + > + cdns,num-lanes: There is a standard way to define the number of lanes. That goes in output endpoint for the DP node. Not that convenient to the phy, but the information is already there, don't duplicate it. > + description: > + Number of lanes. > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [1, 2, 3, 4] > + default: 4 > + > + cdns,max-bit-rate: Same with this. > + description: > + Maximum DisplayPort link bit rate to use, in Mbps > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [2160, 2430, 2700, 3240, 4320, 5400] > + default: 5400 > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - "#phy-cells" > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + dp_phy: phy@32c00000 { > + compatible = "cdns,hdptx-dp-phy"; > + reg = <0x32c00000 0x100000>; > + #phy-cells = <0>; > + clocks = <&hdmi_phy_27m>, <&clk IMX8MQ_CLK_DISP_APB_ROOT>; > + clock-names = "ref", "apb"; > + cdns,num-lanes = <4>; > + cdns,max-bit-rate = <5400>; > + }; > -- > 2.34.1 > >