From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 536ABC4708D for ; Fri, 2 Dec 2022 10:54:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CmdOWI5P1QBTpUKpen/fgraijJm//7toCJ2EtmHLNqg=; b=xAzSrcBQhCvG38 YUx6AahpXSQPVsasO7HVHyISHT1HCz5T1TNz9mB6mz1RDmfpUH4C5pr0amPfD8dFqwVqGsG6Mg9jA IwHGc5JxJt27UduxU1ITMjAHDha/gy/Zh78W7VCpd4rsYBz9Fszs8AVKdkZKMMpxFvdU81wsP5aTt om1Og52oy6iz4VIGfLY1pd5rAie1r514tgmVULRZRzrj2AnzOg9ZQV2MJ7XaAOGOViAe+VO+WjsPL DbLMfI6YZ+b09njBmSU1AMew+kfV1aNvk/KJd/uOSdk1oBolJL5BQk0A2njR4EQZbBxnjYxxkTvGX u+bhv6+lG0la5OsYdVGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p13g8-00Fl5R-QN; Fri, 02 Dec 2022 10:54:00 +0000 Received: from relay7-d.mail.gandi.net ([2001:4b98:dc4:8::227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p13fo-00Fkse-Qw; Fri, 02 Dec 2022 10:53:43 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id BA35820004; Fri, 2 Dec 2022 10:53:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1669978413; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/xbDowsjdVxGHiCknMNfQWZp8ui3AZGVt031X2dFPgs=; b=V0G7HbGVHu1UnQcFOkheErwQ54WBVfssvbvblVvAgBmx2/cx07Wal5slnmzOCj2mHSdCZT YefGXDygzc/XOR2ApaE0zcUcJ/FkG6jbDuje8RBXRdeECWF405vrCpCnhxrHa4wNSA9zUK QR/nXDeMQLRr1AV/hpTTmGFTQg3Gx85OkgD6vYnqn17a721nUP6htat0+vYd6e3yCF+exk fT6byoQdarowANubLCUHizmAnEXebaR9HoPnF+DxHdq8xQV+tvW63souC5VUlj1QlFrF3I iTfpNzAyL5tomVH96yN3nCH/tadjyBct/q8cOc8gYi9AOOGxJVK4Kt9pVggE+Q== Date: Fri, 2 Dec 2022 11:53:27 +0100 From: Miquel Raynal To: Francesco Dolcini Cc: Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, Marek Vasut , Francesco Dolcini , Shawn Guo , linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org Subject: Re: [PATCH v1] mtd: parsers: ofpart: Fix parsing when size-cells is 0 Message-ID: <20221202115327.4475d3a2@xps-13> In-Reply-To: References: <20221202071900.1143950-1-francesco@dolcini.it> <20221202101418.6b4b3711@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221202_025341_233222_0A9BFB23 X-CRM114-Status: GOOD ( 40.50 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgRnJhbmNlc2NvLAoKZnJhbmNlc2NvQGRvbGNpbmkuaXQgd3JvdGUgb24gRnJpLCAyIERlYyAy MDIyIDExOjI0OjI5ICswMTAwOgoKPiBPbiBGcmksIERlYyAwMiwgMjAyMiBhdCAxMToxMjo0M0FN ICswMTAwLCBGcmFuY2VzY28gRG9sY2luaSB3cm90ZToKPiA+IEhlbGxvIE1pcXVlbCwKPiA+IAo+ ID4gT24gRnJpLCBEZWMgMDIsIDIwMjIgYXQgMTA6MTQ6MThBTSArMDEwMCwgTWlxdWVsIFJheW5h bCB3cm90ZTogIAo+ID4gPiBmcmFuY2VzY29AZG9sY2luaS5pdCB3cm90ZSBvbiBGcmksICAyIERl YyAyMDIyIDA4OjE5OjAwICswMTAwOiAgCj4gPiA+ID4gRnJvbTogRnJhbmNlc2NvIERvbGNpbmkg PGZyYW5jZXNjby5kb2xjaW5pQHRvcmFkZXguY29tPgo+ID4gPiA+IAo+ID4gPiA+IEFkZCBhIGZh bGxiYWNrIG1lY2hhbmlzbSB0byBoYW5kbGUgdGhlIGNhc2UgaW4gd2hpY2ggI3NpemUtY2VsbHMg aXMgc2V0Cj4gPiA+ID4gdG8gPDA+LiBBY2NvcmRpbmcgdG8gdGhlIERUIGJpbmRpbmcgdGhlIG5h bmQgY29udHJvbGxlciBub2RlIHNob3VsZCBoYXZlCj4gPiA+ID4gc2V0IGl0IHRvIDAgYW5kIHRo aXMgaXMgbm90IGNvbXBhdGlibGUgd2l0aCB0aGUgbGVnYWN5IHdheSBvZgo+ID4gPiA+IHNwZWNp ZnlpbmcgcGFydGl0aW9ucyBkaXJlY3RseSBhcyBjaGlsZCBub2RlcyBvZiB0aGUgbmFuZC1jb250 cm9sbGVyIG5vZGUuICAKPiA+ID4gCj4gPiA+IEkgdW5kZXJzdGFuZCB0aGUgcHJvYmxlbSwgSSB1 bmRlcnN0YW5kIHRoZSBmaXgsIGJ1dCBJIGhhdmUgdG8gc2F5LCBJCj4gPiA+IHN0cm9uZ2x5IGRp c2xpa2UgaXQgOikgVG91Y2hpbmcgYW4gbXRkIGNvcmUgZHJpdmVyIHRvIGZpeCBhIHNpbmdsZQo+ ID4gPiBicm9rZW4gdXNlIGNhc2UgbGlrZSB0aGF0IGlzLi4uIHByb2JsZW1hdGljLCBmb3IgdGhl IGxlYXN0LiAgCj4gPiBJIGp1c3Qgbm90aWNlZCBpdCAyIGRheXMgYWZ0ZXIgdGhpcyBwYXRjaCB3 YXMgYmFja3BvcnRlZCB0byBhIHN0YWJsZQo+ID4ga2VybmVsLCBJIGFtIGp1c3QgdGhlIGZpcnN0 IG9uZSB0byBub3RpY2UsIHdlIGFyZSBub3QgdGFsa2luZyBhYm91dCBhIHNpbmdsZQo+ID4gdXNl IGNhc2UuCj4gPiAgIAo+ID4gPiBJIGFtIHNvcnJ5IGJ1dCBpZiBhIDYuMCBrZXJuZWwgYnJlYWtz IGJlY2F1c2U6ICAKPiA+IE5vdCBvbmx5IGtlcm5lbCA2LjAgaXMgY3VycmVudGx5IGJyb2tlbi4g VGhpcyBwYXRjaCBpcyBnb2luZyB0byBiZQo+ID4gYmFja3BvcnRlZCB0byBhbnkgc3RhYmxlIGtl cm5lbCBnaXZlbiB0aGUgZml4ZXMgdGFnIGl0IGhhcy4KPiA+ICAgCj4gPiA+IElmIHlvdSByZWFs bHkgd2FudCB0byB3b3JrYXJvdW5kIFUtQm9vdCwgZWl0aGVyIHlvdSByZXZlcnQgdGhhdCBwYXRj aAo+ID4gPiBvciB5b3UganVzdCBmaXggdGhlIERUIGRlc2NyaXB0aW9uIGluc3RlYWQuIFRoZSBw YXJlbnQvY2hpbGQvcGFydGl0aW9ucwo+ID4gPiBzY2hlbWUgaGFzIGJlZW4gZW5mb3JjZWQgZm9y IG1heWJlIDUgeWVhcnMgbm93IGFuZCBmb3IgYSBnb29kIHJlYXNvbjogYQo+ID4gPiBOQU5EIGNv bnRyb2xsZXIgd2l0aCBwYXJ0aXRpb25zIGRvZXMgbm90IG1ha2UgX2FueV8gc2Vuc2UuIFRoZXJl IGFyZQo+ID4gPiBwbGVudHkgb2YgZXhhbXBsZXMgb3V0IHRoZXJlLCBpbXg3LWNvbGlicmkuZHRz aSBoYXMgcmVjZWl2ZWQgbWFueQo+ID4gPiB1cGRhdGVzIHNpbmNlIGl0cyBpbnRyb2R1Y3Rpb24g KGZvciB0aGUgYmVzdCksIHNvIHdoeSBub3QgdGhpcyBvbmU/ICAKPiA+IAo+ID4gSSBjYW4gYW5k IEkgd2lsbCB1cGRhdGUgaW14Ny1jb2xpYnJpLmR0c2kgKHBhdGNoIGNvbWluZyksCgo6dGh1bWJf dXA6Cgo+ID4gYnV0IGlzIHRoaXMKPiA+IGdvb2QgZW5vdWdoIGdpdmVuIHRoZSBraW5kIG9mIGJv b3QgZmFpbHVyZSByZWdyZXNzaW9uIHRoaXMgaW50cm9kdWNlPyBXZQo+ID4gYXJlIGdvaW5nIHRv IGhhdmUgb2xkIHUtYm9vdCBhcm91bmQgdGhhdCB3aWxsIG5vdCB3b3JrIHdpdGggaXQsIGFuZCB0 aGUgIAo+IAo+IEp1c3QgYW5vdGhlciBwaWVjZSBvZiBpbmZvcm1hdGlvbiwgc3VwcG9ydCBmb3Ig dGhlIHBhcnRpdGlvbnMgbm9kZSBpbgo+IFUtQm9vdCB3YXMgYWRkZWQgaW4gdmVyc2lvbiB2MjAy Mi4wNCBbMV0sIHdlIGFyZSBub3QgdGFsa2luZyBhYm91dCBhbmNpZW50Cj4gb2xkIGxlZ2FjeSBz dHVmZi4KCklmIGl0IGlzIHNvIHJlY2VudCwgdGhlbiB0aGlzIGlzIHdoYXQgbmVlZHMgdG8gYmUg Zml4ZWQsIGFuZCBpdCBzaG91bGQKbm90IGJvdGhlciAibWFueSIgcGVvcGxlIGJlY2F1c2UgMjAy Mi4wNCBpcyBub3Qgc28gb2xkLgoKU28gSSBhbSBhIGJpdCBsb3N0LCBJSVVDIHdoYXQgaXMgY3Vy cmVudGx5IGJyb2tlbiBpczoKLSBVLUJvb3QgPiAyMDIyLjA0IGFuZCBhbnkgdmVyc2lvbiBvZiBM aW51eCB3aXRoIHRoZSBiYWNrcG9ydD8KCj4gSWYgSSBhZGQgdGhlIHBhcnRpdGlvbnMgbm9kZSBh cyBhIGNoaWxkIG9mIG15IG5hbmQgY29udHJvbGxlciwgYXMgSSB3YXMKPiBwbGFubmluZyB0byBk byBhbmQgSSB3cm90ZSAxMCBsaW5lcyBhYm92ZSwgSSB3aWxsIGNyZWF0ZSBhIG5ldyBmbGF2b3Ig b2YKPiBub24tYm9vdGluZyBzeXN0ZW0gd2l0aCBVLUJvb3Qgb2xkZXIgdGhhbiB2MjAyMi4wNCA6 LS8KCkkgdGhpbmsgdGhlcmUgaXMgYSBsaXR0bGUgY29uZnVzaW9uIGhlcmUuIFlvdSBhcmUgcmVm ZXJyaW5nIHRvIHRoZSBOQU5ECmNvbnRyb2xsZXIgbm9kZSwgdGhlIGNvbW1pdCByZWZlcnMgdG8g dGhlIE5BTkQgY2hpcCBub2RlLiBXaGF0IHRoaXMKY29tbWl0IGRvZXMgbG9va3MgZmluZSBiZWNh dXNlIGl0IGp1c3QgdHJpZXMgdG8gdXNlIHRoZSBwYXJ0aXRpb25zIHt9Cm5vZGUgcmF0aGVyIHRo YW4gdGhlIE5BTkQgY2hpcCBub2RlIGFuZCBpZiB0aGUgcGFydGl0aW9ucyB7fSBub2RlCmFscmVh ZHkgZXhpc3QsIEkgZXhwZWN0ICNhZGRyZXNzLWNlbGxzIGFuZCAjc2l6ZS1jZWxscyB0byBiZSBk ZWZpbmVkCmFuZCBiZSAhPSAwIGFscmVhZHkuCgpIZXJlIGlzIGEgcHJvcGVyIGRlc2NyaXB0aW9u OgoKbmFuZC1jb250cm9sbGVyIHsKCSNhZGRyZXNzLWNlbGxzID0gPDE+OwoJI3NpemUtY2VsbHMg PSA8MD47CgluYW5kLWNoaXAgewoJCXBhcnRpdGlvbnMgewoJCQkjYWRkcmVzcy1jZWxscyA9IDwx IG9yIDI+OwoJCQkjc2l6ZS1jZWxscyA9IDwxIG9yIDI+OwoJCQlwYXJ0aXRpb25AeCB7IH07CgkJ CXBhcnRpdGlvbkB5IHsgfTsKCQl9OwoJfTsKCgkvKiBIZXJlIHlvdSBjYW4gdmVyeSB3ZWxsIGhh dmUgYW5vdGhlciBuYW5kLWNoaXAgbm9kZSB3aXRoCgkgKiBhbm90aGVyIHJlZyBwcm9wZXJ0eSB3 aGljaCByZXByZXNlbnRzIGl0cyBvd24gQ1MgYW5kIGFub3RoZXIKCSAqIHNldCBvZiBwYXJ0aXRp b25zLgoJICovCn07Cgo+IFUtQm9vdCBvbGRlciB0aGFuIHYyMDIyLjA0IHdpbGwgdXBkYXRlIHRo ZSBuYW5kIGNvbnRyb2xsZXIgbm9kZSBuZXZlcgo+IHRoZSBsZXNzLCB0aGUgcGFydGl0aW9uIG5v ZGUgd2lsbCBzdGlsbCBiZSB0aGVyZSBhbmQgTGludXggd2lsbCB1c2UgaXQsCj4gYnV0IGl0IHdp bGwgYmUgZW1wdHkgc2luY2Ugbm9ib2R5IHBvcHVsYXRlIGl0Lgo+IAo+IEZyYW5jZXNjbwo+IAo+ IFsxXSBjb21taXQgMzZmZWUyZjc2MjFlICgiY29tbW9uOiBmZHRfc3VwcG9ydDogYWRkIHN1cHBv cnQgZm9yICJwYXJ0aXRpb25zIiBzdWJub2RlIHRvIGZkdF9maXh1cF9tdGRwYXJ0cygpIikKCgpU aGFua3MsCk1pcXXDqGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpMaW51eCBNVEQgZGlzY3Vzc2lvbiBtYWlsaW5nIGxpc3QKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17351C4332F for ; Fri, 2 Dec 2022 10:54:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233256AbiLBKya (ORCPT ); Fri, 2 Dec 2022 05:54:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233250AbiLBKxw (ORCPT ); Fri, 2 Dec 2022 05:53:52 -0500 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94F49D0394 for ; Fri, 2 Dec 2022 02:53:37 -0800 (PST) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id BA35820004; Fri, 2 Dec 2022 10:53:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1669978413; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/xbDowsjdVxGHiCknMNfQWZp8ui3AZGVt031X2dFPgs=; b=V0G7HbGVHu1UnQcFOkheErwQ54WBVfssvbvblVvAgBmx2/cx07Wal5slnmzOCj2mHSdCZT YefGXDygzc/XOR2ApaE0zcUcJ/FkG6jbDuje8RBXRdeECWF405vrCpCnhxrHa4wNSA9zUK QR/nXDeMQLRr1AV/hpTTmGFTQg3Gx85OkgD6vYnqn17a721nUP6htat0+vYd6e3yCF+exk fT6byoQdarowANubLCUHizmAnEXebaR9HoPnF+DxHdq8xQV+tvW63souC5VUlj1QlFrF3I iTfpNzAyL5tomVH96yN3nCH/tadjyBct/q8cOc8gYi9AOOGxJVK4Kt9pVggE+Q== Date: Fri, 2 Dec 2022 11:53:27 +0100 From: Miquel Raynal To: Francesco Dolcini Cc: Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, Marek Vasut , Francesco Dolcini , Shawn Guo , linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org Subject: Re: [PATCH v1] mtd: parsers: ofpart: Fix parsing when size-cells is 0 Message-ID: <20221202115327.4475d3a2@xps-13> In-Reply-To: References: <20221202071900.1143950-1-francesco@dolcini.it> <20221202101418.6b4b3711@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi Francesco, francesco@dolcini.it wrote on Fri, 2 Dec 2022 11:24:29 +0100: > On Fri, Dec 02, 2022 at 11:12:43AM +0100, Francesco Dolcini wrote: > > Hello Miquel, > >=20 > > On Fri, Dec 02, 2022 at 10:14:18AM +0100, Miquel Raynal wrote: =20 > > > francesco@dolcini.it wrote on Fri, 2 Dec 2022 08:19:00 +0100: =20 > > > > From: Francesco Dolcini > > > >=20 > > > > Add a fallback mechanism to handle the case in which #size-cells is= set > > > > to <0>. According to the DT binding the nand controller node should= have > > > > set it to 0 and this is not compatible with the legacy way of > > > > specifying partitions directly as child nodes of the nand-controlle= r node. =20 > > >=20 > > > I understand the problem, I understand the fix, but I have to say, I > > > strongly dislike it :) Touching an mtd core driver to fix a single > > > broken use case like that is... problematic, for the least. =20 > > I just noticed it 2 days after this patch was backported to a stable > > kernel, I am just the first one to notice, we are not talking about a s= ingle > > use case. > > =20 > > > I am sorry but if a 6.0 kernel breaks because: =20 > > Not only kernel 6.0 is currently broken. This patch is going to be > > backported to any stable kernel given the fixes tag it has. > > =20 > > > If you really want to workaround U-Boot, either you revert that patch > > > or you just fix the DT description instead. The parent/child/partitio= ns > > > scheme has been enforced for maybe 5 years now and for a good reason:= a > > > NAND controller with partitions does not make _any_ sense. There are > > > plenty of examples out there, imx7-colibri.dtsi has received many > > > updates since its introduction (for the best), so why not this one? = =20 > >=20 > > I can and I will update imx7-colibri.dtsi (patch coming), :thumb_up: > > but is this > > good enough given the kind of boot failure regression this introduce? We > > are going to have old u-boot around that will not work with it, and the= =20 >=20 > Just another piece of information, support for the partitions node in > U-Boot was added in version v2022.04 [1], we are not talking about ancient > old legacy stuff. If it is so recent, then this is what needs to be fixed, and it should not bother "many" people because 2022.04 is not so old. So I am a bit lost, IIUC what is currently broken is: - U-Boot > 2022.04 and any version of Linux with the backport? > If I add the partitions node as a child of my nand controller, as I was > planning to do and I wrote 10 lines above, I will create a new flavor of > non-booting system with U-Boot older than v2022.04 :-/ I think there is a little confusion here. You are referring to the NAND controller node, the commit refers to the NAND chip node. What this commit does looks fine because it just tries to use the partitions {} node rather than the NAND chip node and if the partitions {} node already exist, I expect #address-cells and #size-cells to be defined and be !=3D 0 already. Here is a proper description: nand-controller { #address-cells =3D <1>; #size-cells =3D <0>; nand-chip { partitions { #address-cells =3D <1 or 2>; #size-cells =3D <1 or 2>; partition@x { }; partition@y { }; }; }; /* Here you can very well have another nand-chip node with * another reg property which represents its own CS and another * set of partitions. */ }; > U-Boot older than v2022.04 will update the nand controller node never > the less, the partition node will still be there and Linux will use it, > but it will be empty since nobody populate it. >=20 > Francesco >=20 > [1] commit 36fee2f7621e ("common: fdt_support: add support for "partition= s" subnode to fdt_fixup_mtdparts()") Thanks, Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F005C4332F for ; Fri, 2 Dec 2022 10:54:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9GOIbYTJ8lxmeq480NYG7nka29pRYlsg1blTpsH918U=; b=uwIGVppgZOGrXf 8Zh5rkI1DVRkfeRXP8BZemQghEVYG3W4O+fN2FtNJQrjOcWgbmhXEm2ifKaCO2Ujr5L2D2kF4DfRT QdlxP9qInpnAs+7eHvPcGMKYZEWqanBmhhcTfTJBA564s1tLYbDbw9nNesoitIAg201Bc3cKAxF4j OoEiqf1juPa3yeBWglLZBSzmM7TKD1OXjM3fD3JXiEXOtM/qgk2diTZk7UQLswtT2KAjUOM9XL1TJ bUgt8I7TmvgPzKhmGzC6o/CiDO3Bd9L746yZrzhj+CqehRyEUS4YwF0vVzbVqFEsjPp6RqmrwaP57 tKGGlOedm0YD/I6EvODA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p13fu-00Fkyr-5Y; Fri, 02 Dec 2022 10:53:46 +0000 Received: from relay7-d.mail.gandi.net ([2001:4b98:dc4:8::227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p13fo-00Fkse-Qw; Fri, 02 Dec 2022 10:53:43 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id BA35820004; Fri, 2 Dec 2022 10:53:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1669978413; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/xbDowsjdVxGHiCknMNfQWZp8ui3AZGVt031X2dFPgs=; b=V0G7HbGVHu1UnQcFOkheErwQ54WBVfssvbvblVvAgBmx2/cx07Wal5slnmzOCj2mHSdCZT YefGXDygzc/XOR2ApaE0zcUcJ/FkG6jbDuje8RBXRdeECWF405vrCpCnhxrHa4wNSA9zUK QR/nXDeMQLRr1AV/hpTTmGFTQg3Gx85OkgD6vYnqn17a721nUP6htat0+vYd6e3yCF+exk fT6byoQdarowANubLCUHizmAnEXebaR9HoPnF+DxHdq8xQV+tvW63souC5VUlj1QlFrF3I iTfpNzAyL5tomVH96yN3nCH/tadjyBct/q8cOc8gYi9AOOGxJVK4Kt9pVggE+Q== Date: Fri, 2 Dec 2022 11:53:27 +0100 From: Miquel Raynal To: Francesco Dolcini Cc: Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, Marek Vasut , Francesco Dolcini , Shawn Guo , linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org Subject: Re: [PATCH v1] mtd: parsers: ofpart: Fix parsing when size-cells is 0 Message-ID: <20221202115327.4475d3a2@xps-13> In-Reply-To: References: <20221202071900.1143950-1-francesco@dolcini.it> <20221202101418.6b4b3711@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221202_025341_233222_0A9BFB23 X-CRM114-Status: GOOD ( 40.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgRnJhbmNlc2NvLAoKZnJhbmNlc2NvQGRvbGNpbmkuaXQgd3JvdGUgb24gRnJpLCAyIERlYyAy MDIyIDExOjI0OjI5ICswMTAwOgoKPiBPbiBGcmksIERlYyAwMiwgMjAyMiBhdCAxMToxMjo0M0FN ICswMTAwLCBGcmFuY2VzY28gRG9sY2luaSB3cm90ZToKPiA+IEhlbGxvIE1pcXVlbCwKPiA+IAo+ ID4gT24gRnJpLCBEZWMgMDIsIDIwMjIgYXQgMTA6MTQ6MThBTSArMDEwMCwgTWlxdWVsIFJheW5h bCB3cm90ZTogIAo+ID4gPiBmcmFuY2VzY29AZG9sY2luaS5pdCB3cm90ZSBvbiBGcmksICAyIERl YyAyMDIyIDA4OjE5OjAwICswMTAwOiAgCj4gPiA+ID4gRnJvbTogRnJhbmNlc2NvIERvbGNpbmkg PGZyYW5jZXNjby5kb2xjaW5pQHRvcmFkZXguY29tPgo+ID4gPiA+IAo+ID4gPiA+IEFkZCBhIGZh bGxiYWNrIG1lY2hhbmlzbSB0byBoYW5kbGUgdGhlIGNhc2UgaW4gd2hpY2ggI3NpemUtY2VsbHMg aXMgc2V0Cj4gPiA+ID4gdG8gPDA+LiBBY2NvcmRpbmcgdG8gdGhlIERUIGJpbmRpbmcgdGhlIG5h bmQgY29udHJvbGxlciBub2RlIHNob3VsZCBoYXZlCj4gPiA+ID4gc2V0IGl0IHRvIDAgYW5kIHRo aXMgaXMgbm90IGNvbXBhdGlibGUgd2l0aCB0aGUgbGVnYWN5IHdheSBvZgo+ID4gPiA+IHNwZWNp ZnlpbmcgcGFydGl0aW9ucyBkaXJlY3RseSBhcyBjaGlsZCBub2RlcyBvZiB0aGUgbmFuZC1jb250 cm9sbGVyIG5vZGUuICAKPiA+ID4gCj4gPiA+IEkgdW5kZXJzdGFuZCB0aGUgcHJvYmxlbSwgSSB1 bmRlcnN0YW5kIHRoZSBmaXgsIGJ1dCBJIGhhdmUgdG8gc2F5LCBJCj4gPiA+IHN0cm9uZ2x5IGRp c2xpa2UgaXQgOikgVG91Y2hpbmcgYW4gbXRkIGNvcmUgZHJpdmVyIHRvIGZpeCBhIHNpbmdsZQo+ ID4gPiBicm9rZW4gdXNlIGNhc2UgbGlrZSB0aGF0IGlzLi4uIHByb2JsZW1hdGljLCBmb3IgdGhl IGxlYXN0LiAgCj4gPiBJIGp1c3Qgbm90aWNlZCBpdCAyIGRheXMgYWZ0ZXIgdGhpcyBwYXRjaCB3 YXMgYmFja3BvcnRlZCB0byBhIHN0YWJsZQo+ID4ga2VybmVsLCBJIGFtIGp1c3QgdGhlIGZpcnN0 IG9uZSB0byBub3RpY2UsIHdlIGFyZSBub3QgdGFsa2luZyBhYm91dCBhIHNpbmdsZQo+ID4gdXNl IGNhc2UuCj4gPiAgIAo+ID4gPiBJIGFtIHNvcnJ5IGJ1dCBpZiBhIDYuMCBrZXJuZWwgYnJlYWtz IGJlY2F1c2U6ICAKPiA+IE5vdCBvbmx5IGtlcm5lbCA2LjAgaXMgY3VycmVudGx5IGJyb2tlbi4g VGhpcyBwYXRjaCBpcyBnb2luZyB0byBiZQo+ID4gYmFja3BvcnRlZCB0byBhbnkgc3RhYmxlIGtl cm5lbCBnaXZlbiB0aGUgZml4ZXMgdGFnIGl0IGhhcy4KPiA+ICAgCj4gPiA+IElmIHlvdSByZWFs bHkgd2FudCB0byB3b3JrYXJvdW5kIFUtQm9vdCwgZWl0aGVyIHlvdSByZXZlcnQgdGhhdCBwYXRj aAo+ID4gPiBvciB5b3UganVzdCBmaXggdGhlIERUIGRlc2NyaXB0aW9uIGluc3RlYWQuIFRoZSBw YXJlbnQvY2hpbGQvcGFydGl0aW9ucwo+ID4gPiBzY2hlbWUgaGFzIGJlZW4gZW5mb3JjZWQgZm9y IG1heWJlIDUgeWVhcnMgbm93IGFuZCBmb3IgYSBnb29kIHJlYXNvbjogYQo+ID4gPiBOQU5EIGNv bnRyb2xsZXIgd2l0aCBwYXJ0aXRpb25zIGRvZXMgbm90IG1ha2UgX2FueV8gc2Vuc2UuIFRoZXJl IGFyZQo+ID4gPiBwbGVudHkgb2YgZXhhbXBsZXMgb3V0IHRoZXJlLCBpbXg3LWNvbGlicmkuZHRz aSBoYXMgcmVjZWl2ZWQgbWFueQo+ID4gPiB1cGRhdGVzIHNpbmNlIGl0cyBpbnRyb2R1Y3Rpb24g KGZvciB0aGUgYmVzdCksIHNvIHdoeSBub3QgdGhpcyBvbmU/ICAKPiA+IAo+ID4gSSBjYW4gYW5k IEkgd2lsbCB1cGRhdGUgaW14Ny1jb2xpYnJpLmR0c2kgKHBhdGNoIGNvbWluZyksCgo6dGh1bWJf dXA6Cgo+ID4gYnV0IGlzIHRoaXMKPiA+IGdvb2QgZW5vdWdoIGdpdmVuIHRoZSBraW5kIG9mIGJv b3QgZmFpbHVyZSByZWdyZXNzaW9uIHRoaXMgaW50cm9kdWNlPyBXZQo+ID4gYXJlIGdvaW5nIHRv IGhhdmUgb2xkIHUtYm9vdCBhcm91bmQgdGhhdCB3aWxsIG5vdCB3b3JrIHdpdGggaXQsIGFuZCB0 aGUgIAo+IAo+IEp1c3QgYW5vdGhlciBwaWVjZSBvZiBpbmZvcm1hdGlvbiwgc3VwcG9ydCBmb3Ig dGhlIHBhcnRpdGlvbnMgbm9kZSBpbgo+IFUtQm9vdCB3YXMgYWRkZWQgaW4gdmVyc2lvbiB2MjAy Mi4wNCBbMV0sIHdlIGFyZSBub3QgdGFsa2luZyBhYm91dCBhbmNpZW50Cj4gb2xkIGxlZ2FjeSBz dHVmZi4KCklmIGl0IGlzIHNvIHJlY2VudCwgdGhlbiB0aGlzIGlzIHdoYXQgbmVlZHMgdG8gYmUg Zml4ZWQsIGFuZCBpdCBzaG91bGQKbm90IGJvdGhlciAibWFueSIgcGVvcGxlIGJlY2F1c2UgMjAy Mi4wNCBpcyBub3Qgc28gb2xkLgoKU28gSSBhbSBhIGJpdCBsb3N0LCBJSVVDIHdoYXQgaXMgY3Vy cmVudGx5IGJyb2tlbiBpczoKLSBVLUJvb3QgPiAyMDIyLjA0IGFuZCBhbnkgdmVyc2lvbiBvZiBM aW51eCB3aXRoIHRoZSBiYWNrcG9ydD8KCj4gSWYgSSBhZGQgdGhlIHBhcnRpdGlvbnMgbm9kZSBh cyBhIGNoaWxkIG9mIG15IG5hbmQgY29udHJvbGxlciwgYXMgSSB3YXMKPiBwbGFubmluZyB0byBk byBhbmQgSSB3cm90ZSAxMCBsaW5lcyBhYm92ZSwgSSB3aWxsIGNyZWF0ZSBhIG5ldyBmbGF2b3Ig b2YKPiBub24tYm9vdGluZyBzeXN0ZW0gd2l0aCBVLUJvb3Qgb2xkZXIgdGhhbiB2MjAyMi4wNCA6 LS8KCkkgdGhpbmsgdGhlcmUgaXMgYSBsaXR0bGUgY29uZnVzaW9uIGhlcmUuIFlvdSBhcmUgcmVm ZXJyaW5nIHRvIHRoZSBOQU5ECmNvbnRyb2xsZXIgbm9kZSwgdGhlIGNvbW1pdCByZWZlcnMgdG8g dGhlIE5BTkQgY2hpcCBub2RlLiBXaGF0IHRoaXMKY29tbWl0IGRvZXMgbG9va3MgZmluZSBiZWNh dXNlIGl0IGp1c3QgdHJpZXMgdG8gdXNlIHRoZSBwYXJ0aXRpb25zIHt9Cm5vZGUgcmF0aGVyIHRo YW4gdGhlIE5BTkQgY2hpcCBub2RlIGFuZCBpZiB0aGUgcGFydGl0aW9ucyB7fSBub2RlCmFscmVh ZHkgZXhpc3QsIEkgZXhwZWN0ICNhZGRyZXNzLWNlbGxzIGFuZCAjc2l6ZS1jZWxscyB0byBiZSBk ZWZpbmVkCmFuZCBiZSAhPSAwIGFscmVhZHkuCgpIZXJlIGlzIGEgcHJvcGVyIGRlc2NyaXB0aW9u OgoKbmFuZC1jb250cm9sbGVyIHsKCSNhZGRyZXNzLWNlbGxzID0gPDE+OwoJI3NpemUtY2VsbHMg PSA8MD47CgluYW5kLWNoaXAgewoJCXBhcnRpdGlvbnMgewoJCQkjYWRkcmVzcy1jZWxscyA9IDwx IG9yIDI+OwoJCQkjc2l6ZS1jZWxscyA9IDwxIG9yIDI+OwoJCQlwYXJ0aXRpb25AeCB7IH07CgkJ CXBhcnRpdGlvbkB5IHsgfTsKCQl9OwoJfTsKCgkvKiBIZXJlIHlvdSBjYW4gdmVyeSB3ZWxsIGhh dmUgYW5vdGhlciBuYW5kLWNoaXAgbm9kZSB3aXRoCgkgKiBhbm90aGVyIHJlZyBwcm9wZXJ0eSB3 aGljaCByZXByZXNlbnRzIGl0cyBvd24gQ1MgYW5kIGFub3RoZXIKCSAqIHNldCBvZiBwYXJ0aXRp b25zLgoJICovCn07Cgo+IFUtQm9vdCBvbGRlciB0aGFuIHYyMDIyLjA0IHdpbGwgdXBkYXRlIHRo ZSBuYW5kIGNvbnRyb2xsZXIgbm9kZSBuZXZlcgo+IHRoZSBsZXNzLCB0aGUgcGFydGl0aW9uIG5v ZGUgd2lsbCBzdGlsbCBiZSB0aGVyZSBhbmQgTGludXggd2lsbCB1c2UgaXQsCj4gYnV0IGl0IHdp bGwgYmUgZW1wdHkgc2luY2Ugbm9ib2R5IHBvcHVsYXRlIGl0Lgo+IAo+IEZyYW5jZXNjbwo+IAo+ IFsxXSBjb21taXQgMzZmZWUyZjc2MjFlICgiY29tbW9uOiBmZHRfc3VwcG9ydDogYWRkIHN1cHBv cnQgZm9yICJwYXJ0aXRpb25zIiBzdWJub2RlIHRvIGZkdF9maXh1cF9tdGRwYXJ0cygpIikKCgpU aGFua3MsCk1pcXXDqGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwK