From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93AD5C47088 for ; Fri, 2 Dec 2022 15:01:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xbmeZC+5e5tkuVmwoqznT4J6aBzDglsFgGCUkx3ratQ=; b=zxsGxFG35Yae8V AikvbBdKFYS/oSXmfRJV54T0e68CQ1sZG3I/ei0VpvqwXczi1KxfPl7boVdYq3po5XgrquUl2oVR1 YEecZ5iaLNgrEaYM6aD00Ji2lh3Xtuwkx7YUERnqUoFQWZDC33tZjcihKtmD4z3oUIUEcYBn3Jds7 rVSR18nLDB7sqdVkI3H6ha7CS9OjYLnu7gTRM8npXpFT4PMdt7wAzf5tl0uqR6Yv+9oifeziXRkLP t9p3Z6779NZ5HWxVuYCgHgPqwMzQgpMUzynuuU0v/oMq8Vcs01lvvhm6CLpjC5ZdOAqHW2AQaU7QZ wMSBO+BA1LAlIctuiu1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p17X4-00GxKw-0Q; Fri, 02 Dec 2022 15:00:54 +0000 Received: from relay11.mail.gandi.net ([2001:4b98:dc4:8::231]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p17Wq-00GxGf-IN; Fri, 02 Dec 2022 15:00:42 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id B0F21100007; Fri, 2 Dec 2022 15:00:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1669993236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=59qSwgpaGJCpHjydTIqoo0IPT+OCfNv0dCYixP5EWqg=; b=TaAd/jd7DJaOECXA/cSb/SywJ7kSqgK5OydWuWmhvTIXhgKRyyxWmNG6YzOeT/M30zSuhc WaSxv3dOkKMXexw8SXTLM6GQ62JgFH4Dk0piZgv5otuzG1rxbAx62Hb7Id5E7/b1WySwjB llvxVcds2aETbx3Wqcih+KWrROrFLDc2cuVdGG6Oj8vaO333shCCokqqLGLgX5cBDCqOao +krQkRkGSRtUy+yQxAxeAGJDkMiOaJh3jKeyCbwHxZGAtan+cc+iGFxSvf9/aHp3mg0qVR RS3eZ5IImxAO+2GZR61FyfapFqnCJs+64n1FfLB2bpk9CRQk/3L6NTMvdw/o/A== Date: Fri, 2 Dec 2022 16:00:30 +0100 From: Miquel Raynal To: Marek Vasut Cc: Francesco Dolcini , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, Francesco Dolcini , Shawn Guo , linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, u-boot@lists.denx.de Subject: Re: [PATCH v1] mtd: parsers: ofpart: Fix parsing when size-cells is 0 Message-ID: <20221202160030.1b8d0b8a@xps-13> In-Reply-To: <2b6fc52d-60b9-d0f4-ab91-4cf7a8095999@denx.de> References: <20221202071900.1143950-1-francesco@dolcini.it> <20221202101418.6b4b3711@xps-13> <20221202115327.4475d3a2@xps-13> <20221202150556.14c5ae43@xps-13> <2b6fc52d-60b9-d0f4-ab91-4cf7a8095999@denx.de> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221202_070040_952675_45648EE4 X-CRM114-Status: GOOD ( 35.76 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgTWFyZWssCgptYXJleEBkZW54LmRlIHdyb3RlIG9uIEZyaSwgMiBEZWMgMjAyMiAxNTozMTo0 MCArMDEwMDoKCj4gT24gMTIvMi8yMiAxNTowNSwgTWlxdWVsIFJheW5hbCB3cm90ZToKPiA+IEhp IEZyYW5jZXNjbywgIAo+IAo+IEhpLAo+IAo+IFsuLi5dCj4gCj4gPiBJIHN0aWxsIHN0cm9uZ2x5 IGRpc2FncmVlIHdpdGggdGhlIGluaXRpYWwgcHJvcG9zYWwgYnV0IHdoYXQgSSB0aGluayB3ZQo+ ID4gY2FuIGRvIGlzOgo+ID4gCj4gPiAxLiBUbyBwcmV2ZW50IGZ1dHVyZSBicmVha2FnZXM6Cj4g PiAgICBGaXggZmR0X2ZpeHVwX210ZHBhcnRzKCkgaW4gdS1ib290LiBUaGlzIHdheSBuZXdlciBV LUJvb3QgKyBhbnkKPiA+ICAgIGtlcm5lbCBzaG91bGQgd29yay4KPiA+IAo+ID4gMi4gVG8gaGVs cCB0cmFja2luZyBkb3duIHNpdHVhdGlvbnMgbGlrZSB0aGF0Ogo+ID4gICAgS2VlcCB0aGUgd2Fy bmluZyBpbiBvZnBhcnQuYyBidXQgY29udGludWUgdG8gZmFpbC4KPiA+IAo+ID4gMy4gVG8gZml4 IHRoZSBjdXJyZW50IHNpdHVhdGlvbjoKPiA+ICAgICBJbW1lZGlhdGVseSByZXZlcnQgY29tbWl0 IChhbmQgcHJldmVudCBpdCBmcm9tIGJlaW5nIGJhY2twb3J0ZWQpOgo+ID4gICAgIDc1MzM5NWVh MWU0NSAoIkFSTTogZHRzOiBpbXg3OiBGaXggTkFORCBjb250cm9sbGVyIHNpemUtY2VsbHMiKQo+ ID4gICAgIFRoaXMgd2F5IHlvdXIgb3duIGJvb3QgZmxvdyBpcyBmaXhlZCBpbiB0aGUgc2hvcnQg dGVybS4gIAo+IAo+IEhlcmUgSSBkaXNhZ3JlZSwgdGhlIGZpeCBpcyBjb3JyZWN0IGFuZCBJIHRo aW5rIHdlIHNob3VsZG4ndAo+IHByb2xpZmVyYXRlIGluY29ycmVjdCBEVHMgd2hpY2ggZG9uJ3Qg bWF0Y2ggdGhlIGJpbmRpbmcgZG9jdW1lbnQuCgpJIGFncmVlIHdlIHNob3VsZCBub3QgcHJvbGlm ZXJhdGUgaW5jb3JyZWN0IERUcywgc28gbGV0J3MgdXNlIGEgbW9kZXJuCmRlc2NyaXB0aW9uIHRo ZW4sIHdpdGggYSBjb250cm9sbGVyIGFuZCBhIGNoaWxkIG5vZGUgd2hpY2ggZGVmaW5lcyB0aGUK Y2hpcC4KCj4gUmF0aGVyLCBpZiBhIGJvb3Rsb2FkZXIgZ2VuZXJhdGVzIGluY29ycmVjdCAobmV3 KSBEVCBlbnRyaWVzLCBJCj4gYmVsaWV2ZSB0aGUgZHJpdmVyIHNob3VsZCBpbXBsZW1lbnQgYSBm aXh1cCBhbmQgd2FybiB1c2VyIGFib3V0IHRoaXMuCj4gUEMgZG9lcyB0aGF0IGFzIHdlbGwgd2l0 aCBicm9rZW4gQUNQSSB0YWJsZXMgYXMgZmFyIGFzIEkgY2FuIHRlbGwuCj4gCj4gSSdtIG5vdCBj b252aW5jZWQgbWFraW5nIGEgRFQgbm9uLWNvbXBsaWFudCB3aXRoIGJpbmRpbmdzIGFnYWluLAoK SSBhbSBzb3JyeSB0byBzYXkgc28sIGJ1dCB3aGlsZSB3YXJuaW5ncyByZXBvcnRlZCBieSB0aGUg dG9vbHMKc2hvdWxkIGJlIGZpeGVkLCBpdCdzIG5vdCBiZWNhdXNlIHRoZSB0b29sIGRvZXMgbm90 IHNjcmVhbSBhdCB5b3UgdGhhdAp0aGUgZGVzY3JpcHRpb24gaXMgdmFsaWQuIFdlIGFyZSBhY3Rp dmVseSB3b3JraW5nIG9uIGVuaGFuY2luZyB0aGUKc2NoZW1hIHNvIHRoYXQgImFsbCIgaW1wcm9w ZXIgZGVzY3JpcHRpb25zIGdldCB3YXJuaW5ncyAoc2VlIHRoZSBzZXJpZXMKcG9pbnRlZCBlYXJs aWVyKSwgYnV0IGluIG5vIHdheSB0aGlzIGNoYW5nZSBtYWtlcyB0aGUgbm9kZSBjb21wbGlhbnQK d2l0aCBtb2Rlcm4gYmluZGluZ3MuCgpJJ20gbm90IHNheWluZyB0aGUgZml4IGlzIHdyb25nLCBi dXQgbGV0J3MgYmUgcHJhZ21hdGljLCBpdCBjdXJyZW50bHkKbGVhZHMgdG8gYm9vdCBmYWlsdXJl cy4KCj4gb25seSB0byB3b3JrIGFyb3VuZCBhIHByb2JsZW0gaW5kdWNlZCBieSBib290bG9hZGVy LCBpcyB0aGUgcmlnaHQgYXBwcm9hY2gKPiBoZXJlLgoKV2hlbiBhIHBhdGNoIGJyZWFrcyBhIGJv YXJkIGFuZCB0aGVyZSBpcyBubyBzdHJhaWdodCBmaXgsIHlvdSByZXZlcnQKaXQsIHRoZW4geW91 IHRoaW5rIGhhcmRlci4gVGhhdCdzIHdoYXQgSSBhbSBzYXlpbmcuIFRoaXMgaXMgYSB0ZW1wb3Jh cnkKc29sdXRpb24uCgo+IFRoaXMgd291bGQgYmUgc2V0dGluZyBhIGRhbmdlcm91cyBleGFtcGxl LCB3aGVyZSBhbnlvbmUgY291bGQgcmVxdWVzdCBhIERUIGZpeCB0byBiZSByZXZlcnRlZCBiZWNh dXNlIHRoZWlyIHJhbmRvbSBib290bG9hZGVyIGRvZXMgdGhlIHdyb25nIHRoaW5nIGFuZCB3aXRo IHZhbGlkIERUIGNsZWFuIHVwLCBzb21ldGhpbmcgYnJva2UuCgpQbGVhc2UsIHlvdSBrbm93IHRo aXMgaXMgbm90IHZhbGlkIERUIGNsZWFuIHVwLiBXZSd2ZSBiZWVuIGRlY291cGxpbmcKY29udHJv bGxlciBhbmQgY2hpcCBkZXNjcmlwdGlvbiBzaW5jZSAyMDE2LiBXaGF0IEkgYW0gcHJvcG9zaW5n IGlzIGEKdmFsaWQgRFQgY2xlYW51cCwgbm90IHRvIHRoZSBsYXRlc3Qgc3RhbmRhcmQsIGJ1dCB3 YXkgY2xvc2VyIHRoYW4gdGhlCmN1cnJlbnQgc29sdXRpb24uCgo+ID4gNC4gVGhlcmUgaXMgbm8g cmVhc29uIHRvIHBhcnRpYWxseSBmaXggYSBEVCBsaWtlIHdoYXQgdGhlIGFib3ZlIGRpZAo+ID4g ICAgIGJlc2lkZXMgdHJ5aW5nIHRvIGF2b2lkIHdhcm5pbmdzIGVtaXR0ZWQgYnkgdGhlIERUIGNo ZWNrIHRvb2xzLiAgCj4gCj4gTm90ZSB0aGF0IHRoZSAzLiBkb2VzIG5vdCBwYXJ0aWFsbHkgZml4 IHRoZSBEVCwgaXQgZml4ZXMgdGhlIG5vZGUgZnVsbHkuCj4gCj4gPiAgICAgSWYKPiA+ICAgICBj b21wbHlpbmcgd2l0aCBtb2Rlcm4gYmluZGluZ3MgaXMgYSBnb2FsIChhbmQgSSB0aGluayBpdCBz aG91bGQKPiA+ICAgICBiZSksIHRoZW4gd2UgY2FuIG1vZGVybml6ZSB0aGlzIERUIHdpdGhvdXQg YnJlYWtpbmcgdGhlIGJvb3QgZmxvdzoKPiA+ICAgICBJbnN0ZWFkIG9mIG9ubHkgc2V0dGluZyAj c2l6ZS1jZWxsID0gPDA+LCB5b3UgY2FuIGFzIHdlbGwgZGVmaW5lCj4gPiAgICAgaW4geW91ciBE VCBhIHN1Ym5vZGUgdG8gZGVmaW5lIHRoZSBOQU5EIGNoaXAuIE5BTkQgY2hpcHMgYXJlIG5vdAo+ ID4gICAgIHN1cHBvc2VkIHRvIGhhdmUgI3NpemUtY2VsbHMgcHJvcGVydGllcywgYnV0IGluIHRo ZSBwYXN0IHRoZXkgZGlkLAo+ID4gICAgIHdoaWNoIG1lYW5zICNhZGRyZXNzLWNlbGxzIGFuZCAj c2l6ZS1jZWxscyBhcmUgYWxsb3dlZCAoYW5kIG1hcmtlZAo+ID4gICAgIGRlcHJlY2F0ZWQgaW4g dGhlIHNjaGVtYSkuIFNvIGluIHByYWN0aWNlLCB0aGUgZHQtc2NoZW1hIHdpbGwgbm90Cj4gPiAg ICAgd2FybiB5b3UgaWYgdGhleSBhcmUgdGhlcmUsIHdoaWNoIG1lYW5zIHlvdSBjYW4gc3RpbGwg c2V0Cj4gPiAgICAgI3NpemUtY2VsbCA9IDwxPi4gIAo+IAo+IEkgYW0gcmVhbGx5IG5vdCBjb252 aW5jZWQgd2Ugc2hvdWxkIGhhY2sgYXJvdW5kIHRoaXMgb24gdGhlIERUIGVuZCBhbmQgdHJ5IHRv IHB1c2ggc29tZSBzb3J0IG9mIGNvbnZvbHV0ZWQgd29ya2Fyb3VuZCB0aGVyZSwKCiJjb252b2x1 dGVkIHdvcmthcm91bmQiIDotKQoKPiBpbnN0ZWFkIG9mIGZpeGluZyBpdCBvbiB0aGUgZHJpdmVy IHNpZGUgKGFuZCBib290bG9hZGVyIHNpZGUsIGluIHRoZQo+IGxvbmcgcnVuKS4KPgo+ID4gICAg IFBsZWFzZSBtaW5kLCB0aGUgdG9vbHMgaGF2ZSBiZWVuIHVwZGF0ZWQgdmVyeSByZWNlbnRseSB0 byBtYXRjaAoKcy90b29scy9zY2hlbWEvCgo+ID4gICAgIHdoYXQgSSBhbSBkZXNjcmliaW5nIGFi b3ZlLCBzbyB0aGV5IHdpbGwgbGlrZWx5IHN0aWxsIHJlcG9ydAo+ID4gICAgIGVycm9ycyB1bnRp bCB2Ni4yLXJjMSwgc2VlOgo+ID4gICAgIGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xpbnV4LW10 ZC8yMDIyMTExNDA5MDMxNS44NDgyMDgtMS1taXF1ZWwucmF5bmFsQGJvb3RsaW4uY29tLwo+ID4g Cj4gPiBEb2VzIHRoaXMgc291bmQgcmVhc29uYWJsZT8gIAo+IAo+IFsuLi5dCgoKVGhhbmtzLApN aXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA837C47089 for ; Fri, 2 Dec 2022 15:00:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233612AbiLBPAo (ORCPT ); Fri, 2 Dec 2022 10:00:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229502AbiLBPAk (ORCPT ); Fri, 2 Dec 2022 10:00:40 -0500 Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A3ABE256B for ; Fri, 2 Dec 2022 07:00:37 -0800 (PST) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id B0F21100007; Fri, 2 Dec 2022 15:00:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1669993236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=59qSwgpaGJCpHjydTIqoo0IPT+OCfNv0dCYixP5EWqg=; b=TaAd/jd7DJaOECXA/cSb/SywJ7kSqgK5OydWuWmhvTIXhgKRyyxWmNG6YzOeT/M30zSuhc WaSxv3dOkKMXexw8SXTLM6GQ62JgFH4Dk0piZgv5otuzG1rxbAx62Hb7Id5E7/b1WySwjB llvxVcds2aETbx3Wqcih+KWrROrFLDc2cuVdGG6Oj8vaO333shCCokqqLGLgX5cBDCqOao +krQkRkGSRtUy+yQxAxeAGJDkMiOaJh3jKeyCbwHxZGAtan+cc+iGFxSvf9/aHp3mg0qVR RS3eZ5IImxAO+2GZR61FyfapFqnCJs+64n1FfLB2bpk9CRQk/3L6NTMvdw/o/A== Date: Fri, 2 Dec 2022 16:00:30 +0100 From: Miquel Raynal To: Marek Vasut Cc: Francesco Dolcini , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, Francesco Dolcini , Shawn Guo , linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, u-boot@lists.denx.de Subject: Re: [PATCH v1] mtd: parsers: ofpart: Fix parsing when size-cells is 0 Message-ID: <20221202160030.1b8d0b8a@xps-13> In-Reply-To: <2b6fc52d-60b9-d0f4-ab91-4cf7a8095999@denx.de> References: <20221202071900.1143950-1-francesco@dolcini.it> <20221202101418.6b4b3711@xps-13> <20221202115327.4475d3a2@xps-13> <20221202150556.14c5ae43@xps-13> <2b6fc52d-60b9-d0f4-ab91-4cf7a8095999@denx.de> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi Marek, marex@denx.de wrote on Fri, 2 Dec 2022 15:31:40 +0100: > On 12/2/22 15:05, Miquel Raynal wrote: > > Hi Francesco, =20 >=20 > Hi, >=20 > [...] >=20 > > I still strongly disagree with the initial proposal but what I think we > > can do is: > >=20 > > 1. To prevent future breakages: > > Fix fdt_fixup_mtdparts() in u-boot. This way newer U-Boot + any > > kernel should work. > >=20 > > 2. To help tracking down situations like that: > > Keep the warning in ofpart.c but continue to fail. > >=20 > > 3. To fix the current situation: > > Immediately revert commit (and prevent it from being backported): > > 753395ea1e45 ("ARM: dts: imx7: Fix NAND controller size-cells") > > This way your own boot flow is fixed in the short term. =20 >=20 > Here I disagree, the fix is correct and I think we shouldn't > proliferate incorrect DTs which don't match the binding document. I agree we should not proliferate incorrect DTs, so let's use a modern description then, with a controller and a child node which defines the chip. > Rather, if a bootloader generates incorrect (new) DT entries, I > believe the driver should implement a fixup and warn user about this. > PC does that as well with broken ACPI tables as far as I can tell. >=20 > I'm not convinced making a DT non-compliant with bindings again, I am sorry to say so, but while warnings reported by the tools should be fixed, it's not because the tool does not scream at you that the description is valid. We are actively working on enhancing the schema so that "all" improper descriptions get warnings (see the series pointed earlier), but in no way this change makes the node compliant with modern bindings. I'm not saying the fix is wrong, but let's be pragmatic, it currently leads to boot failures. > only to work around a problem induced by bootloader, is the right approach > here. When a patch breaks a board and there is no straight fix, you revert it, then you think harder. That's what I am saying. This is a temporary solution. > This would be setting a dangerous example, where anyone could request a D= T fix to be reverted because their random bootloader does the wrong thing a= nd with valid DT clean up, something broke. Please, you know this is not valid DT clean up. We've been decoupling controller and chip description since 2016. What I am proposing is a valid DT cleanup, not to the latest standard, but way closer than the current solution. > > 4. There is no reason to partially fix a DT like what the above did > > besides trying to avoid warnings emitted by the DT check tools. =20 >=20 > Note that the 3. does not partially fix the DT, it fixes the node fully. >=20 > > If > > complying with modern bindings is a goal (and I think it should > > be), then we can modernize this DT without breaking the boot flow: > > Instead of only setting #size-cell =3D <0>, you can as well define > > in your DT a subnode to define the NAND chip. NAND chips are not > > supposed to have #size-cells properties, but in the past they did, > > which means #address-cells and #size-cells are allowed (and marked > > deprecated in the schema). So in practice, the dt-schema will not > > warn you if they are there, which means you can still set > > #size-cell =3D <1>. =20 >=20 > I am really not convinced we should hack around this on the DT end and tr= y to push some sort of convoluted workaround there, "convoluted workaround" :-) > instead of fixing it on the driver side (and bootloader side, in the > long run). > > > Please mind, the tools have been updated very recently to match s/tools/schema/ > > what I am describing above, so they will likely still report > > errors until v6.2-rc1, see: > > https://lore.kernel.org/linux-mtd/20221114090315.848208-1-miquel.ra= ynal@bootlin.com/ > >=20 > > Does this sound reasonable? =20 >=20 > [...] Thanks, Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 098CAC47088 for ; Fri, 2 Dec 2022 15:01:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XhWD3UuQeYiZ7XKgP8kWVWYM6GitC5BU7V18zLx5nZo=; b=FwDwJaJAbaJdvB GF9gRDH+9kH2o79mkRXzxxeqJ3aFxnfJMDaY3jJk4NL78AZ2EVo7dWpW2LUtY7iGYXiv1pHPtEFPL oTsH0FDPfz+DyLEujxUKrBxGAXknFuTQew/dU+MGJWO/t6RTqYodv4I2SpLnmL1px+LUPmxp7NjkN UNCa8chtN0gNI1V8i4nOTS6TLhyFlBJN/r+poSJbkuLSDJPy1a/BLIqluZS/CTaUI8tohI53EaT8o hxhjax/OVAy9q8W+VW0Gxt4Ebh/QHCrvoUoZ6t83dRYkkW52oS8ARXaumUmH3fR63KwV0ZxevoFY+ ckEgJanhCSKxLqcKPocA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p17Wu-00GxIh-PE; Fri, 02 Dec 2022 15:00:44 +0000 Received: from relay11.mail.gandi.net ([2001:4b98:dc4:8::231]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p17Wq-00GxGf-IN; Fri, 02 Dec 2022 15:00:42 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id B0F21100007; Fri, 2 Dec 2022 15:00:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1669993236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=59qSwgpaGJCpHjydTIqoo0IPT+OCfNv0dCYixP5EWqg=; b=TaAd/jd7DJaOECXA/cSb/SywJ7kSqgK5OydWuWmhvTIXhgKRyyxWmNG6YzOeT/M30zSuhc WaSxv3dOkKMXexw8SXTLM6GQ62JgFH4Dk0piZgv5otuzG1rxbAx62Hb7Id5E7/b1WySwjB llvxVcds2aETbx3Wqcih+KWrROrFLDc2cuVdGG6Oj8vaO333shCCokqqLGLgX5cBDCqOao +krQkRkGSRtUy+yQxAxeAGJDkMiOaJh3jKeyCbwHxZGAtan+cc+iGFxSvf9/aHp3mg0qVR RS3eZ5IImxAO+2GZR61FyfapFqnCJs+64n1FfLB2bpk9CRQk/3L6NTMvdw/o/A== Date: Fri, 2 Dec 2022 16:00:30 +0100 From: Miquel Raynal To: Marek Vasut Cc: Francesco Dolcini , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, Francesco Dolcini , Shawn Guo , linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, u-boot@lists.denx.de Subject: Re: [PATCH v1] mtd: parsers: ofpart: Fix parsing when size-cells is 0 Message-ID: <20221202160030.1b8d0b8a@xps-13> In-Reply-To: <2b6fc52d-60b9-d0f4-ab91-4cf7a8095999@denx.de> References: <20221202071900.1143950-1-francesco@dolcini.it> <20221202101418.6b4b3711@xps-13> <20221202115327.4475d3a2@xps-13> <20221202150556.14c5ae43@xps-13> <2b6fc52d-60b9-d0f4-ab91-4cf7a8095999@denx.de> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221202_070040_952675_45648EE4 X-CRM114-Status: GOOD ( 35.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTWFyZWssCgptYXJleEBkZW54LmRlIHdyb3RlIG9uIEZyaSwgMiBEZWMgMjAyMiAxNTozMTo0 MCArMDEwMDoKCj4gT24gMTIvMi8yMiAxNTowNSwgTWlxdWVsIFJheW5hbCB3cm90ZToKPiA+IEhp IEZyYW5jZXNjbywgIAo+IAo+IEhpLAo+IAo+IFsuLi5dCj4gCj4gPiBJIHN0aWxsIHN0cm9uZ2x5 IGRpc2FncmVlIHdpdGggdGhlIGluaXRpYWwgcHJvcG9zYWwgYnV0IHdoYXQgSSB0aGluayB3ZQo+ ID4gY2FuIGRvIGlzOgo+ID4gCj4gPiAxLiBUbyBwcmV2ZW50IGZ1dHVyZSBicmVha2FnZXM6Cj4g PiAgICBGaXggZmR0X2ZpeHVwX210ZHBhcnRzKCkgaW4gdS1ib290LiBUaGlzIHdheSBuZXdlciBV LUJvb3QgKyBhbnkKPiA+ICAgIGtlcm5lbCBzaG91bGQgd29yay4KPiA+IAo+ID4gMi4gVG8gaGVs cCB0cmFja2luZyBkb3duIHNpdHVhdGlvbnMgbGlrZSB0aGF0Ogo+ID4gICAgS2VlcCB0aGUgd2Fy bmluZyBpbiBvZnBhcnQuYyBidXQgY29udGludWUgdG8gZmFpbC4KPiA+IAo+ID4gMy4gVG8gZml4 IHRoZSBjdXJyZW50IHNpdHVhdGlvbjoKPiA+ICAgICBJbW1lZGlhdGVseSByZXZlcnQgY29tbWl0 IChhbmQgcHJldmVudCBpdCBmcm9tIGJlaW5nIGJhY2twb3J0ZWQpOgo+ID4gICAgIDc1MzM5NWVh MWU0NSAoIkFSTTogZHRzOiBpbXg3OiBGaXggTkFORCBjb250cm9sbGVyIHNpemUtY2VsbHMiKQo+ ID4gICAgIFRoaXMgd2F5IHlvdXIgb3duIGJvb3QgZmxvdyBpcyBmaXhlZCBpbiB0aGUgc2hvcnQg dGVybS4gIAo+IAo+IEhlcmUgSSBkaXNhZ3JlZSwgdGhlIGZpeCBpcyBjb3JyZWN0IGFuZCBJIHRo aW5rIHdlIHNob3VsZG4ndAo+IHByb2xpZmVyYXRlIGluY29ycmVjdCBEVHMgd2hpY2ggZG9uJ3Qg bWF0Y2ggdGhlIGJpbmRpbmcgZG9jdW1lbnQuCgpJIGFncmVlIHdlIHNob3VsZCBub3QgcHJvbGlm ZXJhdGUgaW5jb3JyZWN0IERUcywgc28gbGV0J3MgdXNlIGEgbW9kZXJuCmRlc2NyaXB0aW9uIHRo ZW4sIHdpdGggYSBjb250cm9sbGVyIGFuZCBhIGNoaWxkIG5vZGUgd2hpY2ggZGVmaW5lcyB0aGUK Y2hpcC4KCj4gUmF0aGVyLCBpZiBhIGJvb3Rsb2FkZXIgZ2VuZXJhdGVzIGluY29ycmVjdCAobmV3 KSBEVCBlbnRyaWVzLCBJCj4gYmVsaWV2ZSB0aGUgZHJpdmVyIHNob3VsZCBpbXBsZW1lbnQgYSBm aXh1cCBhbmQgd2FybiB1c2VyIGFib3V0IHRoaXMuCj4gUEMgZG9lcyB0aGF0IGFzIHdlbGwgd2l0 aCBicm9rZW4gQUNQSSB0YWJsZXMgYXMgZmFyIGFzIEkgY2FuIHRlbGwuCj4gCj4gSSdtIG5vdCBj b252aW5jZWQgbWFraW5nIGEgRFQgbm9uLWNvbXBsaWFudCB3aXRoIGJpbmRpbmdzIGFnYWluLAoK SSBhbSBzb3JyeSB0byBzYXkgc28sIGJ1dCB3aGlsZSB3YXJuaW5ncyByZXBvcnRlZCBieSB0aGUg dG9vbHMKc2hvdWxkIGJlIGZpeGVkLCBpdCdzIG5vdCBiZWNhdXNlIHRoZSB0b29sIGRvZXMgbm90 IHNjcmVhbSBhdCB5b3UgdGhhdAp0aGUgZGVzY3JpcHRpb24gaXMgdmFsaWQuIFdlIGFyZSBhY3Rp dmVseSB3b3JraW5nIG9uIGVuaGFuY2luZyB0aGUKc2NoZW1hIHNvIHRoYXQgImFsbCIgaW1wcm9w ZXIgZGVzY3JpcHRpb25zIGdldCB3YXJuaW5ncyAoc2VlIHRoZSBzZXJpZXMKcG9pbnRlZCBlYXJs aWVyKSwgYnV0IGluIG5vIHdheSB0aGlzIGNoYW5nZSBtYWtlcyB0aGUgbm9kZSBjb21wbGlhbnQK d2l0aCBtb2Rlcm4gYmluZGluZ3MuCgpJJ20gbm90IHNheWluZyB0aGUgZml4IGlzIHdyb25nLCBi dXQgbGV0J3MgYmUgcHJhZ21hdGljLCBpdCBjdXJyZW50bHkKbGVhZHMgdG8gYm9vdCBmYWlsdXJl cy4KCj4gb25seSB0byB3b3JrIGFyb3VuZCBhIHByb2JsZW0gaW5kdWNlZCBieSBib290bG9hZGVy LCBpcyB0aGUgcmlnaHQgYXBwcm9hY2gKPiBoZXJlLgoKV2hlbiBhIHBhdGNoIGJyZWFrcyBhIGJv YXJkIGFuZCB0aGVyZSBpcyBubyBzdHJhaWdodCBmaXgsIHlvdSByZXZlcnQKaXQsIHRoZW4geW91 IHRoaW5rIGhhcmRlci4gVGhhdCdzIHdoYXQgSSBhbSBzYXlpbmcuIFRoaXMgaXMgYSB0ZW1wb3Jh cnkKc29sdXRpb24uCgo+IFRoaXMgd291bGQgYmUgc2V0dGluZyBhIGRhbmdlcm91cyBleGFtcGxl LCB3aGVyZSBhbnlvbmUgY291bGQgcmVxdWVzdCBhIERUIGZpeCB0byBiZSByZXZlcnRlZCBiZWNh dXNlIHRoZWlyIHJhbmRvbSBib290bG9hZGVyIGRvZXMgdGhlIHdyb25nIHRoaW5nIGFuZCB3aXRo IHZhbGlkIERUIGNsZWFuIHVwLCBzb21ldGhpbmcgYnJva2UuCgpQbGVhc2UsIHlvdSBrbm93IHRo aXMgaXMgbm90IHZhbGlkIERUIGNsZWFuIHVwLiBXZSd2ZSBiZWVuIGRlY291cGxpbmcKY29udHJv bGxlciBhbmQgY2hpcCBkZXNjcmlwdGlvbiBzaW5jZSAyMDE2LiBXaGF0IEkgYW0gcHJvcG9zaW5n IGlzIGEKdmFsaWQgRFQgY2xlYW51cCwgbm90IHRvIHRoZSBsYXRlc3Qgc3RhbmRhcmQsIGJ1dCB3 YXkgY2xvc2VyIHRoYW4gdGhlCmN1cnJlbnQgc29sdXRpb24uCgo+ID4gNC4gVGhlcmUgaXMgbm8g cmVhc29uIHRvIHBhcnRpYWxseSBmaXggYSBEVCBsaWtlIHdoYXQgdGhlIGFib3ZlIGRpZAo+ID4g ICAgIGJlc2lkZXMgdHJ5aW5nIHRvIGF2b2lkIHdhcm5pbmdzIGVtaXR0ZWQgYnkgdGhlIERUIGNo ZWNrIHRvb2xzLiAgCj4gCj4gTm90ZSB0aGF0IHRoZSAzLiBkb2VzIG5vdCBwYXJ0aWFsbHkgZml4 IHRoZSBEVCwgaXQgZml4ZXMgdGhlIG5vZGUgZnVsbHkuCj4gCj4gPiAgICAgSWYKPiA+ICAgICBj b21wbHlpbmcgd2l0aCBtb2Rlcm4gYmluZGluZ3MgaXMgYSBnb2FsIChhbmQgSSB0aGluayBpdCBz aG91bGQKPiA+ICAgICBiZSksIHRoZW4gd2UgY2FuIG1vZGVybml6ZSB0aGlzIERUIHdpdGhvdXQg YnJlYWtpbmcgdGhlIGJvb3QgZmxvdzoKPiA+ICAgICBJbnN0ZWFkIG9mIG9ubHkgc2V0dGluZyAj c2l6ZS1jZWxsID0gPDA+LCB5b3UgY2FuIGFzIHdlbGwgZGVmaW5lCj4gPiAgICAgaW4geW91ciBE VCBhIHN1Ym5vZGUgdG8gZGVmaW5lIHRoZSBOQU5EIGNoaXAuIE5BTkQgY2hpcHMgYXJlIG5vdAo+ ID4gICAgIHN1cHBvc2VkIHRvIGhhdmUgI3NpemUtY2VsbHMgcHJvcGVydGllcywgYnV0IGluIHRo ZSBwYXN0IHRoZXkgZGlkLAo+ID4gICAgIHdoaWNoIG1lYW5zICNhZGRyZXNzLWNlbGxzIGFuZCAj c2l6ZS1jZWxscyBhcmUgYWxsb3dlZCAoYW5kIG1hcmtlZAo+ID4gICAgIGRlcHJlY2F0ZWQgaW4g dGhlIHNjaGVtYSkuIFNvIGluIHByYWN0aWNlLCB0aGUgZHQtc2NoZW1hIHdpbGwgbm90Cj4gPiAg ICAgd2FybiB5b3UgaWYgdGhleSBhcmUgdGhlcmUsIHdoaWNoIG1lYW5zIHlvdSBjYW4gc3RpbGwg c2V0Cj4gPiAgICAgI3NpemUtY2VsbCA9IDwxPi4gIAo+IAo+IEkgYW0gcmVhbGx5IG5vdCBjb252 aW5jZWQgd2Ugc2hvdWxkIGhhY2sgYXJvdW5kIHRoaXMgb24gdGhlIERUIGVuZCBhbmQgdHJ5IHRv IHB1c2ggc29tZSBzb3J0IG9mIGNvbnZvbHV0ZWQgd29ya2Fyb3VuZCB0aGVyZSwKCiJjb252b2x1 dGVkIHdvcmthcm91bmQiIDotKQoKPiBpbnN0ZWFkIG9mIGZpeGluZyBpdCBvbiB0aGUgZHJpdmVy IHNpZGUgKGFuZCBib290bG9hZGVyIHNpZGUsIGluIHRoZQo+IGxvbmcgcnVuKS4KPgo+ID4gICAg IFBsZWFzZSBtaW5kLCB0aGUgdG9vbHMgaGF2ZSBiZWVuIHVwZGF0ZWQgdmVyeSByZWNlbnRseSB0 byBtYXRjaAoKcy90b29scy9zY2hlbWEvCgo+ID4gICAgIHdoYXQgSSBhbSBkZXNjcmliaW5nIGFi b3ZlLCBzbyB0aGV5IHdpbGwgbGlrZWx5IHN0aWxsIHJlcG9ydAo+ID4gICAgIGVycm9ycyB1bnRp bCB2Ni4yLXJjMSwgc2VlOgo+ID4gICAgIGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xpbnV4LW10 ZC8yMDIyMTExNDA5MDMxNS44NDgyMDgtMS1taXF1ZWwucmF5bmFsQGJvb3RsaW4uY29tLwo+ID4g Cj4gPiBEb2VzIHRoaXMgc291bmQgcmVhc29uYWJsZT8gIAo+IAo+IFsuLi5dCgoKVGhhbmtzLApN aXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg==