From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DEFCEC4321E for ; Fri, 2 Dec 2022 15:49:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HAV2R8iV0jtGG68qlb+f6bsGc9rG9QrXm70KrQHVXp4=; b=sXB0Q+em+QkcZV hxRBsfdjjheOMHMz1sFjGUzjOvlTBr1olZgzPbt5Nz738apw4ydhfcXTjO78P1E8Iq/mU3CV526x+ jnW9SSdTwCphXao8+aIbk7STpazTWX65mgZotNfshPt9bL8MB1FtEx9KY7LRY6jnOcVmM4K6yidgH CyQSzFW5Y0raiBpPUZY3Ip4bhZeFSEmQFyOxBoweN2gHkC9WfwOOJ4eyxP65PqVJJPTiFdlGdryRS YIplbtbAMcu7PrqqZvO4BQw9Z6w+DBTurN9pcAiv5/2R+fomtusOlImTjeyhpvNAlr5ZajNhUO9rt T+JOaw2+qJzjx34FjZhw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p18I4-00HAnD-J6; Fri, 02 Dec 2022 15:49:28 +0000 Received: from relay7-d.mail.gandi.net ([2001:4b98:dc4:8::227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p18Ht-00HAjJ-4I; Fri, 02 Dec 2022 15:49:19 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 9180D20015; Fri, 2 Dec 2022 15:49:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1669996151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DQFtCkqo0CS4WybTtvswvMI7R2OV7c6arm4hFMGtwQI=; b=IImA+1x5pxVbR5NTTmWENxTn4kQG0X1onXsn6BK3OlrolpzI61AkWVsXCdBWcOn231p5H7 buvzRoQP6f/FA1e6ieCdYgFNXdz4qS0vmkv/ZVuKuE9h1eaVZU29L9daKh+KTyoRslKBVJ pSB5kcocI7gYcRuRIoDKDjPYAM0SEczsUGfFUnCwa0jNCD8aYRiakpGlpyNCKmJ3hYZJzj B+S0hQWohVCAi8hh3IYbJU2tmGtCJTawKCQBEWplj9Q++eJkdVulhmlHOs16N7M3SM85zi ZDnkbIsL6tj5y8XE8NUvUvqeVfnlAuTDXUiaCgXdn1uUd+6p2kv3NHXjZiH8pw== Date: Fri, 2 Dec 2022 16:49:04 +0100 From: Miquel Raynal To: Marek Vasut Cc: Francesco Dolcini , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, Francesco Dolcini , Shawn Guo , linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, u-boot@lists.denx.de Subject: Re: [PATCH v1] mtd: parsers: ofpart: Fix parsing when size-cells is 0 Message-ID: <20221202164904.08d750df@xps-13> In-Reply-To: <223b7a4e-3aff-8070-7387-c77d2ded1dd6@denx.de> References: <20221202071900.1143950-1-francesco@dolcini.it> <20221202101418.6b4b3711@xps-13> <20221202115327.4475d3a2@xps-13> <20221202150556.14c5ae43@xps-13> <2b6fc52d-60b9-d0f4-ab91-4cf7a8095999@denx.de> <20221202160030.1b8d0b8a@xps-13> <223b7a4e-3aff-8070-7387-c77d2ded1dd6@denx.de> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221202_074917_509110_F7FF6926 X-CRM114-Status: GOOD ( 48.66 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgTWFyZWssCgptYXJleEBkZW54LmRlIHdyb3RlIG9uIEZyaSwgMiBEZWMgMjAyMiAxNjoyMzoy OSArMDEwMDoKCj4gT24gMTIvMi8yMiAxNjowMCwgTWlxdWVsIFJheW5hbCB3cm90ZToKPiA+IEhp IE1hcmVrLCAgCj4gCj4gSGksCj4gCj4gPiBtYXJleEBkZW54LmRlIHdyb3RlIG9uIEZyaSwgMiBE ZWMgMjAyMiAxNTozMTo0MCArMDEwMDoKPiA+ICAgCj4gPj4gT24gMTIvMi8yMiAxNTowNSwgTWlx dWVsIFJheW5hbCB3cm90ZTogIAo+ID4+PiBIaSBGcmFuY2VzY28sICAKPiA+Pgo+ID4+IEhpLAo+ ID4+Cj4gPj4gWy4uLl0KPiA+PiAgCj4gPj4+IEkgc3RpbGwgc3Ryb25nbHkgZGlzYWdyZWUgd2l0 aCB0aGUgaW5pdGlhbCBwcm9wb3NhbCBidXQgd2hhdCBJIHRoaW5rIHdlCj4gPj4+IGNhbiBkbyBp czoKPiA+Pj4KPiA+Pj4gMS4gVG8gcHJldmVudCBmdXR1cmUgYnJlYWthZ2VzOgo+ID4+PiAgICAg Rml4IGZkdF9maXh1cF9tdGRwYXJ0cygpIGluIHUtYm9vdC4gVGhpcyB3YXkgbmV3ZXIgVS1Cb290 ICsgYW55Cj4gPj4+ICAgICBrZXJuZWwgc2hvdWxkIHdvcmsuCj4gPj4+Cj4gPj4+IDIuIFRvIGhl bHAgdHJhY2tpbmcgZG93biBzaXR1YXRpb25zIGxpa2UgdGhhdDoKPiA+Pj4gICAgIEtlZXAgdGhl IHdhcm5pbmcgaW4gb2ZwYXJ0LmMgYnV0IGNvbnRpbnVlIHRvIGZhaWwuCj4gPj4+Cj4gPj4+IDMu IFRvIGZpeCB0aGUgY3VycmVudCBzaXR1YXRpb246Cj4gPj4+ICAgICAgSW1tZWRpYXRlbHkgcmV2 ZXJ0IGNvbW1pdCAoYW5kIHByZXZlbnQgaXQgZnJvbSBiZWluZyBiYWNrcG9ydGVkKToKPiA+Pj4g ICAgICA3NTMzOTVlYTFlNDUgKCJBUk06IGR0czogaW14NzogRml4IE5BTkQgY29udHJvbGxlciBz aXplLWNlbGxzIikKPiA+Pj4gICAgICBUaGlzIHdheSB5b3VyIG93biBib290IGZsb3cgaXMgZml4 ZWQgaW4gdGhlIHNob3J0IHRlcm0uICAKPiA+Pgo+ID4+IEhlcmUgSSBkaXNhZ3JlZSwgdGhlIGZp eCBpcyBjb3JyZWN0IGFuZCBJIHRoaW5rIHdlIHNob3VsZG4ndAo+ID4+IHByb2xpZmVyYXRlIGlu Y29ycmVjdCBEVHMgd2hpY2ggZG9uJ3QgbWF0Y2ggdGhlIGJpbmRpbmcgZG9jdW1lbnQuICAKPiA+ IAo+ID4gSSBhZ3JlZSB3ZSBzaG91bGQgbm90IHByb2xpZmVyYXRlIGluY29ycmVjdCBEVHMsIHNv IGxldCdzIHVzZSBhIG1vZGVybgo+ID4gZGVzY3JpcHRpb24gdGhlbiAgCj4gCj4gWWVzIHBsZWFz ZSAhCj4gCj4gPiAsIHdpdGggYSBjb250cm9sbGVyIGFuZCBhIGNoaWxkIG5vZGUgd2hpY2ggZGVm aW5lcyB0aGUKPiA+IGNoaXAuICAKPiAKPiBCdXQgd2hhdCBpZiB0aGVyZSBpcyBubyBjaGlwIGNv bm5lY3RlZCB0byB0aGUgY29udHJvbGxlciBub2RlID8KPiAKPiBJZiBJIHVuZGVyc3RhbmQgdGhl IHByb3Bvc2FsIGhlcmUgcmlnaHQgKHBsZWFzZSBjb3JyZWN0IG1lIGlmIEknbSB3cm9uZyksIHRo ZW46CgpHb29kIGlkZWEgdG8gc3VtbWFyaXplLgoKPiAKPiAxKSBUaGlzIGlzIHRoZSBvcmlnaW5h bCwgb2xkLCB3cm9uZyBiaW5kaW5nOgo+ICZncG1pIHsKPiAgICAjc2l6ZS1jZWxscyA9IDwxPjsK PiAgICAuLi4KPiAgICBwYXJ0aXRpb25ATiB7IC4uLiB9Owo+IH07CgpZZXMuCgo+IAo+IAo+IDIp IFRoaXMgaXMgdGhlIG5ld2VyLCBidXQgc3RpbGwgd3JvbmcgYmluZGluZzoKPiAmZ3BtaSB7Cj4g ICAgI3NpemUtY2VsbHMgPSA8MD47Cj4gICAgLi4uCj4gICAgcGFydGl0aW9ucyB7Cj4gICAgICBw YXJ0aXRpb25ATiB7IC4uLiB9Owo+ICAgIH07Cj4gfTsKCldlbGwsIHRoaXMgaXMgd3JvbmcgZGVz Y3JpcHRpb24sIGJ1dCBpdCB3b3VsZCB3b3JrIChmb3IgY29tcGF0IHJlYXNvbnMsCmV2ZW4gdGhv dWdoIEkgZG9uJ3QgdGhpbmsgdGhpcyBpcyBjb25zaWRlcmVkIHZhbGlkIERUIGJ5IHRoZSBzY2hl bWFzKS4KCj4gCj4gMykgVGhpcyBpcyB0aGUgbmV3ZXN0IGJpbmRpbmcsIHdoYXQgd2Ugd2FudDoK PiAmZ3BtaSB7Cj4gICAgI3NpemUtY2VsbHMgPSA8MD47Cj4gICAgLi4uCj4gICAgbmFuZC1jaGlw IHsKPiAgICAgIHBhcnRpdGlvbnMgewo+ICAgICAgICBwYXJ0aXRpb25ATiB7IC4uLiB9Owo+ICAg ICAgfTsKPiAgICB9Owo+IH07CgpZZXMKCj4gCj4gQnV0IGlmIHRoZXJlIGlzIG5vIHBoeXNpY2Fs IG5hbmQgY2hpcCBjb25uZWN0ZWQgdG8gdGhlIGNvbnRyb2xsZXIsIHdvdWxkIHdlIGVuZCB1cCB3 aXRoIGVtcHR5IG5hbmQtY2hpcCBub2RlIGluIERULCBsaWtlIHRoaXM/Cj4gJmdwbWkgewo+ICAg ICNzaXplLWNlbGxzID0gPFg+Owo+ICAgIC4uLgo+ICAgIG5hbmQtY2hpcCB7IC8qIGVtcHR5ICov IH07Cj4gfTsKCklzIHRoaXMgcmVhbGx5IGEgY29uY2Vybj8gSWYgdGhlcmUgaXMgbm8gTkFORCBj aGlwLCB0aGUgY29udHJvbGxlcgpzaG91bGQgYmUgZGlzYWJsZWQsIG5vPyBJIGd1ZXNzIHRlY2hu aWNhbGx5IHlvdSBjb3VsZCBldmVuIHVzZSB0aGUKc3RhdHVzIHByb3BlcnR5IGluIHRoZSBuYW5k LWNoaXAgbm9kZS4uLgoKSG93ZXZlciwgaXQgc2hvdWxkIG5vdCBiZSBlbXB0eSwgYXQgdGhlIHZl cnkgbGVhc3QgYSByZWcgcHJvcGVydHkKc2hvdWxkIGluZGljYXRlIG9uIHdoaWNoIENTIGl0IGlz IHdpcmVkLCBhcyBleHBlY3RlZCB0aGVyZToKaHR0cHM6Ly9naXQua2VybmVsLm9yZy9wdWIvc2Nt L2xpbnV4L2tlcm5lbC9naXQvbXRkL2xpbnV4LmdpdC90cmVlL0RvY3VtZW50YXRpb24vZGV2aWNl dHJlZS9iaW5kaW5ncy9tdGQvbmFuZC1jaGlwLnlhbWw/aD1tdGQvbmV4dAoKQnV0LCBhcyBuYW5k LWNoaXAueWFtbCByZWZlcmVuY2VzIG10ZC55YW1sLCB5b3UgY2FuIGFzIHdlbGwgdXNlCndoYXRl dmVyIGlzIGRlc2NyaWJlZCBoZXJlOgpodHRwczovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGlu dXgva2VybmVsL2dpdC9tdGQvbGludXguZ2l0L3RyZWUvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVl L2JpbmRpbmdzL210ZC9tdGQueWFtbD9oPW10ZC9uZXh0Cgo+IFdoYXQgd291bGQgYmUgdGhlIGdw bWkgY29udHJvbGxlciBzaXplIGNlbGxzIChYKSBpbiB0aGF0IGNhc2UsIHN0aWxsIDAsIHJpZ2h0 ID8gU28gaG93IGRvZXMgdGhhdCBoZWxwIHNvbHZlIHRoaXMgcHJvYmxlbSwgd291bGRuJ3QgVS1C b290IHN0aWxsIHBvcHVsYXRlIHRoZSBwYXJ0aXRpb25zIGRpcmVjdGx5IHVuZGVyIHRoZSBncG1p IG5vZGUgb3IgaW50byBwYXJ0aXRpb25zIHN1Yi1ub2RlID8KClRoZSBjb21taXQgdGhhdCB3YXMg cG9pbnRlZCBpbiB0aGUgb3JpZ2luYWwgZml4IGNsZWFybHkgc3RhdGVkIHRoYXQgdGhlCk5BTkQg Y2hpcCBub2RlIHdhcyB0YXJnZXRlZCwgbm90IHRoZSBOQU5EIGNvbnRyb2xsZXIgbm9kZS4gSSBo b3BlIHRoaXMKaXMgY29ycmVjdGx5IHN1cHBvcnRlZCBpbiBVLUJvb3QgdGhvdWdoLiBTbyBpZiB0 aGVyZSBpcyBhIE5BTkQgY2hpcApzdWJub2RlLCBJIHN1cHBvc2UgVS1Cb290IHdvdWxkIHRyeSB0 byBjcmVhdGUgdGhlIHBhcnRpdGlvbnMgdGhhdCBhcmUKaW5zaWRlLCBvciBldmVuIGluIHRoZSBz dWIgInBhcnRpdGlvbnMiIGNvbnRhaW5lci4KCj4gPj4gUmF0aGVyLCBpZiBhIGJvb3Rsb2FkZXIg Z2VuZXJhdGVzIGluY29ycmVjdCAobmV3KSBEVCBlbnRyaWVzLCBJCj4gPj4gYmVsaWV2ZSB0aGUg ZHJpdmVyIHNob3VsZCBpbXBsZW1lbnQgYSBmaXh1cCBhbmQgd2FybiB1c2VyIGFib3V0IHRoaXMu Cj4gPj4gUEMgZG9lcyB0aGF0IGFzIHdlbGwgd2l0aCBicm9rZW4gQUNQSSB0YWJsZXMgYXMgZmFy IGFzIEkgY2FuIHRlbGwuCj4gPj4KPiA+PiBJJ20gbm90IGNvbnZpbmNlZCBtYWtpbmcgYSBEVCBu b24tY29tcGxpYW50IHdpdGggYmluZGluZ3MgYWdhaW4sICAKPiA+IAo+ID4gSSBhbSBzb3JyeSB0 byBzYXkgc28sIGJ1dCB3aGlsZSB3YXJuaW5ncyByZXBvcnRlZCBieSB0aGUgdG9vbHMKPiA+IHNo b3VsZCBiZSBmaXhlZCwgaXQncyBub3QgYmVjYXVzZSB0aGUgdG9vbCBkb2VzIG5vdCBzY3JlYW0g YXQgeW91IHRoYXQKPiA+IHRoZSBkZXNjcmlwdGlvbiBpcyB2YWxpZC4gV2UgYXJlIGFjdGl2ZWx5 IHdvcmtpbmcgb24gZW5oYW5jaW5nIHRoZQo+ID4gc2NoZW1hIHNvIHRoYXQgImFsbCIgaW1wcm9w ZXIgZGVzY3JpcHRpb25zIGdldCB3YXJuaW5ncyAoc2VlIHRoZSBzZXJpZXMKPiA+IHBvaW50ZWQg ZWFybGllciksIGJ1dCBpbiBubyB3YXkgdGhpcyBjaGFuZ2UgbWFrZXMgdGhlIG5vZGUgY29tcGxp YW50Cj4gPiB3aXRoIG1vZGVybiBiaW5kaW5ncy4KPiA+IAo+ID4gSSdtIG5vdCBzYXlpbmcgdGhl IGZpeCBpcyB3cm9uZywgYnV0IGxldCdzIGJlIHByYWdtYXRpYywgaXQgY3VycmVudGx5Cj4gPiBs ZWFkcyB0byBib290IGZhaWx1cmVzLiAgCj4gCj4gSSBmdWxseSBhZ3JlZSB0aGF0IHdlIGRvIGhh dmUgYSBwcm9ibGVtLCBhbmQgdGhhdCBpdCB0cmlja2xlZCBpbnRvIHN0YWJsZSBtYWtlcyBpdCBl dmVuIHdvcnNlLiBNYXliZSBJIGRvbid0IGZ1bGx5IHVuZGVyc3RhbmQgdGhlIHRoaW5nIHdpdGgg bmFuZC1jaGlwIHByb3Bvc2FsLCBzZWUgbXkgcXVlc3Rpb24gYWJvdmUsIGVzcC4gdGhlIGxhc3Qg cGFydC4KPiAKPiA+PiBvbmx5IHRvIHdvcmsgYXJvdW5kIGEgcHJvYmxlbSBpbmR1Y2VkIGJ5IGJv b3Rsb2FkZXIsIGlzIHRoZSByaWdodCBhcHByb2FjaAo+ID4+IGhlcmUuICAKPiA+IAo+ID4gV2hl biBhIHBhdGNoIGJyZWFrcyBhIGJvYXJkIGFuZCB0aGVyZSBpcyBubyBzdHJhaWdodCBmaXgsIHlv dSByZXZlcnQKPiA+IGl0LCB0aGVuIHlvdSB0aGluayBoYXJkZXIuIFRoYXQncyB3aGF0IEkgYW0g c2F5aW5nLiBUaGlzIGlzIGEgdGVtcG9yYXJ5Cj4gPiBzb2x1dGlvbi4gIAo+IAo+IElzbid0IHRo aXMgcGF0Y2ggdGhlIHN0cmFpZ2h0IGZpeCwgYXQgbGVhc3QgdW50aWwgdGhlIGJvb3Rsb2FkZXIg Y2FuIGJlIHVwZGF0ZWQgdG8gZ2VuZXJhdGUgdGhlIG5hbmQtY2hpcCBub2RlIGNvcnJlY3RseSA/ Cj4gCj4gPj4gVGhpcyB3b3VsZCBiZSBzZXR0aW5nIGEgZGFuZ2Vyb3VzIGV4YW1wbGUsIHdoZXJl IGFueW9uZSBjb3VsZCByZXF1ZXN0IGEgRFQgZml4IHRvIGJlIHJldmVydGVkIGJlY2F1c2UgdGhl aXIgcmFuZG9tIGJvb3Rsb2FkZXIgZG9lcyB0aGUgd3JvbmcgdGhpbmcgYW5kIHdpdGggdmFsaWQg RFQgY2xlYW4gdXAsIHNvbWV0aGluZyBicm9rZS4gIAo+ID4gCj4gPiBQbGVhc2UsIHlvdSBrbm93 IHRoaXMgaXMgbm90IHZhbGlkIERUIGNsZWFuIHVwLiBXZSd2ZSBiZWVuIGRlY291cGxpbmcKPiA+ IGNvbnRyb2xsZXIgYW5kIGNoaXAgZGVzY3JpcHRpb24gc2luY2UgMjAxNi4gV2hhdCBJIGFtIHBy b3Bvc2luZyBpcyBhCj4gPiB2YWxpZCBEVCBjbGVhbnVwLCBub3QgdG8gdGhlIGxhdGVzdCBzdGFu ZGFyZCwgYnV0IHdheSBjbG9zZXIgdGhhbiB0aGUKPiA+IGN1cnJlbnQgc29sdXRpb24uICAKPiAK PiBJIHRoaW5rIEkgcmVhbGx5IG5lZWQgb25lIG1vcmUgZXhwbGFuYXRpb24gb2YgdGhlIG5hbmQt Y2hpcCBwYXJ0IGFib3ZlLgoKSSBob3BlIHRoaW5ncyBhcmUgY2xlYXJlciBub3cuCgpUaGFua3Ms Ck1pcXXDqGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpMaW51eCBNVEQgZGlzY3Vzc2lvbiBtYWlsaW5nIGxpc3QKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49934C4321E for ; Fri, 2 Dec 2022 15:49:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232678AbiLBPtQ (ORCPT ); Fri, 2 Dec 2022 10:49:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232517AbiLBPtP (ORCPT ); Fri, 2 Dec 2022 10:49:15 -0500 X-Greylist: delayed 17737 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 02 Dec 2022 07:49:12 PST Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5F56AD33F for ; Fri, 2 Dec 2022 07:49:12 -0800 (PST) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 9180D20015; Fri, 2 Dec 2022 15:49:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1669996151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DQFtCkqo0CS4WybTtvswvMI7R2OV7c6arm4hFMGtwQI=; b=IImA+1x5pxVbR5NTTmWENxTn4kQG0X1onXsn6BK3OlrolpzI61AkWVsXCdBWcOn231p5H7 buvzRoQP6f/FA1e6ieCdYgFNXdz4qS0vmkv/ZVuKuE9h1eaVZU29L9daKh+KTyoRslKBVJ pSB5kcocI7gYcRuRIoDKDjPYAM0SEczsUGfFUnCwa0jNCD8aYRiakpGlpyNCKmJ3hYZJzj B+S0hQWohVCAi8hh3IYbJU2tmGtCJTawKCQBEWplj9Q++eJkdVulhmlHOs16N7M3SM85zi ZDnkbIsL6tj5y8XE8NUvUvqeVfnlAuTDXUiaCgXdn1uUd+6p2kv3NHXjZiH8pw== Date: Fri, 2 Dec 2022 16:49:04 +0100 From: Miquel Raynal To: Marek Vasut Cc: Francesco Dolcini , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, Francesco Dolcini , Shawn Guo , linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, u-boot@lists.denx.de Subject: Re: [PATCH v1] mtd: parsers: ofpart: Fix parsing when size-cells is 0 Message-ID: <20221202164904.08d750df@xps-13> In-Reply-To: <223b7a4e-3aff-8070-7387-c77d2ded1dd6@denx.de> References: <20221202071900.1143950-1-francesco@dolcini.it> <20221202101418.6b4b3711@xps-13> <20221202115327.4475d3a2@xps-13> <20221202150556.14c5ae43@xps-13> <2b6fc52d-60b9-d0f4-ab91-4cf7a8095999@denx.de> <20221202160030.1b8d0b8a@xps-13> <223b7a4e-3aff-8070-7387-c77d2ded1dd6@denx.de> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi Marek, marex@denx.de wrote on Fri, 2 Dec 2022 16:23:29 +0100: > On 12/2/22 16:00, Miquel Raynal wrote: > > Hi Marek, =20 >=20 > Hi, >=20 > > marex@denx.de wrote on Fri, 2 Dec 2022 15:31:40 +0100: > > =20 > >> On 12/2/22 15:05, Miquel Raynal wrote: =20 > >>> Hi Francesco, =20 > >> > >> Hi, > >> > >> [...] > >> =20 > >>> I still strongly disagree with the initial proposal but what I think = we > >>> can do is: > >>> > >>> 1. To prevent future breakages: > >>> Fix fdt_fixup_mtdparts() in u-boot. This way newer U-Boot + any > >>> kernel should work. > >>> > >>> 2. To help tracking down situations like that: > >>> Keep the warning in ofpart.c but continue to fail. > >>> > >>> 3. To fix the current situation: > >>> Immediately revert commit (and prevent it from being backported): > >>> 753395ea1e45 ("ARM: dts: imx7: Fix NAND controller size-cells") > >>> This way your own boot flow is fixed in the short term. =20 > >> > >> Here I disagree, the fix is correct and I think we shouldn't > >> proliferate incorrect DTs which don't match the binding document. =20 > >=20 > > I agree we should not proliferate incorrect DTs, so let's use a modern > > description then =20 >=20 > Yes please ! >=20 > > , with a controller and a child node which defines the > > chip. =20 >=20 > But what if there is no chip connected to the controller node ? >=20 > If I understand the proposal here right (please correct me if I'm wrong),= then: Good idea to summarize. >=20 > 1) This is the original, old, wrong binding: > &gpmi { > #size-cells =3D <1>; > ... > partition@N { ... }; > }; Yes. >=20 >=20 > 2) This is the newer, but still wrong binding: > &gpmi { > #size-cells =3D <0>; > ... > partitions { > partition@N { ... }; > }; > }; Well, this is wrong description, but it would work (for compat reasons, even though I don't think this is considered valid DT by the schemas). >=20 > 3) This is the newest binding, what we want: > &gpmi { > #size-cells =3D <0>; > ... > nand-chip { > partitions { > partition@N { ... }; > }; > }; > }; Yes >=20 > But if there is no physical nand chip connected to the controller, would = we end up with empty nand-chip node in DT, like this? > &gpmi { > #size-cells =3D ; > ... > nand-chip { /* empty */ }; > }; Is this really a concern? If there is no NAND chip, the controller should be disabled, no? I guess technically you could even use the status property in the nand-chip node... However, it should not be empty, at the very least a reg property should indicate on which CS it is wired, as expected there: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/tree/Document= ation/devicetree/bindings/mtd/nand-chip.yaml?h=3Dmtd/next But, as nand-chip.yaml references mtd.yaml, you can as well use whatever is described here: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/tree/Document= ation/devicetree/bindings/mtd/mtd.yaml?h=3Dmtd/next > What would be the gpmi controller size cells (X) in that case, still 0, r= ight ? So how does that help solve this problem, wouldn't U-Boot still popu= late the partitions directly under the gpmi node or into partitions sub-nod= e ? The commit that was pointed in the original fix clearly stated that the NAND chip node was targeted, not the NAND controller node. I hope this is correctly supported in U-Boot though. So if there is a NAND chip subnode, I suppose U-Boot would try to create the partitions that are inside, or even in the sub "partitions" container. > >> Rather, if a bootloader generates incorrect (new) DT entries, I > >> believe the driver should implement a fixup and warn user about this. > >> PC does that as well with broken ACPI tables as far as I can tell. > >> > >> I'm not convinced making a DT non-compliant with bindings again, =20 > >=20 > > I am sorry to say so, but while warnings reported by the tools > > should be fixed, it's not because the tool does not scream at you that > > the description is valid. We are actively working on enhancing the > > schema so that "all" improper descriptions get warnings (see the series > > pointed earlier), but in no way this change makes the node compliant > > with modern bindings. > >=20 > > I'm not saying the fix is wrong, but let's be pragmatic, it currently > > leads to boot failures. =20 >=20 > I fully agree that we do have a problem, and that it trickled into stable= makes it even worse. Maybe I don't fully understand the thing with nand-ch= ip proposal, see my question above, esp. the last part. >=20 > >> only to work around a problem induced by bootloader, is the right appr= oach > >> here. =20 > >=20 > > When a patch breaks a board and there is no straight fix, you revert > > it, then you think harder. That's what I am saying. This is a temporary > > solution. =20 >=20 > Isn't this patch the straight fix, at least until the bootloader can be u= pdated to generate the nand-chip node correctly ? >=20 > >> This would be setting a dangerous example, where anyone could request = a DT fix to be reverted because their random bootloader does the wrong thin= g and with valid DT clean up, something broke. =20 > >=20 > > Please, you know this is not valid DT clean up. We've been decoupling > > controller and chip description since 2016. What I am proposing is a > > valid DT cleanup, not to the latest standard, but way closer than the > > current solution. =20 >=20 > I think I really need one more explanation of the nand-chip part above. I hope things are clearer now. Thanks, Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F423C4321E for ; Fri, 2 Dec 2022 15:50:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wk/z5sPisXmqrDenCKeGK/oHoiutpe1C7PuowjHVEFM=; b=yL/cTwYN3ssRhn Rl/UPt3krQUIzPURv1irkT9rhbedaeuNi7mlPdzZVewmiiPXsDTItv1GcvcE0kHG4UuJo3CQApkbz 4HZ000tGXnSO9STVjsFUQkSnVi5oDr2T26kWebtVa/lac7nYKxS/iRnW60o9xqU1ssVWT8nUbe9Yu A6IJzXSzUqj1bQEjsksAOwp+gpnFP8jAdGHyVsf0kxFJ+QBLy0sDGTLWLbAqMrNRbuIQbGWfU/P/1 1qzlk26Zwithg3QjB+JJWjkor9qAAuFbQS8oSlab9Ynx+xiwvPWn3XTZ9GQ7XeNb6+cfre5L+vzsn j12tJM4FQdwi9oDyUgiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p18Hw-00HAlh-MG; Fri, 02 Dec 2022 15:49:20 +0000 Received: from relay7-d.mail.gandi.net ([2001:4b98:dc4:8::227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p18Ht-00HAjJ-4I; Fri, 02 Dec 2022 15:49:19 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 9180D20015; Fri, 2 Dec 2022 15:49:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1669996151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DQFtCkqo0CS4WybTtvswvMI7R2OV7c6arm4hFMGtwQI=; b=IImA+1x5pxVbR5NTTmWENxTn4kQG0X1onXsn6BK3OlrolpzI61AkWVsXCdBWcOn231p5H7 buvzRoQP6f/FA1e6ieCdYgFNXdz4qS0vmkv/ZVuKuE9h1eaVZU29L9daKh+KTyoRslKBVJ pSB5kcocI7gYcRuRIoDKDjPYAM0SEczsUGfFUnCwa0jNCD8aYRiakpGlpyNCKmJ3hYZJzj B+S0hQWohVCAi8hh3IYbJU2tmGtCJTawKCQBEWplj9Q++eJkdVulhmlHOs16N7M3SM85zi ZDnkbIsL6tj5y8XE8NUvUvqeVfnlAuTDXUiaCgXdn1uUd+6p2kv3NHXjZiH8pw== Date: Fri, 2 Dec 2022 16:49:04 +0100 From: Miquel Raynal To: Marek Vasut Cc: Francesco Dolcini , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, Francesco Dolcini , Shawn Guo , linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, u-boot@lists.denx.de Subject: Re: [PATCH v1] mtd: parsers: ofpart: Fix parsing when size-cells is 0 Message-ID: <20221202164904.08d750df@xps-13> In-Reply-To: <223b7a4e-3aff-8070-7387-c77d2ded1dd6@denx.de> References: <20221202071900.1143950-1-francesco@dolcini.it> <20221202101418.6b4b3711@xps-13> <20221202115327.4475d3a2@xps-13> <20221202150556.14c5ae43@xps-13> <2b6fc52d-60b9-d0f4-ab91-4cf7a8095999@denx.de> <20221202160030.1b8d0b8a@xps-13> <223b7a4e-3aff-8070-7387-c77d2ded1dd6@denx.de> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221202_074917_509110_F7FF6926 X-CRM114-Status: GOOD ( 48.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTWFyZWssCgptYXJleEBkZW54LmRlIHdyb3RlIG9uIEZyaSwgMiBEZWMgMjAyMiAxNjoyMzoy OSArMDEwMDoKCj4gT24gMTIvMi8yMiAxNjowMCwgTWlxdWVsIFJheW5hbCB3cm90ZToKPiA+IEhp IE1hcmVrLCAgCj4gCj4gSGksCj4gCj4gPiBtYXJleEBkZW54LmRlIHdyb3RlIG9uIEZyaSwgMiBE ZWMgMjAyMiAxNTozMTo0MCArMDEwMDoKPiA+ICAgCj4gPj4gT24gMTIvMi8yMiAxNTowNSwgTWlx dWVsIFJheW5hbCB3cm90ZTogIAo+ID4+PiBIaSBGcmFuY2VzY28sICAKPiA+Pgo+ID4+IEhpLAo+ ID4+Cj4gPj4gWy4uLl0KPiA+PiAgCj4gPj4+IEkgc3RpbGwgc3Ryb25nbHkgZGlzYWdyZWUgd2l0 aCB0aGUgaW5pdGlhbCBwcm9wb3NhbCBidXQgd2hhdCBJIHRoaW5rIHdlCj4gPj4+IGNhbiBkbyBp czoKPiA+Pj4KPiA+Pj4gMS4gVG8gcHJldmVudCBmdXR1cmUgYnJlYWthZ2VzOgo+ID4+PiAgICAg Rml4IGZkdF9maXh1cF9tdGRwYXJ0cygpIGluIHUtYm9vdC4gVGhpcyB3YXkgbmV3ZXIgVS1Cb290 ICsgYW55Cj4gPj4+ICAgICBrZXJuZWwgc2hvdWxkIHdvcmsuCj4gPj4+Cj4gPj4+IDIuIFRvIGhl bHAgdHJhY2tpbmcgZG93biBzaXR1YXRpb25zIGxpa2UgdGhhdDoKPiA+Pj4gICAgIEtlZXAgdGhl IHdhcm5pbmcgaW4gb2ZwYXJ0LmMgYnV0IGNvbnRpbnVlIHRvIGZhaWwuCj4gPj4+Cj4gPj4+IDMu IFRvIGZpeCB0aGUgY3VycmVudCBzaXR1YXRpb246Cj4gPj4+ICAgICAgSW1tZWRpYXRlbHkgcmV2 ZXJ0IGNvbW1pdCAoYW5kIHByZXZlbnQgaXQgZnJvbSBiZWluZyBiYWNrcG9ydGVkKToKPiA+Pj4g ICAgICA3NTMzOTVlYTFlNDUgKCJBUk06IGR0czogaW14NzogRml4IE5BTkQgY29udHJvbGxlciBz aXplLWNlbGxzIikKPiA+Pj4gICAgICBUaGlzIHdheSB5b3VyIG93biBib290IGZsb3cgaXMgZml4 ZWQgaW4gdGhlIHNob3J0IHRlcm0uICAKPiA+Pgo+ID4+IEhlcmUgSSBkaXNhZ3JlZSwgdGhlIGZp eCBpcyBjb3JyZWN0IGFuZCBJIHRoaW5rIHdlIHNob3VsZG4ndAo+ID4+IHByb2xpZmVyYXRlIGlu Y29ycmVjdCBEVHMgd2hpY2ggZG9uJ3QgbWF0Y2ggdGhlIGJpbmRpbmcgZG9jdW1lbnQuICAKPiA+ IAo+ID4gSSBhZ3JlZSB3ZSBzaG91bGQgbm90IHByb2xpZmVyYXRlIGluY29ycmVjdCBEVHMsIHNv IGxldCdzIHVzZSBhIG1vZGVybgo+ID4gZGVzY3JpcHRpb24gdGhlbiAgCj4gCj4gWWVzIHBsZWFz ZSAhCj4gCj4gPiAsIHdpdGggYSBjb250cm9sbGVyIGFuZCBhIGNoaWxkIG5vZGUgd2hpY2ggZGVm aW5lcyB0aGUKPiA+IGNoaXAuICAKPiAKPiBCdXQgd2hhdCBpZiB0aGVyZSBpcyBubyBjaGlwIGNv bm5lY3RlZCB0byB0aGUgY29udHJvbGxlciBub2RlID8KPiAKPiBJZiBJIHVuZGVyc3RhbmQgdGhl IHByb3Bvc2FsIGhlcmUgcmlnaHQgKHBsZWFzZSBjb3JyZWN0IG1lIGlmIEknbSB3cm9uZyksIHRo ZW46CgpHb29kIGlkZWEgdG8gc3VtbWFyaXplLgoKPiAKPiAxKSBUaGlzIGlzIHRoZSBvcmlnaW5h bCwgb2xkLCB3cm9uZyBiaW5kaW5nOgo+ICZncG1pIHsKPiAgICAjc2l6ZS1jZWxscyA9IDwxPjsK PiAgICAuLi4KPiAgICBwYXJ0aXRpb25ATiB7IC4uLiB9Owo+IH07CgpZZXMuCgo+IAo+IAo+IDIp IFRoaXMgaXMgdGhlIG5ld2VyLCBidXQgc3RpbGwgd3JvbmcgYmluZGluZzoKPiAmZ3BtaSB7Cj4g ICAgI3NpemUtY2VsbHMgPSA8MD47Cj4gICAgLi4uCj4gICAgcGFydGl0aW9ucyB7Cj4gICAgICBw YXJ0aXRpb25ATiB7IC4uLiB9Owo+ICAgIH07Cj4gfTsKCldlbGwsIHRoaXMgaXMgd3JvbmcgZGVz Y3JpcHRpb24sIGJ1dCBpdCB3b3VsZCB3b3JrIChmb3IgY29tcGF0IHJlYXNvbnMsCmV2ZW4gdGhv dWdoIEkgZG9uJ3QgdGhpbmsgdGhpcyBpcyBjb25zaWRlcmVkIHZhbGlkIERUIGJ5IHRoZSBzY2hl bWFzKS4KCj4gCj4gMykgVGhpcyBpcyB0aGUgbmV3ZXN0IGJpbmRpbmcsIHdoYXQgd2Ugd2FudDoK PiAmZ3BtaSB7Cj4gICAgI3NpemUtY2VsbHMgPSA8MD47Cj4gICAgLi4uCj4gICAgbmFuZC1jaGlw IHsKPiAgICAgIHBhcnRpdGlvbnMgewo+ICAgICAgICBwYXJ0aXRpb25ATiB7IC4uLiB9Owo+ICAg ICAgfTsKPiAgICB9Owo+IH07CgpZZXMKCj4gCj4gQnV0IGlmIHRoZXJlIGlzIG5vIHBoeXNpY2Fs IG5hbmQgY2hpcCBjb25uZWN0ZWQgdG8gdGhlIGNvbnRyb2xsZXIsIHdvdWxkIHdlIGVuZCB1cCB3 aXRoIGVtcHR5IG5hbmQtY2hpcCBub2RlIGluIERULCBsaWtlIHRoaXM/Cj4gJmdwbWkgewo+ICAg ICNzaXplLWNlbGxzID0gPFg+Owo+ICAgIC4uLgo+ICAgIG5hbmQtY2hpcCB7IC8qIGVtcHR5ICov IH07Cj4gfTsKCklzIHRoaXMgcmVhbGx5IGEgY29uY2Vybj8gSWYgdGhlcmUgaXMgbm8gTkFORCBj aGlwLCB0aGUgY29udHJvbGxlcgpzaG91bGQgYmUgZGlzYWJsZWQsIG5vPyBJIGd1ZXNzIHRlY2hu aWNhbGx5IHlvdSBjb3VsZCBldmVuIHVzZSB0aGUKc3RhdHVzIHByb3BlcnR5IGluIHRoZSBuYW5k LWNoaXAgbm9kZS4uLgoKSG93ZXZlciwgaXQgc2hvdWxkIG5vdCBiZSBlbXB0eSwgYXQgdGhlIHZl cnkgbGVhc3QgYSByZWcgcHJvcGVydHkKc2hvdWxkIGluZGljYXRlIG9uIHdoaWNoIENTIGl0IGlz IHdpcmVkLCBhcyBleHBlY3RlZCB0aGVyZToKaHR0cHM6Ly9naXQua2VybmVsLm9yZy9wdWIvc2Nt L2xpbnV4L2tlcm5lbC9naXQvbXRkL2xpbnV4LmdpdC90cmVlL0RvY3VtZW50YXRpb24vZGV2aWNl dHJlZS9iaW5kaW5ncy9tdGQvbmFuZC1jaGlwLnlhbWw/aD1tdGQvbmV4dAoKQnV0LCBhcyBuYW5k LWNoaXAueWFtbCByZWZlcmVuY2VzIG10ZC55YW1sLCB5b3UgY2FuIGFzIHdlbGwgdXNlCndoYXRl dmVyIGlzIGRlc2NyaWJlZCBoZXJlOgpodHRwczovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGlu dXgva2VybmVsL2dpdC9tdGQvbGludXguZ2l0L3RyZWUvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVl L2JpbmRpbmdzL210ZC9tdGQueWFtbD9oPW10ZC9uZXh0Cgo+IFdoYXQgd291bGQgYmUgdGhlIGdw bWkgY29udHJvbGxlciBzaXplIGNlbGxzIChYKSBpbiB0aGF0IGNhc2UsIHN0aWxsIDAsIHJpZ2h0 ID8gU28gaG93IGRvZXMgdGhhdCBoZWxwIHNvbHZlIHRoaXMgcHJvYmxlbSwgd291bGRuJ3QgVS1C b290IHN0aWxsIHBvcHVsYXRlIHRoZSBwYXJ0aXRpb25zIGRpcmVjdGx5IHVuZGVyIHRoZSBncG1p IG5vZGUgb3IgaW50byBwYXJ0aXRpb25zIHN1Yi1ub2RlID8KClRoZSBjb21taXQgdGhhdCB3YXMg cG9pbnRlZCBpbiB0aGUgb3JpZ2luYWwgZml4IGNsZWFybHkgc3RhdGVkIHRoYXQgdGhlCk5BTkQg Y2hpcCBub2RlIHdhcyB0YXJnZXRlZCwgbm90IHRoZSBOQU5EIGNvbnRyb2xsZXIgbm9kZS4gSSBo b3BlIHRoaXMKaXMgY29ycmVjdGx5IHN1cHBvcnRlZCBpbiBVLUJvb3QgdGhvdWdoLiBTbyBpZiB0 aGVyZSBpcyBhIE5BTkQgY2hpcApzdWJub2RlLCBJIHN1cHBvc2UgVS1Cb290IHdvdWxkIHRyeSB0 byBjcmVhdGUgdGhlIHBhcnRpdGlvbnMgdGhhdCBhcmUKaW5zaWRlLCBvciBldmVuIGluIHRoZSBz dWIgInBhcnRpdGlvbnMiIGNvbnRhaW5lci4KCj4gPj4gUmF0aGVyLCBpZiBhIGJvb3Rsb2FkZXIg Z2VuZXJhdGVzIGluY29ycmVjdCAobmV3KSBEVCBlbnRyaWVzLCBJCj4gPj4gYmVsaWV2ZSB0aGUg ZHJpdmVyIHNob3VsZCBpbXBsZW1lbnQgYSBmaXh1cCBhbmQgd2FybiB1c2VyIGFib3V0IHRoaXMu Cj4gPj4gUEMgZG9lcyB0aGF0IGFzIHdlbGwgd2l0aCBicm9rZW4gQUNQSSB0YWJsZXMgYXMgZmFy IGFzIEkgY2FuIHRlbGwuCj4gPj4KPiA+PiBJJ20gbm90IGNvbnZpbmNlZCBtYWtpbmcgYSBEVCBu b24tY29tcGxpYW50IHdpdGggYmluZGluZ3MgYWdhaW4sICAKPiA+IAo+ID4gSSBhbSBzb3JyeSB0 byBzYXkgc28sIGJ1dCB3aGlsZSB3YXJuaW5ncyByZXBvcnRlZCBieSB0aGUgdG9vbHMKPiA+IHNo b3VsZCBiZSBmaXhlZCwgaXQncyBub3QgYmVjYXVzZSB0aGUgdG9vbCBkb2VzIG5vdCBzY3JlYW0g YXQgeW91IHRoYXQKPiA+IHRoZSBkZXNjcmlwdGlvbiBpcyB2YWxpZC4gV2UgYXJlIGFjdGl2ZWx5 IHdvcmtpbmcgb24gZW5oYW5jaW5nIHRoZQo+ID4gc2NoZW1hIHNvIHRoYXQgImFsbCIgaW1wcm9w ZXIgZGVzY3JpcHRpb25zIGdldCB3YXJuaW5ncyAoc2VlIHRoZSBzZXJpZXMKPiA+IHBvaW50ZWQg ZWFybGllciksIGJ1dCBpbiBubyB3YXkgdGhpcyBjaGFuZ2UgbWFrZXMgdGhlIG5vZGUgY29tcGxp YW50Cj4gPiB3aXRoIG1vZGVybiBiaW5kaW5ncy4KPiA+IAo+ID4gSSdtIG5vdCBzYXlpbmcgdGhl IGZpeCBpcyB3cm9uZywgYnV0IGxldCdzIGJlIHByYWdtYXRpYywgaXQgY3VycmVudGx5Cj4gPiBs ZWFkcyB0byBib290IGZhaWx1cmVzLiAgCj4gCj4gSSBmdWxseSBhZ3JlZSB0aGF0IHdlIGRvIGhh dmUgYSBwcm9ibGVtLCBhbmQgdGhhdCBpdCB0cmlja2xlZCBpbnRvIHN0YWJsZSBtYWtlcyBpdCBl dmVuIHdvcnNlLiBNYXliZSBJIGRvbid0IGZ1bGx5IHVuZGVyc3RhbmQgdGhlIHRoaW5nIHdpdGgg bmFuZC1jaGlwIHByb3Bvc2FsLCBzZWUgbXkgcXVlc3Rpb24gYWJvdmUsIGVzcC4gdGhlIGxhc3Qg cGFydC4KPiAKPiA+PiBvbmx5IHRvIHdvcmsgYXJvdW5kIGEgcHJvYmxlbSBpbmR1Y2VkIGJ5IGJv b3Rsb2FkZXIsIGlzIHRoZSByaWdodCBhcHByb2FjaAo+ID4+IGhlcmUuICAKPiA+IAo+ID4gV2hl biBhIHBhdGNoIGJyZWFrcyBhIGJvYXJkIGFuZCB0aGVyZSBpcyBubyBzdHJhaWdodCBmaXgsIHlv dSByZXZlcnQKPiA+IGl0LCB0aGVuIHlvdSB0aGluayBoYXJkZXIuIFRoYXQncyB3aGF0IEkgYW0g c2F5aW5nLiBUaGlzIGlzIGEgdGVtcG9yYXJ5Cj4gPiBzb2x1dGlvbi4gIAo+IAo+IElzbid0IHRo aXMgcGF0Y2ggdGhlIHN0cmFpZ2h0IGZpeCwgYXQgbGVhc3QgdW50aWwgdGhlIGJvb3Rsb2FkZXIg Y2FuIGJlIHVwZGF0ZWQgdG8gZ2VuZXJhdGUgdGhlIG5hbmQtY2hpcCBub2RlIGNvcnJlY3RseSA/ Cj4gCj4gPj4gVGhpcyB3b3VsZCBiZSBzZXR0aW5nIGEgZGFuZ2Vyb3VzIGV4YW1wbGUsIHdoZXJl IGFueW9uZSBjb3VsZCByZXF1ZXN0IGEgRFQgZml4IHRvIGJlIHJldmVydGVkIGJlY2F1c2UgdGhl aXIgcmFuZG9tIGJvb3Rsb2FkZXIgZG9lcyB0aGUgd3JvbmcgdGhpbmcgYW5kIHdpdGggdmFsaWQg RFQgY2xlYW4gdXAsIHNvbWV0aGluZyBicm9rZS4gIAo+ID4gCj4gPiBQbGVhc2UsIHlvdSBrbm93 IHRoaXMgaXMgbm90IHZhbGlkIERUIGNsZWFuIHVwLiBXZSd2ZSBiZWVuIGRlY291cGxpbmcKPiA+ IGNvbnRyb2xsZXIgYW5kIGNoaXAgZGVzY3JpcHRpb24gc2luY2UgMjAxNi4gV2hhdCBJIGFtIHBy b3Bvc2luZyBpcyBhCj4gPiB2YWxpZCBEVCBjbGVhbnVwLCBub3QgdG8gdGhlIGxhdGVzdCBzdGFu ZGFyZCwgYnV0IHdheSBjbG9zZXIgdGhhbiB0aGUKPiA+IGN1cnJlbnQgc29sdXRpb24uICAKPiAK PiBJIHRoaW5rIEkgcmVhbGx5IG5lZWQgb25lIG1vcmUgZXhwbGFuYXRpb24gb2YgdGhlIG5hbmQt Y2hpcCBwYXJ0IGFib3ZlLgoKSSBob3BlIHRoaW5ncyBhcmUgY2xlYXJlciBub3cuCgpUaGFua3Ms Ck1pcXXDqGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK