From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22885C47088 for ; Sat, 3 Dec 2022 00:23:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234590AbiLCAXz convert rfc822-to-8bit (ORCPT ); Fri, 2 Dec 2022 19:23:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229657AbiLCAXy (ORCPT ); Fri, 2 Dec 2022 19:23:54 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9B01787CA0; Fri, 2 Dec 2022 16:23:53 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0A96323A; Fri, 2 Dec 2022 16:24:00 -0800 (PST) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 817DF3F73B; Fri, 2 Dec 2022 16:23:51 -0800 (PST) Date: Sat, 3 Dec 2022 00:22:05 +0000 From: Andre Przywara To: Samuel Holland Cc: Chen-Yu Tsai , Jernej Skrabec , Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Philipp Zabel , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, =?UTF-8?B?QW5kcsOhcyBTemVtesWR?= Subject: Re: [PATCH 4/5] clk: sunxi-ng: d1: Mark cpux clock as critical Message-ID: <20221203002205.0f97d3bf@slackpad.lan> In-Reply-To: <20221126191319.6404-5-samuel@sholland.org> References: <20221126191319.6404-1-samuel@sholland.org> <20221126191319.6404-5-samuel@sholland.org> Organization: Arm Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Sat, 26 Nov 2022 13:13:18 -0600 Samuel Holland wrote: > From: András Szemző > > Some SoCs in the D1 family feature ARM CPUs instead of a RISC-V CPU. > In that case, the CPUs are driven from the 'cpux' clock, so it needs > to be marked as critical. Yes, my board hangs without that patch somewhere into the boot, and this patch fixes it. Can you also explain in the commit message why this is needed? IIRC the CPU node itself does not "consume" the clock, this would only be done by DVFS code? And it might be worth noting that we do this for every other Allwinner SoC as well. > Signed-off-by: András Szemző > Signed-off-by: Samuel Holland Reviewed-by: Andre Przywara Cheers, Andre > --- > > drivers/clk/sunxi-ng/ccu-sun20i-d1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/sunxi-ng/ccu-sun20i-d1.c b/drivers/clk/sunxi-ng/ccu-sun20i-d1.c > index 8ef3cdeb7962..c5a7df93602c 100644 > --- a/drivers/clk/sunxi-ng/ccu-sun20i-d1.c > +++ b/drivers/clk/sunxi-ng/ccu-sun20i-d1.c > @@ -240,7 +240,7 @@ static const struct clk_parent_data cpux_parents[] = { > { .hw = &pll_periph0_800M_clk.common.hw }, > }; > static SUNXI_CCU_MUX_DATA(cpux_clk, "cpux", cpux_parents, > - 0x500, 24, 3, CLK_SET_RATE_PARENT); > + 0x500, 24, 3, CLK_SET_RATE_PARENT | CLK_IS_CRITICAL); > > static const struct clk_hw *cpux_hws[] = { &cpux_clk.common.hw }; > static SUNXI_CCU_M_HWS(cpux_axi_clk, "cpux-axi", From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9AD01C4321E for ; Sat, 3 Dec 2022 00:24:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EbFUFRHpn/shFCJuAJk12D3mqHuIHREL+jjCTHD8r6I=; b=LNhRywzUHG0AdR lw8Ry0IStug8fBPE6Hhaud65vBZFNY39wty7YpAjKgKIJ1O+JDmPfjTYh4nD1j3HjNWpTrNV4JTvo czPEOfJIAVoUnishoxa2o8VQaxWH9WUa6sdSYVk94iIdqIpvq7W4OAsOJTSU03yxpl2q1L4URIkXJ YM0NwSrmcHYwCy3Cw52ZGox2ngA1/DNrpdg7UD8bK+5c8U5XeBnUFbT8kaVpWEJ1hMiwnZHRMk7ya y4BajtIblBR69qwksDzzwuBOjhJtxWB4+12LzOqzHVigCbXT0M9k64PcOJz/40kvhuLtCXP24J8Wq 6MbA0GVgvAMK0xwmli6Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p1GJz-001nSG-9s; Sat, 03 Dec 2022 00:23:59 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p1GJw-001nRE-9r for linux-arm-kernel@lists.infradead.org; Sat, 03 Dec 2022 00:23:57 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0A96323A; Fri, 2 Dec 2022 16:24:00 -0800 (PST) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 817DF3F73B; Fri, 2 Dec 2022 16:23:51 -0800 (PST) Date: Sat, 3 Dec 2022 00:22:05 +0000 From: Andre Przywara To: Samuel Holland Cc: Chen-Yu Tsai , Jernej Skrabec , Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Philipp Zabel , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, =?UTF-8?B?QW5kcsOhcyBTemVtesWR?= Subject: Re: [PATCH 4/5] clk: sunxi-ng: d1: Mark cpux clock as critical Message-ID: <20221203002205.0f97d3bf@slackpad.lan> In-Reply-To: <20221126191319.6404-5-samuel@sholland.org> References: <20221126191319.6404-1-samuel@sholland.org> <20221126191319.6404-5-samuel@sholland.org> Organization: Arm Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221202_162356_407037_222F0DB2 X-CRM114-Status: GOOD ( 19.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU2F0LCAyNiBOb3YgMjAyMiAxMzoxMzoxOCAtMDYwMApTYW11ZWwgSG9sbGFuZCA8c2FtdWVs QHNob2xsYW5kLm9yZz4gd3JvdGU6Cgo+IEZyb206IEFuZHLDoXMgU3plbXrFkSA8c3plbXpvLmFu ZHJhc0BnbWFpbC5jb20+Cj4gCj4gU29tZSBTb0NzIGluIHRoZSBEMSBmYW1pbHkgZmVhdHVyZSBB Uk0gQ1BVcyBpbnN0ZWFkIG9mIGEgUklTQy1WIENQVS4KPiBJbiB0aGF0IGNhc2UsIHRoZSBDUFVz IGFyZSBkcml2ZW4gZnJvbSB0aGUgJ2NwdXgnIGNsb2NrLCBzbyBpdCBuZWVkcwo+IHRvIGJlIG1h cmtlZCBhcyBjcml0aWNhbC4KClllcywgbXkgYm9hcmQgaGFuZ3Mgd2l0aG91dCB0aGF0IHBhdGNo IHNvbWV3aGVyZSBpbnRvIHRoZSBib290LCBhbmQKdGhpcyBwYXRjaCBmaXhlcyBpdC4KCkNhbiB5 b3UgYWxzbyBleHBsYWluIGluIHRoZSBjb21taXQgbWVzc2FnZSB3aHkgdGhpcyBpcyBuZWVkZWQ/ IElJUkMKdGhlIENQVSBub2RlIGl0c2VsZiBkb2VzIG5vdCAiY29uc3VtZSIgdGhlIGNsb2NrLCB0 aGlzIHdvdWxkIG9ubHkgYmUKZG9uZSBieSBEVkZTIGNvZGU/CkFuZCBpdCBtaWdodCBiZSB3b3J0 aCBub3RpbmcgdGhhdCB3ZSBkbyB0aGlzIGZvciBldmVyeSBvdGhlcgpBbGx3aW5uZXIgU29DIGFz IHdlbGwuCgo+IFNpZ25lZC1vZmYtYnk6IEFuZHLDoXMgU3plbXrFkSA8c3plbXpvLmFuZHJhc0Bn bWFpbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogU2FtdWVsIEhvbGxhbmQgPHNhbXVlbEBzaG9sbGFu ZC5vcmc+CgpSZXZpZXdlZC1ieTogQW5kcmUgUHJ6eXdhcmEgPGFuZHJlLnByenl3YXJhQGFybS5j b20+CgpDaGVlcnMsCkFuZHJlCgo+IC0tLQo+IAo+ICBkcml2ZXJzL2Nsay9zdW54aS1uZy9jY3Ut c3VuMjBpLWQxLmMgfCAyICstCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBk ZWxldGlvbigtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2Nsay9zdW54aS1uZy9jY3Utc3Vu MjBpLWQxLmMgYi9kcml2ZXJzL2Nsay9zdW54aS1uZy9jY3Utc3VuMjBpLWQxLmMKPiBpbmRleCA4 ZWYzY2RlYjc5NjIuLmM1YTdkZjkzNjAyYyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2Nsay9zdW54 aS1uZy9jY3Utc3VuMjBpLWQxLmMKPiArKysgYi9kcml2ZXJzL2Nsay9zdW54aS1uZy9jY3Utc3Vu MjBpLWQxLmMKPiBAQCAtMjQwLDcgKzI0MCw3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgY2xrX3Bh cmVudF9kYXRhIGNwdXhfcGFyZW50c1tdID0gewo+ICAJeyAuaHcgPSAmcGxsX3BlcmlwaDBfODAw TV9jbGsuY29tbW9uLmh3IH0sCj4gIH07Cj4gIHN0YXRpYyBTVU5YSV9DQ1VfTVVYX0RBVEEoY3B1 eF9jbGssICJjcHV4IiwgY3B1eF9wYXJlbnRzLAo+IC0JCQkgIDB4NTAwLCAyNCwgMywgQ0xLX1NF VF9SQVRFX1BBUkVOVCk7Cj4gKwkJCSAgMHg1MDAsIDI0LCAzLCBDTEtfU0VUX1JBVEVfUEFSRU5U IHwgQ0xLX0lTX0NSSVRJQ0FMKTsKPiAgCj4gIHN0YXRpYyBjb25zdCBzdHJ1Y3QgY2xrX2h3ICpj cHV4X2h3c1tdID0geyAmY3B1eF9jbGsuY29tbW9uLmh3IH07Cj4gIHN0YXRpYyBTVU5YSV9DQ1Vf TV9IV1MoY3B1eF9heGlfY2xrLCAiY3B1eC1heGkiLAoKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0Cmxp bnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK