From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B54CC4321E for ; Sun, 4 Dec 2022 17:09:53 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2D4E6855BC; Sun, 4 Dec 2022 18:09:51 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="b6IVW2Qk"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4A1698562E; Sun, 4 Dec 2022 18:09:49 +0100 (CET) Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 57952854AB for ; Sun, 4 Dec 2022 18:09:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-ed1-x531.google.com with SMTP id z92so12876854ede.1 for ; Sun, 04 Dec 2022 09:09:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pkFHypOI5AVn2a2W61rd82f+hj/ZeYptIwj6QiYRS/s=; b=b6IVW2QkzJ4wUvht4xPLl/+Xb0PF0MCzugbrOs/Os+swDwztmSfTc5eZjIkYCz3hdQ PRoQSS0h/iyzyIWqz7d/0R9AvI+hkFoaRY4oRSrz6NyAi5AViXMtkjNQbR42LA9fU0aM CbS2AuKQ2w8lp8q0/xTU06b0VI3t8SAzPtQj0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pkFHypOI5AVn2a2W61rd82f+hj/ZeYptIwj6QiYRS/s=; b=lozOr7YWG17aoO5vVv4HmITEnsrDZPS2wHAaxCDtSm4jOfVszs7fXpcmpLINF9wfBw MJ7QBJbS8KpdMNh6jhOS+PxANlfIRatR79ScjZTycekLBZB6CR9D53VTuPs8BKltJTuW 4nu88t/WYAKbJU7B3M7wsU876ByUmdlOFSbXwP4gc0JicYjtSGt7lKaavcQ29MOMmsCl 3A0pi4y6d80rjtGtIuieD5y4DroeOlRPNTISWqSR2AEhAclUx2+2pqJNsD2YSA0wGVjx x6svwenfoJ+ed9txKj1rg6ll9gQ6aSMlsT4chnD5958lrKtOsQlnCD0iqWa1+fbd9xMe HajQ== X-Gm-Message-State: ANoB5pkknmFGO+qSu9nLJHI0r5v641t92igRQ0/Bf+Kd9yf6ztQnbfSV IK3in+Kk4J2MgGMKK7n/gqIqkedQRVE6V8pC X-Google-Smtp-Source: AA0mqf53qXkT23coN40SX1ID+E4iFAOHrRzTEuuoFtAKD2wgMC6rt2sXHH/5X+c8DJNBxwuRiF5GvA== X-Received: by 2002:a05:6402:1f09:b0:462:6a0c:cfa with SMTP id b9-20020a0564021f0900b004626a0c0cfamr34164139edb.349.1670173785668; Sun, 04 Dec 2022 09:09:45 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-61c7-2644-b62d-0af3.res6.spectrum.com. [2603:6081:7b00:6400:61c7:2644:b62d:af3]) by smtp.gmail.com with ESMTPSA id h11-20020a056402094b00b004589da5e5cesm3285271edz.41.2022.12.04.09.09.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Dec 2022 09:09:45 -0800 (PST) Date: Sun, 4 Dec 2022 12:09:41 -0500 From: Tom Rini To: u-boot@lists.denx.de Subject: Re: [PATCH 144/149] CI: Replace unmigrated symbol test with non-Kconfig introduction test Message-ID: <20221204170941.GN3787616@bill-the-cat> References: <20221202214251.3027264-41-trini@konsulko.com> <20221204151420.56851-1-trini@konsulko.com> <20221204151420.56851-54-trini@konsulko.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="a/RL+Md+4nRpYrpt" Content-Disposition: inline In-Reply-To: <20221204151420.56851-54-trini@konsulko.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --a/RL+Md+4nRpYrpt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Dec 04, 2022 at 10:14:15AM -0500, Tom Rini wrote: > Now that all symbols have been migrated to Kconfig, or are part of the > CFG namespace we do not need a complex check for unmigrated CONFIG > symbols. Any instance of #define (or #undef) or a CONFIG value is wrong, > so cause CI to fail. >=20 > This test is not as strict as possible yet as we have more symbols that > were not previously caught to deal with. >=20 > Signed-off-by: Tom Rini At this point in the series, I want to make a few comments. First, before applying, there are some recent other series I'll be taking, such as the one to convert keymile platforms, which makes some of the patches here irrelevant. Second, and as implied by the last few patches in this series, the regex pattern here finds more symbols, some of which we can ignore. For example, the final form of this test will just ignore arch/*/dts/ as CONFIG symbols defined there are coming in from Linux and not our concern. And include/linux/kconfig.h defines CONFIG_IS_ENABLED, etc, so also valid defines. But there's a lot of oddball defines out there, which I intend to deal with. Starting with symbols which do NOT follow the pattern of '#defineSPACECONFIG_...' just because there's only a few of them, and dealing with those manually makes scripting something in the form of "for every symbol, is there a non-define usage of it" should get rid of many of them, as unused code. The hopefully follow up to that is usage in code that should be removed anyhow as it's never enabled (and not something like an RTC driver that should be enabled for sandbox as it's otherwise up to date). Third, this is still a big milestone. Everything in the big list of symbols has been handled and tooling is in place to catch re-introductions. I want to thank everyone for their hard work getting us here. --=20 Tom --a/RL+Md+4nRpYrpt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmOM1FIACgkQFHw5/5Y0 tyyK7Qv/THCHLGayN8LeZdS666/92FmzWyd8zb9tC+xoUCD6cCFi1uTOJSfY8M4r FUGOJ2qDmqVF9NoCGxmB9pcij9YmwTm/xpIHOyfMjghCoEa9K17sDLrsgb7FPG7C wakbtD8SY559q7Zo48rLXz6A3HaUDdFFodyv+1Xl4FUzDROcC74hY0WhmT6dRFjV MmRJZDhDnGvLT78iQGFvoaVQ/EaBiIvk77UFHyT5dVP3TjAOf2Wa2MLZQko9P9wc kegtGhrVvoAj8zARPic9bLepzcr9KMzBsljhz2JW9F7TsdD9w40SK/MTJru0oMhg jjof3/3S2OlCKVhwd7g0Hht/UqJpvvZr/QeSnXmFrO5fkdYxnCDkvlL37b255pQx 6Wse1JTtFYKF9tDITuGtTPUFQrFHO3AP3NtlpZ2BJX9TlKWPBJO4F/mLsgjtzeRn 7+Ib5P3zqCZU0UhCWHRI/mKrFmVlhdZ+U+pAxyDJ2NiwWUn4+zivg62DQknESuAY r1dPD0UU =tTEd -----END PGP SIGNATURE----- --a/RL+Md+4nRpYrpt--