Re: [meta-ti][dunfell][PATCH] optee: update optee-client, optee-test, optee-examples to 3.19 tag

[Denys Dmytriyenko <denis@denix.org>]

On Sat, Dec 03, 2022 at 11:04:00AM -0600, Ryan Eatmon wrote:
> 
> 
> On 12/3/2022 9:48, Denys Dmytriyenko wrote:
> >On Fri, Dec 02, 2022 at 08:04:52PM -0600, Ryan Eatmon via lists.yoctoproject.org wrote:
> >>
> >>
> >>On 12/2/2022 4:04, Manorit Chawdhry wrote:
> >>>optee-os was updated to 3.19 tag but the others were still outdated.
> >>>
> >>>Updates other optee components to 3.19 tag
> >>>
> >>>Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
> >>>---
> >>>  recipes-security/optee/optee-client_%.bbappend   | 4 ++--
> >>>  recipes-security/optee/optee-examples_%.bbappend | 4 ++--
> >>>  recipes-security/optee/optee-test_%.bbappend     | 4 ++--
> >>>  3 files changed, 6 insertions(+), 6 deletions(-)
> >>>
> >>>diff --git a/recipes-security/optee/optee-client_%.bbappend b/recipes-security/optee/optee-client_%.bbappend
> >>>index 5675570a..6737ba92 100644
> >>>--- a/recipes-security/optee/optee-client_%.bbappend
> >>>+++ b/recipes-security/optee/optee-client_%.bbappend
> >>>@@ -1,2 +1,2 @@
> >>>-PV_ti-soc = "3.17.0+git${SRCPV}"
> >>>-SRCREV_ti-soc = "a5c30b1277466a9bf85b62f45a6b00e79774e29c"
> >>>+PV_ti-soc = "3.19.0+git${SRCPV}"
> >>>+SRCREV_ti-soc = "140bf463046071d3ca5ebbde3fb21ee0854e1951"
> >>
> >>optee-client will not build against this SRCREV.  They added a call
> >>to pkg-config which is not readily available to the recipe without a
> >>change to your patch.
> >>
> >>You need to add:
> >>
> >>DEPENDS += "pkgconfig"
> >
> >You probably don't want a target pkgconfig, but a native one.
> >Do this instead:
> >
> >inherit pkgconfig
> 
> Actually, I thought that at first too and tried all variations of
> the native (inherit, depends, hosttools, etc...).  The only thing
> that actually made it work was the above.
> 
> In this case, pkg-config is not being called from configure, but
> from the Makefile.  The Makefile is trying to make sure that libuuid
> is installed for the target.  And the native would only make sure it
> is installed on the native side, where as pkgconfig for target looks
> in all of the places for the target library.  At least that was my
> understanding in reading online docs about it.
> 
> But depending on pkgconfig (for target) actually fixed the compile
> issue.  If you want to verify that or disprove it I would be most
> appreciative.  I spent a few hours banging my head on this one.

Looks like you've done your research - it's a bit strange use of pkgconfig 
by optee-client, not a basic normal use case I was referring to.

If the Makefile is trying to check if libuuid is installed, don't you need to 
also have it the DEPENDS?

And we'll see how meta-arm/master handles it soon enough, when updating to 
3.19 upstream...

-- 
Denys