From: shravan kumar <shravan.chippa@microchip.com>
To: <paul.j.murphy@intel.com>, <daniele.alessandrelli@intel.com>,
<mchehab@kernel.org>
Cc: <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Shravan Chippa" <shravan.chippa@microchip.com>,
Sakari Ailus <sakari.ailus@iki.fi>
Subject: [PATCH v6 5/5] media: i2c: imx334: update pixel and link frequency
Date: Mon, 5 Dec 2022 10:49:37 +0530 [thread overview]
Message-ID: <20221205051937.3897001-7-shravan.chippa@microchip.com> (raw)
In-Reply-To: <20221205051937.3897001-1-shravan.chippa@microchip.com>
From: Shravan Chippa <shravan.chippa@microchip.com>
Update pixel_rate and link frequency for 1920x1080@30
while changing mode.
Add dummy ctrl cases for pixel_rate and link frequency
to avoid error while changing the modes dynamically
Suggested-by: Sakari Ailus <sakari.ailus@iki.fi>
Signed-off-by: Shravan Chippa <shravan.chippa@microchip.com>
---
drivers/media/i2c/imx334.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c
index d5b566085da9..64ed77c4258c 100644
--- a/drivers/media/i2c/imx334.c
+++ b/drivers/media/i2c/imx334.c
@@ -50,6 +50,7 @@
/* CSI2 HW configuration */
#define IMX334_LINK_FREQ 1782000000
+#define IMX334_LINK_FREQ_891M 891000000
#define IMX334_NUM_DATA_LANES 4
#define IMX334_REG_MIN 0x00
@@ -145,6 +146,7 @@ struct imx334 {
static const s64 link_freq[] = {
IMX334_LINK_FREQ,
+ IMX334_LINK_FREQ_891M,
};
/* Sensor mode registers */
@@ -468,7 +470,7 @@ static const struct imx334_mode supported_modes[] = {
.vblank_min = 90,
.vblank_max = 132840,
.pclk = 74250000,
- .link_freq_idx = 0,
+ .link_freq_idx = 1,
.reg_list = {
.num_of_regs = ARRAY_SIZE(mode_1920x1080_regs),
.regs = mode_1920x1080_regs,
@@ -598,6 +600,11 @@ static int imx334_update_controls(struct imx334 *imx334,
if (ret)
return ret;
+ ret = __v4l2_ctrl_modify_range(imx334->pclk_ctrl, mode->pclk,
+ mode->pclk, 1, mode->pclk);
+ if (ret)
+ return ret;
+
ret = __v4l2_ctrl_modify_range(imx334->hblank_ctrl, mode->hblank,
mode->hblank, 1, mode->hblank);
if (ret)
@@ -698,6 +705,8 @@ static int imx334_set_ctrl(struct v4l2_ctrl *ctrl)
pm_runtime_put(imx334->dev);
break;
+ case V4L2_CID_PIXEL_RATE:
+ case V4L2_CID_LINK_FREQ:
case V4L2_CID_HBLANK:
ret = 0;
break;
--
2.34.1
next prev parent reply other threads:[~2022-12-05 5:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 5:19 [PATCH v6 0/5] media: i2c: imx334: support lower bandwidth mode shravan kumar
2022-12-05 5:19 ` [PATCH v6 1/5] media: i2c: imx334: modify link frequency as for the configureation shravan kumar
2022-12-05 5:19 ` [PATCH v6 2/5] media: i2c: imx334: replace __v4l2_ctrl_s_ctrl to __v4l2_ctrl_modify_range shravan kumar
2022-12-05 5:19 ` [PATCH v6 3/5] media: i2c: imx334: add missing reset values for mode 3840x2160_regs[] shravan kumar
2022-12-05 5:19 ` [PATCH v6 3/5] media: i2c: imx334: add missing reset values for mode_3840x2160_regs[] shravan kumar
2022-12-05 5:19 ` [PATCH v6 4/5] media: i2c: imx334: support lower bandwidth mode shravan kumar
2022-12-05 9:11 ` kernel test robot
2022-12-05 12:38 ` kernel test robot
2022-12-05 5:19 ` shravan kumar [this message]
2022-12-12 11:31 ` [PATCH v6 0/5] " shravan kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221205051937.3897001-7-shravan.chippa@microchip.com \
--to=shravan.chippa@microchip.com \
--cc=daniele.alessandrelli@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=paul.j.murphy@intel.com \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.