From: Stephen Hemminger <stephen@networkplumber.org>
To: <Daniel.Machon@microchip.com>
Cc: <netdev@vger.kernel.org>, <dsahern@kernel.org>,
<petrm@nvidia.com>, <maxime.chevallier@bootlin.com>,
<vladimir.oltean@nxp.com>, <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH iproute2-next v3 1/2] dcb: add new pcp-prio parameter to dcb app
Date: Mon, 5 Dec 2022 08:23:05 -0800 [thread overview]
Message-ID: <20221205082305.51964674@hermes.local> (raw)
In-Reply-To: <Y426Pzdw5341RbCP@DEN-LT-70577>
On Mon, 5 Dec 2022 09:19:06 +0000
<Daniel.Machon@microchip.com> wrote:
> > > Trying to understand your comment.
> > >
> > > Are you talking about not producing any JSON output with the symbolic
> > > PCP values? eg. ["1de", 1] -> [8, 1]. So basically print with PRINT_FP
> > > in case of printing in JSON context?
> > >
> > > /Daniel
> >
> > What does output look like in json and non-json versions?
>
> non-JSON: pcp-prio 1de:1
> JSON : {"pcp_prio":[["1de",1]]}
Would the JSON be better as:
{ "pcp_prio" :[ { "1de":1 } ] }
It looks like the PCP values are both unique and used in a name/value manner.
>
> > My concern that the json version would be awkward and have colons in it, but looks
> > like it won't.
>
> Yeah, the "%s:" format is only used in non-JSON context, so we are good
> here.
>
> >
> > For the unknown key type is printing error necessary? Maybe just show it in numeric form.
>
> No not necessary, I'll get rid of it.
next prev parent reply other threads:[~2022-12-05 16:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 9:22 [PATCH iproute2-next v3 0/2] Add pcp-prio and new apptrust subcommand Daniel Machon
2022-12-02 9:22 ` [PATCH iproute2-next v3 1/2] dcb: add new pcp-prio parameter to dcb app Daniel Machon
2022-12-03 17:00 ` Stephen Hemminger
2022-12-04 22:27 ` Daniel.Machon
2022-12-05 1:52 ` Stephen Hemminger
2022-12-05 9:19 ` Daniel.Machon
2022-12-05 16:23 ` Stephen Hemminger [this message]
2022-12-05 19:19 ` Daniel.Machon
2022-12-05 21:05 ` Stephen Hemminger
2022-12-06 8:55 ` Petr Machata
2022-12-02 9:22 ` [PATCH iproute2-next v3 2/2] dcb: add new subcommand for apptrust Daniel Machon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221205082305.51964674@hermes.local \
--to=stephen@networkplumber.org \
--cc=Daniel.Machon@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=dsahern@kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=petrm@nvidia.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.