From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jason Gunthorpe <jgg@ziepe.ca>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Matthew Wilcox <willy@infradead.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: [PATCH v2 1/4] container_of: add container_of_const() that preserves const-ness of the pointer
Date: Mon, 5 Dec 2022 13:12:03 +0100 [thread overview]
Message-ID: <20221205121206.166576-1-gregkh@linuxfoundation.org> (raw)
container_of does not preserve the const-ness of a pointer that is
passed into it, which can cause C code that passes in a const pointer to
get a pointer back that is not const and then scribble all over the data
in it. To prevent this, container_of_const() will preserve the const
status of the pointer passed into it using the newly available _Generic()
method.
Suggested-by: Jason Gunthorpe <jgg@ziepe.ca>
Suggested-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
v2: - removed one parameter, now matches container_of(), thanks to
suggestion from Sakari
- changed Jason's tag to suggested-by and reviewed-by
- added Andy's tag
include/linux/container_of.h | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/include/linux/container_of.h b/include/linux/container_of.h
index 2008e9f4058c..1d898f9158b4 100644
--- a/include/linux/container_of.h
+++ b/include/linux/container_of.h
@@ -22,4 +22,17 @@
"pointer type mismatch in container_of()"); \
((type *)(__mptr - offsetof(type, member))); })
+/**
+ * container_of_const - cast a member of a structure out to the containing
+ * structure and preserve the const-ness of the pointer
+ * @ptr: the pointer to the member
+ * @type: the type of the container struct this is embedded in.
+ * @member: the name of the member within the struct.
+ */
+#define container_of_const(ptr, type, member) \
+ _Generic(ptr, \
+ const typeof(*(ptr)) *: ((const type *)container_of(ptr, type, member)),\
+ default: ((type *)container_of(ptr, type, member)) \
+ )
+
#endif /* _LINUX_CONTAINER_OF_H */
--
2.38.1
next reply other threads:[~2022-12-05 12:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 12:12 Greg Kroah-Hartman [this message]
2022-12-05 12:12 ` [PATCH v2 2/4] device.h: move kobj_to_dev() to use container_of_const() Greg Kroah-Hartman
2022-12-05 14:00 ` Rafael J. Wysocki
2022-12-05 12:12 ` [PATCH v2 3/4] usb.h: take advantage of container_of_const() Greg Kroah-Hartman
2022-12-05 12:12 ` [PATCH v2 4/4] firmware_loader: fix up to_fw_sysfs() to preserve const Greg Kroah-Hartman
2022-12-05 14:23 ` Rafael J. Wysocki
2022-12-05 13:59 ` [PATCH v2 1/4] container_of: add container_of_const() that preserves const-ness of the pointer Rafael J. Wysocki
2022-12-05 21:24 ` Sakari Ailus
2022-12-06 15:13 ` Matthew Wilcox
2022-12-06 15:54 ` Greg Kroah-Hartman
2022-12-06 17:18 ` Matthew Wilcox
2022-12-06 18:46 ` Greg Kroah-Hartman
2022-12-06 20:18 ` Matthew Wilcox
2022-12-07 8:29 ` Greg Kroah-Hartman
2022-12-07 9:26 ` Rasmus Villemoes
2022-12-07 16:40 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221205121206.166576-1-gregkh@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jgg@nvidia.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.