From: Jakub Kicinski <kuba@kernel.org>
To: "Wilczynski, Michal" <michal.wilczynski@intel.com>
Cc: <netdev@vger.kernel.org>, <alexandr.lobakin@intel.com>,
<przemyslaw.kitszel@intel.com>, <jiri@resnulli.us>,
<wojciech.drewek@intel.com>, <dsahern@gmail.com>,
<stephen@networkplumber.org>
Subject: Re: [PATCH iproute2-next v2 0/4] Implement new netlink attributes for devlink-rate in iproute2
Date: Mon, 5 Dec 2022 16:24:11 -0800 [thread overview]
Message-ID: <20221205162411.1b016789@kernel.org> (raw)
In-Reply-To: <24bca169-1f7b-4034-9893-5cd1f1c0ad1b@intel.com>
On Mon, 5 Dec 2022 09:41:26 +0100 Wilczynski, Michal wrote:
> On 12/1/2022 5:53 PM, Jakub Kicinski wrote:
> > On Thu, 1 Dec 2022 11:26:22 +0100 Michal Wilczynski wrote:
> >> Patch implementing new netlink attributes for devlink-rate got merged to
> >> net-next.
> >> https://lore.kernel.org/netdev/20221115104825.172668-1-michal.wilczynski@intel.com/
> >>
> >> Now there is a need to support these new attributes in the userspace
> >> tool. Implement tx_priority and tx_weight in devlink userspace tool. Update
> >> documentation.
> > I forgot to ask you - is there anything worth adding to the netdevsim
> > rate selftests to make sure devlink refactoring doesn't break your use
> > case? Probably the ability for the driver to create and destroy the
> > hierarchy?
>
> I think it's a great idea, possibility to export the hierarchy from the driver
> is key for our use case. Would you like me to add this to netdevism ?
Great! Yes, netdevsim and a script that exercises it. There are some
rate tests already in
tools/testing/selftests/drivers/net/netdevsim/devlink.sh
Either just extend that or factor it out to its own script, if the rate
testing gets big. You don't have to be too "unit-testy" it's mostly
about exercising the functionality so that we can catch refactoring
errors.
next prev parent reply other threads:[~2022-12-06 0:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 10:26 [PATCH iproute2-next v2 0/4] Implement new netlink attributes for devlink-rate in iproute2 Michal Wilczynski
2022-12-01 10:26 ` [PATCH iproute2-next v2 1/4] devlink: Add uapi changes for tx_priority and tx_weight Michal Wilczynski
2022-12-01 10:26 ` [PATCH iproute2-next v2 2/4] devlink: Introduce new attribute 'tx_priority' to devlink-rate Michal Wilczynski
2022-12-01 10:26 ` [PATCH iproute2-next v2 3/4] devlink: Introduce new attribute 'tx_weight' " Michal Wilczynski
2022-12-01 10:26 ` [PATCH iproute2-next v2 4/4] devlink: Add documentation for tx_prority and tx_weight Michal Wilczynski
2022-12-01 16:53 ` [PATCH iproute2-next v2 0/4] Implement new netlink attributes for devlink-rate in iproute2 Jakub Kicinski
2022-12-05 8:41 ` Wilczynski, Michal
2022-12-06 0:24 ` Jakub Kicinski [this message]
2022-12-03 17:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221205162411.1b016789@kernel.org \
--to=kuba@kernel.org \
--cc=alexandr.lobakin@intel.com \
--cc=dsahern@gmail.com \
--cc=jiri@resnulli.us \
--cc=michal.wilczynski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
--cc=stephen@networkplumber.org \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.