From: Jakub Kicinski <kuba@kernel.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: Sudheer Mogilappagari <sudheer.mogilappagari@intel.com>,
netdev@vger.kernel.org, mkubecek@suse.cz, andrew@lunn.ch,
corbet@lwn.net, sridhar.samudrala@intel.com,
anthony.l.nguyen@intel.com
Subject: Re: [PATCH net-next v7] ethtool: add netlink based get rss support
Date: Mon, 5 Dec 2022 17:33:24 -0800 [thread overview]
Message-ID: <20221205173324.072b21da@kernel.org> (raw)
In-Reply-To: <Y42hg4MsATH/07ED@unreal>
On Mon, 5 Dec 2022 09:45:07 +0200 Leon Romanovsky wrote:
> > Conversion to netlink stands on its own.
>
> It doesn't answer on my question. The answer is "we do, just because we
> can" is nice but doesn't remove my worries that such "future" extension
> will work with real future feature.
By that logic we should have not merged 90% of netlink ethtool patches,
and I don't think we have had any major backward compat problems.
> From my experience, many UAPI designs without real use case in hand
> will require adaptions and won't work out-of-box.
Which is why this patch has been cut down to the bare minimum.
See the reviews for previous 6 versions.
> IMHO, it is the same sin as premature optimization.
Your feedback has been registered.
next prev parent reply other threads:[~2022-12-06 1:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 0:25 [PATCH net-next v7] ethtool: add netlink based get rss support Sudheer Mogilappagari
2022-12-04 12:17 ` Leon Romanovsky
2022-12-04 23:38 ` Jakub Kicinski
2022-12-05 7:45 ` Leon Romanovsky
2022-12-06 1:33 ` Jakub Kicinski [this message]
2022-12-06 16:14 ` Michal Kubecek
2022-12-07 8:42 ` Leon Romanovsky
2022-12-07 9:32 ` Michal Kubecek
2022-12-08 8:22 ` Leon Romanovsky
2022-12-06 1:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221205173324.072b21da@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=corbet@lwn.net \
--cc=leon@kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=sridhar.samudrala@intel.com \
--cc=sudheer.mogilappagari@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.