From: Jakub Kicinski <kuba@kernel.org>
To: Shannon Nelson <shnelson@amd.com>
Cc: Shay Drory <shayd@nvidia.com>,
netdev@vger.kernel.org, davem@davemloft.net, danielj@nvidia.com,
yishaih@nvidia.com, jiri@nvidia.com, saeedm@nvidia.com,
parav@nvidia.com
Subject: Re: [PATCH net-next V3 4/8] devlink: Expose port function commands to control RoCE
Date: Mon, 5 Dec 2022 18:02:34 -0800 [thread overview]
Message-ID: <20221205180234.2a8a5423@kernel.org> (raw)
In-Reply-To: <34381666-a7b5-9507-211a-162827b86153@amd.com>
On Mon, 5 Dec 2022 15:37:26 -0800 Shannon Nelson wrote:
> > enum devlink_port_function_attr {
> > DEVLINK_PORT_FUNCTION_ATTR_UNSPEC,
> > DEVLINK_PORT_FUNCTION_ATTR_HW_ADDR, /* binary */
> > DEVLINK_PORT_FN_ATTR_STATE, /* u8 */
> > DEVLINK_PORT_FN_ATTR_OPSTATE, /* u8 */
> > + DEVLINK_PORT_FN_ATTR_CAPS, /* bitfield32 */
>
> Will 32 bits be enough, or should we start off with u64? It will
> probably be fine, but since we're setting a uapi thing here we probably
> want to be sure we won't need to change it in the future.
Ah, if only variable size integer types from Olek were ready :(
Unfortunately there is no bf64 today, so we'd either have to add soon
to be deprecated bf64 or hold off waiting for Olek...
I reckon the dumb thing of merging bf32 may be the best choice right
now :(
next prev parent reply other threads:[~2022-12-06 2:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-04 14:16 [PATCH net-next V3 0/8] devlink: Add port function attribute to enable/disable Roce and migratable Shay Drory
2022-12-04 14:16 ` [PATCH net-next V3 1/8] net/mlx5: Introduce IFC bits for migratable Shay Drory
2022-12-04 14:16 ` [PATCH net-next V3 2/8] devlink: Validate port function request Shay Drory
2022-12-04 14:16 ` [PATCH net-next V3 3/8] devlink: Move devlink port function hw_addr attr documentation Shay Drory
2022-12-04 14:16 ` [PATCH net-next V3 4/8] devlink: Expose port function commands to control RoCE Shay Drory
2022-12-05 10:12 ` Jiri Pirko
2022-12-05 23:37 ` Shannon Nelson
2022-12-06 2:02 ` Jakub Kicinski [this message]
2022-12-06 8:52 ` Jiri Pirko
2022-12-04 14:16 ` [PATCH net-next V3 5/8] net/mlx5: Add generic getters for other functions caps Shay Drory
2022-12-04 14:16 ` [PATCH net-next V3 6/8] net/mlx5: E-Switch, Implement devlink port function cmds to control RoCE Shay Drory
2022-12-04 14:16 ` [PATCH net-next V3 7/8] devlink: Expose port function commands to control migratable Shay Drory
2022-12-05 23:37 ` Shannon Nelson
2022-12-06 1:56 ` Jakub Kicinski
2022-12-06 8:55 ` Jiri Pirko
2022-12-06 17:52 ` Shannon Nelson
2022-12-04 14:16 ` [PATCH net-next V3 8/8] net/mlx5: E-Switch, Implement devlink port function cmds " Shay Drory
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221205180234.2a8a5423@kernel.org \
--to=kuba@kernel.org \
--cc=danielj@nvidia.com \
--cc=davem@davemloft.net \
--cc=jiri@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=parav@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=shayd@nvidia.com \
--cc=shnelson@amd.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.