All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Michael Nosthoff via buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH] [RFC] package/boost: Boost.Atomic needs atomic intrinsics
Date: Mon, 5 Dec 2022 18:19:07 +0100	[thread overview]
Message-ID: <20221205181907.2cbb01e7@windsurf> (raw)
In-Reply-To: <20221205125423.13983-1-buildroot@heine.tech>

On Mon,  5 Dec 2022 13:54:22 +0100
Michael Nosthoff via buildroot <buildroot@buildroot.org> wrote:

> From: Michael <buildroot@heine.tech>
> 
> similar to previous problems with nios2 and not-available atomic ints
> the build for Boost.Atomics also fails for ARC Targets which don't
> have the ATOMICS_EXT flag set.
> 
> according to [0] "Boost.Atomic has a hard requirement of the native
> atomic operations on bytes". The same tests mentioned there fail for
> ARC.
> 
> so introduce a dependency on BR2_ARC_ATOMIC_EXT for BR2_arc.
> 
> Fixes:
>   http://autobuild.buildroot.net/results/4ca54a85672d7b9328b1909b457e548c6032a493
> 
> [0] https://github.com/boostorg/atomic/issues/42#issuecomment-734130348
> 
> Signed-off-by: Michael Nosthoff <buildroot@heine.tech>

I wish it would be this simple, but this new "depends on" needs to be
propagated to all places where BR2_PACKAGE_BOOST_ATOMIC is selected.

Aka:

package/boost/Config.in:        select BR2_PACKAGE_BOOST_ATOMIC
package/boost/Config.in:        select BR2_PACKAGE_BOOST_ATOMIC
package/domoticz/Config.in:     select BR2_PACKAGE_BOOST_ATOMIC
package/gnuradio/Config.in:     select BR2_PACKAGE_BOOST_ATOMIC
package/libcpprestsdk/Config.in:        select BR2_PACKAGE_BOOST_ATOMIC
package/log4cxx/Config.in:      select BR2_PACKAGE_BOOST_ATOMIC if !BR2_TOOLCHAIN_GCC_AT_LEAST_7
package/uhd/Config.in:  select BR2_PACKAGE_BOOST_ATOMIC

And of course, if there's anything that selects those options, the new
depends on should be propagated to them again.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-12-05 17:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-05 12:54 [Buildroot] [PATCH] [RFC] package/boost: Boost.Atomic needs atomic intrinsics Michael Nosthoff via buildroot
2022-12-05 17:19 ` Thomas Petazzoni via buildroot [this message]
2022-12-05 20:14   ` Michael Nosthoff via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221205181907.2cbb01e7@windsurf \
    --to=buildroot@buildroot.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.