From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 562EEC47089 for ; Mon, 5 Dec 2022 23:35:15 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1736B841A1; Tue, 6 Dec 2022 00:35:13 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="AEi1qVSz"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A78C9841A1; Tue, 6 Dec 2022 00:35:11 +0100 (CET) Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9E47683A08 for ; Tue, 6 Dec 2022 00:35:08 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-wm1-x331.google.com with SMTP id i131-20020a1c3b89000000b003d1cb516ce0so3687998wma.4 for ; Mon, 05 Dec 2022 15:35:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0UInupYXa3JdFlrAG6nkeEsiO8xC4+BrymPrlWBqDJY=; b=AEi1qVSz0VIRQef93QNnQSQsVbEjyuRJJmXt+JTiwdIIxyB+L3QGhyL+cVkPj32clm EV3MmXwvbiyKg3G7g6XtDJ270gdoJBPryA5jhRCOLe5SfpR7EGiCdvfJLRnrMXAFmsBu Uct7JwX+a4vt0ksnwsUIU+PiR7IUfDtANpHwg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0UInupYXa3JdFlrAG6nkeEsiO8xC4+BrymPrlWBqDJY=; b=xMoPm7386F3eeOX4DrXO6HM6EaDWW+vY6rrliOSlXy4U/y3DlZKdsoP2CbxWo/jkiz vC5Ux1Qit1FMglplzeWBTrogbAZoT34Zlvi8AAAOrwA3U2cydIkZu6sFMkvH0d9Ds6BW Zx9wOl97mcTl5HSMJ6rnhyF96Z5WU/ZdoD5s2p/JlW6g4htBSd7pLrJTbRlue+lQE9Xv csnOVaue6SPIkDmfEAOmjpHtgI/QiZ/NMm/6v5tRplIyvyIMCql8ZcvUzbKUe9m6cxba rU30IfLaabMNK1fkXKGwDBZZbFUXQ42R4y9jqw0sHQTP8RaNGT3MoFMPsdwn7iPkTava qS8Q== X-Gm-Message-State: ANoB5pl7tQ49vcpEJKwyVmhyPH3f+yKPrikbMAaCwqy7siiqzGrXXJTE IpHiW58Rxto1IX2y7jo0LOmBtg== X-Google-Smtp-Source: AA0mqf6zGhSPyq5VWR/Th7OlULJC6QjrAJ736PU5ZafLfaGPNOqY+/PfNyW5iDK16q+Vhe/BPfr8DA== X-Received: by 2002:a1c:7513:0:b0:3cf:8896:e1c9 with SMTP id o19-20020a1c7513000000b003cf8896e1c9mr64085245wmc.119.1670283308053; Mon, 05 Dec 2022 15:35:08 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-3974-0ce5-e869-8ac0.res6.spectrum.com. [2603:6081:7b00:6400:3974:ce5:e869:8ac0]) by smtp.gmail.com with ESMTPSA id w12-20020a05600c474c00b003b435c41103sm29639301wmo.0.2022.12.05.15.35.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Dec 2022 15:35:07 -0800 (PST) Date: Mon, 5 Dec 2022 18:34:59 -0500 From: Tom Rini To: Peter Robinson Cc: Simon Glass , U-Boot Mailing List , Rasmus Villemoes Subject: Re: [PATCH v5 10/16] buildman: Detect binman reporting missing blobs Message-ID: <20221205233459.GC3787616@bill-the-cat> References: <20221110021455.1004335-1-sjg@chromium.org> <20221110021455.1004335-11-sjg@chromium.org> <20221205232338.GB3787616@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="glG7QM0/F4Gfd30i" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --glG7QM0/F4Gfd30i Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 05, 2022 at 11:29:30PM +0000, Peter Robinson wrote: > On Mon, Dec 5, 2022 at 11:23 PM Tom Rini wrote: > > > > On Mon, Dec 05, 2022 at 11:13:03PM +0000, Peter Robinson wrote: > > > On Thu, Nov 10, 2022 at 2:17 AM Simon Glass wrote: > > > > > > > > Buildman should consider a build as a success (with warnings) if mi= ssing > > > > blobs have been dealt with by binman, even though buildman itself r= eturns > > > > and error code overall. This is how other warnings are dealt with. > > > > > > > > We cannot easily access the 103 exit code, so detect the problem in= the > > > > output. > > > > > > > > With this change, missing blobs result in an exit code of 101, alth= ough > > > > they still indicate failure. > > > > > > So either this or Tom's change of "buildman: Add --allow-missing flag > > > to allow missing blobs" has broken rc3 builds for Allwinner boards on > > > Fedora. Tom's isn't a clean revert and I've not had time to test that > > > but either way the SCP firmware is optional and it works just fine, > > > ATM we don't have the SCP firmware available to Fedora builds. > > > > > > Maybe that sort of of change to the build is expected but which ever > > > patch it is, and adding "BINMAN_ALLOW_MISSING=3D1" changes the error = but > > > doesn't change the overall failure, I wouldn't expect this sort of > > > breakage so late in the cycle. > > > > > > Do either of you know which one does the hard breakage here? I thought > > > I'd highlight it now because I don't have time over the next two weeks > > > to fully investigate the regression. > > > > So, is this for 32bit or 64bit? I only have a 64bit allwinner in my lab >=20 > 64 bit, 32 bit is EOL in Fedora as of F-36. >=20 > > and it needs (I've been assuming, since I'm also passing in SCP) BL31 as >=20 > BL31 isn't the same as SCP, the later is a firmware for the onboard > PMIC co-processor where as BL31 is Arm Trusted Firmware. Right, yes. > > well. And since you're mentioning buildman, I assume Fedora IS using > > that rather than make to build everything. I'll go and think about this >=20 > I'm using: > make pine64_plus_defconfig O=3Dbuilds/pine64_plus/ > cp /usr/share/arm-trusted-firmware/sun50i_a64/bl31.bin builds/pine64_plus/ > make CROSS_COMPILE=3D"/usr/bin/aarch64-linux-gnu-" O=3Dbuilds/pine64_plus/ OK, that's a little different than how I run make, that's why it wasn't caught at least. I do: export SCP=3D/home/trini/work/u-boot/external-binaries/pine64_plus/scp.bin export BL31=3D/home/trini/work/u-boot/external-binaries/pine64_plus/bl31.bin make O=3D/tmp/pine64_plus pine64_plus_defconfig all -sj$(nproc) > I thought binman was basically default for this now. We have too many *man tools sometimes. I thought you said buildman, yes, binman assembles the images here, when invoking make. Digging more now, thanks! --=20 Tom --glG7QM0/F4Gfd30i Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmOOgB0ACgkQFHw5/5Y0 tyzLmwwArpgZzdsbvAzrJdDxeK0f0hPkp6+FcTBcDHU/sEaNy3PjHSFJ6hBBKtK2 UC+0x9zQTXF7qSK8lBdKPtomNrlKUqjBjXwhqCeXZ4s0WijS0VWg8UVko3tRCfTu G20uMUmyJvpIzTorWhaw3JIbycn7z2jLODS/aTOTfq1XIjmIzb2hr+7Hs+9MXfT/ 17+MEuyTVXkH/SVYk669G/B5QNKAi+o5zypctnwU5vpU+1WDLxhMHdT+FQDt3PVw /gGZLNIk3GKbBqJxaAph1EbBGyuVeaHMs6FGySPwHv22I/dYK3QDDAxI8pepiHy0 /eF3JP8cOxUWgvSh+/TDTaOAJeTs+KmKakRGKUDWOLU2MI8alhl1+rkBwvsG0BrJ KuXg/EFy80bR6GCvOg0ZoIUUZubWdLC7LcOYtYnjcKR3EL9kd+0vT0cj3I+qb2kJ nwuZOF8kmQTD/9XfLKZGy/IwYj+DA86sjmQICbhS23F4dFzQKWCyt+fkU3Jao+JB O/+DgXcV =cOTA -----END PGP SIGNATURE----- --glG7QM0/F4Gfd30i--