From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2890BC4708C for ; Mon, 5 Dec 2022 23:56:20 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E8BD5852E2; Tue, 6 Dec 2022 00:56:17 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="OkJnS+hE"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5887385301; Tue, 6 Dec 2022 00:56:16 +0100 (CET) Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7D0A8852BD for ; Tue, 6 Dec 2022 00:56:13 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-wm1-x330.google.com with SMTP id ay8-20020a05600c1e0800b003d0808d2826so80335wmb.1 for ; Mon, 05 Dec 2022 15:56:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WNhqOqgLGcjiGv21vc5g15dyVfI6zTS8CinTICaZdSU=; b=OkJnS+hEWrUcdq2ZSu62MV6iA8kDODtma3rWulchZjdutjTJFAepoP6C6Z/IDtXATD RHAUi4OkyHmN05JhvaGDRR86YLOMI6UBYSRAciY4xuEdsXOrTxTpC9VuUSSuKXsC2sBP iMuUlvDffd176wVWSorOsoUSiO8iEmiaaS2bE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WNhqOqgLGcjiGv21vc5g15dyVfI6zTS8CinTICaZdSU=; b=VP81MgWef/hwgrj9ShUk+s9T2hYQg73YhCcXsrgZlzMVGXA1qNj3MuFNFqGHxJ1tq9 bdUIYVk14j8NYp70IDMrmXU1+lCp10bzufuR8yW9DJ9EyjQgOpLLTRV0/HTdXstw86OO T43E+LZvmQV07jXLniIhqLRN45suYXn99spXnlYexD6s6BAZf9xKUrbCm8cqqm4S0u1I j1m04dY33Wb/+XcjM52YR6werySFNTqr5e+TEwlrHfY/IkanY7w1w8RGBcBdbH6YVb1t MpvEQMGS2wxtiOsqKE0eEYh1C7ytwlnhfkUYry120QZAKZaKzTiVkIW1fOE/MQzgsboy wKkw== X-Gm-Message-State: ANoB5pkUtIJq8ztD6AU9+DEMz3g8arpt1TMjugvq/+e1CoglGg0BaB7G 8RidfOYLfBD0c9BYImB4JMbU7NL0HjHIJ1Cz X-Google-Smtp-Source: AA0mqf5GoqBMyqNgT5k7RQWr0n4SJkgRzH6rdikmt/RKZNTGjiYVF7NOyHQBidx1XhxUT8ZumPGRpA== X-Received: by 2002:a05:600c:548b:b0:3cf:b0e4:30d9 with SMTP id iv11-20020a05600c548b00b003cfb0e430d9mr54101293wmb.66.1670284572944; Mon, 05 Dec 2022 15:56:12 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-3974-0ce5-e869-8ac0.res6.spectrum.com. [2603:6081:7b00:6400:3974:ce5:e869:8ac0]) by smtp.gmail.com with ESMTPSA id m126-20020a1c2684000000b003d1d5a83b2esm3446822wmm.35.2022.12.05.15.56.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Dec 2022 15:56:12 -0800 (PST) Date: Mon, 5 Dec 2022 18:56:09 -0500 From: Tom Rini To: Simon Glass Cc: Peter Robinson , U-Boot Mailing List , Rasmus Villemoes Subject: Re: [PATCH v5 10/16] buildman: Detect binman reporting missing blobs Message-ID: <20221205235609.GE3787616@bill-the-cat> References: <20221110021455.1004335-1-sjg@chromium.org> <20221110021455.1004335-11-sjg@chromium.org> <20221205232338.GB3787616@bill-the-cat> <20221205233459.GC3787616@bill-the-cat> <20221205234633.GD3787616@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GsUSTzGf3ObKA1Cs" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --GsUSTzGf3ObKA1Cs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 06, 2022 at 12:55:08PM +1300, Simon Glass wrote: > Hi Tom, >=20 > On Tue, 6 Dec 2022 at 12:46, Tom Rini wrote: > > > > On Mon, Dec 05, 2022 at 11:43:24PM +0000, Peter Robinson wrote: > > > On Mon, Dec 5, 2022 at 11:35 PM Tom Rini wrote: > > > > > > > > On Mon, Dec 05, 2022 at 11:29:30PM +0000, Peter Robinson wrote: > > > > > On Mon, Dec 5, 2022 at 11:23 PM Tom Rini wro= te: > > > > > > > > > > > > On Mon, Dec 05, 2022 at 11:13:03PM +0000, Peter Robinson wrote: > > > > > > > On Thu, Nov 10, 2022 at 2:17 AM Simon Glass wrote: > > > > > > > > > > > > > > > > Buildman should consider a build as a success (with warning= s) if missing > > > > > > > > blobs have been dealt with by binman, even though buildman = itself returns > > > > > > > > and error code overall. This is how other warnings are deal= t with. > > > > > > > > > > > > > > > > We cannot easily access the 103 exit code, so detect the pr= oblem in the > > > > > > > > output. > > > > > > > > > > > > > > > > With this change, missing blobs result in an exit code of 1= 01, although > > > > > > > > they still indicate failure. > > > > > > > > > > > > > > So either this or Tom's change of "buildman: Add --allow-miss= ing flag > > > > > > > to allow missing blobs" has broken rc3 builds for Allwinner b= oards on > > > > > > > Fedora. Tom's isn't a clean revert and I've not had time to t= est that > > > > > > > but either way the SCP firmware is optional and it works just= fine, > > > > > > > ATM we don't have the SCP firmware available to Fedora builds. > > > > > > > > > > > > > > Maybe that sort of of change to the build is expected but whi= ch ever > > > > > > > patch it is, and adding "BINMAN_ALLOW_MISSING=3D1" changes th= e error but > > > > > > > doesn't change the overall failure, I wouldn't expect this so= rt of > > > > > > > breakage so late in the cycle. > > > > > > > > > > > > > > Do either of you know which one does the hard breakage here? = I thought > > > > > > > I'd highlight it now because I don't have time over the next = two weeks > > > > > > > to fully investigate the regression. > > > > > > > > > > > > So, is this for 32bit or 64bit? I only have a 64bit allwinner i= n my lab > > > > > > > > > > 64 bit, 32 bit is EOL in Fedora as of F-36. > > > > > > > > > > > and it needs (I've been assuming, since I'm also passing in SCP= ) BL31 as > > > > > > > > > > BL31 isn't the same as SCP, the later is a firmware for the onboa= rd > > > > > PMIC co-processor where as BL31 is Arm Trusted Firmware. > > > > > > > > Right, yes. > > > > > > > > > > well. And since you're mentioning buildman, I assume Fedora IS= using > > > > > > that rather than make to build everything. I'll go and think ab= out this > > > > > > > > > > I'm using: > > > > > make pine64_plus_defconfig O=3Dbuilds/pine64_plus/ > > > > > cp /usr/share/arm-trusted-firmware/sun50i_a64/bl31.bin builds/pin= e64_plus/ > > > > > make CROSS_COMPILE=3D"/usr/bin/aarch64-linux-gnu-" O=3Dbuilds/pin= e64_plus/ > > > > > > > > OK, that's a little different than how I run make, that's why it wa= sn't > > > > caught at least. I do: > > > > export SCP=3D/home/trini/work/u-boot/external-binaries/pine64_plus/= scp.bin > > > > export BL31=3D/home/trini/work/u-boot/external-binaries/pine64_plus= /bl31.bin > > > > make O=3D/tmp/pine64_plus pine64_plus_defconfig all -sj$(nproc) > > > > > > We build ~90 boards so we've historically copied it to each of the > > > board build output directories, could look at setting vars for each of > > > the loops too. > > > > > > > > I thought binman was basically default for this now. > > > > > > > > We have too many *man tools sometimes. I thought you said buildman,= yes, > > > > binman assembles the images here, when invoking make. Digging more= now, > > > > thanks! > > > > > > It could easily be me getting confused, trying to balance a lot of > > > plates right now :-/ > > > > OK, so yes, you've found a problem here. What I need to throw a CI loop > > at now is: > > diff --git a/Makefile b/Makefile > > index d48f52f2943b..b2253ac8ecde 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -1334,7 +1334,7 @@ cmd_binman =3D $(srctree)/tools/binman/binman $(i= f $(BINMAN_DEBUG),-D) \ > > --toolpath $(objtree)/tools \ > > $(if $(BINMAN_VERBOSE),-v$(BINMAN_VERBOSE)) \ > > build -u -d u-boot.dtb -O . -m \ > > - $(if $(BINMAN_ALLOW_MISSING),--allow-missing --fake-ext= -blobs) \ > > + $(if $(BINMAN_ALLOW_MISSING),--allow-missing --ignore-m= issing) \ >=20 > I think you need to keep the old flag too, right? Not in my first pine64_plus only test, but I just threw CI at the world, so pass-or-fireworks in about an hour. --=20 Tom --GsUSTzGf3ObKA1Cs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmOOhRkACgkQFHw5/5Y0 tyzdtgwAsEF0Auc+afg39z2e/DujxpHTi97vaMzjmr7Eh2MbKdb3ebyONvjP5ljk 8j//1J/HGNM6bXoA1A95YjZ6NKypHAfjsN0rVi8Dg7RbUYCrS/sqiy4b2eE718Gf HT2nd7G05VoVrCJjk4ccay9xBe+VNJK5cMbsHU1AUf67yjpcpc18qCF4K5hS0j69 mfW3OkziT/ySEpghHReQ0/NkRwLQfh24WbGsrs0S5KnT8lkrBforQWljSv2F5nds 7mTCDLiJSix2b3zMiiYnPkEEac6zpbVMpYD0JLM8wLFY0KwoFk87diSSd23o6EPw Ma5gt72HGVEH+C89ujnIALRFLo+QERrly9rKjRWsTzjBucbRkXv3l1hTKpVmuryn x2HIVD+80kym1OIIba/n7+HJkzW6xRWQbh60yWFoFgXP8vrPqXcQFmYqWTnz2/66 gpNY7+1oRP/T1dZh0wjSoqIQMywXLA8Lq2P0ig8UhaSlIPQdUe5s8Yzk+LCguA+3 oAgM32kf =jGau -----END PGP SIGNATURE----- --GsUSTzGf3ObKA1Cs--