All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Steve French <smfrench@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>, Steve French <sfrench@samba.org>,
	Paulo Alcantara <pc@cjr.nz>,
	Ronnie Sahlberg <lsahlber@redhat.com>,
	Shyam Prasad N <sprasad@microsoft.com>,
	Tom Talpey <tom@talpey.com>,
	linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
	David Howells <dhowells@redhat.com>
Subject: Re: RFC: remove cifs_writepage
Date: Tue, 6 Dec 2022 07:36:57 +0100	[thread overview]
Message-ID: <20221206063657.GA6939@lst.de> (raw)
In-Reply-To: <CAH2r5mvZh+5S74fec0o8EGf+OdjP4LaRKsK-FKh-ctf4uzHX0Q@mail.gmail.com>

On Mon, Dec 05, 2022 at 06:22:12PM -0600, Steve French wrote:
> Ran some tests today with the three patch (remove writepage for
> cifs.ko) series.  Let me know if any updates for those.  Also let me
> know which gti branch you would like to see these merged from (mine or
> yours e.g.)

If they work and look fine to you please queue them up in the cifs
tree as-is.

> I did see an intermittent  failure (when run with these three patches)
> that doesn't appear to be obviously related to yours but am still
> investigating it.   Test 043 failed once, and on one of retries of the
> group  -  test 045 failed once. See example below.  This looks related
> to an issue with deferred close (handle leases) and reference counts
> holding up unmount, and not related to these patches (at least at
> first glance).   Continuing to debug

Yes.  I have no good idea but to may suggest what NFS does about
silly renamed inodes to ensure they don't try to get in the way
of mount.

      reply	other threads:[~2022-12-06  6:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-16 13:18 RFC: remove cifs_writepage Christoph Hellwig
2022-11-16 13:18 ` [PATCH 1/3] cifs: wire up >migrate_folio Christoph Hellwig
2022-11-16 13:18 ` [PATCH 2/3] cifs: stop using generic_writepages Christoph Hellwig
2022-11-16 13:18 ` [PATCH 3/3] cifs: remove ->writepage Christoph Hellwig
2022-11-16 18:29 ` RFC: remove cifs_writepage Steve French
2022-12-04  8:19   ` Christoph Hellwig
2022-12-06  0:22     ` Steve French
2022-12-06  6:36       ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221206063657.GA6939@lst.de \
    --to=hch@lst.de \
    --cc=dhowells@redhat.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=lsahlber@redhat.com \
    --cc=pc@cjr.nz \
    --cc=samba-technical@lists.samba.org \
    --cc=sfrench@samba.org \
    --cc=smfrench@gmail.com \
    --cc=sprasad@microsoft.com \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.