From: Jakub Kicinski <kuba@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Arun.Ramadoss@microchip.com
Subject: Re: [PATCH net-next v1 1/1] net: dsa: microchip: add stats64 support for ksz8 series of switches
Date: Tue, 6 Dec 2022 11:41:33 -0800 [thread overview]
Message-ID: <20221206114133.291881a4@kernel.org> (raw)
In-Reply-To: <20221205052904.2834962-1-o.rempel@pengutronix.de>
On Mon, 5 Dec 2022 06:29:04 +0100 Oleksij Rempel wrote:
> + stats->rx_packets = raw->rx_bcast + raw->rx_mcast + raw->rx_ucast +
> + raw->rx_pause;
> + stats->tx_packets = raw->tx_bcast + raw->tx_mcast + raw->tx_ucast +
> + raw->tx_pause;
FWIW for normal netdevs / NICs the rtnl_link_stat pkts do not include
pause frames, normally. Otherwise one can't maintain those stats in SW
(and per-ring stats, if any, don't add up to the full link stats).
But if you have a good reason to do this - I won't nack..
next prev parent reply other threads:[~2022-12-06 19:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 5:29 [PATCH net-next v1 1/1] net: dsa: microchip: add stats64 support for ksz8 series of switches Oleksij Rempel
2022-12-06 17:08 ` Vladimir Oltean
2022-12-07 6:14 ` Oleksij Rempel
2022-12-06 19:41 ` Jakub Kicinski [this message]
2022-12-07 6:16 ` Oleksij Rempel
2022-12-07 23:48 ` Jakub Kicinski
2022-12-08 5:55 ` Oleksij Rempel
2022-12-08 16:27 ` Jakub Kicinski
2022-12-08 16:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221206114133.291881a4@kernel.org \
--to=kuba@kernel.org \
--cc=Arun.Ramadoss@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.