From: <ye.xingchen@zte.com.cn>
To: <jic23@kernel.org>
Cc: <michael.hennerich@analog.com>, <lars@metafoo.de>,
<andriy.shevchenko@linux.intel.com>,
<u.kleine-koenig@pengutronix.de>, <jk@codeconstruct.com.au>,
<wsa@kernel.org>, <ddrokosov@sberdevices.ru>,
<hdegoede@redhat.com>, <haibo.chen@nxp.com>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH] iio: accel: Convert to use sysfs_emit_at() API
Date: Tue, 6 Dec 2022 19:53:20 +0800 (CST) [thread overview]
Message-ID: <202212061953201070549@zte.com.cn> (raw)
From: ye xingchen <ye.xingchen@zte.com.cn>
Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
drivers/iio/accel/adxl372.c | 3 +--
drivers/iio/accel/bma180.c | 3 +--
drivers/iio/accel/mma8452.c | 5 ++---
3 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/iio/accel/adxl372.c b/drivers/iio/accel/adxl372.c
index c4193286eb05..15bcb0d75b8f 100644
--- a/drivers/iio/accel/adxl372.c
+++ b/drivers/iio/accel/adxl372.c
@@ -970,8 +970,7 @@ static ssize_t adxl372_show_filter_freq_avail(struct device *dev,
size_t len = 0;
for (i = 0; i <= st->odr; i++)
- len += scnprintf(buf + len, PAGE_SIZE - len,
- "%d ", adxl372_bw_freq_tbl[i]);
+ len += sysfs_emit_at(buf, len, "%d ", adxl372_bw_freq_tbl[i]);
buf[len - 1] = '\n';
diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c
index eb697eeb4301..9e3e5dfdded7 100644
--- a/drivers/iio/accel/bma180.c
+++ b/drivers/iio/accel/bma180.c
@@ -488,8 +488,7 @@ static ssize_t bma180_show_avail(char *buf, const int *vals, unsigned int n,
for (i = 0; i < n; i++) {
if (!vals[i])
continue;
- len += scnprintf(buf + len, PAGE_SIZE - len,
- micros ? "0.%06d " : "%d ", vals[i]);
+ len += sysfs_emit_at(buf, len, micros ? "0.%06d " : "%d ", vals[i]);
}
buf[len - 1] = '\n';
diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
index f97fb68e3a71..7ba3c743e6f6 100644
--- a/drivers/iio/accel/mma8452.c
+++ b/drivers/iio/accel/mma8452.c
@@ -266,8 +266,7 @@ static ssize_t mma8452_show_int_plus_micros(char *buf, const int (*vals)[2],
size_t len = 0;
while (n-- > 0)
- len += scnprintf(buf + len, PAGE_SIZE - len, "%d.%06d ",
- vals[n][0], vals[n][1]);
+ len += sysfs_emit_at(buf, len, "%d.%06d ", vals[n][0], vals[n][1]);
/* replace trailing space by newline */
buf[len - 1] = '\n';
@@ -423,7 +422,7 @@ static ssize_t mma8452_show_os_ratio_avail(struct device *dev,
val = mma8452_os_ratio[j][i];
- len += scnprintf(buf + len, PAGE_SIZE - len, "%d ", val);
+ len += sysfs_emit_at(buf, len, "%d ", val);
}
buf[len - 1] = '\n';
--
2.25.1
next reply other threads:[~2022-12-06 11:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 11:53 ye.xingchen [this message]
2022-12-06 15:12 ` [PATCH] iio: accel: Convert to use sysfs_emit_at() API Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202212061953201070549@zte.com.cn \
--to=ye.xingchen@zte.com.cn \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ddrokosov@sberdevices.ru \
--cc=haibo.chen@nxp.com \
--cc=hdegoede@redhat.com \
--cc=jic23@kernel.org \
--cc=jk@codeconstruct.com.au \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.