From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: David Howells <dhowells@redhat.com>
Cc: rostedt@goodmis.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] trace: Fix some checker warnings
Date: Tue, 6 Dec 2022 22:59:23 +0900 [thread overview]
Message-ID: <20221206225923.342044429adb3aafe67400a7@kernel.org> (raw)
In-Reply-To: <382777.1670236186@warthog.procyon.org.uk>
On Mon, 05 Dec 2022 10:29:46 +0000
David Howells <dhowells@redhat.com> wrote:
> Btw, do you know how to deal with:
>
> add_ftrace_export(struct trace_export **list, struct trace_export *export)
>
> being called by:
>
> add_ftrace_export(&ftrace_exports_list, export);
>
> but ftrace_exports_list has an __rcu annotation, so the list argument in the
> former should have an __rcu annotation in it somewhere too.
Can't you just add __rcu to the 'list' argument?
>
> OTOH - there's only one user of add_trace_export() and add_ftrace_export(), so
> can they be collapsed into register_ftrace_export()?
Steve, do you have any idea?
Thanks,
>
> David
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2022-12-06 13:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 20:07 [PATCH] trace: Fix some checker warnings David Howells
2022-12-02 12:43 ` kernel test robot
2022-12-05 2:22 ` Masami Hiramatsu
2022-12-05 2:39 ` Steven Rostedt
2022-12-05 3:11 ` Masami Hiramatsu
2022-12-05 3:29 ` Steven Rostedt
2022-12-05 3:29 ` Masami Hiramatsu
2022-12-05 3:33 ` Steven Rostedt
2022-12-02 14:24 ` kernel test robot
2022-12-05 3:32 ` Masami Hiramatsu
2022-12-05 8:28 ` David Howells
2022-12-05 9:06 ` Masami Hiramatsu
2022-12-05 10:22 ` David Howells
2022-12-05 10:29 ` David Howells
2022-12-06 13:59 ` Masami Hiramatsu [this message]
2022-12-05 14:40 ` [PATCH] tracing: Fix complicated dependency of kernel test robot
2022-12-05 15:10 ` kernel test robot
2022-12-06 12:56 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221206225923.342044429adb3aafe67400a7@kernel.org \
--to=mhiramat@kernel.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.