From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1p2kuC-0005hX-Eq for mharc-grub-devel@gnu.org; Tue, 06 Dec 2022 22:15:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2kuA-0005h9-QV for grub-devel@gnu.org; Tue, 06 Dec 2022 22:15:30 -0500 Received: from mail-db5eur01on062d.outbound.protection.outlook.com ([2a01:111:f400:fe02::62d] helo=EUR01-DB5-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2ku9-0005Xh-0P for grub-devel@gnu.org; Tue, 06 Dec 2022 22:15:30 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fSExbFdv691AXY062OLpMbSN/gjubFINpuKmTsc/2MnrSCpIJ//j+VN4yAqbI60YI3ZquKDeozDRYUoBNSbls6/UjlYbLD3FAy+eApJV2agpAwGkA0ttzOdfgwCiDNXfUPabMqQVwUHxhGheQnzlVYpGkogixlLwSDlGFWw7Zk2DwlHX4lQkAwCgAnFGUSCIv2v119SmNv73sWpcjMUZUrFm+t3Kn2bzBYqopj51nZm/OSZTBTpnW7eZzPPiIk502DxejN6PnMQ3Ge7xc+YMmL+j4k8tUNq1m2CK6ITGjNhgzduxoWrcjKbvs+VGLFIFu7PqravMeU1J+QCamungmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JXZoorpnY96/WPMKmfQi50OYRJyKEi7kLpX1UQBptgA=; b=Enf5nfYta0fxIQlnvOWHkkKsunkoVmX6jecLtYI1HTOUJIbGVwwvLDB6awXes3YfUPtedRDQnE+hXexMm54bMiP6P1fOg9SmOkkn0Uwoho5KmL5ws3bCK0X6goFzo0fX48P7/ZZZUkagbXUP1rqHI7tDLTSqLdS2SRCpPNzILpQF2IzdAibGosR0ZbGdjv3ECDEOuY1mHiLslc/z+Fvqmb1lnVU5dNI4m/l2H2s/cfnFXLmPCans8dSDaxcHdImz+u6r23Xn6L+VYEAIqXrAn5ulajROs+QQrt2JjyK2J8TnltZdfBFWbz/YD3Z7KrCzP5MZM7P75z/W9u503prHWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JXZoorpnY96/WPMKmfQi50OYRJyKEi7kLpX1UQBptgA=; b=SJBM2Q7nHfZPuEdjJhDaEttepYSBmw6LllBRfcS76rf8TpMKw7H5/QYI6HXVUvxCvpVungaH9Z1uhsNavCilxvTFCD7Oqifdtla3qmb+HOAEmoQ594JmQOA/YUkU54uC2GnOGmGJu0xSXkFjtVcjQNfSpUDzfd34uZ47GxhvungB7H6vB3JMSH+nS/dUhxnkv6830U7O2MloGTghImB5yaAmDQylDFefWmatp1Al7BmN/x0JXDgTESgVOAKPcggW+pmFrmLhKegJaEjvryHErKYcBW/vmW/jjhgQFzIn+mBO8MZDNMmY78R9NQWhsE/UFRHOiMxtzycY+UWmry+gkA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB9081.eurprd04.prod.outlook.com (2603:10a6:10:2f0::13) by PAXPR04MB8736.eurprd04.prod.outlook.com (2603:10a6:102:20c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.10; Wed, 7 Dec 2022 03:10:23 +0000 Received: from DU2PR04MB9081.eurprd04.prod.outlook.com ([fe80::15fc:8a28:db02:b009]) by DU2PR04MB9081.eurprd04.prod.outlook.com ([fe80::15fc:8a28:db02:b009%3]) with mapi id 15.20.5857.023; Wed, 7 Dec 2022 03:10:23 +0000 Date: Wed, 7 Dec 2022 11:10:17 +0800 From: Michael Chang To: Robbie Harwood Cc: Zhang Boyang , grub-devel@gnu.org, steve@einval.com Subject: Re: [RFC PATCH 4/4] kern/efi/sb: Use shim to verify font files Message-ID: <20221207031017.GA30466@mazu> References: <20221205130605.250715-1-zhangboyang.id@gmail.com> <20221205130605.250715-5-zhangboyang.id@gmail.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-ClientProxiedBy: FR2P281CA0128.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::9) To DU2PR04MB9081.eurprd04.prod.outlook.com (2603:10a6:10:2f0::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB9081:EE_|PAXPR04MB8736:EE_ X-MS-Office365-Filtering-Correlation-Id: cb89bb2c-31e9-4781-c3f8-08dad8009347 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lTCft0XWUV2kBNvuCDn0UFGrGSfqJjtQFZE4WhTymy1qqQGatOIOIqcGBPDNv11ycr+dbDGMGEhCZETow8MbdXubTIe4vIeuzQtBvVtmoQ0tmOWwiBNmba1KaiehWNfYRPn9q9BHfU/fz6MGZi8+n8HJ36Q9Qljr//7ve8o1KJ+kuV/p4ZkJQFNQR4GcIf2zaKP3aCJx6rj+7pSddefAGxZ8gdBLpFOeurPSXTotmpft1irh6CVXgRF161VfCP8MhjasCgPPAHLCwHw6RmwCAltOqktvH/jD1Gb0631Pl9x6EP2yePGYoOsjBVe0RqAxPLkgpgeJzQw/mU7XqhOHPUMoSmflujOSDj4+L2pV+w2QC4oeOOr/WvLeAYS38qPtopqEYN6l1vdse3l9mAsH+VBSd6JVzdsUouXha7+RjOcT4vHsfqZSEQ9f8UAq+Vn0d3dBdcRcAWguQ+oJNEArnk8bqPo875reNIjOYrn25K2WcNT91eBSTmri0V3ZqjQOOPoNsUDpyQIrcy0xIVLNMWqZMILIzIXkSJEnRF/sFziOvsJosTBYf4kB1skPL2k3v3+ngLakQvK5z+higVtWd3NR5iCxENp7/MCMQiAw+TCEDwabxS6qBerVIaR6etW/RPlTbnRjFRGyC/VxwR3KbQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB9081.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(7916004)(136003)(396003)(366004)(376002)(39860400002)(346002)(451199015)(1076003)(186003)(6486002)(6916009)(478600001)(316002)(33656002)(86362001)(83380400001)(38100700002)(6506007)(6512007)(33716001)(6666004)(4326008)(5660300002)(9686003)(41300700001)(15650500001)(8936002)(2906002)(8676002)(66946007)(66556008)(66476007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xIhrd/B5OOxHwokgVKe9HIE4vHwH3ARL+bV2rEcqWO/E09kVq7gfszK30SC6?= =?us-ascii?Q?TVPR91od1u7+nODk6MKPEx0N5TK1RfYiYyHYjypwyzX/UUlQ1efmNa9XHYFS?= =?us-ascii?Q?MN8XZlResYdECBaN44U4mioZiEYmxdZln0QVCO/X/CToZMkRgXWzoRlc5eFF?= =?us-ascii?Q?eIcQBuNieVZTIxhzqdIRhNd6GEcoP+b7tndT1D+2ad6YNvc9QoP+5Ps3BnYm?= =?us-ascii?Q?+/25stV/iS+eZw2XmggkSQ2ytzMWO9E9c45jZvpiN1Ea1WPZEt74y6eM3qBc?= =?us-ascii?Q?mbhkTIyaEK+h7uc7fi64/Q44Wp69X9CKTdioTM823Ic7IqXGPqitZsrsSmZ0?= =?us-ascii?Q?pw6ksooCp7LJ+d6ZAXRDjaM/G+W25eOmmu/rhde0Dtajp2XYQ6ccIvKGdrFW?= =?us-ascii?Q?AQV6vFGkZDMiFNH64TnjfHGybxKsqy2qgFve9OlVtt9YntXZXtQQM3SLr/2K?= =?us-ascii?Q?geMHzH/8FWtwxBRswo9+5nMZ9S9MyO0SkkPB/2Hv3I/1MkOhf8GGcbJsHmG8?= =?us-ascii?Q?3jY1GzY/9xlcEeJVTFGXb/BiXQbD/BdnZi/ymg2s0ugt3JSxCUilfoPtMzcg?= =?us-ascii?Q?74gYb5EPqWhLKWdtfWuIfP4EdZTKN3xyh5WTmzzcM06I4pJ1wK+xWItfHIt7?= =?us-ascii?Q?HdfGtp06ly/1lmuQzltb1BrK7gE/wGSiJIl0Z2JhfgMSWUcFmU98ODvp9vok?= =?us-ascii?Q?pqQ3WwpYw4JlAOCma6uGKuTmWX/LzIBCLlZybGykSx/mQZMCEXxNUbtrAs0M?= =?us-ascii?Q?a+1sKQh0xqVKLkffHug8JmOXYx/5mBwrLffTlOfjO66UvyFYG36b4WHHuLC5?= =?us-ascii?Q?49NIgnMjDrxQKMygBz3oY2GfYFwjpZvg9DZ7CV+uP0Chd3/rSscpT2aYsV0h?= =?us-ascii?Q?liVwQ3OG6Z0ECgtv+HXB+WEVKmDLq+vAYk0rZ9vmItPehZBvxeQVbDaCEQ1h?= =?us-ascii?Q?/TgUBdtqM5bOCa5jlTrP7hyxpg92OxkL45tFVo64TQNOohEwOgdmUZ/k8A4L?= =?us-ascii?Q?gjuhyAtc58JcNtF7u3mmVnATuwlCv7nYZSGr+C/7gGtjlsa6O0RJ5qWiDvJK?= =?us-ascii?Q?2acOE4ppx78vcbcD/iDzKOEYPzwDnEzHJO21SR1AcidBpLYjPhbn/Qe4XccQ?= =?us-ascii?Q?OujJRx/ciMXFF6xAA7nHK/wNj1cHgrzkJTg8Fs+yJqUgwI7xvHv1K5sib2NY?= =?us-ascii?Q?0A1ihVFY0EkiYZyX9912//Q8WPxDKeovU3I1WLZsi9gs9/YIN+3RJ6+klaTY?= =?us-ascii?Q?6dlYHGKmC3JdlRXmNT9YckPRidbLdUkX9vQ5grglqA2H/EYGVXOnv/tijV7J?= =?us-ascii?Q?xCfW+SeUQjsWd0qLThHBtceksWejYg9MeRi+XlRM2XzvMsJYunDvcSztqhF6?= =?us-ascii?Q?/MUbfO45IBZlG82v6kgq488R6X3SlHTQuScDvp1Rpkx2v9VTfJ4fqn4LrTBJ?= =?us-ascii?Q?7HyEOXCb2KrEMp8cdvBOwZPEn8/OBAxVoLYN25JlSLwImpKCEs62prmPU17v?= =?us-ascii?Q?O+kLqKao3/7TkvhPZn73whA1jIGcqg1XLuNPPv8Hj5SnMTNtkoJ6cE11TwNR?= =?us-ascii?Q?vi9Ub2yr56OHIaicxCbkgtyG8U8Rz+KSTklnwMI1Bhp8kzGw3jDmjw16RIfU?= =?us-ascii?Q?Tu9GZtPL/ve4GlcljT04yeWbBNZ2TP3nur8NKy8Ghm3H?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb89bb2c-31e9-4781-c3f8-08dad8009347 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB9081.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2022 03:10:22.9985 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NPpaj8lUqY1/1HsL60sVxgUZzAuZi//qdoa/cNtbSIhgF1VU4WJtlhpfcZ7+VxtW X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8736 Received-SPF: pass client-ip=2a01:111:f400:fe02::62d; envelope-from=MChang@suse.com; helo=EUR01-DB5-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Dec 2022 03:15:31 -0000 On Tue, Dec 06, 2022 at 11:09:57AM -0500, Robbie Harwood wrote: > Zhang Boyang writes: > > > Since font files can be wrapped as PE images by grub-wrap, use shim to > > verify font files if Secure Boot is enabled. To prevent other PE files > > (e.g. kernel images) used as wrappers, it only allows files marked as > > Windows GUI used as wrappers. > > Thanks for writing this; it's helpful to have something concrete to look > at. > > This approach is very font-focused, and while I understand that given > the discussion, I do still wonder if it wouldn't be better to make fonts > an instance of modules. If fonts become instances of modules, and > modules are wrapped into PE files, that not only seems cleaner but also > gives us signed module support without baking those into the image. Why not just making the PE wrap applicable to all file types, be it font files, grub modules or even (static) initrd. Providing a solution to sign arbitrary data or binary with this PE envelope sounds to me a very attractive feature and worthwhile the extra miles. :) Thanks, Michael > > What do you think? > > Be well, > --Robbie