From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D9A7C63705 for ; Wed, 7 Dec 2022 13:37:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670420246; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=K2yp2PeVlv3lIHo1pcvwZ2lKBn+Qkxp7V5+xFGWlAEA=; b=G4yBn0S/6653xkiiOufXoQgs/DlHT2zGiLA62OHku5BvWNm3dmfz8hF+n+D+dVCvbryrg1 1l0+Pubd+cZafjlUkg+Yczm0H1VrwiH7sX6AJhfueBqnhxOcp9f4MfgndaqKXa8l7Ss00l Ji3yWeq0Td7IOwwFBo7cv9y9WO1uCfI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-144-cqv7UolqPZqB9Vga57kN9A-1; Wed, 07 Dec 2022 08:37:19 -0500 X-MC-Unique: cqv7UolqPZqB9Vga57kN9A-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2CBC685CE14; Wed, 7 Dec 2022 13:37:18 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 170292027061; Wed, 7 Dec 2022 13:37:18 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 49FD71946A6E; Wed, 7 Dec 2022 13:37:17 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 158B519465B1 for ; Wed, 7 Dec 2022 10:21:55 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id A6DFE492B05; Wed, 7 Dec 2022 10:21:55 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9FFBA492B04 for ; Wed, 7 Dec 2022 10:21:55 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 84E8F185A7AD for ; Wed, 7 Dec 2022 10:21:55 +0000 (UTC) Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-37-bjBsythsNBWQZ2HrNjpfOQ-1; Wed, 07 Dec 2022 05:21:54 -0500 X-MC-Unique: bjBsythsNBWQZ2HrNjpfOQ-1 Received: by mail-wr1-f69.google.com with SMTP id h10-20020adfaa8a000000b0024208cf285eso4121368wrc.22 for ; Wed, 07 Dec 2022 02:21:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lPzI0+evVSHS3ztOGGIP3CFHgC5aN3okr0QkVN6UmJ0=; b=Qik458vaM03zXw3B3VGj+BrdP4FwHPV8+AFjiFARi5iTokKKWZh97jDlsPTpuccLWe rOol3w0c35iltCnUQq4JcPrny0i9WE/M7hC6CC3QhvPnukNuzWHTaskeT0kJxmsGw5kh hmGG4lnwt5D0AUeuF54th3CnvTvPes6274R0g2Mk3YoNznSXZ3hLEaFrJeXyecMUp231 s0lXUjBest9V3yAgFZVzGr19EQr7fNiowahbUDO4NaRYfBqX8lONKl5UZzaspdaSk1FY o1X9N9577diBSHKjMdHHYIF7DqPdfhDlxVBoHQxX568/zdo86ArXvTlzTTujA0BNJ9En nDUw== X-Gm-Message-State: ANoB5pkymHJAuADAtZDP1aY71+gXu6PwM7nSm6tXJyq4+NZTKzI6YzmK rqMMacB7JjNhUiE+kWNm/frNS5mcDwRTC/jOPh8I9J6LXbuGOYNyWoV9Bo2W7TGRS8ttkDAvDpW mEtME8a6VWuTSyG4= X-Received: by 2002:a5d:6745:0:b0:242:7e6:a0a0 with SMTP id l5-20020a5d6745000000b0024207e6a0a0mr32733379wrw.512.1670408513093; Wed, 07 Dec 2022 02:21:53 -0800 (PST) X-Google-Smtp-Source: AA0mqf7DMVf3SQ+wTGuF0LUdq4DNgtoQvJFTl9h4t7vhp8I5BZbj8QdljNko1W2iVKGLUD6JkmsMhA== X-Received: by 2002:a5d:6745:0:b0:242:7e6:a0a0 with SMTP id l5-20020a5d6745000000b0024207e6a0a0mr32733365wrw.512.1670408512850; Wed, 07 Dec 2022 02:21:52 -0800 (PST) Received: from redhat.com ([2.52.154.114]) by smtp.gmail.com with ESMTPSA id a3-20020adffac3000000b0024245e543absm13739316wrs.88.2022.12.07.02.21.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Dec 2022 02:21:52 -0800 (PST) Date: Wed, 7 Dec 2022 05:21:48 -0500 From: "Michael S. Tsirkin" To: Christoph Hellwig Message-ID: <20221207052001-mutt-send-email-mst@kernel.org> References: <20221205162035.2261037-1-alvaro.karsz@solid-run.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mailman-Approved-At: Wed, 07 Dec 2022 13:37:16 +0000 Subject: Re: [dm-devel] [PATCH v3] virtio_blk: add VIRTIO_BLK_F_LIFETIME feature support X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , linux-scsi@vger.kernel.org, Alvaro Karsz , Jason Wang , linux-nvme@lists.infradead.org, virtualization@lists.linux-foundation.org, linux-block@vger.kernel.org, dm-devel@redhat.com, Stefan Hajnoczi , Paolo Bonzini Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Dec 06, 2022 at 11:35:31PM -0800, Christoph Hellwig wrote: > This just seems like a horrible interface. And virtio-blk should be > a simple passthrough and not grow tons of side-band crap like this. > > If you want to pass through random misc information use virtio-scsi > or nvme with shadow doorbell buffers. Christoph you acked the spec patch adding this to virtio blk: Still not a fan of the encoding, but at least it is properly documented now: Acked-by: Christoph Hellwig Did you change your mind then? Or do you prefer a different encoding for the ioctl then? could you help sugesting what kind? Thanks, -- MST -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 017C7C47089 for ; Wed, 7 Dec 2022 10:22:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230337AbiLGKWw (ORCPT ); Wed, 7 Dec 2022 05:22:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229523AbiLGKWw (ORCPT ); Wed, 7 Dec 2022 05:22:52 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CF0F1C435 for ; Wed, 7 Dec 2022 02:21:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670408515; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lPzI0+evVSHS3ztOGGIP3CFHgC5aN3okr0QkVN6UmJ0=; b=XxqhSdMO3ZmBnSnuyb1+dDd4LLSqFogsTW24UMzyWLu5hOaQ+9HKM6V2KuhWP9N+2ShkZr 5PSHSp+YbgEBsz+DsKWjAu2TOXI3V9WfFHgfa4DQicVb64xvnmRogjhrB7N/FxwC2/+bsE v2GVNUDKkU+j491woh1Ow96fbEe9rbs= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-73-nLFSCZQ1Nv26VvxyhAF82A-1; Wed, 07 Dec 2022 05:21:54 -0500 X-MC-Unique: nLFSCZQ1Nv26VvxyhAF82A-1 Received: by mail-wm1-f71.google.com with SMTP id a6-20020a05600c224600b003d1f3ed49adso436321wmm.4 for ; Wed, 07 Dec 2022 02:21:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lPzI0+evVSHS3ztOGGIP3CFHgC5aN3okr0QkVN6UmJ0=; b=aSiysC4KN524wxXtqdbbxsZWnuvASy69vM3OHv3KCdiaamIQats1h+MMZrGlvGA+tn 4+qvTIlo9c7WBUIoqWYYT2Jbf/cfJ8CbOWpPY7kF7yVWKQoUXyyK8I1Hm4WsD3HTbI4C 1+AxRvh0BaLSEFDim845k9W2RdoAOvu3/nZZz56yj1B38gksWr1ROFXabfzdXXpTfDk/ D8ypeDs8PxfYLfEeon3wyjPvEUfIjDDDa1D7MXQPsQzJguNeiQuD21kUzzBkSE+KqVqC 3ueH9a1uM16yOob/tzbshfkmKtfepa/y6dKH4rJLCkVh7BbPdE2gETbVa37ZFY7lyoua uiqQ== X-Gm-Message-State: ANoB5pnQATrQRe31XnTYSoPu6qqWPmjK7KBawBKQX3ymSkwBn1J8RQXW zK84HC0uc9UlswJZdH0cHO51iD7D/3oPE8UDGXah12BS4Ml33gXZUDOz6ydJGQc5zaowYUYGIET ic+6HX0ReySwLPv3OdLLz3hE= X-Received: by 2002:a5d:6745:0:b0:242:7e6:a0a0 with SMTP id l5-20020a5d6745000000b0024207e6a0a0mr32733377wrw.512.1670408513092; Wed, 07 Dec 2022 02:21:53 -0800 (PST) X-Google-Smtp-Source: AA0mqf7DMVf3SQ+wTGuF0LUdq4DNgtoQvJFTl9h4t7vhp8I5BZbj8QdljNko1W2iVKGLUD6JkmsMhA== X-Received: by 2002:a5d:6745:0:b0:242:7e6:a0a0 with SMTP id l5-20020a5d6745000000b0024207e6a0a0mr32733365wrw.512.1670408512850; Wed, 07 Dec 2022 02:21:52 -0800 (PST) Received: from redhat.com ([2.52.154.114]) by smtp.gmail.com with ESMTPSA id a3-20020adffac3000000b0024245e543absm13739316wrs.88.2022.12.07.02.21.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Dec 2022 02:21:52 -0800 (PST) Date: Wed, 7 Dec 2022 05:21:48 -0500 From: "Michael S. Tsirkin" To: Christoph Hellwig Cc: Alvaro Karsz , virtualization@lists.linux-foundation.org, linux-block@vger.kernel.org, dm-devel@redhat.com, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, Jason Wang , Paolo Bonzini , Stefan Hajnoczi , Jens Axboe Subject: Re: [PATCH v3] virtio_blk: add VIRTIO_BLK_F_LIFETIME feature support Message-ID: <20221207052001-mutt-send-email-mst@kernel.org> References: <20221205162035.2261037-1-alvaro.karsz@solid-run.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Dec 06, 2022 at 11:35:31PM -0800, Christoph Hellwig wrote: > This just seems like a horrible interface. And virtio-blk should be > a simple passthrough and not grow tons of side-band crap like this. > > If you want to pass through random misc information use virtio-scsi > or nvme with shadow doorbell buffers. Christoph you acked the spec patch adding this to virtio blk: Still not a fan of the encoding, but at least it is properly documented now: Acked-by: Christoph Hellwig Did you change your mind then? Or do you prefer a different encoding for the ioctl then? could you help sugesting what kind? Thanks, -- MST From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28B1CC352A1 for ; Wed, 7 Dec 2022 10:22:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 835D761096; Wed, 7 Dec 2022 10:22:01 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 835D761096 Authentication-Results: smtp3.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=XxqhSdMO X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rFZXzAC7TY55; Wed, 7 Dec 2022 10:22:00 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTPS id E69C1600C4; Wed, 7 Dec 2022 10:21:59 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org E69C1600C4 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8BBDFC0032; Wed, 7 Dec 2022 10:21:59 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id AA59DC002D for ; Wed, 7 Dec 2022 10:21:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 7628E4054B for ; Wed, 7 Dec 2022 10:21:57 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 7628E4054B Authentication-Results: smtp2.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=XxqhSdMO X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zE1tJ4xQcpO8 for ; Wed, 7 Dec 2022 10:21:57 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org CCD0B4049A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp2.osuosl.org (Postfix) with ESMTPS id CCD0B4049A for ; Wed, 7 Dec 2022 10:21:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670408515; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lPzI0+evVSHS3ztOGGIP3CFHgC5aN3okr0QkVN6UmJ0=; b=XxqhSdMO3ZmBnSnuyb1+dDd4LLSqFogsTW24UMzyWLu5hOaQ+9HKM6V2KuhWP9N+2ShkZr 5PSHSp+YbgEBsz+DsKWjAu2TOXI3V9WfFHgfa4DQicVb64xvnmRogjhrB7N/FxwC2/+bsE v2GVNUDKkU+j491woh1Ow96fbEe9rbs= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-211-AaTyaxhCNemLwPGTUurFGQ-1; Wed, 07 Dec 2022 05:21:54 -0500 X-MC-Unique: AaTyaxhCNemLwPGTUurFGQ-1 Received: by mail-wm1-f69.google.com with SMTP id c187-20020a1c35c4000000b003cfee3c91cdso9765541wma.6 for ; Wed, 07 Dec 2022 02:21:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lPzI0+evVSHS3ztOGGIP3CFHgC5aN3okr0QkVN6UmJ0=; b=DVWtjqCegOji5daphQq7gAEbS0TnJG4xrhUYpQ8JslEPnY/YGNnhYrKOmPvhXSxl73 X2cf0KVa1ZiZiR80F7eirSaId0Fl36rddLro8KM66xqNPJ13sBdrVMiYKH8W2uuKYSNB bxx33mDF3Y3Q0hoABmba8g6AH8Frjlbdq2fH2UGelmS8x6obCNCZ2Z/udiXxIu78/sEm SyzMv/Pw00bh3SxuMF1bFP7HDGkOT0ifeUGSav8sDRobEJEzcZ0/+Kd8PgMrWE1ruAzo h+vEqmNtkz8vmMNvMuDZTHZpOye3lO0+YBzALiCR6daHiVI0g44Osj53JMi+c3oua+Em 1IwA== X-Gm-Message-State: ANoB5plupLTsjU5Ulkb+rR6AZZyzYjbFtIKJsIoEmRUjpnuKTPDIQJeG HvRyJuT2EBAPgYcFL5ndiNzsO510r7g3qrkEg9b+L5D1Agt3X6Lqx2oJfUehrH51gF1O3yIXJX0 Gdns6v83vYcbdcwTIQhV4428Ryw5lMWyO9t4VWhrPHQ== X-Received: by 2002:a5d:6745:0:b0:242:7e6:a0a0 with SMTP id l5-20020a5d6745000000b0024207e6a0a0mr32733380wrw.512.1670408513093; Wed, 07 Dec 2022 02:21:53 -0800 (PST) X-Google-Smtp-Source: AA0mqf7DMVf3SQ+wTGuF0LUdq4DNgtoQvJFTl9h4t7vhp8I5BZbj8QdljNko1W2iVKGLUD6JkmsMhA== X-Received: by 2002:a5d:6745:0:b0:242:7e6:a0a0 with SMTP id l5-20020a5d6745000000b0024207e6a0a0mr32733365wrw.512.1670408512850; Wed, 07 Dec 2022 02:21:52 -0800 (PST) Received: from redhat.com ([2.52.154.114]) by smtp.gmail.com with ESMTPSA id a3-20020adffac3000000b0024245e543absm13739316wrs.88.2022.12.07.02.21.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Dec 2022 02:21:52 -0800 (PST) Date: Wed, 7 Dec 2022 05:21:48 -0500 From: "Michael S. Tsirkin" To: Christoph Hellwig Subject: Re: [PATCH v3] virtio_blk: add VIRTIO_BLK_F_LIFETIME feature support Message-ID: <20221207052001-mutt-send-email-mst@kernel.org> References: <20221205162035.2261037-1-alvaro.karsz@solid-run.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: Jens Axboe , linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org, virtualization@lists.linux-foundation.org, linux-block@vger.kernel.org, dm-devel@redhat.com, Stefan Hajnoczi , Paolo Bonzini X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Tue, Dec 06, 2022 at 11:35:31PM -0800, Christoph Hellwig wrote: > This just seems like a horrible interface. And virtio-blk should be > a simple passthrough and not grow tons of side-band crap like this. > > If you want to pass through random misc information use virtio-scsi > or nvme with shadow doorbell buffers. Christoph you acked the spec patch adding this to virtio blk: Still not a fan of the encoding, but at least it is properly documented now: Acked-by: Christoph Hellwig Did you change your mind then? Or do you prefer a different encoding for the ioctl then? could you help sugesting what kind? Thanks, -- MST _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization