From: Jakub Kicinski <kuba@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: syzbot+fda18eaa8c12534ccb3b@syzkaller.appspotmail.com,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Pavel Begunkov <asml.silence@gmail.com>,
pepsipu <soopthegoop@gmail.com>, Vlastimil Babka <vbabka@suse.cz>,
kasan-dev <kasan-dev@googlegroups.com>,
Andrii Nakryiko <andrii@kernel.org>,
ast@kernel.org, bpf <bpf@vger.kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Hao Luo <haoluo@google.com>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
jolsa@kernel.org, KP Singh <kpsingh@kernel.org>,
martin.lau@linux.dev, Stanislav Fomichev <sdf@google.com>,
song@kernel.org, Yonghong Song <yhs@fb.com>,
netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Rasesh Mody <rmody@marvell.com>, Ariel Elior <aelior@marvell.com>,
Manish Chopra <manishc@marvell.com>,
Menglong Dong <imagedong@tencent.com>,
David Ahern <dsahern@kernel.org>,
Richard Gobert <richardbgobert@gmail.com>,
David Rientjes <rientjes@google.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
GR-Linux-NIC-Dev@marvell.com, linux-hardening@vger.kernel.org
Subject: Re: [PATCH net-next v2] skbuff: Introduce slab_build_skb()
Date: Wed, 7 Dec 2022 18:34:40 -0800 [thread overview]
Message-ID: <20221207183440.4c80918b@kernel.org> (raw)
In-Reply-To: <20221208000209.gonna.368-kees@kernel.org>
On Wed, 7 Dec 2022 16:02:13 -0800 Kees Cook wrote:
> Is this what you had in mind for this kind of change?
nice, thanks a lot!
the only thing left to do is kdoc updates:
- the existing kdocs should no longer mention frag_size == 0
- kdoc on the slab_build_skb() should say:
/* build_skb() variant which can operate on slab buffers.
* Note that this should be used sparingly as slab buffers
* cannot be combined efficiently by GRO!
*/
But this can all be done by us in a follow up, there's probably
more cleaning we can do in those kdocs.
> v2: introduce separate helper (kuba)
> v1: https://lore.kernel.org/netdev/20221206231659.never.929-kees@kernel.org/
prev parent reply other threads:[~2022-12-08 2:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 0:02 [PATCH net-next v2] skbuff: Introduce slab_build_skb() Kees Cook
2022-12-08 2:34 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221207183440.4c80918b@kernel.org \
--to=kuba@kernel.org \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=aelior@marvell.com \
--cc=andreyknvl@gmail.com \
--cc=andrii@kernel.org \
--cc=asml.silence@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=hawk@kernel.org \
--cc=imagedong@tencent.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kasan-dev@googlegroups.com \
--cc=keescook@chromium.org \
--cc=kpsingh@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardbgobert@gmail.com \
--cc=rientjes@google.com \
--cc=rmody@marvell.com \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=soopthegoop@gmail.com \
--cc=syzbot+fda18eaa8c12534ccb3b@syzkaller.appspotmail.com \
--cc=vbabka@suse.cz \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.