From: Stephen Boyd <sboyd@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Steven Rostedt <rostedt@goodmis.org>,
maxime@cerno.tech
Cc: Maxime Ripard <maxime@cerno.tech>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v2 2/2] clk: Add trace events for rate requests
Date: Wed, 07 Dec 2022 13:48:52 -0800 [thread overview]
Message-ID: <20221207214854.74030C433D7@smtp.kernel.org> (raw)
In-Reply-To: <20221018-clk-rate-request-tracing-v2-2-5170b363c413@cerno.tech>
Quoting maxime@cerno.tech (2022-10-26 06:46:59)
> It is currently fairly difficult to follow what clk_rate_request are
> issued, and how they have been modified once done.
>
> Indeed, there's multiple paths that can be taken, some functions are
> recursive and will just forward the request to its parent, etc.
>
> Adding a lot of debug prints is just not very convenient, so let's add
> trace events for the clock requests, one before they are submitted and
> one after they are returned.
>
> That way we can simply toggle the tracing on without modifying the
> kernel code and without affecting performances or the kernel logs too
> much.
>
> Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
Applied to clk-next
prev parent reply other threads:[~2022-12-07 21:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 13:46 [PATCH v2 0/2] clk: Rate Request Tracing maxime
2022-10-26 13:46 ` [PATCH v2 1/2] clk: Store clk_core for clk_rate_request maxime
2022-12-07 21:48 ` Stephen Boyd
2022-10-26 13:46 ` [PATCH v2 2/2] clk: Add trace events for rate requests maxime
2022-12-07 21:48 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221207214854.74030C433D7@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=mhiramat@kernel.org \
--cc=mturquette@baylibre.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.