From: Qais Yousef <qyousef@layalina.io>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Lukasz Luba <lukasz.luba@arm.com>, Wei Wang <wvw@google.com>,
Xuewen Yan <xuewen.yan94@gmail.com>, Hank <han.lin@mediatek.com>,
Jonathan JMChen <Jonathan.JMChen@mediatek.com>
Subject: Re: [PATCH v2] sched/fair: Fixes for capacity inversion detection
Date: Thu, 8 Dec 2022 14:58:25 +0000 [thread overview]
Message-ID: <20221208145825.gt3rsysykqaklrwt@airbuntu> (raw)
In-Reply-To: <20221208145409.453308-1-qyousef@layalina.io>
On 12/08/22 14:54, Qais Yousef wrote:
> Traversing the Perf Domains requires rcu_read_lock() to be held and is
> conditional on sched_energy_enabled(). rcu_read_lock() is held while in
> load_balance(), add an assert to ensure this is always the case.
Err that should say instead
Traversing the Perf Domains requires rcu_read_lock() to be held and is
conditional on sched_energy_enabled(). Ensure right protections applied.
Peter, let me know if you want me to resend with that fixed or happy to apply
yourself.
Thanks!
--
Qais Yousef
>
> Also skip capacity inversion detection for our own pd; which was an
> error.
>
> Fixes: 44c7b80bffc3 ("sched/fair: Detect capacity inversion")
> Reported-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
> Signed-off-by: Qais Yousef (Google) <qyousef@layalina.io>
> ---
>
> Changes in v2:
>
> * Make sure to hold rcu_read_lock() as we need it's not held in all
> paths (thanks Dietmar!)
next prev parent reply other threads:[~2022-12-08 14:58 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-27 14:17 [PATCH 0/3] Fixes for uclamp and capacity inversion detection Qais Yousef
2022-11-27 14:17 ` [PATCH 1/3] sched/uclamp: Fix a uninitialized variable warnings Qais Yousef
2022-12-01 22:38 ` Dietmar Eggemann
2022-12-03 14:32 ` Qais Yousef
2022-12-08 14:51 ` [PATCH v2] " Qais Yousef
2022-11-27 14:17 ` [PATCH 2/3] sched/fair: Fixes for capacity inversion detection Qais Yousef
2022-12-01 22:39 ` Dietmar Eggemann
2022-12-03 14:32 ` Qais Yousef
2022-12-08 14:54 ` [PATCH v2] " Qais Yousef
2022-12-08 14:58 ` Qais Yousef [this message]
2022-11-27 14:17 ` [RFC PATCH 3/3] sched/fair: Traverse cpufreq policies to detect capacity inversion Qais Yousef
2022-11-30 18:27 ` Rafael J. Wysocki
2022-12-03 14:32 ` Qais Yousef
2022-12-05 12:39 ` Rafael J. Wysocki
2022-12-05 14:09 ` Qais Yousef
2022-12-02 14:57 ` Vincent Guittot
2022-12-03 14:33 ` Qais Yousef
2022-12-04 11:35 ` Vincent Guittot
2022-12-05 11:01 ` Qais Yousef
2022-12-06 18:12 ` Vincent Guittot
2022-12-08 14:05 ` Qais Yousef
2022-12-09 16:47 ` Vincent Guittot
2022-12-12 18:43 ` Qais Yousef
2022-12-13 17:38 ` Dietmar Eggemann
2022-12-15 17:46 ` Vincent Guittot
2022-12-20 11:50 ` Qais Yousef
2022-12-13 17:42 ` Lukasz Luba
2022-12-20 11:51 ` Qais Yousef
2022-12-20 12:52 ` Lukasz Luba
2022-12-15 17:39 ` Vincent Guittot
2022-12-20 12:32 ` Qais Yousef
2022-12-20 13:50 ` Vincent Guittot
2022-12-23 11:58 ` Qais Yousef
2022-12-27 13:33 ` Vincent Guittot
2022-12-28 17:18 ` Vincent Guittot
2023-01-09 16:40 ` Qais Yousef
2023-01-10 16:38 ` Vincent Guittot
2023-01-10 16:44 ` Qais Yousef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221208145825.gt3rsysykqaklrwt@airbuntu \
--to=qyousef@layalina.io \
--cc=Jonathan.JMChen@mediatek.com \
--cc=dietmar.eggemann@arm.com \
--cc=han.lin@mediatek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=wvw@google.com \
--cc=xuewen.yan94@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.