All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Gwenhael Goavec-Merou <gwenj@trabucayre.com>
Cc: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/gnuradio: restrict gcc to >= 9.3.0
Date: Fri, 9 Dec 2022 15:50:05 +0100	[thread overview]
Message-ID: <20221209155005.48a59bf8@windsurf> (raw)
In-Reply-To: <1670579823-1721-1-git-send-email-gwenj@trabucayre.com>

On Fri,  9 Dec 2022 10:57:03 +0100
Gwenhael Goavec-Merou <gwenj@trabucayre.com> wrote:

> From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
> 
> Since commit 5a15095f65c655356989c91e52da1746cd96f41b gnuradio requires
> gcc >= 9.3.0
> 
> This patch add this dependency and removes BR2_TOOLCHAIN_HAS_GCC_BUG_64735
> dependency because it is only required for gcc < 7.
> 
> Also gcc restriction is required because volk needs a toolchain with a gcc > 7.
> 
> fix:
> - http://autobuild.buildroot.net/results/6a82605c58f9ef9eb6c14603777dd8523dd00aa5/
> - http://autobuild.buildroot.net/results/c7c4ae76954e388ab639b39fd521d90acfe4edc9/
> 
> Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
> ---
>  package/gnuradio/Config.in | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/package/gnuradio/Config.in b/package/gnuradio/Config.in
> index de19732cfb..2028cfb483 100644
> --- a/package/gnuradio/Config.in
> +++ b/package/gnuradio/Config.in
> @@ -4,10 +4,13 @@ comment "gnuradio needs a toolchain w/ C++, NPTL, wchar, dynamic library"
>  	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
>  		!BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
>  
> -comment "gnuradio needs a toolchain not affected by GCC bug 43744 and 64735"
> +comment "gnuradio needs a toolchain not affected by GCC bug 43744"
>  	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_43744
>  	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_64735

You're not really removing it here :-)

> +comment "gnuradio needs a gcc >= 9.3.0"
> +	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_9

This should be in the main Config.in comment:

comment "gnuradio needs a toolchain w/ C++, NPTL, wchar, dynamic library, gcc >= 9"

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-12-09 14:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-09  9:57 [Buildroot] [PATCH] package/gnuradio: restrict gcc to >= 9.3.0 Gwenhael Goavec-Merou
2022-12-09 14:50 ` Thomas Petazzoni via buildroot [this message]
2022-12-09 15:21   ` Gwenhael Goavec-Merou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221209155005.48a59bf8@windsurf \
    --to=buildroot@buildroot.org \
    --cc=gwenhael.goavec-merou@trabucayre.com \
    --cc=gwenj@trabucayre.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.