From: Jakub Kicinski <kuba@kernel.org>
To: Benjamin Coddington <bcodding@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Philipp Reisner" <philipp.reisner@linbit.com>,
"Lars Ellenberg" <lars.ellenberg@linbit.com>,
"Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>,
"Jens Axboe" <axboe@kernel.dk>,
"Josef Bacik" <josef@toxicpanda.com>,
"Keith Busch" <kbusch@kernel.org>,
"Christoph Hellwig" <hch@lst.de>,
"Sagi Grimberg" <sagi@grimberg.me>,
"Lee Duncan" <lduncan@suse.com>,
"Chris Leech" <cleech@redhat.com>,
"Mike Christie" <michael.christie@oracle.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"Valentina Manea" <valentina.manea.m@gmail.com>,
"Shuah Khan" <shuah@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"David Howells" <dhowells@redhat.com>,
"Marc Dionne" <marc.dionne@auristor.com>,
"Steve French" <sfrench@samba.org>,
"Christine Caulfield" <ccaulfie@redhat.com>,
"David Teigland" <teigland@redhat.com>,
"Mark Fasheh" <mark@fasheh.com>,
"Joel Becker" <jlbec@evilplan.org>,
"Joseph Qi" <joseph.qi@linux.alibaba.com>,
"Eric Van Hensbergen" <ericvh@gmail.com>,
"Latchesar Ionkov" <lucho@ionkov.net>,
"Dominique Martinet" <asmadeus@codewreck.org>,
"Ilya Dryomov" <idryomov@gmail.com>,
"Xiubo Li" <xiubli@redhat.com>,
"Chuck Lever" <chuck.lever@oracle.com>,
"Jeff Layton" <jlayton@kernel.org>,
"Trond Myklebust" <trond.myklebust@hammerspace.com>,
"Anna Schumaker" <anna@kernel.org>,
"Steffen Klassert" <steffen.klassert@secunet.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
netdev@vger.kernel.org
Subject: Re: [PATCH net v2 1/3] net: Introduce sk_use_task_frag in struct sock.
Date: Fri, 9 Dec 2022 20:11:27 -0800 [thread overview]
Message-ID: <20221209201127.65dc2cdb@kernel.org> (raw)
In-Reply-To: <774369bc01dd625aec8202a47ba38008c43b003d.1670609077.git.bcodding@redhat.com>
On Fri, 9 Dec 2022 13:19:23 -0500 Benjamin Coddington wrote:
> + * @sk_use_task_frag: allow sk_page_frag() to use current->task_frag.
> + Sockets that can be used under memory reclaim should
> + set this to false.
sorry to nit pick but kernel-doc does not like the lack of * at the
start of these lines:
include/net/sock.h:322: warning: bad line: Sockets that can be used under memory reclaim should
include/net/sock.h:323: warning: bad line: set this to false.
next prev parent reply other threads:[~2022-12-10 4:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 18:19 [PATCH net v2 0/3] Stop corrupting socket's task_frag Benjamin Coddington
2022-12-09 18:19 ` [PATCH net v2 1/3] net: Introduce sk_use_task_frag in struct sock Benjamin Coddington
2022-12-10 4:11 ` Jakub Kicinski [this message]
2022-12-11 11:19 ` Benjamin Coddington
2022-12-11 11:20 ` [PATCH net v3 " Benjamin Coddington
2022-12-12 23:14 ` Jakub Kicinski
2022-12-09 18:19 ` [PATCH net v2 2/3] Treewide: Stop corrupting socket's task_frag Benjamin Coddington
2022-12-09 21:27 ` Guillaume Nault
2022-12-09 18:19 ` [PATCH net v2 3/3] net: simplify sk_page_frag Benjamin Coddington
2022-12-09 21:28 ` Guillaume Nault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221209201127.65dc2cdb@kernel.org \
--to=kuba@kernel.org \
--cc=anna@kernel.org \
--cc=asmadeus@codewreck.org \
--cc=axboe@kernel.dk \
--cc=bcodding@redhat.com \
--cc=ccaulfie@redhat.com \
--cc=christoph.boehmwalder@linbit.com \
--cc=chuck.lever@oracle.com \
--cc=cleech@redhat.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=ericvh@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=herbert@gondor.apana.org.au \
--cc=idryomov@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=jlayton@kernel.org \
--cc=jlbec@evilplan.org \
--cc=josef@toxicpanda.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=kbusch@kernel.org \
--cc=lars.ellenberg@linbit.com \
--cc=lduncan@suse.com \
--cc=lucho@ionkov.net \
--cc=marc.dionne@auristor.com \
--cc=mark@fasheh.com \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=philipp.reisner@linbit.com \
--cc=sagi@grimberg.me \
--cc=sfrench@samba.org \
--cc=shuah@kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=teigland@redhat.com \
--cc=trond.myklebust@hammerspace.com \
--cc=valentina.manea.m@gmail.com \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.